]> git.meshlink.io Git - meshlink/commitdiff
Always remove a node from the UDP tree before freeing it.
authorGuus Sliepen <guus@tinc-vpn.org>
Tue, 8 Sep 2009 14:35:28 +0000 (16:35 +0200)
committerGuus Sliepen <guus@tinc-vpn.org>
Tue, 8 Sep 2009 14:35:28 +0000 (16:35 +0200)
Valgrind caught tinc reading free'd memory during a purge(). This was caused by
first removing it from the main node tree, which will already call free_node(),
and then removing it from the UDP tree. This might cause spurious segmentation
faults.

src/node.c

index a4ef78f27271647f0b53fb60d8270825510675a7..f2bb39907188c97ff365565ca029859288668a5b 100644 (file)
@@ -137,8 +137,8 @@ void node_del(node_t *n)
                edge_del(e);
        }
 
-       avl_delete(node_tree, n);
        avl_delete(node_udp_tree, n);
+       avl_delete(node_tree, n);
 }
 
 node_t *lookup_node(char *name)