Fix __warn_unused_result__, add more of it and fix the resulting warnings.

[meshlink] / test / blackbox / run_blackbox_tests / test_cases_random_port_bindings02.c

diff --git a/test/blackbox/run_blackbox_tests/test_cases_random_port_bindings02.c b/test/blackbox/run_blackbox_tests/test_cases_random_port_bindings02.c
index 2d24c3af774db5833107928a9c1573f6a25b2425..168915adf262baf5b64b48c5cdf9be9e9e721346 100644 (file)
--- a/test/blackbox/run_blackbox_tests/test_cases_random_port_bindings02.c
+++ b/test/blackbox/run_blackbox_tests/test_cases_random_port_bindings02.c
@@ -16,6 +16,11 @@
     with this program; if not, write to the Free Software Foundation, Inc.,
     51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
+
+#ifdef NDEBUG
+#undef NDEBUG
+#endif
+
 #include <stdlib.h>
 #include <stdarg.h>
 #include <setjmp.h>
@@ -51,6 +56,8 @@ static netns_state_t *test_random_port_bindings_state;
 static bool localnode = false;
 
 static int setup_test(void **state) {
+       (void)state;
+
        netns_create_topology(test_random_port_bindings_state);
        fprintf(stderr, "\nCreated topology\n");
 
@@ -62,23 +69,27 @@ static int setup_test(void **state) {
        set_sync_flag(&test_random_port_binding_peer_closed, false);
        set_sync_flag(&test_random_port_binding_nut_closed, false);
 
-       meshlink_destroy("nut");
-       meshlink_destroy("peer");
-       meshlink_destroy("relay");
+       assert(meshlink_destroy("nut"));
+       assert(meshlink_destroy("peer"));
+       assert(meshlink_destroy("relay"));
 
        return EXIT_SUCCESS;
 }
 
 static int teardown_test(void **state) {
-       meshlink_destroy("nut");
-       meshlink_destroy("peer");
-       meshlink_destroy("relay");
+       (void)state;
+
+       assert(meshlink_destroy("nut"));
+       assert(meshlink_destroy("peer"));
+       assert(meshlink_destroy("relay"));
        netns_destroy_topology(test_random_port_bindings_state);
 
        return EXIT_SUCCESS;
 }
 
 static void execute_test(test_step_func_t step_func, void **state) {
+       (void)state;
+
 
        fprintf(stderr, "\n\x1b[32mRunning Test\x1b[0m\n");
        bool test_result = step_func();
@@ -89,6 +100,8 @@ static void execute_test(test_step_func_t step_func, void **state) {
 }
 
 static void message_log(meshlink_handle_t *mesh, meshlink_log_level_t level, const char *text) {
+       (void)level;
+
        char *levelstr = "\x1b[32mRELAY";
 
        if(strcmp(mesh->name, "peer") == 0) {
@@ -125,7 +138,7 @@ static void *relay_node(void *arg) {
 
        //system("ifconfig");
 
-       meshlink_destroy("relay");
+       assert(meshlink_destroy("relay"));
 
        relay = meshlink_open(mesh_arg->node_name, mesh_arg->confbase, mesh_arg->app_name, mesh_arg->dev_class);
        assert(relay);
@@ -143,7 +156,7 @@ static void *relay_node(void *arg) {
        if(localnode == true) {
                assert(wait_sync_flag(&test_random_port_binding_make_switch, 300));
                meshlink_close(relay);
-               meshlink_destroy("relay");
+               assert(meshlink_destroy("relay"));
 
 
                set_sync_flag(&test_random_port_binding_relay_closed, true);
@@ -154,7 +167,7 @@ static void *relay_node(void *arg) {
        assert(wait_sync_flag(&test_random_port_binding_node_connected, 300));
 
        meshlink_close(relay);
-       meshlink_destroy("relay");
+       assert(meshlink_destroy("relay"));
 
 
        set_sync_flag(&test_random_port_binding_relay_closed, true);
@@ -167,7 +180,7 @@ static void *peer_node(void *arg) {
 
        fprintf(stderr, "\n\x1b[32mPeer Thread Started\x1b[0m\n");
 
-       meshlink_destroy("peer");
+       assert(meshlink_destroy("peer"));
 
        peer = meshlink_open(mesh_arg->node_name, mesh_arg->confbase, mesh_arg->app_name, mesh_arg->dev_class);
        assert(peer);
@@ -196,7 +209,7 @@ static void *peer_node(void *arg) {
        assert(wait_sync_flag(&test_random_port_binding_node_connected, 300));
 
        meshlink_close(peer);
-       meshlink_destroy("peer");
+       assert(meshlink_destroy("peer"));
 
        set_sync_flag(&test_random_port_binding_peer_closed, true);
 
@@ -208,7 +221,7 @@ static void *nut_node(void *arg) {
 
        fprintf(stderr, "\n\x1b[32mNut Thread Started\x1b[0m\n");
 
-       meshlink_destroy("nut");
+       assert(meshlink_destroy("nut"));
 
        nut_instance = meshlink_open(mesh_arg->node_name, mesh_arg->confbase, mesh_arg->app_name, mesh_arg->dev_class);
        assert(nut_instance);
@@ -241,7 +254,7 @@ static void *nut_node(void *arg) {
        assert(wait_sync_flag(&test_random_port_binding_node_connected, 300));
 
        meshlink_close(nut_instance);
-       meshlink_destroy("nut");
+       assert(meshlink_destroy("nut"));
 
        set_sync_flag(&test_random_port_binding_nut_closed, true);