Avoid allocating packet buffers unnecessarily.

[meshlink] / src / sptps.h

diff --git a/src/sptps.h b/src/sptps.h
index 9754811c447508c306248ee42dc106ee4c79b21d..c91d3882b428d09ea5c4d4f9154941a83a0727ed 100644 (file)
--- a/src/sptps.h
+++ b/src/sptps.h
@@ -1,6 +1,9 @@
+#ifndef MESHLINK_SPTPS_H
+#define MESHLINK_SPTPS_H
+
 /*
     sptps.h -- Simple Peer-to-Peer Security
-    Copyright (C) 2014 Guus Sliepen <guus@meshlink.io>
+    Copyright (C) 2014, 2017 Guus Sliepen <guus@meshlink.io>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -17,9 +20,6 @@
     51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
-#ifndef __SPTPS_H__
-#define __SPTPS_H__
-
 #include "system.h"
 
 #include "chacha-poly1305/chacha-poly1305.h"
@@ -39,29 +39,42 @@
 #define SPTPS_SIG 3           // Waiting for a SIGnature record
 #define SPTPS_ACK 4           // Waiting for an ACKnowledgement record
 
-typedef bool (*send_data_t)(void *handle, uint8_t type, const char *data, size_t len);
-typedef bool (*receive_record_t)(void *handle, uint8_t type, const char *data, uint16_t len);
+typedef bool (*send_data_t)(void *handle, uint8_t type, const void *data, size_t len);
+typedef bool (*receive_record_t)(void *handle, uint8_t type, const void *data, uint16_t len);
 
 typedef struct sptps {
+       // State
        bool initiator;
        bool datagram;
+       bool instate;
+       bool outstate;
+
        int state;
 
+       // Main member variables
        char *inbuf;
        size_t buflen;
-       uint16_t reclen;
 
-       bool instate;
        chacha_poly1305_ctx_t *incipher;
+       uint32_t replaywin;
        uint32_t inseqno;
        uint32_t received;
-       unsigned int replaywin;
-       char *late;
+       uint16_t reclen;
 
-       bool outstate;
        chacha_poly1305_ctx_t *outcipher;
        uint32_t outseqno;
 
+       char *late;
+
+       char *decrypted_buffer;
+       size_t decrypted_buffer_len;
+
+       // Callbacks
+       void *handle;
+       send_data_t send_data;
+       receive_record_t receive_record;
+
+       // Variables used for the authentication phase
        ecdsa_t *mykey;
        ecdsa_t *hiskey;
        ecdh_t *ecdh;
@@ -72,20 +85,16 @@ typedef struct sptps {
        char *label;
        size_t labellen;
 
-       void *handle;
-       send_data_t send_data;
-       receive_record_t receive_record;
 } sptps_t;
 
-extern unsigned int sptps_replaywin;
 extern void sptps_log_quiet(sptps_t *s, int s_errno, const char *format, va_list ap);
 extern void sptps_log_stderr(sptps_t *s, int s_errno, const char *format, va_list ap);
 extern void (*sptps_log)(sptps_t *s, int s_errno, const char *format, va_list ap);
-extern bool sptps_start(sptps_t *s, void *handle, bool initiator, bool datagram, ecdsa_t *mykey, ecdsa_t *hiskey, const char *label, size_t labellen, send_data_t send_data, receive_record_t receive_record);
+extern bool sptps_start(sptps_t *s, void *handle, bool initiator, bool datagram, ecdsa_t *mykey, ecdsa_t *hiskey, const char *label, size_t labellen, send_data_t send_data, receive_record_t receive_record) __attribute__((__warn_unused_result__));
 extern bool sptps_stop(sptps_t *s);
-extern bool sptps_send_record(sptps_t *s, uint8_t type, const char *data, uint16_t len);
-extern bool sptps_receive_data(sptps_t *s, const char *data, size_t len);
-extern bool sptps_force_kex(sptps_t *s);
-extern bool sptps_verify_datagram(sptps_t *s, const char *data, size_t len);
+extern bool sptps_send_record(sptps_t *s, uint8_t type, const void *data, uint16_t len);
+extern bool sptps_receive_data(sptps_t *s, const void *data, size_t len) __attribute__((__warn_unused_result__));
+extern bool sptps_force_kex(sptps_t *s) __attribute__((__warn_unused_result__));
+extern bool sptps_verify_datagram(sptps_t *s, const void *data, size_t len) __attribute__((__warn_unused_result__));
 
 #endif