]> git.meshlink.io Git - meshlink/blobdiff - src/protocol_edge.c
Add duplicate node detection callback.
[meshlink] / src / protocol_edge.c
index 92d31dbdd889cf35624ac7c28d9ad5f25da4eea0..6788109847371e0afb7e6dd7ff754cf11661a0cb 100644 (file)
@@ -1,7 +1,6 @@
 /*
     protocol_edge.c -- handle the meta-protocol, edges
-    Copyright (C) 1999-2005 Ivo Timmermans,
-                  2000-2006 Guus Sliepen <guus@tinc-vpn.org>
+    Copyright (C) 2014 Guus Sliepen <guus@meshlink.io>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-    $Id$
+    You should have received a copy of the GNU General Public License along
+    with this program; if not, write to the Free Software Foundation, Inc.,
+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
 #include "system.h"
 
-#include "splay_tree.h"
 #include "conf.h"
 #include "connection.h"
 #include "edge.h"
 #include "graph.h"
 #include "logger.h"
+#include "meshlink_internal.h"
 #include "meta.h"
 #include "net.h"
 #include "netutl.h"
 #include "utils.h"
 #include "xalloc.h"
 
-bool send_add_edge(connection_t *c, const edge_t *e) {
+extern bool node_write_devclass(meshlink_handle_t *mesh, node_t *n);
+
+bool send_add_edge(meshlink_handle_t *mesh, connection_t *c, const edge_t *e, int contradictions) {
        bool x;
        char *address, *port;
 
-       cp();
-
        sockaddr2str(&e->address, &address, &port);
 
-       x = send_request(c, "%d %x %s %s %s %s %lx %d", ADD_EDGE, rand(),
-                                        e->from->name, e->to->name, address, port,
-                                        e->options, e->weight);
+       x = send_request(mesh, c, "%d %x %s %d %s %s %s %d %x %d %d", ADD_EDGE, rand(),
+                        e->from->name, e->from->devclass, e->to->name, address, port, e->to->devclass,
+                        e->options, e->weight, contradictions);
        free(address);
        free(port);
 
        return x;
 }
 
-bool add_edge_h(connection_t *c, char *request) {
+bool add_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
        edge_t *e;
        node_t *from, *to;
        char from_name[MAX_STRING_SIZE];
+       int from_devclass;
        char to_name[MAX_STRING_SIZE];
        char to_address[MAX_STRING_SIZE];
        char to_port[MAX_STRING_SIZE];
+       int to_devclass;
        sockaddr_t address;
-       long int options;
+       uint32_t options;
        int weight;
+       int contradictions = 0;
 
-       cp();
-
-       if(sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING" "MAX_STRING" "MAX_STRING" %lx %d",
-                         from_name, to_name, to_address, to_port, &options, &weight) != 6) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s)"), "ADD_EDGE", c->name,
-                          c->hostname);
+       if(sscanf(request, "%*d %*x "MAX_STRING" %d "MAX_STRING" "MAX_STRING" "MAX_STRING" %d %x %d %d",
+                       from_name, &from_devclass, to_name, to_address, to_port, &to_devclass, &options, &weight, &contradictions) < 8) {
+               logger(mesh, MESHLINK_ERROR, "Got bad %s from %s", "ADD_EDGE", c->name);
                return false;
        }
 
        /* Check if names are valid */
 
-       if(!check_id(from_name)) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s): %s"), "ADD_EDGE", c->name,
-                          c->hostname, _("invalid name"));
+       if(!check_id(from_name) || !check_id(to_name)) {
+               logger(mesh, MESHLINK_ERROR, "Got bad %s from %s: %s", "ADD_EDGE", c->name, "invalid name");
+               return false;
+       }
+
+       // Check if devclasses are valid
+
+       if(from_devclass < 0 || from_devclass > _DEV_CLASS_MAX) {
+               logger(mesh, MESHLINK_ERROR, "Got bad %s from %s: %s", "ADD_EDGE", c->name, "from devclass invalid");
                return false;
        }
 
-       if(!check_id(to_name)) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s): %s"), "ADD_EDGE", c->name,
-                          c->hostname, _("invalid name"));
+       if(to_devclass < 0 || to_devclass > _DEV_CLASS_MAX) {
+               logger(mesh, MESHLINK_ERROR, "Got bad %s from %s: %s", "ADD_EDGE", c->name, "to devclass invalid");
                return false;
        }
 
-       if(seen_request(request))
+       if(seen_request(mesh, request)) {
                return true;
+       }
 
        /* Lookup nodes */
 
-       from = lookup_node(from_name);
-       to = lookup_node(to_name);
-
-       if(tunnelserver &&
-          from != myself && from != c->node &&
-          to != myself && to != c->node) {
-               /* ignore indirect edge registrations for tunnelserver */
-               ifdebug(PROTOCOL) logger(LOG_WARNING,
-                  _("Ignoring indirect %s from %s (%s)"),
-                  "ADD_EDGE", c->name, c->hostname);
-               return true;
-       }
+       from = lookup_node(mesh, from_name);
+       to = lookup_node(mesh, to_name);
 
        if(!from) {
                from = new_node();
+               from->status.blacklisted = mesh->default_blacklist;
                from->name = xstrdup(from_name);
-               node_add(from);
+               node_add(mesh, from);
+       }
+
+       if(contradictions > 50) {
+               handle_duplicate_node(mesh, from);
        }
 
+       from->devclass = from_devclass;
+       node_write_devclass(mesh, from);
+
        if(!to) {
                to = new_node();
+               to->status.blacklisted = mesh->default_blacklist;
                to->name = xstrdup(to_name);
-               node_add(to);
+               node_add(mesh, to);
        }
 
+       to->devclass = to_devclass;
+       node_write_devclass(mesh, to);
 
        /* Convert addresses */
 
@@ -128,26 +132,28 @@ bool add_edge_h(connection_t *c, char *request) {
 
        if(e) {
                if(e->weight != weight || e->options != options || sockaddrcmp(&e->address, &address)) {
-                       if(from == myself) {
-                               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) for ourself which does not match existing entry"),
-                                                  "ADD_EDGE", c->name, c->hostname);
-                               send_add_edge(c, e);
+                       if(from == mesh->self) {
+                               logger(mesh, MESHLINK_WARNING, "Got %s from %s for ourself which does not match existing entry",
+                                      "ADD_EDGE", c->name);
+                               send_add_edge(mesh, c, e, 0);
                                return true;
                        } else {
-                               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) which does not match existing entry"),
-                                                  "ADD_EDGE", c->name, c->hostname);
-                               edge_del(e);
-                               graph();
+                               logger(mesh, MESHLINK_WARNING, "Got %s from %s which does not match existing entry",
+                                      "ADD_EDGE", c->name);
+                               edge_del(mesh, e);
+                               graph(mesh);
                        }
-               } else
+               } else {
                        return true;
-       } else if(from == myself) {
-               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) for ourself which does not exist"),
-                                  "ADD_EDGE", c->name, c->hostname);
+               }
+       } else if(from == mesh->self) {
+               logger(mesh, MESHLINK_WARNING, "Got %s from %s for ourself which does not exist",
+                      "ADD_EDGE", c->name);
+               mesh->contradicting_add_edge++;
                e = new_edge();
                e->from = from;
                e->to = to;
-               send_del_edge(c, e);
+               send_del_edge(mesh, c, e, mesh->contradicting_add_edge);
                free_edge(e);
                return true;
        }
@@ -158,123 +164,106 @@ bool add_edge_h(connection_t *c, char *request) {
        e->address = address;
        e->options = options;
        e->weight = weight;
-       edge_add(e);
+       edge_add(mesh, e);
 
        /* Tell the rest about the new edge */
 
-       if(!tunnelserver)
-               forward_request(c, request);
+       forward_request(mesh, c, request);
 
        /* Run MST before or after we tell the rest? */
 
-       graph();
+       graph(mesh);
 
        return true;
 }
 
-bool send_del_edge(connection_t *c, const edge_t *e) {
-       cp();
-
-       return send_request(c, "%d %x %s %s", DEL_EDGE, rand(),
-                                               e->from->name, e->to->name);
+bool send_del_edge(meshlink_handle_t *mesh, connection_t *c, const edge_t *e, int contradictions) {
+       return send_request(mesh, c, "%d %x %s %s %d", DEL_EDGE, rand(),
+                           e->from->name, e->to->name, contradictions);
 }
 
-bool del_edge_h(connection_t *c, char *request) {
+bool del_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
        edge_t *e;
        char from_name[MAX_STRING_SIZE];
        char to_name[MAX_STRING_SIZE];
        node_t *from, *to;
+       int contradictions = 0;
 
-       cp();
-
-       if(sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING, from_name, to_name) != 2) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s)"), "DEL_EDGE", c->name,
-                          c->hostname);
+       if(sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING" %d", from_name, to_name, &contradictions) < 2) {
+               logger(mesh, MESHLINK_ERROR, "Got bad %s from %s", "DEL_EDGE", c->name);
                return false;
        }
 
        /* Check if names are valid */
 
-       if(!check_id(from_name)) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s): %s"), "DEL_EDGE", c->name,
-                          c->hostname, _("invalid name"));
-               return false;
-       }
-
-       if(!check_id(to_name)) {
-               logger(LOG_ERR, _("Got bad %s from %s (%s): %s"), "DEL_EDGE", c->name,
-                          c->hostname, _("invalid name"));
+       if(!check_id(from_name) || !check_id(to_name)) {
+               logger(mesh, MESHLINK_ERROR, "Got bad %s from %s: %s", "DEL_EDGE", c->name, "invalid name");
                return false;
        }
 
-       if(seen_request(request))
+       if(seen_request(mesh, request)) {
                return true;
+       }
 
        /* Lookup nodes */
 
-       from = lookup_node(from_name);
-       to = lookup_node(to_name);
-
-       if(tunnelserver &&
-          from != myself && from != c->node &&
-          to != myself && to != c->node) {
-               /* ignore indirect edge registrations for tunnelserver */
-               ifdebug(PROTOCOL) logger(LOG_WARNING,
-                  _("Ignoring indirect %s from %s (%s)"),
-                  "DEL_EDGE", c->name, c->hostname);
-               return true;
-       }
+       from = lookup_node(mesh, from_name);
+       to = lookup_node(mesh, to_name);
 
        if(!from) {
-               ifdebug(PROTOCOL) logger(LOG_ERR, _("Got %s from %s (%s) which does not appear in the edge tree"),
-                                  "DEL_EDGE", c->name, c->hostname);
+               logger(mesh, MESHLINK_ERROR, "Got %s from %s which does not appear in the edge tree",
+                      "DEL_EDGE", c->name);
                return true;
        }
 
        if(!to) {
-               ifdebug(PROTOCOL) logger(LOG_ERR, _("Got %s from %s (%s) which does not appear in the edge tree"),
-                                  "DEL_EDGE", c->name, c->hostname);
+               logger(mesh, MESHLINK_ERROR, "Got %s from %s which does not appear in the edge tree",
+                      "DEL_EDGE", c->name);
                return true;
        }
 
+       if(contradictions > 50) {
+               handle_duplicate_node(mesh, from);
+       }
+
        /* Check if edge exists */
 
        e = lookup_edge(from, to);
 
        if(!e) {
-               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) which does not appear in the edge tree"),
-                                  "DEL_EDGE", c->name, c->hostname);
+               logger(mesh, MESHLINK_WARNING, "Got %s from %s which does not appear in the edge tree",
+                      "DEL_EDGE", c->name);
                return true;
        }
 
-       if(e->from == myself) {
-               ifdebug(PROTOCOL) logger(LOG_WARNING, _("Got %s from %s (%s) for ourself"),
-                                  "DEL_EDGE", c->name, c->hostname);
-               send_add_edge(c, e);    /* Send back a correction */
+       if(e->from == mesh->self) {
+               logger(mesh, MESHLINK_WARNING, "Got %s from %s for ourself",
+                      "DEL_EDGE", c->name);
+               mesh->contradicting_del_edge++;
+               send_add_edge(mesh, c, e, mesh->contradicting_del_edge);    /* Send back a correction */
                return true;
        }
 
        /* Tell the rest about the deleted edge */
 
-       if(!tunnelserver)
-               forward_request(c, request);
+       forward_request(mesh, c, request);
 
        /* Delete the edge */
 
-       edge_del(e);
+       edge_del(mesh, e);
 
        /* Run MST before or after we tell the rest? */
 
-       graph();
+       graph(mesh);
 
        /* If the node is not reachable anymore but we remember it had an edge to us, clean it up */
 
        if(!to->status.reachable) {
-               e = lookup_edge(to, myself);
+               e = lookup_edge(to, mesh->self);
+
                if(e) {
-                       if(!tunnelserver)
-                               send_del_edge(broadcast, e);
-                       edge_del(e);
+                       send_del_edge(mesh, mesh->everyone, e, 0);
+                       edge_del(mesh, e);
                }
        }