Fix a memory leak when an invitation file contains an invalid submesh name.

[meshlink] / src / protocol_auth.c

diff --git a/src/protocol_auth.c b/src/protocol_auth.c
index 5ae4501e2cbb6feee7f7d62f954b50b9f3ba1fa1..6517d9ceef8765bcb5493d03b75daecd98c9865a 100644 (file)
--- a/src/protocol_auth.c
+++ b/src/protocol_auth.c
@@ -164,8 +164,18 @@ static bool finalize_invitation(meshlink_handle_t *mesh, connection_t *c, const
        n->devclass = DEV_CLASS_UNKNOWN;
        n->ecdsa = ecdsa_set_public_key(data);
        n->submesh = c->submesh;
+
+       // Remember its current address
+       node_add_recent_address(mesh, n, &c->address);
+
+       if(!node_write_config(mesh, n) || !config_sync(mesh, "current")) {
+               logger(mesh, MESHLINK_ERROR, "Error writing configuration file for invited node %s!\n", c->name);
+               free_node(n);
+               return false;
+
+       }
+
        node_add(mesh, n);
-       node_write_config(mesh, n);
 
        logger(mesh, MESHLINK_INFO, "Key successfully received from %s", c->name);
 
@@ -220,17 +230,20 @@ static bool receive_invitation_sptps(void *handle, uint8_t type, const void *dat
        char *submesh_name = packmsg_get_str_dup(&in);
 
        if(!strcmp(submesh_name, CORE_MESH)) {
+               free(submesh_name);
                c->submesh = NULL;
        } else {
                if(!check_id(submesh_name)) {
                        logger(mesh, MESHLINK_ERROR, "Invalid invitation file %s\n", cookie);
-                       abort();
+                       free(submesh_name);
                        return false;
                }
 
                c->submesh = lookup_or_create_submesh(mesh, submesh_name);
+               free(submesh_name);
 
                if(!c->submesh) {
+                       logger(mesh, MESHLINK_ERROR, "Unknown submesh in invitation file %s\n", cookie);
                        return false;
                }
        }
@@ -239,7 +252,6 @@ static bool receive_invitation_sptps(void *handle, uint8_t type, const void *dat
        sptps_send_record(&c->sptps, 0, config.buf, config.len);
 
        config_free(&config);
-       free(submesh_name);
 
        c->status.invitation_used = true;
 
@@ -248,6 +260,9 @@ static bool receive_invitation_sptps(void *handle, uint8_t type, const void *dat
 }
 
 bool id_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
+       assert(request);
+       assert(*request);
+
        char name[MAX_STRING_SIZE];
 
        if(sscanf(request, "%*d " MAX_STRING " %d.%d", name, &c->protocol_major, &c->protocol_minor) < 2) {
@@ -333,9 +348,7 @@ bool id_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
                return false;
        }
 
-       node_read_public_key(mesh, n);
-
-       if(!ecdsa_active(n->ecdsa)) {
+       if(!node_read_public_key(mesh, n)) {
                logger(mesh, MESHLINK_ERROR, "No key known for peer %s", c->name);
 
                if(n->status.reachable && !n->status.waitingforkey) {
@@ -385,6 +398,9 @@ static void send_everything(meshlink_handle_t *mesh, connection_t *c) {
 }
 
 bool ack_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
+       assert(request);
+       assert(*request);
+
        char hisport[MAX_STRING_SIZE];
        int devclass;
        uint32_t options;
@@ -423,9 +439,11 @@ bool ack_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
                                n->connection->outgoing = NULL;
                        }
 
+                       /* Remove the edge before terminating the connection, to prevent a graph update. */
+                       edge_del(mesh, n->connection->edge);
+                       n->connection->edge = NULL;
+
                        terminate_connection(mesh, n->connection, false);
-                       /* Run graph algorithm to keep things in sync */
-                       graph(mesh);
                }
        }