]> git.meshlink.io Git - meshlink/blobdiff - src/net_socket.c
Lock meshlink.conf to ensure only one instance can run at a time.
[meshlink] / src / net_socket.c
index 2ddf837b0a357589df87b280ccb9c512dfa6880b..ea5fdaa03853131d9b19c7b9b17b8fb06525873a 100644 (file)
@@ -1,6 +1,6 @@
 /*
     net_socket.c -- Handle various kinds of sockets.
-    Copyright (C) 2014 Guus Sliepen <guus@meshlink.io>
+    Copyright (C) 2014-2017 Guus Sliepen <guus@meshlink.io>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
 #define SOL_TCP IPPROTO_TCP
 #endif
 
+#ifndef MSG_NOSIGNAL
+#define MSG_NOSIGNAL 0
+#endif
+
 int addressfamily = AF_UNSPEC;
 int seconds_till_retry = 5;
 int max_connection_burst = 100;
@@ -47,24 +51,26 @@ static void configure_tcp(connection_t *c) {
        int flags = fcntl(c->socket, F_GETFL);
 
        if(fcntl(c->socket, F_SETFL, flags | O_NONBLOCK) < 0) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "fcntl for %s: %s", c->hostname, strerror(errno));
+               logger(c->mesh, MESHLINK_ERROR, "System call `%s' failed: %s", "fcntl", strerror(errno));
        }
+
 #elif defined(WIN32)
        unsigned long arg = 1;
 
        if(ioctlsocket(c->socket, FIONBIO, &arg) != 0) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "ioctlsocket for %s: %s", c->hostname, sockstrerror(sockerrno));
+               logger(c->mesh, MESHLINK_ERROR, "System call `%s' failed: %s", "ioctlsocket", sockstrerror(sockerrno));
        }
+
 #endif
 
 #if defined(SOL_TCP) && defined(TCP_NODELAY)
-       option = 1;
-       setsockopt(c->socket, SOL_TCP, TCP_NODELAY, (void *)&option, sizeof option);
+       int nodelay = 1;
+       setsockopt(c->socket, SOL_TCP, TCP_NODELAY, (void *)&nodelay, sizeof(nodelay));
 #endif
 
-#if defined(SOL_IP) && defined(IP_TOS) && defined(IPTOS_LOWDELAY)
-       option = IPTOS_LOWDELAY;
-       setsockopt(c->socket, SOL_IP, IP_TOS, (void *)&option, sizeof option);
+#if defined(IP_TOS) && defined(IPTOS_LOWDELAY)
+       int lowdelay = IPTOS_LOWDELAY;
+       setsockopt(c->socket, IPPROTO_IP, IP_TOS, (void *)&lowdelay, sizeof(lowdelay));
 #endif
 }
 
@@ -72,24 +78,31 @@ static bool bind_to_address(meshlink_handle_t *mesh, connection_t *c) {
        int s = -1;
 
        for(int i = 0; i < mesh->listen_sockets && mesh->listen_socket[i].bindto; i++) {
-               if(mesh->listen_socket[i].sa.sa.sa_family != c->address.sa.sa_family)
+               if(mesh->listen_socket[i].sa.sa.sa_family != c->address.sa.sa_family) {
                        continue;
-               if(s >= 0)
+               }
+
+               if(s >= 0) {
                        return false;
+               }
+
                s = i;
        }
 
-       if(s < 0)
+       if(s < 0) {
                return false;
+       }
 
        sockaddr_t sa = mesh->listen_socket[s].sa;
-       if(sa.sa.sa_family == AF_INET)
+
+       if(sa.sa.sa_family == AF_INET) {
                sa.in.sin_port = 0;
-       else if(sa.sa.sa_family == AF_INET6)
+       } else if(sa.sa.sa_family == AF_INET6) {
                sa.in6.sin6_port = 0;
+       }
 
        if(bind(c->socket, &sa.sa, SALEN(sa.sa))) {
-               logger(DEBUG_CONNECTIONS, LOG_WARNING, "Can't bind outgoing socket: %s", strerror(errno));
+               logger(mesh, MESHLINK_WARNING, "Can't bind outgoing socket: %s", strerror(errno));
                return false;
        }
 
@@ -104,7 +117,7 @@ int setup_listen_socket(const sockaddr_t *sa) {
        nfd = socket(sa->sa.sa_family, SOCK_STREAM, IPPROTO_TCP);
 
        if(nfd < 0) {
-               logger(DEBUG_STATUS, LOG_ERR, "Creating metasocket failed: %s", sockstrerror(sockerrno));
+               logger(NULL, MESHLINK_ERROR, "Creating metasocket failed: %s", sockstrerror(sockerrno));
                return -1;
        }
 
@@ -115,24 +128,29 @@ int setup_listen_socket(const sockaddr_t *sa) {
        /* Optimize TCP settings */
 
        option = 1;
-       setsockopt(nfd, SOL_SOCKET, SO_REUSEADDR, (void *)&option, sizeof option);
+       setsockopt(nfd, SOL_SOCKET, SO_REUSEADDR, (void *)&option, sizeof(option));
+
+#if defined(IPV6_V6ONLY)
 
-#if defined(SOL_IPV6) && defined(IPV6_V6ONLY)
-       if(sa->sa.sa_family == AF_INET6)
-               setsockopt(nfd, SOL_IPV6, IPV6_V6ONLY, (void *)&option, sizeof option);
+       if(sa->sa.sa_family == AF_INET6) {
+               setsockopt(nfd, IPPROTO_IPV6, IPV6_V6ONLY, (void *)&option, sizeof(option));
+       }
+
+#else
+#warning IPV6_V6ONLY not defined
 #endif
 
        if(bind(nfd, &sa->sa, SALEN(sa->sa))) {
                closesocket(nfd);
                addrstr = sockaddr2hostname(sa);
-               logger(DEBUG_ALWAYS, LOG_ERR, "Can't bind to %s/tcp: %s", addrstr, sockstrerror(sockerrno));
+               logger(NULL, MESHLINK_ERROR, "Can't bind to %s/tcp: %s", addrstr, sockstrerror(sockerrno));
                free(addrstr);
                return -1;
        }
 
        if(listen(nfd, 3)) {
                closesocket(nfd);
-               logger(DEBUG_ALWAYS, LOG_ERR, "System call `%s' failed: %s", "listen", sockstrerror(sockerrno));
+               logger(NULL, MESHLINK_ERROR, "System call `%s' failed: %s", "listen", sockstrerror(sockerrno));
                return -1;
        }
 
@@ -147,7 +165,7 @@ int setup_vpn_in_socket(meshlink_handle_t *mesh, const sockaddr_t *sa) {
        nfd = socket(sa->sa.sa_family, SOCK_DGRAM, IPPROTO_UDP);
 
        if(nfd < 0) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "Creating UDP socket failed: %s", sockstrerror(sockerrno));
+               logger(mesh, MESHLINK_ERROR, "Creating UDP socket failed: %s", sockstrerror(sockerrno));
                return -1;
        }
 
@@ -161,59 +179,71 @@ int setup_vpn_in_socket(meshlink_handle_t *mesh, const sockaddr_t *sa) {
 
                if(fcntl(nfd, F_SETFL, flags | O_NONBLOCK) < 0) {
                        closesocket(nfd);
-                       logger(DEBUG_ALWAYS, LOG_ERR, "System call `%s' failed: %s", "fcntl",
-                                  strerror(errno));
+                       logger(mesh, MESHLINK_ERROR, "System call `%s' failed: %s", "fcntl",
+                              strerror(errno));
                        return -1;
                }
        }
 #elif defined(WIN32)
        {
                unsigned long arg = 1;
+
                if(ioctlsocket(nfd, FIONBIO, &arg) != 0) {
                        closesocket(nfd);
-                       logger(DEBUG_ALWAYS, LOG_ERR, "Call to `%s' failed: %s", "ioctlsocket", sockstrerror(sockerrno));
+                       logger(mesh, MESHLINK_ERROR, "Call to `%s' failed: %s", "ioctlsocket", sockstrerror(sockerrno));
                        return -1;
                }
        }
 #endif
 
        option = 1;
-       setsockopt(nfd, SOL_SOCKET, SO_REUSEADDR, (void *)&option, sizeof option);
-       setsockopt(nfd, SOL_SOCKET, SO_BROADCAST, (void *)&option, sizeof option);
+       setsockopt(nfd, SOL_SOCKET, SO_REUSEADDR, (void *)&option, sizeof(option));
+       setsockopt(nfd, SOL_SOCKET, SO_BROADCAST, (void *)&option, sizeof(option));
+
+#if defined(IPV6_V6ONLY)
+
+       if(sa->sa.sa_family == AF_INET6) {
+               setsockopt(nfd, IPPROTO_IPV6, IPV6_V6ONLY, (void *)&option, sizeof(option));
+       }
 
-#if defined(IPPROTO_IPV6) && defined(IPV6_V6ONLY)
-       if(sa->sa.sa_family == AF_INET6)
-               setsockopt(nfd, IPPROTO_IPV6, IPV6_V6ONLY, (void *)&option, sizeof option);
 #endif
 
 #if defined(IP_DONTFRAG) && !defined(IP_DONTFRAGMENT)
 #define IP_DONTFRAGMENT IP_DONTFRAG
 #endif
 
-#if defined(SOL_IP) && defined(IP_MTU_DISCOVER) && defined(IP_PMTUDISC_DO)
+#if defined(IP_MTU_DISCOVER) && defined(IP_PMTUDISC_DO)
+
        if(mesh->self->options & OPTION_PMTU_DISCOVERY) {
                option = IP_PMTUDISC_DO;
-               setsockopt(nfd, SOL_IP, IP_MTU_DISCOVER, (void *)&option, sizeof(option));
+               setsockopt(nfd, IPPROTO_IP, IP_MTU_DISCOVER, (void *)&option, sizeof(option));
        }
-#elif defined(IPPROTO_IP) && defined(IP_DONTFRAGMENT)
+
+#elif defined(IP_DONTFRAGMENT)
+
        if(mesh->self->options & OPTION_PMTU_DISCOVERY) {
                option = 1;
                setsockopt(nfd, IPPROTO_IP, IP_DONTFRAGMENT, (void *)&option, sizeof(option));
        }
+
 #else
 #warning No way to disable IPv4 fragmentation
 #endif
 
-#if defined(SOL_IPV6) && defined(IPV6_MTU_DISCOVER) && defined(IPV6_PMTUDISC_DO)
+#if defined(IPV6_MTU_DISCOVER) && defined(IPV6_PMTUDISC_DO)
+
        if(mesh->self->options & OPTION_PMTU_DISCOVERY) {
                option = IPV6_PMTUDISC_DO;
-               setsockopt(nfd, SOL_IPV6, IPV6_MTU_DISCOVER, (void *)&option, sizeof(option));
+               setsockopt(nfd, IPPROTO_IPV6, IPV6_MTU_DISCOVER, (void *)&option, sizeof(option));
        }
-#elif defined(IPPROTO_IPV6) && defined(IPV6_DONTFRAG)
+
+#elif defined(IPV6_DONTFRAG)
+
        if(mesh->self->options & OPTION_PMTU_DISCOVERY) {
                option = 1;
                setsockopt(nfd, IPPROTO_IPV6, IPV6_DONTFRAG, (void *)&option, sizeof(option));
        }
+
 #else
 #warning No way to disable IPv6 fragmentation
 #endif
@@ -221,7 +251,7 @@ int setup_vpn_in_socket(meshlink_handle_t *mesh, const sockaddr_t *sa) {
        if(bind(nfd, &sa->sa, SALEN(sa->sa))) {
                closesocket(nfd);
                addrstr = sockaddr2hostname(sa);
-               logger(DEBUG_ALWAYS, LOG_ERR, "Can't bind to %s/udp: %s", addrstr, sockstrerror(sockerrno));
+               logger(mesh, MESHLINK_ERROR, "Can't bind to %s/udp: %s", addrstr, sockstrerror(sockerrno));
                free(addrstr);
                return -1;
        }
@@ -238,16 +268,19 @@ static void retry_outgoing_handler(event_loop_t *loop, void *data) {
 void retry_outgoing(meshlink_handle_t *mesh, outgoing_t *outgoing) {
        outgoing->timeout += 5;
 
-       if(outgoing->timeout > mesh->maxtimeout)
+       if(outgoing->timeout > mesh->maxtimeout) {
                outgoing->timeout = mesh->maxtimeout;
+       }
 
-       timeout_add(&mesh->loop, &outgoing->ev, retry_outgoing_handler, outgoing, &(struct timeval){outgoing->timeout, rand() % 100000});
+       timeout_add(&mesh->loop, &outgoing->ev, retry_outgoing_handler, outgoing, &(struct timeval) {
+               outgoing->timeout, rand() % 100000
+       });
 
-       logger(DEBUG_CONNECTIONS, LOG_NOTICE, "Trying to re-establish outgoing connection in %d seconds", outgoing->timeout);
+       logger(mesh, MESHLINK_INFO, "Trying to re-establish outgoing connection in %d seconds", outgoing->timeout);
 }
 
 void finish_connecting(meshlink_handle_t *mesh, connection_t *c) {
-       logger(DEBUG_CONNECTIONS, LOG_INFO, "Connected to %s (%s)", c->name, c->hostname);
+       logger(mesh, MESHLINK_INFO, "Connected to %s", c->name);
 
        c->last_ping_time = mesh->loop.now.tv_sec;
        c->status.connecting = false;
@@ -255,65 +288,21 @@ void finish_connecting(meshlink_handle_t *mesh, connection_t *c) {
        send_id(mesh, c);
 }
 
-static void do_outgoing_pipe(meshlink_handle_t *mesh, connection_t *c, char *command) {
-#ifndef HAVE_MINGW
-       int fd[2];
-
-       if(socketpair(AF_UNIX, SOCK_STREAM, 0, fd)) {
-               logger(DEBUG_ALWAYS, LOG_ERR, "Could not create socketpair: %s", strerror(errno));
-               return;
-       }
-
-       if(fork()) {
-               c->socket = fd[0];
-               close(fd[1]);
-               logger(DEBUG_CONNECTIONS, LOG_DEBUG, "Using proxy %s", command);
+static void handle_meta_write(meshlink_handle_t *mesh, connection_t *c) {
+       if(c->outbuf.len <= c->outbuf.offset) {
                return;
        }
 
-       close(0);
-       close(1);
-       close(fd[0]);
-       dup2(fd[1], 0);
-       dup2(fd[1], 1);
-       close(fd[1]);
-
-       // Other filedescriptors should be closed automatically by CLOEXEC
-
-       char *host = NULL;
-       char *port = NULL;
+       ssize_t outlen = send(c->socket, c->outbuf.data + c->outbuf.offset, c->outbuf.len - c->outbuf.offset, MSG_NOSIGNAL);
 
-       sockaddr2str(&c->address, &host, &port);
-       setenv("REMOTEADDRESS", host, true);
-       setenv("REMOTEPORT", port, true);
-       setenv("NODE", c->name, true);
-       setenv("NAME", mesh->self->name, true);
-
-       int result = system(command);
-       if(result < 0)
-               logger(DEBUG_ALWAYS, LOG_ERR, "Could not execute %s: %s", command, strerror(errno));
-       else if(result)
-               logger(DEBUG_ALWAYS, LOG_ERR, "%s exited with non-zero status %d", command, result);
-       exit(result);
-#else
-       logger(DEBUG_ALWAYS, LOG_ERR, "Proxy type exec not supported on this platform!");
-       return;
-#endif
-}
-
-static void handle_meta_write(meshlink_handle_t *mesh, connection_t *c) {
-       if(c->outbuf.len <= c->outbuf.offset)
-               return;
-
-       ssize_t outlen = send(c->socket, c->outbuf.data + c->outbuf.offset, c->outbuf.len - c->outbuf.offset, 0);
        if(outlen <= 0) {
                if(!errno || errno == EPIPE) {
-                       logger(DEBUG_CONNECTIONS, LOG_NOTICE, "Connection closed by %s (%s)", c->name, c->hostname);
+                       logger(mesh, MESHLINK_INFO, "Connection closed by %s", c->name);
                } else if(sockwouldblock(sockerrno)) {
-                       logger(DEBUG_CONNECTIONS, LOG_DEBUG, "Sending %d bytes to %s (%s) would block", c->outbuf.len - c->outbuf.offset, c->name, c->hostname);
+                       logger(mesh, MESHLINK_DEBUG, "Sending %lu bytes to %s would block", (unsigned long)(c->outbuf.len - c->outbuf.offset), c->name);
                        return;
                } else {
-                       logger(DEBUG_CONNECTIONS, LOG_ERR, "Could not send %d bytes of data to %s (%s): %s", c->outbuf.len - c->outbuf.offset, c->name, c->hostname, strerror(errno));
+                       logger(mesh, MESHLINK_ERROR, "Could not send %lu bytes of data to %s: %s", (unsigned long)(c->outbuf.len - c->outbuf.offset), c->name, strerror(errno));
                }
 
                terminate_connection(mesh, c, c->status.active);
@@ -321,8 +310,10 @@ static void handle_meta_write(meshlink_handle_t *mesh, connection_t *c) {
        }
 
        buffer_read(&c->outbuf, outlen);
-       if(!c->outbuf.len)
+
+       if(!c->outbuf.len) {
                io_set(&mesh->loop, &c->io, IO_READ);
+       }
 }
 
 static void handle_meta_io(event_loop_t *loop, void *data, int flags) {
@@ -333,123 +324,261 @@ static void handle_meta_io(event_loop_t *loop, void *data, int flags) {
                c->status.connecting = false;
 
                int result;
-               socklen_t len = sizeof result;
+               socklen_t len = sizeof(result);
                getsockopt(c->socket, SOL_SOCKET, SO_ERROR, (void *)&result, &len);
 
-               if(!result)
+               if(!result) {
                        finish_connecting(mesh, c);
-               else {
-                       logger(DEBUG_CONNECTIONS, LOG_DEBUG, "Error while connecting to %s (%s): %s", c->name, c->hostname, sockstrerror(result));
+               else {
+                       logger(mesh, MESHLINK_DEBUG, "Error while connecting to %s: %s", c->name, sockstrerror(result));
                        terminate_connection(mesh, c, false);
                        return;
                }
        }
 
-       if(flags & IO_WRITE)
+       if(flags & IO_WRITE) {
                handle_meta_write(mesh, c);
-       else
+       } else {
                handle_meta_connection_data(mesh, c);
+       }
 }
 
-bool do_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
-       char *address, *port, *space;
-       struct addrinfo *proxyai = NULL;
-       int result;
+// Find edges pointing to this node, and use them to build a list of unique, known addresses.
+static struct addrinfo *get_known_addresses(node_t *n) {
+       struct addrinfo *ai = NULL;
 
-begin:
-       if(!outgoing->ai) {
-               if(!outgoing->cfg) {
-                       logger(DEBUG_CONNECTIONS, LOG_ERR, "Could not set up a meta connection to %s", outgoing->name);
-                       retry_outgoing(mesh, outgoing);
-                       return false;
+       for splay_each(edge_t, e, n->edge_tree) {
+               if(!e->reverse) {
+                       continue;
                }
 
-               get_config_string(outgoing->cfg, &address);
+               bool found = false;
 
-               space = strchr(address, ' ');
-               if(space) {
-                       port = xstrdup(space + 1);
-                       *space = 0;
-               } else {
-                       // TODO: Only allow Address statements?
-                       if(!get_config_string(lookup_config(outgoing->config_tree, "Port"), &port))
-                               port = xstrdup("655");
+               for(struct addrinfo *aip = ai; aip; aip = aip->ai_next) {
+                       if(!sockaddrcmp(&e->reverse->address, (sockaddr_t *)aip->ai_addr)) {
+                               found = true;
+                               break;
+                       }
                }
 
-               outgoing->ai = str2addrinfo(address, port, SOCK_STREAM);
-               free(address);
-               free(port);
+               if(found) {
+                       continue;
+               }
+
+               // Create a new struct addrinfo, and put it at the head of the list.
+               struct addrinfo *nai = xzalloc(sizeof(*nai) + SALEN(e->reverse->address.sa));
+               nai->ai_next = ai;
+               ai = nai;
+
+               ai->ai_family = e->reverse->address.sa.sa_family;
+               ai->ai_socktype = SOCK_STREAM;
+               ai->ai_protocol = IPPROTO_TCP;
+               ai->ai_addrlen = SALEN(e->reverse->address.sa);
+               ai->ai_addr = (struct sockaddr *)(nai + 1);
+               memcpy(ai->ai_addr, &e->reverse->address, ai->ai_addrlen);
+       }
+
+       return ai;
+}
+
+// Free struct addrinfo list from get_known_addresses().
+static void free_known_addresses(struct addrinfo *ai) {
+       for(struct addrinfo *aip = ai, *next; aip; aip = next) {
+               next = aip->ai_next;
+               free(aip);
+       }
+}
+
+static bool get_recent(meshlink_handle_t *mesh, outgoing_t *outgoing) {
+       node_t *n = lookup_node(mesh, outgoing->name);
+
+       if(!n) {
+               return false;
+       }
+
+       outgoing->ai = get_known_addresses(n);
+       outgoing->aip = outgoing->ai;
+       return outgoing->aip;
+}
+
+static bool get_next_ai(meshlink_handle_t *mesh, outgoing_t *outgoing) {
+       if(!outgoing->ai) {
+               char *address = NULL;
+
+               if(get_config_string(outgoing->cfg, &address)) {
+                       char *port;
+                       char *space = strchr(address, ' ');
+
+                       if(space) {
+                               port = xstrdup(space + 1);
+                               *space = 0;
+                       } else {
+                               if(!get_config_string(lookup_config(outgoing->config_tree, "Port"), &port)) {
+                                       logger(mesh, MESHLINK_ERROR, "No Port known for %s", outgoing->name);
+                                       return false;
+                               }
+                       }
+
+                       outgoing->ai = str2addrinfo(address, port, SOCK_STREAM);
+                       free(port);
+                       free(address);
+               }
 
                outgoing->aip = outgoing->ai;
+       } else {
+               outgoing->aip = outgoing->aip->ai_next;
+       }
+
+       return outgoing->aip;
+}
+
+static bool get_next_cfg(meshlink_handle_t *mesh, outgoing_t *outgoing, char *variable) {
+       (void)mesh;
+
+       if(!outgoing->cfg) {
+               outgoing->cfg = lookup_config(outgoing->config_tree, variable);
+       } else {
                outgoing->cfg = lookup_config_next(outgoing->config_tree, outgoing->cfg);
        }
 
-       if(!outgoing->aip) {
-               if(outgoing->ai)
-                       freeaddrinfo(outgoing->ai);
-               outgoing->ai = NULL;
-               goto begin;
+       return outgoing->cfg;
+}
+
+static bool get_next_outgoing_address(meshlink_handle_t *mesh, outgoing_t *outgoing) {
+       bool start = false;
+
+       if(outgoing->state == OUTGOING_START) {
+               start = true;
+               outgoing->state = OUTGOING_CANONICAL;
+       }
+
+       if(outgoing->state == OUTGOING_CANONICAL) {
+               if(outgoing->aip || get_next_cfg(mesh, outgoing, "CanonicalAddress")) {
+                       if(get_next_ai(mesh, outgoing)) {
+                               return true;
+                       } else {
+                               freeaddrinfo(outgoing->ai);
+                               outgoing->ai = NULL;
+                               outgoing->aip = NULL;
+                       }
+               }
+
+               outgoing->state = OUTGOING_RECENT;
+       }
+
+       if(outgoing->state == OUTGOING_RECENT) {
+               if(outgoing->aip || get_next_cfg(mesh, outgoing, "Address")) {
+                       if(get_next_ai(mesh, outgoing)) {
+                               return true;
+                       } else {
+                               freeaddrinfo(outgoing->ai);
+                               outgoing->ai = NULL;
+                               outgoing->aip = NULL;
+                       }
+               }
+
+               outgoing->state = OUTGOING_KNOWN;
+       }
+
+       if(outgoing->state == OUTGOING_KNOWN) {
+               if(outgoing->aip || get_recent(mesh, outgoing)) {
+                       if(get_next_ai(mesh, outgoing)) {
+                               return true;
+                       } else {
+                               free_known_addresses(outgoing->ai);
+                               outgoing->ai = NULL;
+                               outgoing->aip = NULL;
+                       }
+               }
+
+               outgoing->state = OUTGOING_END;
+       }
+
+       if(start) {
+               outgoing->state = OUTGOING_NO_KNOWN_ADDRESSES;
+       }
+
+       return false;
+}
+
+bool do_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
+       struct addrinfo *proxyai = NULL;
+       int result;
+
+begin:
+
+       if(!get_next_outgoing_address(mesh, outgoing)) {
+               if(outgoing->state == OUTGOING_NO_KNOWN_ADDRESSES) {
+                       logger(mesh, MESHLINK_ERROR, "No known addresses for %s", outgoing->name);
+               } else {
+                       logger(mesh, MESHLINK_ERROR, "Could not set up a meta connection to %s", outgoing->name);
+                       retry_outgoing(mesh, outgoing);
+               }
+
+               return false;
        }
 
        connection_t *c = new_connection();
        c->outgoing = outgoing;
 
        memcpy(&c->address, outgoing->aip->ai_addr, outgoing->aip->ai_addrlen);
-       outgoing->aip = outgoing->aip->ai_next;
 
-       c->hostname = sockaddr2hostname(&c->address);
+       char *hostname = sockaddr2hostname(&c->address);
 
-       logger(DEBUG_CONNECTIONS, LOG_INFO, "Trying to connect to %s (%s)", outgoing->name, c->hostname);
+       logger(mesh, MESHLINK_INFO, "Trying to connect to %s at %s", outgoing->name, hostname);
 
        if(!mesh->proxytype) {
                c->socket = socket(c->address.sa.sa_family, SOCK_STREAM, IPPROTO_TCP);
                configure_tcp(c);
-       } else if(mesh->proxytype == PROXY_EXEC) {
-               do_outgoing_pipe(mesh, c, mesh->proxyhost);
        } else {
                proxyai = str2addrinfo(mesh->proxyhost, mesh->proxyport, SOCK_STREAM);
+
                if(!proxyai) {
                        free_connection(c);
+                       free(hostname);
                        goto begin;
                }
-               logger(DEBUG_CONNECTIONS, LOG_INFO, "Using proxy at %s port %s", mesh->proxyhost, mesh->proxyport);
+
+               logger(mesh, MESHLINK_INFO, "Using proxy at %s port %s", mesh->proxyhost, mesh->proxyport);
                c->socket = socket(proxyai->ai_family, SOCK_STREAM, IPPROTO_TCP);
                configure_tcp(c);
        }
 
        if(c->socket == -1) {
-               logger(DEBUG_CONNECTIONS, LOG_ERR, "Creating socket for %s failed: %s", c->hostname, sockstrerror(sockerrno));
+               logger(mesh, MESHLINK_ERROR, "Creating socket for %s at %s failed: %s", c->name, hostname, sockstrerror(sockerrno));
                free_connection(c);
+               free(hostname);
                goto begin;
        }
 
+       free(hostname);
+
 #ifdef FD_CLOEXEC
        fcntl(c->socket, F_SETFD, FD_CLOEXEC);
 #endif
 
-       if(mesh->proxytype != PROXY_EXEC) {
-#if defined(SOL_IPV6) && defined(IPV6_V6ONLY)
-               int option = 1;
-               if(c->address.sa.sa_family == AF_INET6)
-                       setsockopt(c->socket, SOL_IPV6, IPV6_V6ONLY, (void *)&option, sizeof option);
-#endif
+#if defined(IPV6_V6ONLY)
 
-               bind_to_address(mesh, c);
+       if(c->address.sa.sa_family == AF_INET6) {
+               static const int option = 1;
+               setsockopt(c->socket, IPPROTO_IPV6, IPV6_V6ONLY, (void *)&option, sizeof(option));
        }
 
+#endif
+
+       bind_to_address(mesh, c);
+
        /* Connect */
 
        if(!mesh->proxytype) {
                result = connect(c->socket, &c->address.sa, SALEN(c->address.sa));
-       } else if(mesh->proxytype == PROXY_EXEC) {
-               result = 0;
        } else {
                result = connect(c->socket, proxyai->ai_addr, proxyai->ai_addrlen);
                freeaddrinfo(proxyai);
        }
 
        if(result == -1 && !sockinprogress(sockerrno)) {
-               logger(DEBUG_CONNECTIONS, LOG_ERR, "Could not connect to %s (%s): %s", outgoing->name, c->hostname, sockstrerror(sockerrno));
+               logger(mesh, MESHLINK_ERROR, "Could not connect to %s: %s", outgoing->name, sockstrerror(sockerrno));
                free_connection(c);
 
                goto begin;
@@ -464,44 +593,11 @@ begin:
 
        connection_add(mesh, c);
 
-       io_add(&mesh->loop, &c->io, handle_meta_io, c, c->socket, IO_READ|IO_WRITE);
+       io_add(&mesh->loop, &c->io, handle_meta_io, c, c->socket, IO_READ | IO_WRITE);
 
        return true;
 }
 
-// Find edges pointing to this node, and use them to build a list of unique, known addresses.
-static struct addrinfo *get_known_addresses(node_t *n) {
-       struct addrinfo *ai = NULL;
-
-       for splay_each(edge_t, e, n->edge_tree) {
-               if(!e->reverse)
-                       continue;
-
-               bool found = false;
-               for(struct addrinfo *aip = ai; aip; aip = aip->ai_next) {
-                       if(!sockaddrcmp(&e->reverse->address, (sockaddr_t *)aip->ai_addr)) {
-                               found = true;
-                               break;
-                       }
-               }
-               if(found)
-                       continue;
-
-               struct addrinfo *nai = xzalloc(sizeof *nai);
-               if(ai)
-                       ai->ai_next = nai;
-               ai = nai;
-               ai->ai_family = e->reverse->address.sa.sa_family;
-               ai->ai_socktype = SOCK_STREAM;
-               ai->ai_protocol = IPPROTO_TCP;
-               ai->ai_addrlen = SALEN(e->reverse->address.sa);
-               ai->ai_addr = xmalloc(ai->ai_addrlen);
-               memcpy(ai->ai_addr, &e->reverse->address, ai->ai_addrlen);
-       }
-
-       return ai;
-}
-
 void setup_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
        bool blacklisted = false;
        timeout_del(&mesh->loop, &outgoing->ev);
@@ -509,26 +605,32 @@ void setup_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
        node_t *n = lookup_node(mesh, outgoing->name);
 
        if(n && n->connection) {
-               logger(DEBUG_CONNECTIONS, LOG_INFO, "Already connected to %s", outgoing->name);
+               logger(mesh, MESHLINK_INFO, "Already connected to %s", outgoing->name);
 
                n->connection->outgoing = outgoing;
                return;
        }
 
+
+       if(outgoing->ai) {
+               if(outgoing->state == OUTGOING_KNOWN) {
+                       free_known_addresses(outgoing->ai);
+               } else {
+                       freeaddrinfo(outgoing->ai);
+               }
+       }
+
+       outgoing->cfg = NULL;
+
+       exit_configuration(&outgoing->config_tree); // discard old configuration if present
        init_configuration(&outgoing->config_tree);
        read_host_config(mesh, outgoing->config_tree, outgoing->name);
-       outgoing->cfg = lookup_config(outgoing->config_tree, "Address");
-
        get_config_bool(lookup_config(outgoing->config_tree, "blacklisted"), &blacklisted);
-       if (blacklisted) return;
 
-       if(!outgoing->cfg) {
-               if(n)
-                       outgoing->aip = outgoing->ai = get_known_addresses(n);
-               if(!outgoing->ai) {
-                       logger(DEBUG_ALWAYS, LOG_ERR, "No address known for %s", outgoing->name);
-                       return;
-               }
+       outgoing->state = OUTGOING_START;
+
+       if(blacklisted) {
+               return;
        }
 
        do_outgoing_connection(mesh, outgoing);
@@ -539,12 +641,13 @@ void setup_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
   new connection
 */
 void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
+       (void)flags;
        meshlink_handle_t *mesh = loop->data;
        listen_socket_t *l = data;
        connection_t *c;
-       sockaddr_t sa;
+       sockaddr_t sa = {0};
        int fd;
-       socklen_t len = sizeof sa;
+       socklen_t len = sizeof(sa);
 
        fd = accept(l->tcp.fd, &sa.sa, &len);
 
@@ -554,7 +657,7 @@ void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
                        return;
                }
 
-               logger(DEBUG_ALWAYS, LOG_ERR, "Accepting a new connection failed: %s", sockstrerror(sockerrno));
+               logger(mesh, MESHLINK_ERROR, "Accepting a new connection failed: %s", sockstrerror(sockerrno));
                return;
        }
 
@@ -574,10 +677,11 @@ void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
                static int samehost_burst;
                static int samehost_burst_time;
 
-               if(mesh->loop.now.tv_sec - samehost_burst_time > samehost_burst)
+               if(mesh->loop.now.tv_sec - samehost_burst_time > samehost_burst) {
                        samehost_burst = 0;
-               else
+               } else {
                        samehost_burst -= mesh->loop.now.tv_sec - samehost_burst_time;
+               }
 
                samehost_burst_time = mesh->loop.now.tv_sec;
                samehost_burst++;
@@ -588,17 +692,18 @@ void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
                }
        }
 
-       memcpy(&prev_sa, &sa, sizeof sa);
+       memcpy(&prev_sa, &sa, sizeof(sa));
 
        // Check if we get many connections from different hosts
 
        static int connection_burst;
        static int connection_burst_time;
 
-       if(mesh->loop.now.tv_sec - connection_burst_time > connection_burst)
+       if(mesh->loop.now.tv_sec - connection_burst_time > connection_burst) {
                connection_burst = 0;
-       else
+       } else {
                connection_burst -= mesh->loop.now.tv_sec - connection_burst_time;
+       }
 
        connection_burst_time = mesh->loop.now.tv_sec;
        connection_burst++;
@@ -616,11 +721,12 @@ void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
        c->outcompression = mesh->self->connection->outcompression;
 
        c->address = sa;
-       c->hostname = sockaddr2hostname(&sa);
        c->socket = fd;
        c->last_ping_time = mesh->loop.now.tv_sec;
 
-       logger(DEBUG_CONNECTIONS, LOG_NOTICE, "Connection from %s", c->hostname);
+       char *hostname = sockaddr2hostname(&sa);
+       logger(mesh, MESHLINK_INFO, "Connection from %s", hostname);
+       free(hostname);
 
        io_add(&mesh->loop, &c->io, handle_meta_io, c, c->socket, IO_READ);
 
@@ -632,17 +738,26 @@ void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
        send_id(mesh, c);
 }
 
-static void free_outgoing(meshlink_handle_t *mesh, outgoing_t *outgoing) {
+static void free_outgoing(outgoing_t *outgoing) {
+       meshlink_handle_t *mesh = outgoing->mesh;
+
        timeout_del(&mesh->loop, &outgoing->ev);
 
-       if(outgoing->ai)
-               freeaddrinfo(outgoing->ai);
+       if(outgoing->ai) {
+               if(outgoing->state == OUTGOING_KNOWN) {
+                       free_known_addresses(outgoing->ai);
+               } else {
+                       freeaddrinfo(outgoing->ai);
+               }
+       }
 
-       if(outgoing->config_tree)
+       if(outgoing->config_tree) {
                exit_configuration(&outgoing->config_tree);
+       }
 
-       if(outgoing->name)
+       if(outgoing->name) {
                free(outgoing->name);
+       }
 
        free(outgoing);
 }
@@ -653,8 +768,9 @@ void try_outgoing_connections(meshlink_handle_t *mesh) {
        if(!mesh->outgoings) {
                mesh->outgoings = list_alloc((list_action_t)free_outgoing);
        } else {
-               for list_each(outgoing_t, outgoing, mesh->outgoings)
+               for list_each(outgoing_t, outgoing, mesh->outgoings) {
                        outgoing->timeout = -1;
+               }
        }
 
        /* Make sure there is one outgoing_t in the list for each ConnectTo. */
@@ -665,9 +781,9 @@ void try_outgoing_connections(meshlink_handle_t *mesh) {
                get_config_string(cfg, &name);
 
                if(!check_id(name)) {
-                       logger(DEBUG_ALWAYS, LOG_ERR,
-                                  "Invalid name for outgoing connection in %s line %d",
-                                  cfg->file, cfg->line);
+                       logger(mesh, MESHLINK_ERROR,
+                              "Invalid name for outgoing connection in line %d",
+                              cfg->line);
                        free(name);
                        continue;
                }
@@ -683,7 +799,8 @@ void try_outgoing_connections(meshlink_handle_t *mesh) {
                }
 
                if(!found) {
-                       outgoing_t *outgoing = xzalloc(sizeof *outgoing);
+                       outgoing_t *outgoing = xzalloc(sizeof(*outgoing));
+                       outgoing->mesh = mesh;
                        outgoing->name = name;
                        list_insert_tail(mesh->outgoings, outgoing);
                        setup_outgoing_connection(mesh, outgoing);
@@ -695,7 +812,7 @@ void try_outgoing_connections(meshlink_handle_t *mesh) {
        for list_each(connection_t, c, mesh->connections) {
                if(c->outgoing && c->outgoing->timeout == -1) {
                        c->outgoing = NULL;
-                       logger(DEBUG_CONNECTIONS, LOG_INFO, "No more outgoing connection to %s", c->name);
+                       logger(mesh, MESHLINK_INFO, "No more outgoing connection to %s", c->name);
                        terminate_connection(mesh, c, c->status.active);
                }
        }
@@ -703,6 +820,7 @@ void try_outgoing_connections(meshlink_handle_t *mesh) {
        /* Delete outgoing_ts for which there is no ConnectTo. */
 
        for list_each(outgoing_t, outgoing, mesh->outgoings)
-               if(outgoing->timeout == -1)
+               if(outgoing->timeout == -1) {
                        list_delete_node(mesh->outgoings, node);
+               }
 }