]> git.meshlink.io Git - meshlink/blobdiff - src/net_socket.c
Avoid allocating packet buffers unnecessarily.
[meshlink] / src / net_socket.c
index d1a5df99a05f2e42b4ea9eaea335e1b3cf0dc3d4..63bf49ea3c6f0511de3322e9d84e21d8ddcc5092 100644 (file)
@@ -40,9 +40,7 @@
 #define MSG_NOSIGNAL 0
 #endif
 
-int addressfamily = AF_UNSPEC;
-int seconds_till_retry = 5;
-int max_connection_burst = 100;
+static const int max_connection_burst = 100;
 
 /* Setup sockets */
 
@@ -74,206 +72,27 @@ static void configure_tcp(connection_t *c) {
 #endif
 }
 
-static bool bind_to_address(meshlink_handle_t *mesh, connection_t *c) {
-       int s = -1;
-
-       for(int i = 0; i < mesh->listen_sockets && mesh->listen_socket[i].bindto; i++) {
-               if(mesh->listen_socket[i].sa.sa.sa_family != c->address.sa.sa_family) {
-                       continue;
-               }
-
-               if(s >= 0) {
-                       return false;
-               }
-
-               s = i;
-       }
-
-       if(s < 0) {
-               return false;
-       }
-
-       sockaddr_t sa = mesh->listen_socket[s].sa;
-
-       if(sa.sa.sa_family == AF_INET) {
-               sa.in.sin_port = 0;
-       } else if(sa.sa.sa_family == AF_INET6) {
-               sa.in6.sin6_port = 0;
-       }
-
-       if(bind(c->socket, &sa.sa, SALEN(sa.sa))) {
-               logger(mesh, MESHLINK_WARNING, "Can't bind outgoing socket: %s", strerror(errno));
-               return false;
-       }
-
-       return true;
-}
-
-int setup_listen_socket(const sockaddr_t *sa) {
-       int nfd;
-       char *addrstr;
-       int option;
-
-       nfd = socket(sa->sa.sa_family, SOCK_STREAM, IPPROTO_TCP);
-
-       if(nfd < 0) {
-               logger(NULL, MESHLINK_ERROR, "Creating metasocket failed: %s", sockstrerror(sockerrno));
-               return -1;
-       }
-
-#ifdef FD_CLOEXEC
-       fcntl(nfd, F_SETFD, FD_CLOEXEC);
-#endif
-
-       /* Optimize TCP settings */
-
-       option = 1;
-       setsockopt(nfd, SOL_SOCKET, SO_REUSEADDR, (void *)&option, sizeof(option));
-
-#if defined(IPV6_V6ONLY)
-
-       if(sa->sa.sa_family == AF_INET6) {
-               setsockopt(nfd, IPPROTO_IPV6, IPV6_V6ONLY, (void *)&option, sizeof(option));
-       }
-
-#else
-#warning IPV6_V6ONLY not defined
-#endif
-
-       if(bind(nfd, &sa->sa, SALEN(sa->sa))) {
-               closesocket(nfd);
-               addrstr = sockaddr2hostname(sa);
-               logger(NULL, MESHLINK_ERROR, "Can't bind to %s/tcp: %s", addrstr, sockstrerror(sockerrno));
-               free(addrstr);
-               return -1;
-       }
-
-       if(listen(nfd, 3)) {
-               closesocket(nfd);
-               logger(NULL, MESHLINK_ERROR, "System call `%s' failed: %s", "listen", sockstrerror(sockerrno));
-               return -1;
-       }
-
-       return nfd;
-}
-
-int setup_vpn_in_socket(meshlink_handle_t *mesh, const sockaddr_t *sa) {
-       int nfd;
-       char *addrstr;
-       int option;
-
-       nfd = socket(sa->sa.sa_family, SOCK_DGRAM, IPPROTO_UDP);
-
-       if(nfd < 0) {
-               logger(mesh, MESHLINK_ERROR, "Creating UDP socket failed: %s", sockstrerror(sockerrno));
-               return -1;
-       }
-
-#ifdef FD_CLOEXEC
-       fcntl(nfd, F_SETFD, FD_CLOEXEC);
-#endif
-
-#ifdef O_NONBLOCK
-       {
-               int flags = fcntl(nfd, F_GETFL);
-
-               if(fcntl(nfd, F_SETFL, flags | O_NONBLOCK) < 0) {
-                       closesocket(nfd);
-                       logger(mesh, MESHLINK_ERROR, "System call `%s' failed: %s", "fcntl",
-                              strerror(errno));
-                       return -1;
-               }
-       }
-#elif defined(WIN32)
-       {
-               unsigned long arg = 1;
-
-               if(ioctlsocket(nfd, FIONBIO, &arg) != 0) {
-                       closesocket(nfd);
-                       logger(mesh, MESHLINK_ERROR, "Call to `%s' failed: %s", "ioctlsocket", sockstrerror(sockerrno));
-                       return -1;
-               }
-       }
-#endif
-
-       option = 1;
-       setsockopt(nfd, SOL_SOCKET, SO_REUSEADDR, (void *)&option, sizeof(option));
-       setsockopt(nfd, SOL_SOCKET, SO_BROADCAST, (void *)&option, sizeof(option));
-
-#if defined(IPV6_V6ONLY)
-
-       if(sa->sa.sa_family == AF_INET6) {
-               setsockopt(nfd, IPPROTO_IPV6, IPV6_V6ONLY, (void *)&option, sizeof(option));
-       }
-
-#endif
-
-#if defined(IP_DONTFRAG) && !defined(IP_DONTFRAGMENT)
-#define IP_DONTFRAGMENT IP_DONTFRAG
-#endif
-
-#if defined(IP_MTU_DISCOVER) && defined(IP_PMTUDISC_DO)
-
-       if(mesh->self->options & OPTION_PMTU_DISCOVERY) {
-               option = IP_PMTUDISC_DO;
-               setsockopt(nfd, IPPROTO_IP, IP_MTU_DISCOVER, (void *)&option, sizeof(option));
-       }
-
-#elif defined(IP_DONTFRAGMENT)
-
-       if(mesh->self->options & OPTION_PMTU_DISCOVERY) {
-               option = 1;
-               setsockopt(nfd, IPPROTO_IP, IP_DONTFRAGMENT, (void *)&option, sizeof(option));
-       }
-
-#else
-#warning No way to disable IPv4 fragmentation
-#endif
-
-#if defined(IPV6_MTU_DISCOVER) && defined(IPV6_PMTUDISC_DO)
-
-       if(mesh->self->options & OPTION_PMTU_DISCOVERY) {
-               option = IPV6_PMTUDISC_DO;
-               setsockopt(nfd, IPPROTO_IPV6, IPV6_MTU_DISCOVER, (void *)&option, sizeof(option));
-       }
-
-#elif defined(IPV6_DONTFRAG)
-
-       if(mesh->self->options & OPTION_PMTU_DISCOVERY) {
-               option = 1;
-               setsockopt(nfd, IPPROTO_IPV6, IPV6_DONTFRAG, (void *)&option, sizeof(option));
-       }
-
-#else
-#warning No way to disable IPv6 fragmentation
-#endif
-
-       if(bind(nfd, &sa->sa, SALEN(sa->sa))) {
-               closesocket(nfd);
-               addrstr = sockaddr2hostname(sa);
-               logger(mesh, MESHLINK_ERROR, "Can't bind to %s/udp: %s", addrstr, sockstrerror(sockerrno));
-               free(addrstr);
-               return -1;
-       }
-
-       return nfd;
-} /* int setup_vpn_in_socket */
-
 static void retry_outgoing_handler(event_loop_t *loop, void *data) {
+       assert(data);
+
        meshlink_handle_t *mesh = loop->data;
        outgoing_t *outgoing = data;
        setup_outgoing_connection(mesh, outgoing);
 }
 
 void retry_outgoing(meshlink_handle_t *mesh, outgoing_t *outgoing) {
-       outgoing->timeout += 5;
+       if(!mesh->reachable && mesh->loop.now.tv_sec < mesh->last_unreachable + mesh->dev_class_traits[mesh->devclass].fast_retry_period) {
+               outgoing->timeout = 1;
+       } else {
+               outgoing->timeout += 5;
+       }
 
        if(outgoing->timeout > mesh->maxtimeout) {
                outgoing->timeout = mesh->maxtimeout;
        }
 
-       timeout_add(&mesh->loop, &outgoing->ev, retry_outgoing_handler, outgoing, &(struct timeval) {
-               outgoing->timeout, rand() % 100000
+       timeout_add(&mesh->loop, &outgoing->ev, retry_outgoing_handler, outgoing, &(struct timespec) {
+               outgoing->timeout, prng(mesh, TIMER_FUDGE)
        });
 
        logger(mesh, MESHLINK_INFO, "Trying to re-establish outgoing connection in %d seconds", outgoing->timeout);
@@ -381,6 +200,38 @@ static struct addrinfo *get_known_addresses(node_t *n) {
        return ai;
 }
 
+// Build a list of recently seen addresses.
+static struct addrinfo *get_recent_addresses(node_t *n) {
+       struct addrinfo *ai = NULL;
+       struct addrinfo *aip;
+
+       for(int i = 0; i < 5; i++) {
+               if(!n->recent[i].sa.sa_family) {
+                       break;
+               }
+
+               // Create a new struct addrinfo, and put it at the end of the list.
+               struct addrinfo *nai = xzalloc(sizeof(*nai) + SALEN(n->recent[i].sa));
+
+               if(!ai) {
+                       ai = nai;
+               } else {
+                       aip->ai_next = nai;
+               }
+
+               aip = nai;
+
+               nai->ai_family = n->recent[i].sa.sa_family;
+               nai->ai_socktype = SOCK_STREAM;
+               nai->ai_protocol = IPPROTO_TCP;
+               nai->ai_addrlen = SALEN(n->recent[i].sa);
+               nai->ai_addr = (struct sockaddr *)(nai + 1);
+               memcpy(nai->ai_addr, &n->recent[i], nai->ai_addrlen);
+       }
+
+       return ai;
+}
+
 // Free struct addrinfo list from get_known_addresses().
 static void free_known_addresses(struct addrinfo *ai) {
        for(struct addrinfo *aip = ai, *next; aip; aip = next) {
@@ -389,62 +240,30 @@ static void free_known_addresses(struct addrinfo *ai) {
        }
 }
 
-static bool get_recent(meshlink_handle_t *mesh, outgoing_t *outgoing) {
-       node_t *n = lookup_node(mesh, outgoing->name);
-
-       if(!n) {
+static struct addrinfo *get_canonical_address(node_t *n) {
+       if(!n->canonical_address) {
                return false;
        }
 
-       outgoing->ai = get_known_addresses(n);
-       outgoing->aip = outgoing->ai;
-       return outgoing->aip;
-}
-
-static bool get_next_ai(meshlink_handle_t *mesh, outgoing_t *outgoing) {
-       if(!outgoing->ai) {
-               char *address = NULL;
-
-               if(get_config_string(outgoing->cfg, &address)) {
-                       char *port;
-                       char *space = strchr(address, ' ');
-
-                       if(space) {
-                               port = xstrdup(space + 1);
-                               *space = 0;
-                       } else {
-                               if(!get_config_string(lookup_config(outgoing->config_tree, "Port"), &port)) {
-                                       logger(mesh, MESHLINK_ERROR, "No Port known for %s", outgoing->name);
-                                       return false;
-                               }
-                       }
+       char *address = xstrdup(n->canonical_address);
+       char *port = strchr(address, ' ');
 
-                       outgoing->ai = str2addrinfo(address, port, SOCK_STREAM);
-                       free(port);
-                       free(address);
-               }
-
-               outgoing->aip = outgoing->ai;
-       } else {
-               outgoing->aip = outgoing->aip->ai_next;
+       if(!port) {
+               free(address);
+               return false;
        }
 
-       return outgoing->aip;
-}
-
-static bool get_next_cfg(meshlink_handle_t *mesh, outgoing_t *outgoing, char *variable) {
-       (void)mesh;
+       *port++ = 0;
 
-       if(!outgoing->cfg) {
-               outgoing->cfg = lookup_config(outgoing->config_tree, variable);
-       } else {
-               outgoing->cfg = lookup_config_next(outgoing->config_tree, outgoing->cfg);
-       }
+       struct addrinfo *ai = str2addrinfo(address, port, SOCK_STREAM);
+       free(address);
 
-       return outgoing->cfg;
+       return ai;
 }
 
 static bool get_next_outgoing_address(meshlink_handle_t *mesh, outgoing_t *outgoing) {
+       (void)mesh;
+
        bool start = false;
 
        if(outgoing->state == OUTGOING_START) {
@@ -453,48 +272,56 @@ static bool get_next_outgoing_address(meshlink_handle_t *mesh, outgoing_t *outgo
        }
 
        if(outgoing->state == OUTGOING_CANONICAL) {
-               while(outgoing->aip || get_next_cfg(mesh, outgoing, "CanonicalAddress")) {
-                       if(get_next_ai(mesh, outgoing)) {
-                               return true;
-                       } else {
-                               freeaddrinfo(outgoing->ai);
-                               outgoing->ai = NULL;
-                               outgoing->aip = NULL;
-                       }
+               if(!outgoing->aip) {
+                       outgoing->ai = get_canonical_address(outgoing->node);
+                       outgoing->aip = outgoing->ai;
+               } else {
+                       outgoing->aip = outgoing->aip->ai_next;
+               }
+
+               if(outgoing->aip) {
+                       return true;
                }
 
+               freeaddrinfo(outgoing->ai);
+               outgoing->ai = NULL;
+               outgoing->aip = NULL;
                outgoing->state = OUTGOING_RECENT;
        }
 
        if(outgoing->state == OUTGOING_RECENT) {
-               while(outgoing->aip || get_next_cfg(mesh, outgoing, "Address")) {
-                       if(get_next_ai(mesh, outgoing)) {
-                               return true;
-                       } else {
-                               freeaddrinfo(outgoing->ai);
-                               outgoing->ai = NULL;
-                               outgoing->aip = NULL;
-                       }
+               if(!outgoing->aip) {
+                       outgoing->ai = get_recent_addresses(outgoing->node);
+                       outgoing->aip = outgoing->ai;
+               } else {
+                       outgoing->aip = outgoing->aip->ai_next;
+               }
+
+               if(outgoing->aip) {
+                       return true;
                }
 
+               free_known_addresses(outgoing->ai);
+               outgoing->ai = NULL;
+               outgoing->aip = NULL;
                outgoing->state = OUTGOING_KNOWN;
        }
 
        if(outgoing->state == OUTGOING_KNOWN) {
                if(!outgoing->aip) {
-                       get_recent(mesh, outgoing);
+                       outgoing->ai = get_known_addresses(outgoing->node);
+                       outgoing->aip = outgoing->ai;
                } else {
                        outgoing->aip = outgoing->aip->ai_next;
                }
 
                if(outgoing->aip) {
                        return true;
-               } else {
-                       free_known_addresses(outgoing->ai);
-                       outgoing->ai = NULL;
-                       outgoing->aip = NULL;
                }
 
+               free_known_addresses(outgoing->ai);
+               outgoing->ai = NULL;
+               outgoing->aip = NULL;
                outgoing->state = OUTGOING_END;
        }
 
@@ -505,7 +332,7 @@ static bool get_next_outgoing_address(meshlink_handle_t *mesh, outgoing_t *outgo
        return false;
 }
 
-bool do_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
+void do_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
        struct addrinfo *proxyai = NULL;
        int result;
 
@@ -513,13 +340,13 @@ begin:
 
        if(!get_next_outgoing_address(mesh, outgoing)) {
                if(outgoing->state == OUTGOING_NO_KNOWN_ADDRESSES) {
-                       logger(mesh, MESHLINK_ERROR, "No known addresses for %s", outgoing->name);
+                       logger(mesh, MESHLINK_ERROR, "No known addresses for %s", outgoing->node->name);
                } else {
-                       logger(mesh, MESHLINK_ERROR, "Could not set up a meta connection to %s", outgoing->name);
+                       logger(mesh, MESHLINK_ERROR, "Could not set up a meta connection to %s", outgoing->node->name);
                        retry_outgoing(mesh, outgoing);
                }
 
-               return false;
+               return;
        }
 
        connection_t *c = new_connection();
@@ -529,7 +356,7 @@ begin:
 
        char *hostname = sockaddr2hostname(&c->address);
 
-       logger(mesh, MESHLINK_INFO, "Trying to connect to %s at %s", outgoing->name, hostname);
+       logger(mesh, MESHLINK_INFO, "Trying to connect to %s at %s", outgoing->node->name, hostname);
 
        if(!mesh->proxytype) {
                c->socket = socket(c->address.sa.sa_family, SOCK_STREAM, IPPROTO_TCP);
@@ -570,8 +397,6 @@ begin:
 
 #endif
 
-       bind_to_address(mesh, c);
-
        /* Connect */
 
        if(!mesh->proxytype) {
@@ -582,7 +407,7 @@ begin:
        }
 
        if(result == -1 && !sockinprogress(sockerrno)) {
-               logger(mesh, MESHLINK_ERROR, "Could not connect to %s: %s", outgoing->name, sockstrerror(sockerrno));
+               logger(mesh, MESHLINK_ERROR, "Could not connect to %s: %s", outgoing->node->name, sockstrerror(sockerrno));
                free_connection(c);
 
                goto begin;
@@ -591,68 +416,66 @@ begin:
        /* Now that there is a working socket, fill in the rest and register this connection. */
 
        c->status.connecting = true;
-       c->name = xstrdup(outgoing->name);
-       c->outcompression = mesh->self->connection->outcompression;
+       c->status.initiator = true;
+       c->name = xstrdup(outgoing->node->name);
        c->last_ping_time = mesh->loop.now.tv_sec;
 
        connection_add(mesh, c);
 
        io_add(&mesh->loop, &c->io, handle_meta_io, c, c->socket, IO_READ | IO_WRITE);
-
-       return true;
 }
 
-void setup_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
-       bool blacklisted = false;
-       timeout_del(&mesh->loop, &outgoing->ev);
-
-       node_t *n = lookup_node(mesh, outgoing->name);
-
-       if(n && n->connection) {
-               logger(mesh, MESHLINK_INFO, "Already connected to %s", outgoing->name);
-
-               n->connection->outgoing = outgoing;
-               return;
-       }
-
-
+void reset_outgoing(outgoing_t *outgoing) {
        if(outgoing->ai) {
-               if(outgoing->state == OUTGOING_KNOWN) {
+               if(outgoing->state == OUTGOING_RECENT || outgoing->state == OUTGOING_KNOWN) {
                        free_known_addresses(outgoing->ai);
                } else {
                        freeaddrinfo(outgoing->ai);
                }
        }
 
-       outgoing->cfg = NULL;
+       outgoing->ai = NULL;
+       outgoing->aip = NULL;
+       outgoing->state = OUTGOING_START;
+}
+
+void setup_outgoing_connection(meshlink_handle_t *mesh, outgoing_t *outgoing) {
+       timeout_del(&mesh->loop, &outgoing->ev);
 
-       exit_configuration(&outgoing->config_tree); // discard old configuration if present
-       init_configuration(&outgoing->config_tree);
-       read_host_config(mesh, outgoing->config_tree, outgoing->name);
-       get_config_bool(lookup_config(outgoing->config_tree, "blacklisted"), &blacklisted);
+       if(outgoing->node->connection) {
+               logger(mesh, MESHLINK_INFO, "Already connected to %s", outgoing->node->name);
 
-       outgoing->state = OUTGOING_START;
+               outgoing->node->connection->outgoing = outgoing;
+               return;
+       }
 
-       if(blacklisted) {
+       reset_outgoing(outgoing);
+
+       if(outgoing->node->status.blacklisted) {
                return;
        }
 
+       if(mesh->connection_try_cb) {
+               mesh->connection_try_cb(mesh, (meshlink_node_t *)outgoing->node);
+       }
+
        do_outgoing_connection(mesh, outgoing);
 }
 
 /// Delayed close of a filedescriptor.
-static void tarpit(int fd) {
-       static int pits[10] = {-1, -1, -1, -1, -1, -1, -1, -1, -1, -1};
-       static int next_pit = 0;
+static void tarpit(meshlink_handle_t *mesh, int fd) {
+       if(!fd) {
+               return;
+       }
 
-       if(pits[next_pit] != -1) {
-               closesocket(pits[next_pit]);
+       if(mesh->pits[mesh->next_pit]) {
+               closesocket(mesh->pits[mesh->next_pit]);
        }
 
-       pits[next_pit++] = fd;
+       mesh->pits[mesh->next_pit++] = fd;
 
-       if(next_pit >= (int)(sizeof pits / sizeof pits[0])) {
-               next_pit = 0;
+       if(mesh->next_pit >= (int)(sizeof mesh->pits / sizeof mesh->pits[0])) {
+               mesh->next_pit = 0;
        }
 }
 
@@ -665,10 +488,12 @@ void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
        meshlink_handle_t *mesh = loop->data;
        listen_socket_t *l = data;
        connection_t *c;
-       sockaddr_t sa = {0};
+       sockaddr_t sa;
        int fd;
        socklen_t len = sizeof(sa);
 
+       memset(&sa, 0, sizeof(sa));
+
        fd = accept(l->tcp.fd, &sa.sa, &len);
 
        if(fd < 0) {
@@ -685,26 +510,22 @@ void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
 
        /* Rate limit incoming connections to max_connection_burst/second. */
 
-       static int connection_burst;
-       static int connection_burst_time;
-
-       if(mesh->loop.now.tv_sec != connection_burst_time) {
-               connection_burst_time = mesh->loop.now.tv_sec;
-               connection_burst = 0;
+       if(mesh->loop.now.tv_sec != mesh->connection_burst_time) {
+               mesh->connection_burst_time = mesh->loop.now.tv_sec;
+               mesh->connection_burst = 0;
        }
 
-       if(connection_burst >= max_connection_burst) {
-               tarpit(fd);
+       if(mesh->connection_burst >= max_connection_burst) {
+               tarpit(mesh, fd);
                return;
        }
 
-       connection_burst++;
+       mesh->connection_burst++;
 
        // Accept the new connection
 
        c = new_connection();
        c->name = xstrdup("<unknown>");
-       c->outcompression = mesh->self->connection->outcompression;
 
        c->address = sa;
        c->socket = fd;
@@ -725,88 +546,28 @@ void handle_new_meta_connection(event_loop_t *loop, void *data, int flags) {
 }
 
 static void free_outgoing(outgoing_t *outgoing) {
-       meshlink_handle_t *mesh = outgoing->mesh;
+       meshlink_handle_t *mesh = outgoing->node->mesh;
 
        timeout_del(&mesh->loop, &outgoing->ev);
 
        if(outgoing->ai) {
-               if(outgoing->state == OUTGOING_KNOWN) {
+               if(outgoing->state == OUTGOING_RECENT || outgoing->state == OUTGOING_KNOWN) {
                        free_known_addresses(outgoing->ai);
                } else {
                        freeaddrinfo(outgoing->ai);
                }
        }
 
-       if(outgoing->config_tree) {
-               exit_configuration(&outgoing->config_tree);
-       }
-
-       if(outgoing->name) {
-               free(outgoing->name);
-       }
-
        free(outgoing);
 }
 
-void try_outgoing_connections(meshlink_handle_t *mesh) {
-       /* If there is no outgoing list yet, create one. Otherwise, mark all outgoings as deleted. */
-
-       if(!mesh->outgoings) {
-               mesh->outgoings = list_alloc((list_action_t)free_outgoing);
-       } else {
-               for list_each(outgoing_t, outgoing, mesh->outgoings) {
-                       outgoing->timeout = -1;
-               }
-       }
-
-       /* Make sure there is one outgoing_t in the list for each ConnectTo. */
-
-       // TODO: Drop support for ConnectTo since AutoConnect is now always on?
-       for(config_t *cfg = lookup_config(mesh->config, "ConnectTo"); cfg; cfg = lookup_config_next(mesh->config, cfg)) {
-               char *name;
-               get_config_string(cfg, &name);
-
-               if(!check_id(name)) {
-                       logger(mesh, MESHLINK_ERROR,
-                              "Invalid name for outgoing connection in line %d",
-                              cfg->line);
-                       free(name);
-                       continue;
-               }
-
-               bool found = false;
-
-               for list_each(outgoing_t, outgoing, mesh->outgoings) {
-                       if(!strcmp(outgoing->name, name)) {
-                               found = true;
-                               outgoing->timeout = 0;
-                               break;
-                       }
-               }
-
-               if(!found) {
-                       outgoing_t *outgoing = xzalloc(sizeof(*outgoing));
-                       outgoing->mesh = mesh;
-                       outgoing->name = name;
-                       list_insert_tail(mesh->outgoings, outgoing);
-                       setup_outgoing_connection(mesh, outgoing);
-               }
-       }
-
-       /* Terminate any connections whose outgoing_t is to be deleted. */
+void init_outgoings(meshlink_handle_t *mesh) {
+       mesh->outgoings = list_alloc((list_action_t)free_outgoing);
+}
 
-       for list_each(connection_t, c, mesh->connections) {
-               if(c->outgoing && c->outgoing->timeout == -1) {
-                       c->outgoing = NULL;
-                       logger(mesh, MESHLINK_INFO, "No more outgoing connection to %s", c->name);
-                       terminate_connection(mesh, c, c->status.active);
-               }
+void exit_outgoings(meshlink_handle_t *mesh) {
+       if(mesh->outgoings) {
+               list_delete_list(mesh->outgoings);
+               mesh->outgoings = NULL;
        }
-
-       /* Delete outgoing_ts for which there is no ConnectTo. */
-
-       for list_each(outgoing_t, outgoing, mesh->outgoings)
-               if(outgoing->timeout == -1) {
-                       list_delete_node(mesh->outgoings, node);
-               }
 }