]> git.meshlink.io Git - meshlink/blobdiff - src/meta.c
Move assert()s that dereference a pointer to after the pointer NULL check.
[meshlink] / src / meta.c
index e1e1c677ca81fbd75c7c061794f9db13971015de..f3ab47f10be486767446de93ea0399ffb32bbc43 100644 (file)
@@ -1,7 +1,6 @@
 /*
     meta.c -- handle the meta communication
-    Copyright (C) 2000-2002 Guus Sliepen <guus@sliepen.eu.org>,
-                  2000-2002 Ivo Timmermans <ivo@o2w.nl>
+    Copyright (C) 2014-2017 Guus Sliepen <guus@meshlink.io>,
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-    $Id: meta.c,v 1.1.2.33 2003/03/19 11:45:05 guus Exp $
+    You should have received a copy of the GNU General Public License along
+    with this program; if not, write to the Free Software Foundation, Inc.,
+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
-#include "config.h"
-#include <utils.h>
-#include <avl_tree.h>
-
-#include <errno.h>
-#include <syslog.h>
-#include <unistd.h>
-#include <string.h>
-/* This line must be below the rest for FreeBSD */
-#include <sys/types.h>
-#include <sys/socket.h>
-
-#include <openssl/evp.h>
+#include "system.h"
 
-#include "net.h"
 #include "connection.h"
-#include "system.h"
+#include "logger.h"
+#include "meshlink_internal.h"
+#include "meta.h"
+#include "net.h"
 #include "protocol.h"
+#include "utils.h"
+#include "xalloc.h"
 
-int send_meta(connection_t *c, char *buffer, int length)
-{
-       char *bufp;
-       int outlen;
-       char outbuf[MAXBUFSIZE];
-       int result;
-
-       cp();
-
-       if(debug_lvl >= DEBUG_META)
-               syslog(LOG_DEBUG, _("Sending %d bytes of metadata to %s (%s)"), length,
-                          c->name, c->hostname);
-
-       if(c->status.encryptout) {
-               EVP_EncryptUpdate(c->outctx, outbuf, &outlen, buffer, length);
-               bufp = outbuf;
-               length = outlen;
-       } else
-               bufp = buffer;
-
-       while(length) {
-               result = write(c->socket, bufp, length);
-               if(result <= 0) {
-                       if(errno == EINTR)
-                               continue;
-                       syslog(LOG_ERR, _("Sending meta data to %s (%s) failed: %s"), c->name,
-                                  c->hostname, strerror(errno));
-                       return -1;
-               }
-               bufp += result;
-               length -= result;
+bool send_meta_sptps(void *handle, uint8_t type, const void *buffer, size_t length) {
+       (void)type;
+
+       assert(handle);
+       assert(buffer);
+       assert(length);
+
+       connection_t *c = handle;
+       meshlink_handle_t *mesh = c->mesh;
+
+       buffer_add(&c->outbuf, (const char *)buffer, length);
+       io_set(&mesh->loop, &c->io, IO_READ | IO_WRITE);
+
+       return true;
+}
+
+bool send_meta(meshlink_handle_t *mesh, connection_t *c, const char *buffer, int length) {
+       assert(c);
+       assert(buffer);
+       assert(length);
+
+       logger(mesh, MESHLINK_DEBUG, "Sending %d bytes of metadata to %s", length, c->name);
+
+       if(c->allow_request == ID) {
+               buffer_add(&c->outbuf, buffer, length);
+               io_set(&mesh->loop, &c->io, IO_READ | IO_WRITE);
+               return true;
        }
-       
-       return 0;
+
+       return sptps_send_record(&c->sptps, 0, buffer, length);
 }
 
-void broadcast_meta(connection_t *from, char *buffer, int length)
-{
-       avl_node_t *node;
-       connection_t *c;
+void broadcast_meta(meshlink_handle_t *mesh, connection_t *from, const char *buffer, int length) {
+       assert(buffer);
+       assert(length);
 
-       cp();
+       for list_each(connection_t, c, mesh->connections)
+               if(c != from && c->status.active) {
+                       send_meta(mesh, c, buffer, length);
+               }
+}
 
-       for(node = connection_tree->head; node; node = node->next) {
-               c = (connection_t *) node->data;
+void broadcast_submesh_meta(meshlink_handle_t *mesh, connection_t *from, submesh_t *s, const char *buffer, int length) {
+       assert(buffer);
+       assert(length);
 
-               if(c != from && c->status.active)
-                       send_meta(c, buffer, length);
-       }
+       for list_each(connection_t, c, mesh->connections)
+               if(c != from && c->status.active) {
+                       if(c->node && submesh_allows_node(s, c->node)) {
+                               send_meta(mesh, c, buffer, length);
+                       }
+               }
 }
 
-int receive_meta(connection_t *c)
-{
-       int x;
-       socklen_t l = sizeof(x);
-       int oldlen, i;
-       int lenin, reqlen;
-       int decrypted = 0;
-       char inbuf[MAXBUFSIZE];
+bool receive_meta_sptps(void *handle, uint8_t type, const void *data, uint16_t length) {
+       assert(handle);
+       assert(!length || data);
 
-       cp();
+       connection_t *c = handle;
+       meshlink_handle_t *mesh = c->mesh;
+       char *request = (char *)data;
 
-       if(getsockopt(c->socket, SOL_SOCKET, SO_ERROR, &x, &l) < 0) {
-               syslog(LOG_ERR, _("This is a bug: %s:%d: %d:%s %s (%s)"), __FILE__,
-                          __LINE__, c->socket, strerror(errno), c->name, c->hostname);
-               return -1;
+       if(!c) {
+               logger(mesh, MESHLINK_ERROR, "receive_meta_sptps() called with NULL pointer!");
+               abort();
        }
 
-       if(x) {
-               syslog(LOG_ERR, _("Metadata socket error for %s (%s): %s"),
-                          c->name, c->hostname, strerror(x));
-               return -1;
+       if(type == SPTPS_HANDSHAKE) {
+               if(c->allow_request == ACK) {
+                       return send_ack(mesh, c);
+               } else {
+                       return true;
+               }
        }
 
-       /* Strategy:
-          - Read as much as possible from the TCP socket in one go.
-          - Decrypt it.
-          - Check if a full request is in the input buffer.
-          - If yes, process request and remove it from the buffer,
-          then check again.
-          - If not, keep stuff in buffer and exit.
-        */
-
-       lenin = read(c->socket, c->buffer + c->buflen, MAXBUFSIZE - c->buflen);
-
-       if(lenin <= 0) {
-               if(lenin == 0) {
-                       if(debug_lvl >= DEBUG_CONNECTIONS)
-                               syslog(LOG_NOTICE, _("Connection closed by %s (%s)"),
-                                          c->name, c->hostname);
-               } else if(errno == EINTR)
-                       return 0;
-               else
-                       syslog(LOG_ERR, _("Metadata socket read error for %s (%s): %s"),
-                                  c->name, c->hostname, strerror(errno));
-
-               return -1;
+       if(!request) {
+               return true;
        }
 
-       oldlen = c->buflen;
-       c->buflen += lenin;
+       /* Are we receiving a TCPpacket? */
 
-       while(lenin) {
-               /* Decrypt */
+       if(c->tcplen) {
+               abort(); // TODO: get rid of tcplen altogether
+       }
 
-               if(c->status.decryptin && !decrypted) {
-                       EVP_DecryptUpdate(c->inctx, inbuf, &lenin, c->buffer + oldlen, lenin);
-                       memcpy(c->buffer + oldlen, inbuf, lenin);
-                       decrypted = 1;
-               }
+       /* Change newline to null byte, just like non-SPTPS requests */
 
-               /* Are we receiving a TCPpacket? */
+       if(request[length - 1] == '\n') {
+               request[length - 1] = 0;
+       }
 
-               if(c->tcplen) {
-                       if(c->tcplen <= c->buflen) {
-                               receive_tcppacket(c, c->buffer, c->tcplen);
+       /* Otherwise we are waiting for a request */
 
-                               c->buflen -= c->tcplen;
-                               lenin -= c->tcplen;
-                               memmove(c->buffer, c->buffer + c->tcplen, c->buflen);
-                               oldlen = 0;
-                               c->tcplen = 0;
-                               continue;
-                       } else {
-                               break;
-                       }
+       return receive_request(mesh, c, request);
+}
+
+bool receive_meta(meshlink_handle_t *mesh, connection_t *c) {
+       int inlen;
+       char inbuf[MAXBUFSIZE];
+
+       inlen = recv(c->socket, inbuf, sizeof(inbuf), 0);
+
+       if(inlen <= 0) {
+               if(!inlen || !errno) {
+                       logger(mesh, MESHLINK_INFO, "Connection closed by %s", c->name);
+               } else if(sockwouldblock(sockerrno)) {
+                       return true;
+               } else {
+                       logger(mesh, MESHLINK_ERROR, "Metadata socket read error for %s: %s", c->name, sockstrerror(sockerrno));
                }
 
-               /* Otherwise we are waiting for a request */
+               return false;
+       }
+
+       if(c->allow_request == ID) {
+               buffer_add(&c->inbuf, inbuf, inlen);
 
-               reqlen = 0;
+               char *request = buffer_readline(&c->inbuf);
 
-               for(i = oldlen; i < c->buflen; i++) {
-                       if(c->buffer[i] == '\n') {
-                               c->buffer[i] = '\0';    /* replace end-of-line by end-of-string so we can use sscanf */
-                               reqlen = i + 1;
-                               break;
+               if(request) {
+                       if(!receive_request(mesh, c, request) || c->allow_request == ID) {
+                               return false;
                        }
-               }
 
-               if(reqlen) {
-                       c->reqlen = reqlen;
-                       if(receive_request(c))
-                               return -1;
+                       int left = c->inbuf.len - c->inbuf.offset;
 
-                       c->buflen -= reqlen;
-                       lenin -= reqlen;
-                       memmove(c->buffer, c->buffer + reqlen, c->buflen);
-                       oldlen = 0;
-                       continue;
-               } else {
-                       break;
+                       if(left > 0) {
+                               return sptps_receive_data(&c->sptps, buffer_read(&c->inbuf, left), left);
+                       } else {
+                               return true;
+                       }
                }
-       }
 
-       if(c->buflen >= MAXBUFSIZE) {
-               syslog(LOG_ERR, _("Metadata read buffer overflow for %s (%s)"),
-                          c->name, c->hostname);
-               return -1;
+               if(c->inbuf.len >= sizeof(inbuf)) {
+                       logger(mesh, MESHLINK_ERROR, "Input buffer full for %s", c->name);
+                       return false;
+               } else {
+                       return true;
+               }
        }
 
-       c->last_ping_time = now;
-
-       return 0;
+       return sptps_receive_data(&c->sptps, inbuf, inlen);
 }