]> git.meshlink.io Git - meshlink/blobdiff - src/meshlink.c
Have try_bind() reuse the setup_*_listen_socket() functions.
[meshlink] / src / meshlink.c
index 3ebaee01da441aa589279e2ecd4076dd75cc7f1b..9f3b6ecd2094a89c92e68c0e9e62537b55a04518 100644 (file)
@@ -421,10 +421,15 @@ void remove_duplicate_hostnames(char *host[], char *port[], int n) {
 
 // This gets the hostname part for use in invitation URLs
 static char *get_my_hostname(meshlink_handle_t *mesh, uint32_t flags) {
-       char *hostname[4] = {NULL};
-       char *port[4] = {NULL};
+       int count = 4 + (mesh->invitation_addresses ? mesh->invitation_addresses->count : 0);
+       int n = 0;
+       char *hostname[count];
+       char *port[count];
        char *hostport = NULL;
 
+       memset(hostname, 0, sizeof(hostname));
+       memset(port, 0, sizeof(port));
+
        if(!(flags & (MESHLINK_INVITE_LOCAL | MESHLINK_INVITE_PUBLIC))) {
                flags |= MESHLINK_INVITE_LOCAL | MESHLINK_INVITE_PUBLIC;
        }
@@ -433,44 +438,61 @@ static char *get_my_hostname(meshlink_handle_t *mesh, uint32_t flags) {
                flags |= MESHLINK_INVITE_IPV4 | MESHLINK_INVITE_IPV6;
        }
 
+       // Add all explicitly set invitation addresses
+       if(mesh->invitation_addresses) {
+               for list_each(char, combo, mesh->invitation_addresses) {
+                       hostname[n] = xstrdup(combo);
+                       char *slash = strrchr(hostname[n], '/');
+
+                       if(slash) {
+                               *slash = 0;
+                               port[n] = xstrdup(slash + 1);
+                       }
+
+                       n++;
+               }
+       }
+
        // Add local addresses if requested
        if(flags & MESHLINK_INVITE_LOCAL) {
                if(flags & MESHLINK_INVITE_IPV4) {
-                       hostname[0] = meshlink_get_local_address_for_family(mesh, AF_INET);
+                       hostname[n++] = meshlink_get_local_address_for_family(mesh, AF_INET);
                }
 
                if(flags & MESHLINK_INVITE_IPV6) {
-                       hostname[1] = meshlink_get_local_address_for_family(mesh, AF_INET6);
+                       hostname[n++] = meshlink_get_local_address_for_family(mesh, AF_INET6);
                }
        }
 
        // Add public/canonical addresses if requested
        if(flags & MESHLINK_INVITE_PUBLIC) {
                // Try the CanonicalAddress first
-               get_canonical_address(mesh->self, &hostname[2], &port[2]);
+               get_canonical_address(mesh->self, &hostname[n], &port[n]);
 
-               if(!hostname[2]) {
+               if(!hostname[n] && count == 4) {
                        if(flags & MESHLINK_INVITE_IPV4) {
-                               hostname[2] = meshlink_get_external_address_for_family(mesh, AF_INET);
+                               hostname[n++] = meshlink_get_external_address_for_family(mesh, AF_INET);
                        }
 
                        if(flags & MESHLINK_INVITE_IPV6) {
-                               hostname[3] = meshlink_get_external_address_for_family(mesh, AF_INET6);
+                               hostname[n++] = meshlink_get_external_address_for_family(mesh, AF_INET6);
                        }
+               } else {
+                       n++;
                }
        }
 
-       for(int i = 0; i < 4; i++) {
+       for(int i = 0; i < n; i++) {
                // Ensure we always have a port number
                if(hostname[i] && !port[i]) {
                        port[i] = xstrdup(mesh->myport);
                }
        }
 
-       remove_duplicate_hostnames(hostname, port, 4);
+       remove_duplicate_hostnames(hostname, port, n);
 
        // Resolve the hostnames
-       for(int i = 0; i < 4; i++) {
+       for(int i = 0; i < n; i++) {
                if(!hostname[i]) {
                        continue;
                }
@@ -488,8 +510,10 @@ static char *get_my_hostname(meshlink_handle_t *mesh, uint32_t flags) {
                        continue;
                }
 
-               // Remember the address
-               node_add_recent_address(mesh, mesh->self, (sockaddr_t *)ai_in->ai_addr);
+               // Remember the address(es)
+               for(struct addrinfo *aip = ai_in; aip; aip = aip->ai_next) {
+                       node_add_recent_address(mesh, mesh->self, (sockaddr_t *)aip->ai_addr);
+               }
 
                if(flags & MESHLINK_INVITE_NUMERIC) {
                        // We don't need to do any further conversion
@@ -532,10 +556,10 @@ static char *get_my_hostname(meshlink_handle_t *mesh, uint32_t flags) {
        }
 
        // Remove duplicates again, since IPv4 and IPv6 addresses might map to the same hostname
-       remove_duplicate_hostnames(hostname, port, 4);
+       remove_duplicate_hostnames(hostname, port, n);
 
        // Concatenate all unique address to the hostport string
-       for(int i = 0; i < 4; i++) {
+       for(int i = 0; i < n; i++) {
                if(!hostname[i]) {
                        continue;
                }
@@ -553,7 +577,7 @@ static char *get_my_hostname(meshlink_handle_t *mesh, uint32_t flags) {
        return hostport;
 }
 
-static bool try_bind(int port) {
+static bool try_bind(meshlink_handle_t *mesh, int port) {
        struct addrinfo *ai = NULL;
        struct addrinfo hint = {
                .ai_flags = AI_PASSIVE,
@@ -574,16 +598,9 @@ static bool try_bind(int port) {
        for(struct addrinfo *aip = ai; aip; aip = aip->ai_next) {
                /* Try to bind to TCP. */
 
-               int tcp_fd = socket(aip->ai_family, SOCK_STREAM, IPPROTO_TCP);
+               int tcp_fd = setup_tcp_listen_socket(mesh, aip);
 
                if(tcp_fd == -1) {
-                       continue;
-               }
-
-               int result = bind(tcp_fd, aip->ai_addr, aip->ai_addrlen);
-               closesocket(tcp_fd);
-
-               if(result) {
                        if(errno == EADDRINUSE) {
                                /* If this port is in use for any address family, avoid it. */
                                success = false;
@@ -595,21 +612,16 @@ static bool try_bind(int port) {
 
                /* If TCP worked, then we require that UDP works as well. */
 
-               int udp_fd = socket(aip->ai_family, SOCK_DGRAM, IPPROTO_UDP);
+               int udp_fd = setup_udp_listen_socket(mesh, aip);
 
                if(udp_fd == -1) {
+                       closesocket(tcp_fd);
                        success = false;
                        break;
                }
 
-               result = bind(udp_fd, aip->ai_addr, aip->ai_addrlen);
+               closesocket(tcp_fd);
                closesocket(udp_fd);
-
-               if(result) {
-                       success = false;
-                       break;
-               }
-
                success = true;
        }
 
@@ -617,11 +629,11 @@ static bool try_bind(int port) {
        return success;
 }
 
-static int check_port(meshlink_handle_t *mesh) {
+int check_port(meshlink_handle_t *mesh) {
        for(int i = 0; i < 1000; i++) {
                int port = 0x1000 + prng(mesh, 0x8000);
 
-               if(try_bind(port)) {
+               if(try_bind(mesh, port)) {
                        free(mesh->myport);
                        xasprintf(&mesh->myport, "%d", port);
                        return port;
@@ -1789,6 +1801,10 @@ void meshlink_close(meshlink_handle_t *mesh) {
        free(mesh->external_address_url);
        ecdsa_free(mesh->private_key);
 
+       if(mesh->invitation_addresses) {
+               list_delete_list(mesh->invitation_addresses);
+       }
+
        main_config_unlock(mesh);
 
        pthread_mutex_unlock(&mesh->mutex);
@@ -2420,6 +2436,60 @@ bool meshlink_set_canonical_address(meshlink_handle_t *mesh, meshlink_node_t *no
        return config_sync(mesh, "current");
 }
 
+bool meshlink_add_invitation_address(struct meshlink_handle *mesh, const char *address, const char *port) {
+       if(!mesh || !address) {
+               meshlink_errno = MESHLINK_EINVAL;
+               return false;
+       }
+
+       if(!is_valid_hostname(address)) {
+               logger(mesh, MESHLINK_DEBUG, "Invalid character in address: %s\n", address);
+               meshlink_errno = MESHLINK_EINVAL;
+               return false;
+       }
+
+       if(port && !is_valid_port(port)) {
+               logger(mesh, MESHLINK_DEBUG, "Invalid character in port: %s\n", address);
+               meshlink_errno = MESHLINK_EINVAL;
+               return false;
+       }
+
+       char *combo;
+
+       if(port) {
+               xasprintf(&combo, "%s/%s", address, port);
+       } else {
+               combo = xstrdup(address);
+       }
+
+       pthread_mutex_lock(&mesh->mutex);
+
+       if(!mesh->invitation_addresses) {
+               mesh->invitation_addresses = list_alloc((list_action_t)free);
+       }
+
+       list_insert_tail(mesh->invitation_addresses, combo);
+       pthread_mutex_unlock(&mesh->mutex);
+
+       return true;
+}
+
+void meshlink_clear_invitation_addresses(struct meshlink_handle *mesh) {
+       if(!mesh) {
+               meshlink_errno = MESHLINK_EINVAL;
+               return;
+       }
+
+       pthread_mutex_lock(&mesh->mutex);
+
+       if(mesh->invitation_addresses) {
+               list_delete_list(mesh->invitation_addresses);
+               mesh->invitation_addresses = NULL;
+       }
+
+       pthread_mutex_unlock(&mesh->mutex);
+}
+
 bool meshlink_add_address(meshlink_handle_t *mesh, const char *address) {
        return meshlink_set_canonical_address(mesh, (meshlink_node_t *)mesh->self, address, NULL);
 }
@@ -2436,7 +2506,7 @@ bool meshlink_add_external_address(meshlink_handle_t *mesh) {
                return false;
        }
 
-       bool rval = meshlink_add_address(mesh, address);
+       bool rval = meshlink_set_canonical_address(mesh, (meshlink_node_t *)mesh->self, address, NULL);
        free(address);
 
        return rval;
@@ -2472,7 +2542,7 @@ bool meshlink_set_port(meshlink_handle_t *mesh, int port) {
                return true;
        }
 
-       if(!try_bind(port)) {
+       if(!try_bind(mesh, port)) {
                meshlink_errno = MESHLINK_ENETWORK;
                return false;
        }