/// Generate a path to the main configuration file.
static void make_main_path(meshlink_handle_t *mesh, const char *conf_subdir, char *path, size_t len) {
+ assert(conf_subdir);
+ assert(path);
+ assert(len);
+
snprintf(path, len, "%s" SLASH "%s" SLASH "meshlink.conf", mesh->confbase, conf_subdir);
}
/// Generate a path to a host configuration file.
static void make_host_path(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, char *path, size_t len) {
+ assert(conf_subdir);
+ assert(name);
+ assert(path);
+ assert(len);
+
snprintf(path, len, "%s" SLASH "%s" SLASH "hosts" SLASH "%s", mesh->confbase, conf_subdir, name);
}
/// Generate a path to an unused invitation file.
static void make_invitation_path(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, char *path, size_t len) {
+ assert(conf_subdir);
+ assert(name);
+ assert(path);
+ assert(len);
+
snprintf(path, len, "%s" SLASH "%s" SLASH "invitations" SLASH "%s", mesh->confbase, conf_subdir, name);
}
/// Generate a path to a used invitation file.
static void make_used_invitation_path(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, char *path, size_t len) {
+ assert(conf_subdir);
+ assert(name);
+ assert(path);
+ assert(len);
+
snprintf(path, len, "%s" SLASH "%s" SLASH "invitations" SLASH "%s.used", mesh->confbase, conf_subdir, name);
}
/// Remove a directory recursively
-static void deltree(const char *dirname) {
+static bool deltree(const char *dirname) {
+ assert(dirname);
+
DIR *d = opendir(dirname);
if(d) {
snprintf(filename, sizeof(filename), "%s" SLASH "%s", dirname, ent->d_name);
if(unlink(filename)) {
- deltree(filename);
+ if(!deltree(filename)) {
+ return false;
+ }
}
}
closedir(d);
+ } else {
+ return errno == ENOENT;
}
- rmdir(dirname);
+ return rmdir(dirname) == 0;
}
-static bool sync_path(const char *pathname) {
+bool sync_path(const char *pathname) {
+ assert(pathname);
+
int fd = open(pathname, O_RDONLY);
if(fd < 0) {
logger(NULL, MESHLINK_ERROR, "Failed to open %s: %s\n", pathname, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(fsync(fd)) {
logger(NULL, MESHLINK_ERROR, "Failed to sync %s: %s\n", pathname, strerror(errno));
close(fd);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(close(fd)) {
logger(NULL, MESHLINK_ERROR, "Failed to close %s: %s\n", pathname, strerror(errno));
close(fd);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
/// Try decrypting the main configuration file from the given sub-directory.
static bool main_config_decrypt(meshlink_handle_t *mesh, const char *conf_subdir) {
- if(!mesh->config_key && !mesh->confbase && !conf_subdir) {
- return false;
- }
+ assert(mesh->config_key);
+ assert(mesh->confbase);
+ assert(conf_subdir);
config_t config;
/// Create a fresh configuration directory
bool config_init(meshlink_handle_t *mesh, const char *conf_subdir) {
+ assert(conf_subdir);
+
if(!mesh->confbase) {
return true;
}
- if(!conf_subdir) {
- return false;
- }
-
- if(mkdir(mesh->confbase, 0700) && errno != EEXIST) {
- logger(mesh, MESHLINK_DEBUG, "Could not create directory %s: %s\n", mesh->confbase, strerror(errno));
- return false;
- }
-
char path[PATH_MAX];
// Create "current" sub-directory in the confbase
snprintf(path, sizeof(path), "%s" SLASH "%s", mesh->confbase, conf_subdir);
- deltree(path);
+
+ if(!deltree(path)) {
+ logger(mesh, MESHLINK_DEBUG, "Could not delete directory %s: %s\n", path, strerror(errno));
+ return false;
+ }
if(mkdir(path, 0700)) {
logger(mesh, MESHLINK_DEBUG, "Could not create directory %s: %s\n", path, strerror(errno));
/// Wipe an existing configuration directory
bool config_destroy(const char *confbase, const char *conf_subdir) {
- if(!confbase && !conf_subdir) {
- return false;
+ assert(conf_subdir);
+
+ if(!confbase) {
+ return true;
}
struct stat st;
}
snprintf(path, sizeof(path), "%s" SLASH "%s", confbase, conf_subdir);
- deltree(path);
- return true;
-}
-static bool copytree(const char *src_dir_name, const void *src_key, const char *dst_dir_name, const void *dst_key) {
- if(!src_dir_name || !dst_dir_name) {
+ if(!deltree(path)) {
+ logger(NULL, MESHLINK_ERROR, "Cannot delete %s: %s\n", path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
+ return sync_path(confbase);
+}
+
+static bool copytree(const char *src_dir_name, const void *src_key, const char *dst_dir_name, const void *dst_key) {
+ assert(src_dir_name);
+ assert(dst_dir_name);
+
char src_filename[PATH_MAX];
char dst_filename[PATH_MAX];
struct dirent *ent;
if(!src_dir) {
logger(NULL, MESHLINK_ERROR, "Could not open directory file %s\n", src_dir_name);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
// Delete if already exists and create a new destination directory
- deltree(dst_dir_name);
+ if(!deltree(dst_dir_name)) {
+ logger(NULL, MESHLINK_ERROR, "Cannot delete %s: %s\n", dst_dir_name, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
+ return false;
+ }
if(mkdir(dst_dir_name, 0700)) {
logger(NULL, MESHLINK_ERROR, "Could not create directory %s\n", dst_filename);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(ent->d_type == DT_DIR) {
if(!copytree(src_filename, src_key, dst_filename, dst_key)) {
logger(NULL, MESHLINK_ERROR, "Copying %s to %s failed\n", src_filename, dst_filename);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(stat(src_filename, &st)) {
logger(NULL, MESHLINK_ERROR, "Could not stat file `%s': %s\n", src_filename, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(!f) {
logger(NULL, MESHLINK_ERROR, "Failed to open `%s': %s\n", src_filename, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(!config_read_file(NULL, f, &config, src_key)) {
logger(NULL, MESHLINK_ERROR, "Failed to read `%s': %s\n", src_filename, strerror(errno));
fclose(f);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(fclose(f)) {
logger(NULL, MESHLINK_ERROR, "Failed to close `%s': %s\n", src_filename, strerror(errno));
config_free(&config);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(!f) {
logger(NULL, MESHLINK_ERROR, "Failed to open `%s': %s", dst_filename, strerror(errno));
config_free(&config);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
logger(NULL, MESHLINK_ERROR, "Failed to write `%s': %s", dst_filename, strerror(errno));
config_free(&config);
fclose(f);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(fclose(f)) {
logger(NULL, MESHLINK_ERROR, "Failed to close `%s': %s", dst_filename, strerror(errno));
config_free(&config);
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(utime(dst_filename, ×)) {
logger(NULL, MESHLINK_ERROR, "Failed to utime `%s': %s", dst_filename, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
}
}
bool config_copy(meshlink_handle_t *mesh, const char *src_dir_name, const void *src_key, const char *dst_dir_name, const void *dst_key) {
+ assert(src_dir_name);
+ assert(dst_dir_name);
+
char src_filename[PATH_MAX];
char dst_filename[PATH_MAX];
/// Check the presence of the main configuration file.
bool main_config_exists(meshlink_handle_t *mesh, const char *conf_subdir) {
- if(!mesh->confbase && !conf_subdir) {
+ assert(conf_subdir);
+
+ if(!mesh->confbase) {
return false;
}
}
bool config_rename(meshlink_handle_t *mesh, const char *old_conf_subdir, const char *new_conf_subdir) {
- if(!mesh->confbase && !old_conf_subdir && !new_conf_subdir) {
+ assert(old_conf_subdir);
+ assert(new_conf_subdir);
+
+ if(!mesh->confbase) {
return false;
}
snprintf(old_path, sizeof(old_path), "%s" SLASH "%s", mesh->confbase, old_conf_subdir);
snprintf(new_path, sizeof(new_path), "%s" SLASH "%s", mesh->confbase, new_conf_subdir);
- return rename(old_path, new_path) == 0;
+ return rename(old_path, new_path) == 0 && sync_path(mesh->confbase);
+}
+
+bool config_sync(meshlink_handle_t *mesh, const char *conf_subdir) {
+ assert(conf_subdir);
+
+ if(!mesh->confbase) {
+ return true;
+ }
+
+ char path[PATH_MAX];
+ snprintf(path, sizeof(path), "%s" SLASH "%s" SLASH "hosts", mesh->confbase, conf_subdir);
+
+ if(!sync_path(path)) {
+ return false;
+ }
+
+ snprintf(path, sizeof(path), "%s" SLASH "%s", mesh->confbase, conf_subdir);
+
+ if(!sync_path(path)) {
+ return false;
+ }
+
+ return true;
}
bool meshlink_confbase_exists(meshlink_handle_t *mesh) {
// Cleanup if current is existing with old and new
if(confbase_exists && confbase_decryptable) {
- config_destroy(mesh->confbase, "old");
- config_destroy(mesh->confbase, "new");
+ if(!config_destroy(mesh->confbase, "old") || !config_destroy(mesh->confbase, "new")) {
+ return false;
+ }
}
return confbase_exists;
}
-/// Lock the main configuration file.
+/// Lock the main configuration file. Creates confbase if necessary.
bool main_config_lock(meshlink_handle_t *mesh) {
if(!mesh->confbase) {
return true;
}
+ if(mkdir(mesh->confbase, 0700) && errno != EEXIST) {
+ logger(NULL, MESHLINK_ERROR, "Cannot create configuration directory %s: %s", mesh->confbase, strerror(errno));
+ meshlink_close(mesh);
+ meshlink_errno = MESHLINK_ESTORAGE;
+ return NULL;
+ }
+
char path[PATH_MAX];
- make_main_path(mesh, "current", path, sizeof(path));
+ snprintf(path, sizeof(path), "%s" SLASH "meshlink.lock", mesh->confbase);
- mesh->conffile = fopen(path, "r");
+ mesh->lockfile = fopen(path, "w+");
- if(!mesh->conffile) {
+ if(!mesh->lockfile) {
logger(NULL, MESHLINK_ERROR, "Cannot not open %s: %s\n", path, strerror(errno));
meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
#ifdef FD_CLOEXEC
- fcntl(fileno(mesh->conffile), F_SETFD, FD_CLOEXEC);
+ fcntl(fileno(mesh->lockfile), F_SETFD, FD_CLOEXEC);
#endif
#ifdef HAVE_MINGW
// TODO: use _locking()?
#else
- if(flock(fileno(mesh->conffile), LOCK_EX | LOCK_NB) != 0) {
+ if(flock(fileno(mesh->lockfile), LOCK_EX | LOCK_NB) != 0) {
logger(NULL, MESHLINK_ERROR, "Cannot lock %s: %s\n", path, strerror(errno));
- fclose(mesh->conffile);
- mesh->conffile = NULL;
+ fclose(mesh->lockfile);
+ mesh->lockfile = NULL;
meshlink_errno = MESHLINK_EBUSY;
return false;
}
/// Unlock the main configuration file.
void main_config_unlock(meshlink_handle_t *mesh) {
- if(mesh->conffile) {
- fclose(mesh->conffile);
- mesh->conffile = NULL;
+ if(mesh->lockfile) {
+ fclose(mesh->lockfile);
+ mesh->lockfile = NULL;
}
}
/// Read a configuration file from a FILE handle.
bool config_read_file(meshlink_handle_t *mesh, FILE *f, config_t *config, const void *key) {
+ assert(f);
+
long len;
if(fseek(f, 0, SEEK_END) || !(len = ftell(f)) || fseek(f, 0, SEEK_SET)) {
logger(mesh, MESHLINK_ERROR, "Cannot get config file size: %s\n", strerror(errno));
meshlink_errno = MESHLINK_ESTORAGE;
- fclose(f);
return false;
}
if(fread(buf, len, 1, f) != 1) {
logger(mesh, MESHLINK_ERROR, "Cannot read config file: %s\n", strerror(errno));
meshlink_errno = MESHLINK_ESTORAGE;
- fclose(f);
return false;
}
/// Write a configuration file to a FILE handle.
bool config_write_file(meshlink_handle_t *mesh, FILE *f, const config_t *config, const void *key) {
+ assert(f);
+
if(key) {
uint8_t buf[config->len + 16];
size_t len = sizeof(buf);
if(chacha_poly1305_encrypt_iv96(ctx, seqbuf, config->buf, config->len, buf, &len)) {
success = fwrite(seqbuf, sizeof(seqbuf), 1, f) == 1 && fwrite(buf, len, 1, f) == 1;
+
+ if(!success) {
+ logger(mesh, MESHLINK_ERROR, "Cannot write config file: %s", strerror(errno));
+ }
+
+ meshlink_errno = MESHLINK_ESTORAGE;
} else {
logger(mesh, MESHLINK_ERROR, "Cannot encrypt config file\n");
meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
+ if(fflush(f)) {
+ logger(mesh, MESHLINK_ERROR, "Failed to flush file: %s", strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
+ return false;
+ }
+
if(fsync(fileno(f))) {
logger(mesh, MESHLINK_ERROR, "Failed to sync file: %s\n", strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
/// Free resources of a loaded configuration file.
void config_free(config_t *config) {
+ assert(!config->len || config->buf);
+
free((uint8_t *)config->buf);
config->buf = NULL;
config->len = 0;
/// Check the presence of a host configuration file.
bool config_exists(meshlink_handle_t *mesh, const char *conf_subdir, const char *name) {
- if(!mesh->confbase && !conf_subdir) {
+ assert(conf_subdir);
+
+ if(!mesh->confbase) {
return false;
}
/// Read a host configuration file.
bool config_read(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, config_t *config, void *key) {
- if(!mesh->confbase && !conf_subdir) {
+ assert(conf_subdir);
+
+ if(!mesh->confbase) {
return false;
}
}
bool config_scan_all(meshlink_handle_t *mesh, const char *conf_subdir, const char *conf_type, config_scan_action_t action, void *arg) {
- if(!mesh->confbase && !conf_subdir && !conf_type) {
- return false;
+ assert(conf_subdir);
+ assert(conf_type);
+
+ if(!mesh->confbase) {
+ return true;
}
DIR *dir;
/// Write a host configuration file.
bool config_write(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, const config_t *config, void *key) {
- if(!mesh->confbase && !conf_subdir && !name) {
+ assert(conf_subdir);
+ assert(name);
+ assert(config);
+
+ if(!mesh->confbase) {
return true;
}
if(!f) {
logger(mesh, MESHLINK_ERROR, "Failed to open `%s': %s", tmp_path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
return false;
}
- if(fsync(fileno(f))) {
- logger(mesh, MESHLINK_ERROR, "Failed to sync `%s': %s", tmp_path, strerror(errno));
- fclose(f);
- return false;
- }
-
if(fclose(f)) {
logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", tmp_path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
if(rename(tmp_path, path)) {
logger(mesh, MESHLINK_ERROR, "Failed to rename `%s' to `%s': %s", tmp_path, path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
+ return false;
+ }
+
+ return true;
+}
+
+/// Delete a host configuration file.
+bool config_delete(meshlink_handle_t *mesh, const char *conf_subdir, const char *name) {
+ assert(conf_subdir);
+ assert(name);
+
+ if(!mesh->confbase) {
+ return true;
+ }
+
+ char path[PATH_MAX];
+ make_host_path(mesh, conf_subdir, name, path, sizeof(path));
+
+ if(unlink(path) && errno != ENOENT) {
+ logger(mesh, MESHLINK_ERROR, "Failed to unlink `%s': %s", path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
/// Read the main configuration file.
bool main_config_read(meshlink_handle_t *mesh, const char *conf_subdir, config_t *config, void *key) {
- if(!mesh->confbase && !conf_subdir) {
+ assert(conf_subdir);
+ assert(config);
+
+ if(!mesh->confbase) {
return false;
}
/// Write the main configuration file.
bool main_config_write(meshlink_handle_t *mesh, const char *conf_subdir, const config_t *config, void *key) {
- if(!mesh->confbase && !conf_subdir) {
+ assert(conf_subdir);
+ assert(config);
+
+ if(!mesh->confbase) {
return true;
}
if(!f) {
logger(mesh, MESHLINK_ERROR, "Failed to open `%s': %s", tmp_path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
return false;
}
- if(fsync(fileno(f))) {
- logger(mesh, MESHLINK_ERROR, "Failed to sync `%s': %s", tmp_path, strerror(errno));
- fclose(f);
- return false;
- }
-
if(rename(tmp_path, path)) {
logger(mesh, MESHLINK_ERROR, "Failed to rename `%s' to `%s': %s", tmp_path, path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
+ fclose(f);
return false;
}
if(fclose(f)) {
logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", tmp_path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
/// Read an invitation file from the confbase sub-directory, and immediately delete it.
bool invitation_read(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, config_t *config, void *key) {
- if(!mesh->confbase && !conf_subdir) {
+ assert(conf_subdir);
+ assert(name);
+ assert(config);
+
+ if(!mesh->confbase) {
return false;
}
return false;
}
- if(mesh->loop.now.tv_sec > st.st_mtime + mesh->invitation_timeout) {
+ if(mesh->loop.now.tv_sec >= st.st_mtime + mesh->invitation_timeout) {
logger(mesh, MESHLINK_ERROR, "Peer tried to use an outdated invitation file %s\n", name);
fclose(f);
unlink(used_path);
fclose(f);
- unlink(used_path);
+ if(unlink(used_path)) {
+ logger(mesh, MESHLINK_ERROR, "Failed to unlink `%s': %s", path, strerror(errno));
+ return false;
+ }
+
+ snprintf(path, sizeof(path), "%s" SLASH "%s" SLASH "invitations", mesh->confbase, conf_subdir);
+
+ if(!sync_path(path)) {
+ logger(mesh, MESHLINK_ERROR, "Failed to sync `%s': %s", path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
+ return false;
+ }
+
return true;
}
/// Write an invitation file.
bool invitation_write(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, const config_t *config, void *key) {
- if(!mesh->confbase && !conf_subdir) {
+ assert(conf_subdir);
+ assert(name);
+ assert(config);
+
+ if(!mesh->confbase) {
return false;
}
if(!f) {
logger(mesh, MESHLINK_ERROR, "Failed to open `%s': %s", path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
return false;
}
- if(fsync(fileno(f))) {
- logger(mesh, MESHLINK_ERROR, "Failed to sync `%s': %s", path, strerror(errno));
+ if(fclose(f)) {
+ logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
- if(fclose(f)) {
- logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", path, strerror(errno));
+ snprintf(path, sizeof(path), "%s" SLASH "%s" SLASH "invitations", mesh->confbase, conf_subdir);
+
+ if(!sync_path(path)) {
+ logger(mesh, MESHLINK_ERROR, "Failed to sync `%s': %s", path, strerror(errno));
+ meshlink_errno = MESHLINK_ESTORAGE;
return false;
}
projects / meshlink / blobdiff