Add missing newline.

[meshlink] / src / tincctl.c

diff --git a/src/tincctl.c b/src/tincctl.c
index 7d27341effe7f21f397f10ef32761decc9426420..c055db5af01b6cd733a574f8713d527324dbc36a 100644 (file)
--- a/src/tincctl.c
+++ b/src/tincctl.c
@@ -405,14 +405,14 @@ bool recvdata(int fd, char *data, size_t len) {
 bool sendline(int fd, char *format, ...) {
        static char buffer[4096];
        char *p = buffer;
-       size_t blen = 0;
+       int blen = 0;
        va_list ap;
 
        va_start(ap, format);
        blen = vsnprintf(buffer, sizeof buffer, format, ap);
        va_end(ap);
 
-       if(blen < 0 || blen >= sizeof buffer)
+       if(blen < 1 || blen >= sizeof buffer)
                return false;
 
        buffer[blen] = '\n';
@@ -422,7 +422,7 @@ bool sendline(int fd, char *format, ...) {
                int result = send(fd, p, blen, 0);
                if(result == -1 && errno == EINTR)
                        continue;
-               else if(result <= 0);
+               else if(result <= 0)
                        return false;
                p += result;
                blen -= result;
@@ -482,6 +482,41 @@ void pcap(int fd, FILE *out) {
        }
 }
 
+#ifdef HAVE_MINGW
+static bool remove_service(void) {
+       SC_HANDLE manager = NULL;
+       SC_HANDLE service = NULL;
+       SERVICE_STATUS status = {0};
+
+       manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
+       if(!manager) {
+               fprintf(stderr, "Could not open service manager: %s\n", winerror(GetLastError()));
+               return false;
+       }
+
+       service = OpenService(manager, identname, SERVICE_ALL_ACCESS);
+
+       if(!service) {
+               fprintf(stderr, "Could not open %s service: %s\n", identname, winerror(GetLastError()));
+               return false;
+       }
+
+       if(!ControlService(service, SERVICE_CONTROL_STOP, &status))
+               fprintf(stderr, "Could not stop %s service: %s\n", identname, winerror(GetLastError()));
+       else
+               fprintf(stderr, "%s service stopped\n", identname);
+
+       if(!DeleteService(service)) {
+               fprintf(stderr, "Could not remove %s service: %s\n", identname, winerror(GetLastError()));
+               return false;
+       }
+
+       fprintf(stderr, "%s service removed\n", identname);
+
+       return true;
+}
+#endif
+
 int main(int argc, char *argv[], char *envp[]) {
        int fd;
        int result;
@@ -574,7 +609,7 @@ int main(int argc, char *argv[], char *envp[]) {
        struct addrinfo *res = NULL;
 
        if(getaddrinfo(host, port, &hints, &res) || !res) {
-               fprintf(stderr, "Cannot resolve %s port %s: %s", host ?: "localhost", port, strerror(errno));
+               fprintf(stderr, "Cannot resolve %s port %s: %s", host, port, strerror(errno));
                return 1;
        }
 
@@ -593,7 +628,7 @@ int main(int argc, char *argv[], char *envp[]) {
 #endif
 
        if(connect(fd, res->ai_addr, res->ai_addrlen) < 0) {
-               fprintf(stderr, "Cannot connect to %s port %s: %s\n", host ?: "localhost", port, sockstrerror(sockerrno));
+               fprintf(stderr, "Cannot connect to %s port %s: %s\n", host, port, sockstrerror(sockerrno));
                return 1;
        }
 
@@ -622,11 +657,16 @@ int main(int argc, char *argv[], char *envp[]) {
        }
 
        if(!strcasecmp(argv[optind], "stop")) {
+#ifndef HAVE_MINGW
                sendline(fd, "%d %d", CONTROL, REQ_STOP);
                if(!recvline(fd, line, sizeof line) || sscanf(line, "%d %d %d", &code, &req, &result) != 3 || code != CONTROL || req != REQ_STOP || result) {
                        fprintf(stderr, "Could not stop tinc daemon\n");
                        return 1;
                }
+#else
+               if(!remove_service())
+                       return 1;
+#endif
                return 0;
        }