src/net_socket.c bind_to_address(): Use after free in error path.

[meshlink] / src / net_socket.c

diff --git a/src/net_socket.c b/src/net_socket.c
index 163553ad3de22374e4c13ea287438f98efe28f71..db7fb5c190f6af51d8a2d3ac7830cbae2d27b686 100644 (file)
--- a/src/net_socket.c
+++ b/src/net_socket.c
@@ -137,9 +137,9 @@ static bool bind_to_address(connection_t *c) {
        status = getaddrinfo(node, /* service = */ NULL,
                        &ai_hints, &ai_list);
        if(status) {
-               free(node);
                logger(LOG_WARNING, "Error looking up %s port %s: %s",
                                node, "any", gai_strerror(status));
+               free(node);
                return false;
        }
        assert(ai_list != NULL);
@@ -449,7 +449,7 @@ begin:
        return;
 }
 
-void handle_meta_write(int sock, short events, void *data) {
+static void handle_meta_write(int sock, short events, void *data) {
        ifdebug(META) logger(LOG_DEBUG, "handle_meta_write() called");
 
        connection_t *c = data;
@@ -466,7 +466,7 @@ void handle_meta_write(int sock, short events, void *data) {
                event_del(&c->outevent);
 }
 
-void handle_meta_connection_error(struct bufferevent *event, short what, void *data) {
+static void handle_meta_connection_error(struct bufferevent *event, short what, void *data) {
        connection_t *c = data;
        logger(LOG_ERR, "handle_meta_connection_error() called: %d: %s", what, strerror(errno));
        terminate_connection(c, c->status.active);
@@ -564,7 +564,7 @@ void handle_new_meta_connection(int sock, short events, void *data) {
        send_id(c);
 }
 
-void free_outgoing(outgoing_t *outgoing) {
+static void free_outgoing(outgoing_t *outgoing) {
        if(outgoing->ai)
                freeaddrinfo(outgoing->ai);