Remove unnecessary parentheses from sizeof, apply sizeof to variables instead of...

[meshlink] / src / conf.c

diff --git a/src/conf.c b/src/conf.c
index 49b78bbc0593acfe5f56e080dc14b20161ab7b17..1b0ac641fceda969305e347da768cd27eff6a6b8 100644 (file)
--- a/src/conf.c
+++ b/src/conf.c
@@ -218,9 +218,9 @@ bool get_config_subnet(const config_t *cfg, subnet_t ** result) {
        /* Teach newbies what subnets are... */
 
        if(((subnet.type == SUBNET_IPV4)
-               && !maskcheck(&subnet.net.ipv4.address, subnet.net.ipv4.prefixlength, sizeof(ipv4_t)))
+               && !maskcheck(&subnet.net.ipv4.address, subnet.net.ipv4.prefixlength, sizeof subnet.net.ipv4.address))
                || ((subnet.type == SUBNET_IPV6)
-               && !maskcheck(&subnet.net.ipv6.address, subnet.net.ipv6.prefixlength, sizeof(ipv6_t)))) {
+               && !maskcheck(&subnet.net.ipv6.address, subnet.net.ipv6.prefixlength, sizeof subnet.net.ipv6.address))) {
                logger(LOG_ERR, _ ("Network address and prefix length do not match for configuration variable %s in %s line %d"),
                           cfg->variable, cfg->file, cfg->line);
                return false;
@@ -328,6 +328,11 @@ int read_config_file(splay_tree_t *config_tree, const char *fname) {
        buffer = xmalloc(bufsize);
 
        for(;;) {
+               if(feof(fp)) {
+                       err = 0;
+                       break;
+               }
+
                line = readline(fp, &buffer, &bufsize);
 
                if(!line) {
@@ -335,11 +340,6 @@ int read_config_file(splay_tree_t *config_tree, const char *fname) {
                        break;
                }
 
-               if(feof(fp)) {
-                       err = 0;
-                       break;
-               }
-
                lineno++;
 
                if(!*line || *line == '#')
@@ -410,66 +410,3 @@ bool read_server_config() {
 
        return x == 0;
 }
-
-FILE *ask_and_open(const char *filename, const char *what, const char *mode) {
-       FILE *r;
-       char *directory;
-       char *fn;
-
-       /* Check stdin and stdout */
-       if(!isatty(0) || !isatty(1)) {
-               /* Argh, they are running us from a script or something.  Write
-                  the files to the current directory and let them burn in hell
-                  for ever. */
-               fn = xstrdup(filename);
-       } else {
-               /* Ask for a file and/or directory name. */
-               fprintf(stdout, _("Please enter a file to save %s to [%s]: "),
-                               what, filename);
-               fflush(stdout);
-
-               fn = readline(stdin, NULL, NULL);
-
-               if(!fn) {
-                       fprintf(stderr, _("Error while reading stdin: %s\n"),
-                                       strerror(errno));
-                       return NULL;
-               }
-
-               if(!strlen(fn))
-                       /* User just pressed enter. */
-                       fn = xstrdup(filename);
-       }
-
-#ifdef HAVE_MINGW
-       if(fn[0] != '\\' && fn[0] != '/' && !strchr(fn, ':')) {
-#else
-       if(fn[0] != '/') {
-#endif
-               /* The directory is a relative path or a filename. */
-               char *p;
-
-               directory = get_current_dir_name();
-               asprintf(&p, "%s/%s", directory, fn);
-               free(fn);
-               free(directory);
-               fn = p;
-       }
-
-       umask(0077);                            /* Disallow everything for group and other */
-
-       /* Open it first to keep the inode busy */
-
-       r = fopen(fn, mode);
-
-       if(!r) {
-               fprintf(stderr, _("Error opening file `%s': %s\n"),
-                               fn, strerror(errno));
-               free(fn);
-               return NULL;
-       }
-
-       free(fn);
-
-       return r;
-}