]> git.meshlink.io Git - catta/blobdiff - avahi-core/resolve-service.c
forgot to pull the publish_no_reverse change to the example.
[catta] / avahi-core / resolve-service.c
index de347e278d56bb58a3acc0c32a3970295919ff8d..3377a509cc76d0fd3123b3b941b318300d6aaaae 100644 (file)
@@ -1,18 +1,16 @@
-/* $Id$ */
-
 /***
   This file is part of avahi.
+
   avahi is free software; you can redistribute it and/or modify it
   under the terms of the GNU Lesser General Public License as
   published by the Free Software Foundation; either version 2.1 of the
   License, or (at your option) any later version.
+
   avahi is distributed in the hope that it will be useful, but WITHOUT
   ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
   or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General
   Public License for more details.
+
   You should have received a copy of the GNU Lesser General Public
   License along with avahi; if not, write to the Free Software
   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
@@ -54,7 +52,7 @@ struct AvahiSServiceResolver {
 
     AvahiRecord *srv_record, *txt_record, *address_record;
     AvahiLookupResultFlags srv_flags, txt_flags, address_flags;
-    
+
     AvahiSServiceResolverCallback callback;
     void* userdata;
     AvahiLookupFlags user_flags;
@@ -66,7 +64,7 @@ struct AvahiSServiceResolver {
 
 static void finish(AvahiSServiceResolver *r, AvahiResolverEvent event) {
     AvahiLookupResultFlags flags;
-    
+
     assert(r);
 
     if (r->time_event) {
@@ -78,12 +76,10 @@ static void finish(AvahiSServiceResolver *r, AvahiResolverEvent event) {
         r->txt_flags |
         r->srv_flags |
         r->address_flags;
-    
+
     switch (event) {
         case AVAHI_RESOLVER_FAILURE:
-        case AVAHI_RESOLVER_NOT_FOUND:
-        case AVAHI_RESOLVER_TIMEOUT:
-            
+
             r->callback(
                 r,
                 r->interface,
@@ -103,9 +99,9 @@ static void finish(AvahiSServiceResolver *r, AvahiResolverEvent event) {
 
         case AVAHI_RESOLVER_FOUND: {
             AvahiAddress a;
-            
+
             assert(event == AVAHI_RESOLVER_FOUND);
-            
+
             assert(r->srv_record);
 
             if (r->address_record) {
@@ -114,17 +110,17 @@ static void finish(AvahiSServiceResolver *r, AvahiResolverEvent event) {
                         a.proto = AVAHI_PROTO_INET;
                         a.data.ipv4 = r->address_record->data.a.address;
                         break;
-                        
+
                     case AVAHI_DNS_TYPE_AAAA:
                         a.proto = AVAHI_PROTO_INET6;
                         a.data.ipv6 = r->address_record->data.aaaa.address;
                         break;
-                        
+
                     default:
                         assert(0);
                 }
             }
-            
+
             r->callback(
                 r,
                 r->interface,
@@ -133,7 +129,7 @@ static void finish(AvahiSServiceResolver *r, AvahiResolverEvent event) {
                 r->service_name,
                 r->service_type,
                 r->domain_name,
-                r->address_record ? r->address_record->key->name : r->srv_record->data.srv.name,
+                r->srv_record->data.srv.name,
                 r->address_record ? &a : NULL,
                 r->srv_record->data.srv.port,
                 r->txt_record ? r->txt_record->data.txt.string_list : NULL,
@@ -147,13 +143,12 @@ static void finish(AvahiSServiceResolver *r, AvahiResolverEvent event) {
 
 static void time_event_callback(AvahiTimeEvent *e, void *userdata) {
     AvahiSServiceResolver *r = userdata;
-    
+
     assert(e);
     assert(r);
 
-    avahi_log_debug("timeout");
-    
-    finish(r, AVAHI_RESOLVER_TIMEOUT);
+    avahi_server_set_errno(r->server, AVAHI_ERR_TIMEOUT);
+    finish(r, AVAHI_RESOLVER_FAILURE);
 }
 
 static void start_timeout(AvahiSServiceResolver *r) {
@@ -176,7 +171,7 @@ static void record_browser_callback(
     AvahiRecord *record,
     AvahiLookupResultFlags flags,
     void* userdata) {
-    
+
     AvahiSServiceResolver *r = userdata;
 
     assert(rr);
@@ -194,30 +189,30 @@ static void record_browser_callback(
         case AVAHI_BROWSER_NEW: {
             int changed = 0;
             assert(record);
-            
+
             if (r->interface > 0 && interface > 0 &&  interface != r->interface)
                 return;
-            
+
             if (r->protocol != AVAHI_PROTO_UNSPEC && protocol != AVAHI_PROTO_UNSPEC && protocol != r->protocol)
                 return;
-            
+
             if (r->interface <= 0)
                 r->interface = interface;
-            
+
             if (r->protocol == AVAHI_PROTO_UNSPEC)
                 r->protocol = protocol;
-            
+
             switch (record->key->type) {
                 case AVAHI_DNS_TYPE_SRV:
                     if (!r->srv_record) {
                         r->srv_record = avahi_record_ref(record);
                         changed = 1;
-                        
+
                         if (r->record_browser_a) {
                             avahi_s_record_browser_free(r->record_browser_a);
                             r->record_browser_a = NULL;
                         }
-                        
+
                         if (r->record_browser_aaaa) {
                             avahi_s_record_browser_free(r->record_browser_aaaa);
                             r->record_browser_aaaa = NULL;
@@ -229,8 +224,8 @@ static void record_browser_callback(
                                 AvahiKey *k = avahi_key_new(r->srv_record->data.srv.name, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_A);
                                 r->record_browser_a = avahi_s_record_browser_new(r->server, r->interface, r->protocol, k, r->user_flags & ~(AVAHI_LOOKUP_NO_TXT|AVAHI_LOOKUP_NO_ADDRESS), record_browser_callback, r);
                                 avahi_key_unref(k);
-                            } 
-                        
+                            }
+
                             if (r->address_protocol == AVAHI_PROTO_INET6 || r->address_protocol == AVAHI_PROTO_UNSPEC) {
                                 AvahiKey *k = avahi_key_new(r->srv_record->data.srv.name, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_AAAA);
                                 r->record_browser_aaaa = avahi_s_record_browser_new(r->server, r->interface, r->protocol, k, r->user_flags & ~(AVAHI_LOOKUP_NO_TXT|AVAHI_LOOKUP_NO_ADDRESS), record_browser_callback, r);
@@ -239,7 +234,7 @@ static void record_browser_callback(
                         }
                     }
                     break;
-                
+
                 case AVAHI_DNS_TYPE_TXT:
 
                     assert(!(r->user_flags & AVAHI_LOOKUP_NO_TXT));
@@ -249,7 +244,7 @@ static void record_browser_callback(
                         changed = 1;
                     }
                     break;
-                
+
                 case AVAHI_DNS_TYPE_A:
                 case AVAHI_DNS_TYPE_AAAA:
 
@@ -260,7 +255,7 @@ static void record_browser_callback(
                         changed = 1;
                     }
                     break;
-                
+
                 default:
                     abort();
             }
@@ -275,14 +270,14 @@ static void record_browser_callback(
             break;
 
         }
-            
+
         case AVAHI_BROWSER_REMOVE:
 
             assert(record);
 
             switch (record->key->type) {
                 case AVAHI_DNS_TYPE_SRV:
-                    
+
                     if (r->srv_record && avahi_record_equal_no_ttl(record, r->srv_record)) {
                         avahi_record_unref(r->srv_record);
                         r->srv_record = NULL;
@@ -291,42 +286,42 @@ static void record_browser_callback(
                             avahi_s_record_browser_free(r->record_browser_a);
                             r->record_browser_a = NULL;
                         }
-                        
+
                         if (r->record_browser_aaaa) {
                             avahi_s_record_browser_free(r->record_browser_aaaa);
                             r->record_browser_aaaa = NULL;
                         }
-                        
+
                         /** Look for a replacement */
                         avahi_s_record_browser_restart(r->record_browser_srv);
                         start_timeout(r);
                     }
-                    
+
                     break;
-                    
+
                 case AVAHI_DNS_TYPE_TXT:
-                    
+
                     assert(!(r->user_flags & AVAHI_LOOKUP_NO_TXT));
-                    
+
                     if (r->txt_record && avahi_record_equal_no_ttl(record, r->txt_record)) {
                         avahi_record_unref(r->txt_record);
                         r->txt_record = NULL;
-                        
+
                         /** Look for a replacement */
                         avahi_s_record_browser_restart(r->record_browser_txt);
                         start_timeout(r);
                     }
                     break;
-                    
+
                 case AVAHI_DNS_TYPE_A:
                 case AVAHI_DNS_TYPE_AAAA:
-                    
+
                     assert(!(r->user_flags & AVAHI_LOOKUP_NO_ADDRESS));
-                    
+
                     if (r->address_record && avahi_record_equal_no_ttl(record, r->address_record)) {
                         avahi_record_unref(r->address_record);
                         r->address_record = NULL;
-                        
+
                         /** Look for a replacement */
                         if (r->record_browser_aaaa)
                             avahi_s_record_browser_restart(r->record_browser_aaaa);
@@ -335,7 +330,7 @@ static void record_browser_callback(
                         start_timeout(r);
                     }
                     break;
-                    
+
                 default:
                     abort();
             }
@@ -346,10 +341,8 @@ static void record_browser_callback(
         case AVAHI_BROWSER_ALL_FOR_NOW:
             break;
 
-        case AVAHI_BROWSER_NOT_FOUND:
         case AVAHI_BROWSER_FAILURE:
 
-            
             if (rr == r->record_browser_a && r->record_browser_aaaa) {
                 /* We were looking for both AAAA and A, and the other query is still living, so we'll not die */
                 avahi_s_record_browser_free(r->record_browser_a);
@@ -364,9 +357,8 @@ static void record_browser_callback(
                 break;
             }
 
-
             /* Hmm, everything's lost, tell the user */
-            
+
             if (r->record_browser_srv)
                 avahi_s_record_browser_free(r->record_browser_srv);
             if (r->record_browser_txt)
@@ -378,7 +370,7 @@ static void record_browser_callback(
 
             r->record_browser_srv = r->record_browser_txt = r->record_browser_a = r->record_browser_aaaa = NULL;
 
-            finish(r, event == AVAHI_BROWSER_FAILURE ? AVAHI_RESOLVER_FAILURE : AVAHI_RESOLVER_NOT_FOUND);
+            finish(r, AVAHI_RESOLVER_FAILURE);
             break;
     }
 }
@@ -394,55 +386,41 @@ AvahiSServiceResolver *avahi_s_service_resolver_new(
     AvahiLookupFlags flags,
     AvahiSServiceResolverCallback callback,
     void* userdata) {
-    
+
     AvahiSServiceResolver *r;
     AvahiKey *k;
-    char t[256];
+    char n[AVAHI_DOMAIN_NAME_MAX];
     int ret;
-    
+
     assert(server);
     assert(type);
     assert(callback);
 
-    assert(aprotocol == AVAHI_PROTO_UNSPEC || aprotocol == AVAHI_PROTO_INET || aprotocol == AVAHI_PROTO_INET6);
-
-    if (!AVAHI_IF_VALID(interface)) {
-        avahi_server_set_errno(server, AVAHI_ERR_INVALID_INTERFACE);
-        return NULL;
-    }
-
-    if (name && !avahi_is_valid_service_name(name)) {
-        avahi_server_set_errno(server, AVAHI_ERR_INVALID_SERVICE_NAME);
-        return NULL;
-    }
-
-    if (!avahi_is_valid_service_type(type)) {
-        avahi_server_set_errno(server, AVAHI_ERR_INVALID_SERVICE_TYPE);
-        return NULL;
-    }
-
-    if (domain && !avahi_is_valid_domain_name(domain)) {
-        avahi_server_set_errno(server, AVAHI_ERR_INVALID_DOMAIN_NAME);
-        return NULL;
-    }
+    AVAHI_CHECK_VALIDITY_RETURN_NULL(server, AVAHI_IF_VALID(interface), AVAHI_ERR_INVALID_INTERFACE);
+    AVAHI_CHECK_VALIDITY_RETURN_NULL(server, AVAHI_PROTO_VALID(protocol), AVAHI_ERR_INVALID_PROTOCOL);
+    AVAHI_CHECK_VALIDITY_RETURN_NULL(server, AVAHI_PROTO_VALID(aprotocol), AVAHI_ERR_INVALID_PROTOCOL);
+    AVAHI_CHECK_VALIDITY_RETURN_NULL(server, !domain || avahi_is_valid_domain_name(domain), AVAHI_ERR_INVALID_DOMAIN_NAME);
+    AVAHI_CHECK_VALIDITY_RETURN_NULL(server, !name || avahi_is_valid_service_name(name), AVAHI_ERR_INVALID_SERVICE_NAME);
+    AVAHI_CHECK_VALIDITY_RETURN_NULL(server, avahi_is_valid_service_type_strict(type), AVAHI_ERR_INVALID_SERVICE_TYPE);
+    AVAHI_CHECK_VALIDITY_RETURN_NULL(server, AVAHI_FLAGS_VALID(flags, AVAHI_LOOKUP_USE_WIDE_AREA|AVAHI_LOOKUP_USE_MULTICAST|AVAHI_LOOKUP_NO_TXT|AVAHI_LOOKUP_NO_ADDRESS), AVAHI_ERR_INVALID_FLAGS);
 
     if (!domain)
         domain = server->domain_name;
-    
-    if (!AVAHI_FLAGS_VALID(flags, AVAHI_LOOKUP_USE_WIDE_AREA|AVAHI_LOOKUP_USE_MULTICAST|AVAHI_LOOKUP_NO_TXT|AVAHI_LOOKUP_NO_ADDRESS)) {
-        avahi_server_set_errno(server, AVAHI_ERR_INVALID_FLAGS);
+
+    if ((ret = avahi_service_name_join(n, sizeof(n), name, type, domain)) < 0) {
+        avahi_server_set_errno(server, ret);
         return NULL;
     }
-    
+
     if (!(r = avahi_new(AvahiSServiceResolver, 1))) {
         avahi_server_set_errno(server, AVAHI_ERR_NO_MEMORY);
         return NULL;
     }
-    
+
     r->server = server;
     r->service_name = avahi_strdup(name);
-    r->service_type = avahi_normalize_name(type);
-    r->domain_name = avahi_normalize_name(domain);
+    r->service_type = avahi_normalize_name_strdup(type);
+    r->domain_name = avahi_normalize_name_strdup(domain);
     r->callback = callback;
     r->userdata = userdata;
     r->address_protocol = aprotocol;
@@ -455,13 +433,7 @@ AvahiSServiceResolver *avahi_s_service_resolver_new(
     r->time_event = NULL;
     AVAHI_LLIST_PREPEND(AvahiSServiceResolver, resolver, server->service_resolvers, r);
 
-    if ((ret = avahi_service_name_snprint(t, sizeof(t), name, r->service_type, r->domain_name)) < 0) {
-        avahi_server_set_errno(server, ret);
-        avahi_s_service_resolver_free(r);
-        return NULL;
-    }
-    
-    k = avahi_key_new(t, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_SRV);
+    k = avahi_key_new(n, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_SRV);
     r->record_browser_srv = avahi_s_record_browser_new(server, interface, protocol, k, flags & ~(AVAHI_LOOKUP_NO_TXT|AVAHI_LOOKUP_NO_ADDRESS), record_browser_callback, r);
     avahi_key_unref(k);
 
@@ -471,10 +443,10 @@ AvahiSServiceResolver *avahi_s_service_resolver_new(
     }
 
     if (!(flags & AVAHI_LOOKUP_NO_TXT)) {
-        k = avahi_key_new(t, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_TXT);
+        k = avahi_key_new(n, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_TXT);
         r->record_browser_txt = avahi_s_record_browser_new(server, interface, protocol, k, flags & ~(AVAHI_LOOKUP_NO_TXT|AVAHI_LOOKUP_NO_ADDRESS),  record_browser_callback, r);
         avahi_key_unref(k);
-        
+
         if (!r->record_browser_txt) {
             avahi_s_service_resolver_free(r);
             return NULL;
@@ -482,7 +454,7 @@ AvahiSServiceResolver *avahi_s_service_resolver_new(
     }
 
     start_timeout(r);
-    
+
     return r;
 }
 
@@ -493,7 +465,7 @@ void avahi_s_service_resolver_free(AvahiSServiceResolver *r) {
 
     if (r->time_event)
         avahi_time_event_free(r->time_event);
-    
+
     if (r->record_browser_srv)
         avahi_s_record_browser_free(r->record_browser_srv);
     if (r->record_browser_txt)
@@ -509,7 +481,7 @@ void avahi_s_service_resolver_free(AvahiSServiceResolver *r) {
         avahi_record_unref(r->txt_record);
     if (r->address_record)
         avahi_record_unref(r->address_record);
-    
+
     avahi_free(r->service_name);
     avahi_free(r->service_type);
     avahi_free(r->domain_name);