From e5e96882c3825cee81ff163490b2f39fad3192b8 Mon Sep 17 00:00:00 2001
From: Guus Sliepen <guus@tinc-vpn.org>
Date: Sat, 21 Jul 2012 16:33:09 +0200
Subject: [PATCH] Windows doesn't like quotes around "edit" when calling it
through system().
Even though that works fine on the command line.
---
src/tincctl.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/tincctl.c b/src/tincctl.c
index f519e78d..5f24ae4d 100644
--- a/src/tincctl.c
+++ b/src/tincctl.c
@@ -1461,14 +1461,12 @@ static int cmd_edit(int argc, char *argv[]) {
}
}
+ char *command;
#ifndef HAVE_MINGW
- char *editor = getenv("VISUAL") ?: getenv("EDITOR") ?: "vi";
+ xasprintf(&command, "\"%s\" \"%s\"", getenv("VISUAL") ?: getenv("EDITOR") ?: "vi", filename);
#else
- char *editor = "edit";
+ xasprintf(&command, "edit \"%s\"", filename);
#endif
-
- char *command;
- xasprintf(&command, "\"%s\" \"%s\"", editor, filename);
int result = system(command);
if(result)
return result;
--
2.39.5