From d7636352ce359e807b392a6e5ac0a6aeff4a63d2 Mon Sep 17 00:00:00 2001 From: Guus Sliepen Date: Sun, 2 Jan 2011 16:52:36 +0100 Subject: [PATCH] Limit field width when scanning PID file. Cppcheck warns that scanf() might otherwise crash when presented with a huge, bogus PID file. --- lib/pidfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pidfile.c b/lib/pidfile.c index 47f6359f..425b3043 100644 --- a/lib/pidfile.c +++ b/lib/pidfile.c @@ -41,7 +41,7 @@ pid_t read_pid (char *pidfile) if (!(f=fopen(pidfile,"r"))) return 0; - if(fscanf(f,"%ld", &pid) != 1) + if(fscanf(f,"%20ld", &pid) != 1) pid = 0; fclose(f); return pid; -- 2.39.5