From 2178842d04c649ed22457dc0829153fd1092521c Mon Sep 17 00:00:00 2001 From: Guus Sliepen Date: Sun, 20 Jun 2021 22:51:41 +0200 Subject: [PATCH] Remove the UTCP send and receive buffers. --- src/meshlink-tiny++.h | 72 ------- src/meshlink-tiny.h | 87 -------- src/meshlink.c | 62 ------ src/meshlink.sym | 6 - src/utcp.c | 458 +++--------------------------------------- src/utcp.h | 13 -- src/utcp_priv.h | 20 -- 7 files changed, 32 insertions(+), 686 deletions(-) diff --git a/src/meshlink-tiny++.h b/src/meshlink-tiny++.h index d916877..cfcf2b9 100644 --- a/src/meshlink-tiny++.h +++ b/src/meshlink-tiny++.h @@ -561,30 +561,6 @@ public: return meshlink_forget_node(handle, node); } - /// Set the send buffer size of a channel. - /** This function sets the desired size of the send buffer. - * The default size is 128 kB. - * - * @param channel A handle for the channel. - * @param size The desired size for the send buffer. - * If a NULL pointer is given, the callback will be disabled. - */ - void set_channel_sndbuf(channel *channel, size_t size) { - meshlink_set_channel_sndbuf(handle, channel, size); - } - - /// Set the receive buffer size of a channel. - /** This function sets the desired size of the receive buffer. - * The default size is 128 kB. - * - * @param channel A handle for the channel. - * @param size The desired size for the send buffer. - * If a NULL pointer is given, the callback will be disabled. - */ - void set_channel_rcvbuf(channel *channel, size_t size) { - meshlink_set_channel_rcvbuf(handle, channel, size); - } - /// Set the flags of a channel. /** This function allows changing some of the channel flags. * Currently only MESHLINK_CHANNEL_NO_PARTIAL and MESHLINK_CHANNEL_DROP_LATE are supported, other flags are ignored. @@ -598,30 +574,6 @@ public: meshlink_set_channel_flags(handle, channel, flags); } - /// Set the send buffer storage of a channel. - /** This function provides MeshLink with a send buffer allocated by the application. - * - * @param channel A handle for the channel. - * @param buf A pointer to the start of the buffer. - * If a NULL pointer is given, MeshLink will use its own internal buffer again. - * @param size The size of the buffer. - */ - void set_channel_sndbuf_storage(channel *channel, void *buf, size_t size) { - meshlink_set_channel_sndbuf_storage(handle, channel, buf, size); - } - - /// Set the receive buffer storage of a channel. - /** This function provides MeshLink with a receive buffer allocated by the application. - * - * @param channel A handle for the channel. - * @param buf A pointer to the start of the buffer. - * If a NULL pointer is given, MeshLink will use its own internal buffer again. - * @param size The size of the buffer. - */ - void set_channel_rcvbuf_storage(channel *channel, void *buf, size_t size) { - meshlink_set_channel_rcvbuf_storage(handle, channel, buf, size); - } - /// Set the connection timeout used for channels to the given node. /** This sets the timeout after which unresponsive channels will be reported as closed. * The timeout is set for all current and future channels to the given node. @@ -736,30 +688,6 @@ public: return meshlink_channel_send(handle, channel, data, len); } - /// Get the amount of bytes in the send buffer. - /** This returns the amount of bytes in the send buffer. - * These bytes have not been received by the peer yet. - * - * @param channel A handle for the channel. - * - * @return The amount of un-ACKed bytes in the send buffer. - */ - size_t channel_get_sendq(channel *channel) { - return meshlink_channel_get_sendq(handle, channel); - } - - /// Get the amount of bytes in the receive buffer. - /** This returns the amount of bytes in the receive buffer. - * These bytes have not been processed by the application yet. - * - * @param channel A handle for the channel. - * - * @return The amount of bytes in the receive buffer. - */ - size_t channel_get_recvq(channel *channel) { - return meshlink_channel_get_recvq(handle, channel); - } - /// Get the maximum segment size of a channel. /** This returns the amount of bytes that can be sent at once for channels with UDP semantics. * diff --git a/src/meshlink-tiny.h b/src/meshlink-tiny.h index ad32802..8ba8add 100644 --- a/src/meshlink-tiny.h +++ b/src/meshlink-tiny.h @@ -939,69 +939,6 @@ void meshlink_set_channel_accept_cb(struct meshlink_handle *mesh, meshlink_chann */ void meshlink_set_channel_receive_cb(struct meshlink_handle *mesh, struct meshlink_channel *channel, meshlink_channel_receive_cb_t cb); -/// Set the poll callback. -/** This functions sets the callback that is called whenever data can be sent to another node. - * The callback is run in MeshLink's own thread. - * It is therefore important that the callback uses apprioriate methods (queues, pipes, locking, etc.) - * to pass data to or from the application's thread. - * The callback should also not block itself and return as quickly as possible. - * - * \memberof meshlink_channel - * @param mesh A handle which represents an instance of MeshLink. - * @param channel A handle for the channel. - * @param cb A pointer to the function which will be called when data can be sent to another node. - * If a NULL pointer is given, the callback will be disabled. - */ -void meshlink_set_channel_poll_cb(struct meshlink_handle *mesh, struct meshlink_channel *channel, meshlink_channel_poll_cb_t cb); - -/// Set the send buffer size of a channel. -/** This function sets the desired size of the send buffer. - * The default size is 128 kB. - * - * \memberof meshlink_channel - * @param mesh A handle which represents an instance of MeshLink. - * @param channel A handle for the channel. - * @param size The desired size for the send buffer. - */ -void meshlink_set_channel_sndbuf(struct meshlink_handle *mesh, struct meshlink_channel *channel, size_t size); - -/// Set the receive buffer size of a channel. -/** This function sets the desired size of the receive buffer. - * The default size is 128 kB. - * - * \memberof meshlink_channel - * @param mesh A handle which represents an instance of MeshLink. - * @param channel A handle for the channel. - * @param size The desired size for the send buffer. - */ -void meshlink_set_channel_rcvbuf(struct meshlink_handle *mesh, struct meshlink_channel *channel, size_t size); - -/// Set the send buffer storage of a channel. -/** This function provides MeshLink with a send buffer allocated by the application. - * The buffer must be valid until the channel is closed or until this function is called again with a NULL pointer for @a buf. - * - * \memberof meshlink_channel - * @param mesh A handle which represents an instance of MeshLink. - * @param channel A handle for the channel. - * @param buf A pointer to the start of the buffer. - * If a NULL pointer is given, MeshLink will use its own internal buffer again. - * @param size The size of the buffer. - */ -void meshlink_set_channel_sndbuf_storage(struct meshlink_handle *mesh, struct meshlink_channel *channel, void *buf, size_t size); - -/// Set the receive buffer storage of a channel. -/** This function provides MeshLink with a receive buffer allocated by the application. - * The buffer must be valid until the channel is closed or until this function is called again with a NULL pointer for @a buf. - * - * \memberof meshlink_channel - * @param mesh A handle which represents an instance of MeshLink. - * @param channel A handle for the channel. - * @param buf A pointer to the start of the buffer. - * If a NULL pointer is given, MeshLink will use its own internal buffer again. - * @param size The size of the buffer. - */ -void meshlink_set_channel_rcvbuf_storage(struct meshlink_handle *mesh, struct meshlink_channel *channel, void *buf, size_t size); - /// Set the flags of a channel. /** This function allows changing some of the channel flags. * Currently only MESHLINK_CHANNEL_NO_PARTIAL and MESHLINK_CHANNEL_DROP_LATE are supported, other flags are ignored. @@ -1137,30 +1074,6 @@ ssize_t meshlink_channel_send(struct meshlink_handle *mesh, struct meshlink_chan */ uint32_t meshlink_channel_get_flags(struct meshlink_handle *mesh, struct meshlink_channel *channel) __attribute__((__warn_unused_result__)); -/// Get the amount of bytes in the send buffer. -/** This returns the amount of bytes in the send buffer. - * These bytes have not been received by the peer yet. - * - * \memberof meshlink_channel - * @param mesh A handle which represents an instance of MeshLink. - * @param channel A handle for the channel. - * - * @return The amount of un-ACKed bytes in the send buffer. - */ -size_t meshlink_channel_get_sendq(struct meshlink_handle *mesh, struct meshlink_channel *channel) __attribute__((__warn_unused_result__)); - -/// Get the amount of bytes in the receive buffer. -/** This returns the amount of bytes in the receive buffer. - * These bytes have not been processed by the application yet. - * - * \memberof meshlink_channel - * @param mesh A handle which represents an instance of MeshLink. - * @param channel A handle for the channel. - * - * @return The amount of bytes in the receive buffer. - */ -size_t meshlink_channel_get_recvq(struct meshlink_handle *mesh, struct meshlink_channel *channel) __attribute__((__warn_unused_result__)); - /// Get the maximum segment size of a channel. /** This returns the amount of bytes that can be sent at once for channels with UDP semantics. * diff --git a/src/meshlink.c b/src/meshlink.c index 64580cf..c27afc8 100644 --- a/src/meshlink.c +++ b/src/meshlink.c @@ -2379,50 +2379,6 @@ void meshlink_set_channel_accept_cb(meshlink_handle_t *mesh, meshlink_channel_ac pthread_mutex_unlock(&mesh->mutex); } -void meshlink_set_channel_sndbuf(meshlink_handle_t *mesh, meshlink_channel_t *channel, size_t size) { - logger(mesh, MESHLINK_DEBUG, "meshlink_set_channel_sndbuf(%p, %zu)", (void *)channel, size); - - meshlink_set_channel_sndbuf_storage(mesh, channel, NULL, size); -} - -void meshlink_set_channel_rcvbuf(meshlink_handle_t *mesh, meshlink_channel_t *channel, size_t size) { - logger(mesh, MESHLINK_DEBUG, "meshlink_set_channel_rcvbuf(%p, %zu)", (void *)channel, size); - - meshlink_set_channel_rcvbuf_storage(mesh, channel, NULL, size); -} - -void meshlink_set_channel_sndbuf_storage(meshlink_handle_t *mesh, meshlink_channel_t *channel, void *buf, size_t size) { - logger(mesh, MESHLINK_DEBUG, "meshlink_set_channel_sndbuf_storage(%p, %p, %zu)", (void *)channel, buf, size); - - if(!mesh || !channel) { - meshlink_errno = MESHLINK_EINVAL; - return; - } - - if(pthread_mutex_lock(&mesh->mutex) != 0) { - abort(); - } - - utcp_set_sndbuf(channel->c, buf, size); - pthread_mutex_unlock(&mesh->mutex); -} - -void meshlink_set_channel_rcvbuf_storage(meshlink_handle_t *mesh, meshlink_channel_t *channel, void *buf, size_t size) { - logger(mesh, MESHLINK_DEBUG, "meshlink_set_channel_rcvbuf_storage(%p, %p, %zu)", (void *)channel, buf, size); - - if(!mesh || !channel) { - meshlink_errno = MESHLINK_EINVAL; - return; - } - - if(pthread_mutex_lock(&mesh->mutex) != 0) { - abort(); - } - - utcp_set_rcvbuf(channel->c, buf, size); - pthread_mutex_unlock(&mesh->mutex); -} - void meshlink_set_channel_flags(meshlink_handle_t *mesh, meshlink_channel_t *channel, uint32_t flags) { logger(mesh, MESHLINK_DEBUG, "meshlink_set_channel_flags(%p, %u)", (void *)channel, flags); @@ -2614,24 +2570,6 @@ uint32_t meshlink_channel_get_flags(meshlink_handle_t *mesh, meshlink_channel_t return channel->c->flags; } -size_t meshlink_channel_get_sendq(meshlink_handle_t *mesh, meshlink_channel_t *channel) { - if(!mesh || !channel) { - meshlink_errno = MESHLINK_EINVAL; - return -1; - } - - return utcp_get_sendq(channel->c); -} - -size_t meshlink_channel_get_recvq(meshlink_handle_t *mesh, meshlink_channel_t *channel) { - if(!mesh || !channel) { - meshlink_errno = MESHLINK_EINVAL; - return -1; - } - - return utcp_get_recvq(channel->c); -} - size_t meshlink_channel_get_mss(meshlink_handle_t *mesh, meshlink_channel_t *channel) { if(!mesh || !channel) { meshlink_errno = MESHLINK_EINVAL; diff --git a/src/meshlink.sym b/src/meshlink.sym index 6806917..d7051a7 100644 --- a/src/meshlink.sym +++ b/src/meshlink.sym @@ -9,8 +9,6 @@ meshlink_channel_abort meshlink_channel_close meshlink_channel_get_flags meshlink_channel_get_mss -meshlink_channel_get_recvq -meshlink_channel_get_sendq meshlink_channel_open_ex meshlink_channel_send meshlink_channel_shutdown @@ -51,11 +49,7 @@ meshlink_set_canonical_address meshlink_set_channel_accept_cb meshlink_set_channel_flags meshlink_set_channel_listen_cb -meshlink_set_channel_rcvbuf -meshlink_set_channel_rcvbuf_storage meshlink_set_channel_receive_cb -meshlink_set_channel_sndbuf -meshlink_set_channel_sndbuf_storage meshlink_set_connection_try_cb meshlink_set_dev_class_fast_retry_period meshlink_set_dev_class_maxtimeout diff --git a/src/utcp.c b/src/utcp.c index dc30fe6..0909a01 100644 --- a/src/utcp.c +++ b/src/utcp.c @@ -186,274 +186,6 @@ static int32_t seqdiff(uint32_t a, uint32_t b) { return a - b; } -// Buffer functions -static bool buffer_wraps(struct buffer *buf) { - return buf->size - buf->offset < buf->used; -} - -static bool buffer_resize(struct buffer *buf, uint32_t newsize) { - assert(!buf->external); - - if(!newsize) { - free(buf->data); - buf->data = NULL; - buf->size = 0; - buf->offset = 0; - return true; - } - - char *newdata = realloc(buf->data, newsize); - - if(!newdata) { - return false; - } - - buf->data = newdata; - - if(buffer_wraps(buf)) { - // Shift the right part of the buffer until it hits the end of the new buffer. - // Old situation: - // [345......012] - // New situation: - // [345.........|........012] - uint32_t tailsize = buf->size - buf->offset; - uint32_t newoffset = newsize - tailsize; - memmove(buf->data + newoffset, buf->data + buf->offset, tailsize); - buf->offset = newoffset; - } - - buf->size = newsize; - return true; -} - -// Store data into the buffer -static ssize_t buffer_put_at(struct buffer *buf, size_t offset, const void *data, size_t len) { - debug(NULL, "buffer_put_at %lu %lu %lu\n", (unsigned long)buf->used, (unsigned long)offset, (unsigned long)len); - - // Ensure we don't store more than maxsize bytes in total - size_t required = offset + len; - - if(required > buf->maxsize) { - if(offset >= buf->maxsize) { - return 0; - } - - len = buf->maxsize - offset; - required = buf->maxsize; - } - - // Check if we need to resize the buffer - if(required > buf->size) { - size_t newsize = buf->size; - - if(!newsize) { - newsize = 4096; - } - - do { - newsize *= 2; - } while(newsize < required); - - if(newsize > buf->maxsize) { - newsize = buf->maxsize; - } - - if(!buffer_resize(buf, newsize)) { - return -1; - } - } - - uint32_t realoffset = buf->offset + offset; - - if(buf->size - buf->offset <= offset) { - // The offset wrapped - realoffset -= buf->size; - } - - if(buf->size - realoffset < len) { - // The new chunk of data must be wrapped - memcpy(buf->data + realoffset, data, buf->size - realoffset); - memcpy(buf->data, (char *)data + buf->size - realoffset, len - (buf->size - realoffset)); - } else { - memcpy(buf->data + realoffset, data, len); - } - - if(required > buf->used) { - buf->used = required; - } - - return len; -} - -static ssize_t buffer_put(struct buffer *buf, const void *data, size_t len) { - return buffer_put_at(buf, buf->used, data, len); -} - -// Copy data from the buffer without removing it. -static ssize_t buffer_copy(struct buffer *buf, void *data, size_t offset, size_t len) { - // Ensure we don't copy more than is actually stored in the buffer - if(offset >= buf->used) { - return 0; - } - - if(buf->used - offset < len) { - len = buf->used - offset; - } - - uint32_t realoffset = buf->offset + offset; - - if(buf->size - buf->offset <= offset) { - // The offset wrapped - realoffset -= buf->size; - } - - if(buf->size - realoffset < len) { - // The data is wrapped - memcpy(data, buf->data + realoffset, buf->size - realoffset); - memcpy((char *)data + buf->size - realoffset, buf->data, len - (buf->size - realoffset)); - } else { - memcpy(data, buf->data + realoffset, len); - } - - return len; -} - -// Discard data from the buffer. -static ssize_t buffer_discard(struct buffer *buf, size_t len) { - if(buf->used < len) { - len = buf->used; - } - - if(buf->size - buf->offset <= len) { - buf->offset -= buf->size; - } - - if(buf->used == len) { - buf->offset = 0; - } else { - buf->offset += len; - } - - buf->used -= len; - - return len; -} - -static void buffer_clear(struct buffer *buf) { - buf->used = 0; - buf->offset = 0; -} - -static bool buffer_set_size(struct buffer *buf, uint32_t minsize, uint32_t maxsize) { - if(maxsize < minsize) { - maxsize = minsize; - } - - buf->maxsize = maxsize; - - return buf->size >= minsize || buffer_resize(buf, minsize); -} - -static void buffer_transfer(struct buffer *buf, char *newdata, size_t newsize) { - if(buffer_wraps(buf)) { - // Old situation: - // [345......012] - // New situation: - // [012345......] - uint32_t tailsize = buf->size - buf->offset; - memcpy(newdata, buf->data + buf->offset, tailsize); - memcpy(newdata + tailsize, buf->data, buf->used - tailsize); - } else { - // Old situation: - // [....012345..] - // New situation: - // [012345......] - memcpy(newdata, buf->data + buf->offset, buf->used); - } - - buf->offset = 0; - buf->size = newsize; -} - -static void set_buffer_storage(struct buffer *buf, char *data, size_t size) { - if(size > UINT32_MAX) { - size = UINT32_MAX; - } - - buf->maxsize = size; - - if(data) { - if(buf->external) { - // Don't allow resizing an external buffer - abort(); - } - - if(size < buf->used) { - // Ignore requests for an external buffer if we are already using more than it can store - return; - } - - // Transition from internal to external buffer - buffer_transfer(buf, data, size); - free(buf->data); - buf->data = data; - buf->external = true; - } else if(buf->external) { - // Transition from external to internal buf - size_t minsize = buf->used <= DEFAULT_SNDBUFSIZE ? DEFAULT_SNDBUFSIZE : buf->used; - - if(minsize) { - data = malloc(minsize); - - if(!data) { - // Cannot handle this - abort(); - } - - buffer_transfer(buf, data, minsize); - buf->data = data; - } else { - buf->data = NULL; - buf->size = 0; - } - - buf->external = false; - } else { - // Don't do anything if the buffer wraps - if(buffer_wraps(buf)) { - return; - } - - // Realloc internal storage - size_t minsize = max(DEFAULT_SNDBUFSIZE, buf->offset + buf->used); - - if(minsize) { - data = realloc(buf->data, minsize); - - if(data) { - buf->data = data; - buf->size = minsize; - } - } else { - free(buf->data); - buf->data = NULL; - buf->size = 0; - } - } -} - -static void buffer_exit(struct buffer *buf) { - if(!buf->external) { - free(buf->data); - } - - memset(buf, 0, sizeof(*buf)); -} - -static uint32_t buffer_free(const struct buffer *buf) { - return buf->maxsize > buf->used ? buf->maxsize - buf->used : 0; -} - // Connections are stored in a sorted list. // This gives O(log(N)) lookup time, O(N log(N)) insertion time and O(N) deletion time. @@ -498,8 +230,6 @@ static void free_connection(struct utcp_connection *c) { memmove(cp, cp + 1, (utcp->nconnections - i - 1) * sizeof(*cp)); utcp->nconnections--; - buffer_exit(&c->rcvbuf); - buffer_exit(&c->sndbuf); free(c); } @@ -548,17 +278,6 @@ static struct utcp_connection *allocate_connection(struct utcp *utcp, uint16_t s return NULL; } - if(!buffer_set_size(&c->sndbuf, DEFAULT_SNDBUFSIZE, DEFAULT_MAXSNDBUFSIZE)) { - free(c); - return NULL; - } - - if(!buffer_set_size(&c->rcvbuf, DEFAULT_RCVBUFSIZE, DEFAULT_MAXRCVBUFSIZE)) { - buffer_exit(&c->sndbuf); - free(c); - return NULL; - } - // Fill in the details c->src = src; @@ -666,7 +385,7 @@ struct utcp_connection *utcp_connect_ex(struct utcp *utcp, uint16_t dst, utcp_re pkt.hdr.dst = c->dst; pkt.hdr.seq = c->snd.iss; pkt.hdr.ack = 0; - pkt.hdr.wnd = c->rcvbuf.maxsize; + pkt.hdr.wnd = c->utcp->mtu; pkt.hdr.ctl = SYN; pkt.hdr.aux = 0x0101; pkt.init[0] = 1; @@ -699,28 +418,7 @@ void utcp_accept(struct utcp_connection *c, utcp_recv_t recv, void *priv) { set_state(c, ESTABLISHED); } -static void ack(struct utcp_connection *c, bool sendatleastone) { - int32_t left = seqdiff(c->snd.last, c->snd.nxt); - int32_t cwndleft = MAX_UNRELIABLE_SIZE; - - assert(left >= 0); - - if(cwndleft <= 0) { - left = 0; - } else if(cwndleft < left) { - left = cwndleft; - - if(!sendatleastone || cwndleft > c->utcp->mss) { - left -= left % c->utcp->mss; - } - } - - debug(c, "cwndleft %d left %d\n", cwndleft, left); - - if(!left && !sendatleastone) { - return; - } - +static void ack(struct utcp_connection *c, const void *data, size_t len) { struct { struct hdr hdr; uint8_t data[]; @@ -733,34 +431,31 @@ static void ack(struct utcp_connection *c, bool sendatleastone) { pkt->hdr.ctl = ACK; pkt->hdr.aux = 0; - do { - uint32_t seglen = left > c->utcp->mss ? c->utcp->mss : left; - pkt->hdr.seq = c->snd.nxt; - - buffer_copy(&c->sndbuf, pkt->data, seqdiff(c->snd.nxt, c->snd.una), seglen); + uint32_t seglen = len; + pkt->hdr.seq = c->snd.nxt; - c->snd.nxt += seglen; - left -= seglen; + c->snd.nxt += seglen; - if(seglen && fin_wanted(c, c->snd.nxt)) { - seglen--; - pkt->hdr.ctl |= FIN; - } + if(fin_wanted(c, c->snd.nxt)) { + pkt->hdr.ctl |= FIN; + } - if(!c->rtt_start.tv_sec) { - // Start RTT measurement - clock_gettime(UTCP_CLOCK, &c->rtt_start); - c->rtt_seq = pkt->hdr.seq + seglen; - debug(c, "starting RTT measurement, expecting ack %u\n", c->rtt_seq); - } + if(data && len) { + assert(len <= c->utcp->mtu); + memcpy(pkt->data, data, len); + } else { + assert(!data && !len); + } - print_packet(c, "send", pkt, sizeof(pkt->hdr) + seglen); - c->utcp->send(c->utcp, pkt, sizeof(pkt->hdr) + seglen); + if(!c->rtt_start.tv_sec) { + // Start RTT measurement + clock_gettime(UTCP_CLOCK, &c->rtt_start); + c->rtt_seq = pkt->hdr.seq + seglen; + debug(c, "starting RTT measurement, expecting ack %u\n", c->rtt_seq); + } - if(left) { - pkt->hdr.wnd += seglen; - } - } while(left); + print_packet(c, "send", pkt, sizeof(pkt->hdr) + seglen); + c->utcp->send(c->utcp, pkt, sizeof(pkt->hdr) + seglen); } ssize_t utcp_send(struct utcp_connection *c, const void *data, size_t len) { @@ -804,15 +499,9 @@ ssize_t utcp_send(struct utcp_connection *c, const void *data, size_t len) { return -1; } - // Add data to send buffer. - - if(c->state != SYN_SENT && c->state != SYN_RECEIVED) { - if(len > MAX_UNRELIABLE_SIZE || buffer_put(&c->sndbuf, data, len) != (ssize_t)len) { - errno = EMSGSIZE; - return -1; - } - } else { - return 0; + if(len > MAX_UNRELIABLE_SIZE || len > c->utcp->mtu) { + errno = EMSGSIZE; + return -1; } if(len <= 0) { @@ -827,10 +516,9 @@ ssize_t utcp_send(struct utcp_connection *c, const void *data, size_t len) { return len; } - ack(c, false); + ack(c, data, len); c->snd.una = c->snd.nxt = c->snd.last; - buffer_discard(&c->sndbuf, c->sndbuf.used); return len; } @@ -857,7 +545,7 @@ static void retransmit(struct utcp_connection *c) { pkt->hdr.src = c->src; pkt->hdr.dst = c->dst; - pkt->hdr.wnd = c->rcvbuf.maxsize; + pkt->hdr.wnd = c->utcp->mtu; pkt->hdr.aux = 0; switch(c->state) { @@ -1048,8 +736,6 @@ ssize_t utcp_recv(struct utcp *utcp, const void *data, size_t len) { ptr += 2; } - bool has_data = len || (hdr.ctl & (SYN | FIN)); - // Is it for a new connection? if(!c) { @@ -1104,7 +790,7 @@ synack: pkt.hdr.dst = c->dst; pkt.hdr.ack = c->rcv.irs + 1; pkt.hdr.seq = c->snd.iss; - pkt.hdr.wnd = c->rcvbuf.maxsize; + pkt.hdr.wnd = c->utcp->mtu; pkt.hdr.ctl = SYN | ACK; if(init) { @@ -1224,8 +910,6 @@ synack: // The peer has aborted our connection. set_state(c, CLOSED); errno = ECONNRESET; - buffer_clear(&c->sndbuf); - buffer_clear(&c->rcvbuf); if(c->recv) { c->recv(c, NULL, 0); @@ -1310,10 +994,6 @@ synack: assert(data_acked <= bufused); #endif - if(data_acked) { - buffer_discard(&c->sndbuf, data_acked); - } - // Also advance snd.nxt if possible if(seqdiff(c->snd.nxt, hdr.ack) < 0) { c->snd.nxt = hdr.ack; @@ -1337,8 +1017,8 @@ synack: c->snd.cwnd += max(1, (utcp->mss * utcp->mss) / c->snd.cwnd); // eq. 3 } - if(c->snd.cwnd > c->sndbuf.maxsize) { - c->snd.cwnd = c->sndbuf.maxsize; + if(c->snd.cwnd > c->utcp->mtu) { + c->snd.cwnd = c->utcp->mtu; } debug_cwnd(c); @@ -1538,7 +1218,7 @@ skip_ack: // -> sendatleastone = false if(hdr.ctl & SYN || hdr.ctl & FIN) { - ack(c, has_data); + ack(c, NULL, 0); } return 0; @@ -1630,7 +1310,7 @@ int utcp_shutdown(struct utcp_connection *c, int dir) { c->snd.last++; - ack(c, false); + ack(c, NULL, 0); if(!timespec_isset(&c->rtrx_timeout)) { start_retransmit_timer(c); @@ -1651,9 +1331,6 @@ static bool reset_connection(struct utcp_connection *c) { return false; } - buffer_clear(&c->sndbuf); - buffer_clear(&c->rcvbuf); - switch(c->state) { case CLOSED: return true; @@ -1693,9 +1370,6 @@ static bool reset_connection(struct utcp_connection *c) { } static void set_reapable(struct utcp_connection *c) { - set_buffer_storage(&c->sndbuf, NULL, min(c->sndbuf.maxsize, DEFAULT_MAXSNDBUFSIZE)); - set_buffer_storage(&c->rcvbuf, NULL, min(c->rcvbuf.maxsize, DEFAULT_MAXRCVBUFSIZE)); - c->recv = NULL; c->reapable = true; } @@ -1775,8 +1449,6 @@ struct timespec utcp_timeout(struct utcp *utcp) { if(timespec_isset(&c->conn_timeout) && timespec_lt(&c->conn_timeout, &now)) { errno = ETIMEDOUT; c->state = CLOSED; - buffer_clear(&c->sndbuf); - buffer_clear(&c->rcvbuf); if(c->recv) { c->recv(c, NULL, 0); @@ -1862,16 +1534,11 @@ void utcp_exit(struct utcp *utcp) { struct utcp_connection *c = utcp->connections[i]; if(!c->reapable) { - buffer_clear(&c->sndbuf); - buffer_clear(&c->rcvbuf); - if(c->recv) { c->recv(c, NULL, 0); } } - buffer_exit(&c->rcvbuf); - buffer_exit(&c->sndbuf); free(c); } @@ -1957,63 +1624,6 @@ void utcp_set_user_timeout(struct utcp *u, int timeout) { } } -size_t utcp_get_sndbuf(struct utcp_connection *c) { - return c ? c->sndbuf.maxsize : 0; -} - -size_t utcp_get_sndbuf_free(struct utcp_connection *c) { - if(!c) { - return 0; - } - - switch(c->state) { - case SYN_SENT: - case SYN_RECEIVED: - case ESTABLISHED: - case CLOSE_WAIT: - return buffer_free(&c->sndbuf); - - default: - return 0; - } -} - -void utcp_set_sndbuf(struct utcp_connection *c, void *data, size_t size) { - if(!c) { - return; - } - - set_buffer_storage(&c->sndbuf, data, size); -} - -size_t utcp_get_rcvbuf(struct utcp_connection *c) { - return c ? c->rcvbuf.maxsize : 0; -} - -size_t utcp_get_rcvbuf_free(struct utcp_connection *c) { - if(c && (c->state == ESTABLISHED || c->state == CLOSE_WAIT)) { - return buffer_free(&c->rcvbuf); - } else { - return 0; - } -} - -void utcp_set_rcvbuf(struct utcp_connection *c, void *data, size_t size) { - if(!c) { - return; - } - - set_buffer_storage(&c->rcvbuf, data, size); -} - -size_t utcp_get_sendq(struct utcp_connection *c) { - return c->sndbuf.used; -} - -size_t utcp_get_recvq(struct utcp_connection *c) { - return c->rcvbuf.used; -} - bool utcp_get_nodelay(struct utcp_connection *c) { return c ? c->nodelay : false; } @@ -2034,10 +1644,6 @@ void utcp_set_keepalive(struct utcp_connection *c, bool keepalive) { } } -size_t utcp_get_outq(struct utcp_connection *c) { - return c ? seqdiff(c->snd.nxt, c->snd.una) : 0; -} - void utcp_set_recv_cb(struct utcp_connection *c, utcp_recv_t recv) { if(c) { c->recv = recv; diff --git a/src/utcp.h b/src/utcp.h index 1d1111c..e34d96c 100644 --- a/src/utcp.h +++ b/src/utcp.h @@ -93,25 +93,12 @@ void utcp_offline(struct utcp *utcp, bool offline); // Per-socket options -size_t utcp_get_sndbuf(struct utcp_connection *connection); -void utcp_set_sndbuf(struct utcp_connection *connection, void *buf, size_t size); -size_t utcp_get_sndbuf_free(struct utcp_connection *connection); - -size_t utcp_get_rcvbuf(struct utcp_connection *connection); -void utcp_set_rcvbuf(struct utcp_connection *connection, void *buf, size_t size); -size_t utcp_get_rcvbuf_free(struct utcp_connection *connection); - -size_t utcp_get_sendq(struct utcp_connection *connection); -size_t utcp_get_recvq(struct utcp_connection *connection); - bool utcp_get_nodelay(struct utcp_connection *connection); void utcp_set_nodelay(struct utcp_connection *connection, bool nodelay); bool utcp_get_keepalive(struct utcp_connection *connection); void utcp_set_keepalive(struct utcp_connection *connection, bool keepalive); -size_t utcp_get_outq(struct utcp_connection *connection); - void utcp_expect_data(struct utcp_connection *connection, bool expect); void utcp_set_flags(struct utcp_connection *connection, uint32_t flags); diff --git a/src/utcp_priv.h b/src/utcp_priv.h index 602140a..2c41349 100644 --- a/src/utcp_priv.h +++ b/src/utcp_priv.h @@ -36,11 +36,6 @@ #define AUX_SAK 3 #define AUX_TIMESTAMP 4 -#define DEFAULT_SNDBUFSIZE 0 -#define DEFAULT_MAXSNDBUFSIZE 131072 -#define DEFAULT_RCVBUFSIZE 0 -#define DEFAULT_MAXRCVBUFSIZE 131072 - #define MAX_UNRELIABLE_SIZE 16777215 #define DEFAULT_MTU 1000 @@ -88,15 +83,6 @@ static const char *strstate[] __attribute__((unused)) = { [TIME_WAIT] = "TIME_WAIT" }; -struct buffer { - char *data; - uint32_t offset; - uint32_t used; - uint32_t size; - uint32_t maxsize; - bool external; -}; - struct utcp_connection { void *priv; struct utcp *utcp; @@ -145,12 +131,6 @@ struct utcp_connection { uint32_t rttvar; // usec uint32_t rto; // usec - // Buffers - - uint32_t prev_free; - struct buffer sndbuf; - struct buffer rcvbuf; - // Per-socket options bool nodelay; -- 2.39.5