From: Guus Sliepen <guus@meshlink.io>
Date: Wed, 3 Feb 2021 22:30:36 +0000 (+0100)
Subject: Don't clear node dirty flag in meshlink_stop().
X-Git-Url: https://git.meshlink.io/?a=commitdiff_plain;h=b8e1873fb13abde89eb0e367409b2f8286bbc74a;p=meshlink

Don't clear node dirty flag in meshlink_stop().

It's node_write_config() itself that should unset the dirty flag, depending
on the storage policy and if storage succeeded. Otherwise, we risk that
setting the storage policy back to ENABLED after calling meshlink_stop()
will not cause pending updates to be written out by meshlink_close().
---

diff --git a/src/meshlink.c b/src/meshlink.c
index 79f5eeba..b812d273 100644
--- a/src/meshlink.c
+++ b/src/meshlink.c
@@ -1843,7 +1843,9 @@ void meshlink_stop(meshlink_handle_t *mesh) {
 	if(mesh->nodes) {
 		for splay_each(node_t, n, mesh->nodes) {
 			if(n->status.dirty) {
-				n->status.dirty = !node_write_config(mesh, n, false);
+				if(!node_write_config(mesh, n, false)) {
+					// ignore
+				}
 			}
 		}
 	}