From: Guus Sliepen <guus@meshlink.io>
Date: Thu, 31 Oct 2019 18:44:27 +0000 (+0100)
Subject: Only add confirmed reflexive UDP addresses to ANS_KEY messages.
X-Git-Url: https://git.meshlink.io/?a=commitdiff_plain;h=a5750efefc491d77ff6a45f0ebc21976831eebfe;p=meshlink

Only add confirmed reflexive UDP addresses to ANS_KEY messages.
---

diff --git a/src/protocol_key.c b/src/protocol_key.c
index 9f69d803..1d708e4a 100644
--- a/src/protocol_key.c
+++ b/src/protocol_key.c
@@ -324,7 +324,8 @@ bool ans_key_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
 			return true;
 		}
 
-		if(!*address && from->address.sa.sa_family != AF_UNSPEC) {
+		/* Append the known UDP address of the from node, if we have a confirmed one */
+		if(!*address && from->status.udp_confirmed && from->address.sa.sa_family != AF_UNSPEC) {
 			char *address, *port;
 			logger(mesh, MESHLINK_DEBUG, "Appending reflexive UDP address to ANS_KEY from %s to %s", from->name, to->name);
 			sockaddr2str(&from->address, &address, &port);