Group discovery related variables together.

diff --git a/src/discovery.c b/src/discovery.c
index e0e4fb4ed3e346b46da63287db2141f2f4f6ec78..428e44074fcc4103d76ad74f9fad75bf8ec726c4 100644 (file)
--- a/src/discovery.c
+++ b/src/discovery.c
@@ -171,7 +171,7 @@ static void send_mdns_packet(meshlink_handle_t *mesh, const discovery_address_t
 
        switch(addr->address.sa.sa_family) {
        case AF_INET:
-               fd = mesh->discovery_sockets[0].fd;
+               fd = mesh->discovery.sockets[0].fd;
 #ifdef IP_MULTICAST_IF
                {
                        struct ip_mreqn mreq = {
@@ -191,7 +191,7 @@ static void send_mdns_packet(meshlink_handle_t *mesh, const discovery_address_t
                break;
 
        case AF_INET6:
-               fd = mesh->discovery_sockets[1].fd;
+               fd = mesh->discovery.sockets[1].fd;
 #ifdef IPV6_MULTICAST_IF
 
                if(setsockopt(fd, IPPROTO_IPV6, IPV6_MULTICAST_IF, &addr->index, sizeof(addr->index)) != 0) {
@@ -288,36 +288,36 @@ static void mdns_io_handler(event_loop_t *loop, void *data, int flags) {
 }
 
 static void iface_up(meshlink_handle_t *mesh, int index) {
-       int *p = bsearch(&index, mesh->discovery_ifaces, mesh->discovery_iface_count, sizeof(*p), iface_compare);
+       int *p = bsearch(&index, mesh->discovery.ifaces, mesh->discovery.iface_count, sizeof(*p), iface_compare);
 
        if(p) {
                return;
        }
 
        fprintf(stderr, "iface %d up\n", index);
-       mesh->discovery_ifaces = xrealloc(mesh->discovery_ifaces, ++mesh->discovery_iface_count * sizeof(*p));
-       mesh->discovery_ifaces[mesh->discovery_iface_count - 1] = index;
-       qsort(mesh->discovery_ifaces, mesh->discovery_iface_count, sizeof(*p), iface_compare);
+       mesh->discovery.ifaces = xrealloc(mesh->discovery.ifaces, ++mesh->discovery.iface_count * sizeof(*p));
+       mesh->discovery.ifaces[mesh->discovery.iface_count - 1] = index;
+       qsort(mesh->discovery.ifaces, mesh->discovery.iface_count, sizeof(*p), iface_compare);
 
        // Add multicast membership
        struct ip_mreqn mreq4 = {
                .imr_multiaddr = mdns_address_ipv4.in.sin_addr,
                .imr_ifindex = index,
        };
-       setsockopt(mesh->discovery_sockets[0].fd, IPPROTO_IP, IP_DROP_MEMBERSHIP, &mreq4, sizeof(mreq4));
-       setsockopt(mesh->discovery_sockets[0].fd, IPPROTO_IP, IP_ADD_MEMBERSHIP, &mreq4, sizeof(mreq4));
+       setsockopt(mesh->discovery.sockets[0].fd, IPPROTO_IP, IP_DROP_MEMBERSHIP, &mreq4, sizeof(mreq4));
+       setsockopt(mesh->discovery.sockets[0].fd, IPPROTO_IP, IP_ADD_MEMBERSHIP, &mreq4, sizeof(mreq4));
 
        struct ipv6_mreq mreq6 = {
                .ipv6mr_multiaddr = mdns_address_ipv6.in6.sin6_addr,
                .ipv6mr_interface = index,
        };
-       setsockopt(mesh->discovery_sockets[1].fd, IPPROTO_IPV6, IPV6_DROP_MEMBERSHIP, &mreq6, sizeof(mreq6));
-       setsockopt(mesh->discovery_sockets[1].fd, IPPROTO_IPV6, IPV6_ADD_MEMBERSHIP, &mreq6, sizeof(mreq6));
+       setsockopt(mesh->discovery.sockets[1].fd, IPPROTO_IPV6, IPV6_DROP_MEMBERSHIP, &mreq6, sizeof(mreq6));
+       setsockopt(mesh->discovery.sockets[1].fd, IPPROTO_IPV6, IPV6_ADD_MEMBERSHIP, &mreq6, sizeof(mreq6));
 
        // Send an announcement for all addresses associated with this interface
-       for(int i = 0; i < mesh->discovery_address_count; i++) {
-               if(mesh->discovery_addresses[i].index == index) {
-                       send_mdns_packet(mesh, &mesh->discovery_addresses[i]);
+       for(int i = 0; i < mesh->discovery.address_count; i++) {
+               if(mesh->discovery.addresses[i].index == index) {
+                       send_mdns_packet(mesh, &mesh->discovery.addresses[i]);
                }
        }
 
@@ -325,7 +325,7 @@ static void iface_up(meshlink_handle_t *mesh, int index) {
 }
 
 static void iface_down(meshlink_handle_t *const mesh, int index) {
-       int *p = bsearch(&index, mesh->discovery_ifaces, mesh->discovery_iface_count, sizeof(*p), iface_compare);
+       int *p = bsearch(&index, mesh->discovery.ifaces, mesh->discovery.iface_count, sizeof(*p), iface_compare);
 
        if(!p) {
                return;
@@ -336,47 +336,47 @@ static void iface_down(meshlink_handle_t *const mesh, int index) {
                .imr_multiaddr = mdns_address_ipv4.in.sin_addr,
                .imr_ifindex = index,
        };
-       setsockopt(mesh->discovery_sockets[0].fd, IPPROTO_IP, IP_DROP_MEMBERSHIP, &mreq4, sizeof(mreq4));
+       setsockopt(mesh->discovery.sockets[0].fd, IPPROTO_IP, IP_DROP_MEMBERSHIP, &mreq4, sizeof(mreq4));
 
        struct ipv6_mreq mreq6 = {
                .ipv6mr_multiaddr = mdns_address_ipv6.in6.sin6_addr,
                .ipv6mr_interface = index,
        };
-       setsockopt(mesh->discovery_sockets[1].fd, IPPROTO_IPV6, IPV6_DROP_MEMBERSHIP, &mreq6, sizeof(mreq6));
+       setsockopt(mesh->discovery.sockets[1].fd, IPPROTO_IPV6, IPV6_DROP_MEMBERSHIP, &mreq6, sizeof(mreq6));
 
        fprintf(stderr, "iface %d down\n", index);
-       memmove(p, p + 1, (mesh->discovery_ifaces + --mesh->discovery_iface_count - p) * sizeof(*p));
+       memmove(p, p + 1, (mesh->discovery.ifaces + --mesh->discovery.iface_count - p) * sizeof(*p));
 
-       handle_network_change(mesh, mesh->discovery_iface_count);
+       handle_network_change(mesh, mesh->discovery.iface_count);
 }
 
 static void addr_add(meshlink_handle_t *mesh, const discovery_address_t *addr) {
-       discovery_address_t *p = bsearch(addr, mesh->discovery_addresses, mesh->discovery_address_count, sizeof(*p), address_compare);
+       discovery_address_t *p = bsearch(addr, mesh->discovery.addresses, mesh->discovery.address_count, sizeof(*p), address_compare);
 
        if(p) {
                return;
        }
 
-       bool up = bsearch(&addr->index, mesh->discovery_ifaces, mesh->discovery_iface_count, sizeof(int), iface_compare);
+       bool up = bsearch(&addr->index, mesh->discovery.ifaces, mesh->discovery.iface_count, sizeof(int), iface_compare);
        char *host = NULL, *port = NULL;
        sockaddr2str(&addr->address, &host, &port);
        fprintf(stderr, "address %d %s port %s up %d\n", addr->index, host, port, up);
        free(host);
        free(port);
 
-       mesh->discovery_addresses = xrealloc(mesh->discovery_addresses, ++mesh->discovery_address_count * sizeof(*p));
-       mesh->discovery_addresses[mesh->discovery_address_count - 1] = *addr;
-       mesh->discovery_addresses[mesh->discovery_address_count - 1].up = up;
+       mesh->discovery.addresses = xrealloc(mesh->discovery.addresses, ++mesh->discovery.address_count * sizeof(*p));
+       mesh->discovery.addresses[mesh->discovery.address_count - 1] = *addr;
+       mesh->discovery.addresses[mesh->discovery.address_count - 1].up = up;
 
        if(up) {
-               send_mdns_packet(mesh, &mesh->discovery_addresses[mesh->discovery_address_count - 1]);
+               send_mdns_packet(mesh, &mesh->discovery.addresses[mesh->discovery.address_count - 1]);
        }
 
-       qsort(mesh->discovery_addresses, mesh->discovery_address_count, sizeof(*p), address_compare);
+       qsort(mesh->discovery.addresses, mesh->discovery.address_count, sizeof(*p), address_compare);
 }
 
 static void addr_del(meshlink_handle_t *mesh, const discovery_address_t *addr) {
-       discovery_address_t *p = bsearch(addr, mesh->discovery_addresses, mesh->discovery_address_count, sizeof(*p), address_compare);
+       discovery_address_t *p = bsearch(addr, mesh->discovery.addresses, mesh->discovery.address_count, sizeof(*p), address_compare);
 
        if(!p) {
                return;
@@ -388,7 +388,7 @@ static void addr_del(meshlink_handle_t *mesh, const discovery_address_t *addr) {
        free(host);
        free(port);
 
-       memmove(p, p + 1, (mesh->discovery_addresses + --mesh->discovery_address_count - p) * sizeof(*p));
+       memmove(p, p + 1, (mesh->discovery.addresses + --mesh->discovery.address_count - p) * sizeof(*p));
 }
 
 #if defined(__linux)
@@ -505,7 +505,7 @@ static void netlink_parse(meshlink_handle_t *mesh, const void *data, size_t len)
 static void netlink_io_handler(event_loop_t *loop, void *data, int flags) {
        (void)flags;
        static time_t prev_update;
-       meshlink_handle_t *mesh = data;
+       meshlink_handle_t *mesh = loop->data;
 
        struct {
                struct nlmsghdr nlm;
@@ -513,7 +513,7 @@ static void netlink_io_handler(event_loop_t *loop, void *data, int flags) {
        } msg;
 
        while(true) {
-               ssize_t result = recv(mesh->pfroute_io.fd, &msg, sizeof(msg), MSG_DONTWAIT);
+               ssize_t result = recv(mesh->discovery.pfroute_io.fd, &msg, sizeof(msg), MSG_DONTWAIT);
 
                if(result <= 0) {
                        if(result == 0 || errno == EAGAIN || errno == EINTR) {
@@ -521,7 +521,7 @@ static void netlink_io_handler(event_loop_t *loop, void *data, int flags) {
                        }
 
                        logger(mesh, MESHLINK_ERROR, "Reading from Netlink socket failed: %s\n", strerror(errno));
-                       io_set(loop, &mesh->pfroute_io, 0);
+                       io_set(loop, &mesh->discovery.pfroute_io, 0);
                }
 
                if((size_t)result < sizeof(msg.nlm)) {
@@ -532,7 +532,7 @@ static void netlink_io_handler(event_loop_t *loop, void *data, int flags) {
                if(msg.nlm.nlmsg_type == NLMSG_DONE) {
                        if(msg.nlm.nlmsg_seq == 1) {
                                // We just got the result of GETLINK, now send GETADDR.
-                               netlink_getaddr(mesh->pfroute_io.fd);
+                               netlink_getaddr(mesh->discovery.pfroute_io.fd);
                        }
                } else {
                        netlink_parse(mesh, &msg, result);
@@ -548,7 +548,7 @@ static void netlink_io_handler(event_loop_t *loop, void *data, int flags) {
 static void pfroute_io_handler(event_loop_t *loop, void *data, int flags) {
        (void)flags;
        static time_t prev_update;
-       meshlink_handle_t *mesh = data;
+       meshlink_handle_t *mesh = loop->data;
 
        struct {
                struct rt_msghdr rtm;
@@ -557,7 +557,7 @@ static void pfroute_io_handler(event_loop_t *loop, void *data, int flags) {
 
        while(true) {
                msg.rtm.rtm_version = 0;
-               ssize_t result = recv(mesh->pfroute_io.fd, &msg, sizeof(msg), MSG_DONTWAIT);
+               ssize_t result = recv(mesh->discovery.pfroute_io.fd, &msg, sizeof(msg), MSG_DONTWAIT);
 
                if(result <= 0) {
                        if(result == 0 || errno == EAGAIN || errno == EINTR) {
@@ -565,7 +565,7 @@ static void pfroute_io_handler(event_loop_t *loop, void *data, int flags) {
                        }
 
                        logger(mesh, MESHLINK_ERROR, "Reading from PFROUTE socket failed: %s\n", strerror(errno));
-                       io_set(loop, &mesh->pfroute_io, 0);
+                       io_set(loop, &mesh->discovery.pfroute_io, 0);
                }
 
                if(msg.rtm.rtm_version != RTM_VERSION) {
@@ -609,7 +609,7 @@ bool discovery_start(meshlink_handle_t *mesh) {
        bind(fd, &sa4.sa, SALEN(sa4.sa));
        setsockopt(fd, IPPROTO_IP, IP_MULTICAST_LOOP, &one, sizeof(one));
        setsockopt(fd, IPPROTO_IP, IP_MULTICAST_TTL, &ttl, sizeof(ttl));
-       io_add(&mesh->loop, &mesh->discovery_sockets[0], mdns_io_handler, &mesh->discovery_sockets[0], fd, IO_READ);
+       io_add(&mesh->loop, &mesh->discovery.sockets[0], mdns_io_handler, &mesh->discovery.sockets[0], fd, IO_READ);
 
        sockaddr_t sa6 = {
                .in6.sin6_family = AF_INET6,
@@ -621,7 +621,7 @@ bool discovery_start(meshlink_handle_t *mesh) {
        bind(fd, &sa6.sa, SALEN(sa6.sa));
        setsockopt(fd, IPPROTO_IPV6, IPV6_MULTICAST_LOOP, &one, sizeof(one));
        setsockopt(fd, IPPROTO_IPV6, IPV6_MULTICAST_HOPS, &ttl, sizeof(ttl));
-       io_add(&mesh->loop, &mesh->discovery_sockets[1], mdns_io_handler, &mesh->discovery_sockets[1], fd, IO_READ);
+       io_add(&mesh->loop, &mesh->discovery.sockets[1], mdns_io_handler, &mesh->discovery.sockets[1], fd, IO_READ);
 
 #if defined(__linux)
        int sock = socket(AF_NETLINK, SOCK_DGRAM, NETLINK_ROUTE);
@@ -633,7 +633,7 @@ bool discovery_start(meshlink_handle_t *mesh) {
                sa.nl_groups = RTMGRP_LINK | RTMGRP_IPV4_IFADDR | RTMGRP_IPV6_IFADDR;
 
                if(bind(sock, (struct sockaddr *)&sa, sizeof(sa)) != -1) {
-                       io_add(&mesh->loop, &mesh->pfroute_io, netlink_io_handler, mesh, sock, IO_READ);
+                       io_add(&mesh->loop, &mesh->discovery.pfroute_io, netlink_io_handler, NULL, sock, IO_READ);
                        netlink_getlink(sock);
                } else {
                        logger(mesh, MESHLINK_WARNING, "Could not bind AF_NETLINK socket: %s", strerror(errno));
@@ -646,7 +646,7 @@ bool discovery_start(meshlink_handle_t *mesh) {
        int sock = socket(PF_ROUTE, SOCK_RAW, AF_UNSPEC);
 
        if(sock != -1) {
-               io_add(&mesh->loop, &mesh->pfroute_io, pfroute_io_handler, mesh, sock, IO_READ);
+               io_add(&mesh->loop, &mesh->discovery.pfroute_io, pfroute_io_handler, NULL, sock, IO_READ);
        } else {
                logger(mesh, MESHLINK_WARNING, "Could not open PF_ROUTE socket: %s", strerror(errno));
        }
@@ -661,28 +661,28 @@ void discovery_stop(meshlink_handle_t *mesh) {
 
        assert(mesh);
 
-       free(mesh->discovery_ifaces);
-       free(mesh->discovery_addresses);
-       mesh->discovery_iface_count = 0;
-       mesh->discovery_address_count = 0;
+       free(mesh->discovery.ifaces);
+       free(mesh->discovery.addresses);
+       mesh->discovery.iface_count = 0;
+       mesh->discovery.address_count = 0;
 
-       if(mesh->pfroute_io.cb) {
-               close(mesh->pfroute_io.fd);
-               io_del(&mesh->loop, &mesh->pfroute_io);
+       if(mesh->discovery.pfroute_io.cb) {
+               close(mesh->discovery.pfroute_io.fd);
+               io_del(&mesh->loop, &mesh->discovery.pfroute_io);
        }
 
        for(int i = 0; i < 2; i++) {
-               if(mesh->discovery_sockets[i].cb) {
-                       close(mesh->discovery_sockets[i].fd);
-                       io_del(&mesh->loop, &mesh->discovery_sockets[i]);
+               if(mesh->discovery.sockets[i].cb) {
+                       close(mesh->discovery.sockets[i].fd);
+                       io_del(&mesh->loop, &mesh->discovery.sockets[i]);
                }
        }
 }
 
 void discovery_refresh(meshlink_handle_t *mesh) {
-       for(int i = 0; i < mesh->discovery_address_count; i++) {
-               if(mesh->discovery_addresses[i].up) {
-                       send_mdns_packet(mesh, &mesh->discovery_addresses[i]);
+       for(int i = 0; i < mesh->discovery.address_count; i++) {
+               if(mesh->discovery.addresses[i].up) {
+                       send_mdns_packet(mesh, &mesh->discovery.addresses[i]);
                }
        }
 }

diff --git a/src/meshlink.c b/src/meshlink.c
index ba2c84be4e29ab23bcf119a34b7ecb90e1ed4aac..1b7b03cf05868ad545bd6f51fa227be9776cbf83 100644 (file)
--- a/src/meshlink.c
+++ b/src/meshlink.c
@@ -1481,7 +1481,7 @@ meshlink_handle_t *meshlink_open_ex(const meshlink_open_params_t *params) {
 
        mesh->appname = xstrdup(params->appname);
        mesh->devclass = params->devclass;
-       mesh->discovery = true;
+       mesh->discovery.enabled = true;
        mesh->invitation_timeout = 604800; // 1 week
        mesh->netns = params->netns;
        mesh->submeshes = NULL;
@@ -1522,9 +1522,6 @@ meshlink_handle_t *meshlink_open_ex(const meshlink_open_params_t *params) {
        pthread_mutex_init(&mesh->mutex, &attr);
        pthread_cond_init(&mesh->cond, NULL);
 
-       pthread_mutex_init(&mesh->discovery_mutex, NULL);
-       pthread_cond_init(&mesh->discovery_cond, NULL);
-
        pthread_cond_init(&mesh->adns_cond, NULL);
 
        mesh->threadstarted = false;
@@ -1653,7 +1650,7 @@ static void *meshlink_main_loop(void *arg) {
 #endif // HAVE_SETNS
        }
 
-       if(mesh->discovery) {
+       if(mesh->discovery.enabled) {
                discovery_start(mesh);
        }
 
@@ -1669,7 +1666,7 @@ static void *meshlink_main_loop(void *arg) {
        pthread_mutex_unlock(&mesh->mutex);
 
        // Stop discovery
-       if(mesh->discovery) {
+       if(mesh->discovery.enabled) {
                discovery_stop(mesh);
        }
 
@@ -4476,7 +4473,7 @@ void meshlink_enable_discovery(meshlink_handle_t *mesh, bool enable) {
                abort();
        }
 
-       if(mesh->discovery == enable) {
+       if(mesh->discovery.enabled == enable) {
                goto end;
        }
 
@@ -4488,7 +4485,7 @@ void meshlink_enable_discovery(meshlink_handle_t *mesh, bool enable) {
                }
        }
 
-       mesh->discovery = enable;
+       mesh->discovery.enabled = enable;
 
 end:
        pthread_mutex_unlock(&mesh->mutex);
@@ -4563,7 +4560,7 @@ void meshlink_reset_timers(struct meshlink_handle *mesh) {
 
        handle_network_change(mesh, true);
 
-       if(mesh->discovery) {
+       if(mesh->discovery.enabled) {
                discovery_refresh(mesh);
        }
 

diff --git a/src/meshlink_internal.h b/src/meshlink_internal.h
index 6c6c4c4def9a17bcc62de9962a975be61e93181e..d5781622982851d7ced8b421cd6846616a666d15 100644 (file)
--- a/src/meshlink_internal.h
+++ b/src/meshlink_internal.h
@@ -156,7 +156,6 @@ struct meshlink_handle {
        int netns;
 
        bool default_blacklist;
-       bool discovery;         // Whether mDNS discovery is enabled or not
        bool inviter_commits_first;
 
        // Configuration
@@ -169,18 +168,18 @@ struct meshlink_handle {
        // Thread management
        pthread_t thread;
        pthread_cond_t cond;
-       pthread_mutex_t discovery_mutex;
-       pthread_cond_t discovery_cond;
        bool threadstarted;
-       bool discovery_threadstarted;
 
        // mDNS discovery
-       io_t pfroute_io;
-       int *discovery_ifaces;
-       struct discovery_address *discovery_addresses;
-       int discovery_iface_count;
-       int discovery_address_count;
-       io_t discovery_sockets[2];
+       struct {
+               bool enabled;
+               io_t pfroute_io;
+               int *ifaces;
+               struct discovery_address *addresses;
+               int iface_count;
+               int address_count;
+               io_t sockets[2];
+       } discovery;
 
        // ADNS
        pthread_t adns_thread;