} while (0)
#endif
+static inline size_t min(size_t a, size_t b) {
+ return a < b ? a : b;
+}
+
static inline size_t max(size_t a, size_t b) {
return a > b ? a : b;
}
debug("\n");
}
+
+static void debug_cwnd(struct utcp_connection *c) {
+ debug("snd.cwnd = %u\n", c->snd.cwnd);
+}
#else
#define debug(...) do {} while(0)
#define print_packet(...) do {} while(0)
+#define debug_cwnd(...) do {} while(0)
#endif
static void set_state(struct utcp_connection *c, enum state state) {
#endif
c->snd.una = c->snd.iss;
c->snd.nxt = c->snd.iss + 1;
- c->rcv.wnd = utcp->mtu;
c->snd.last = c->snd.nxt;
- c->snd.cwnd = utcp->mtu;
+ c->snd.cwnd = (utcp->mtu > 2190 ? 2 : utcp->mtu > 1095 ? 3 : 4) * utcp->mtu;
+ c->snd.ssthresh = ~0;
+ debug_cwnd(c);
c->utcp = utcp;
// Add it to the sorted list of connections
if(!utcp->srtt) {
utcp->srtt = rtt;
utcp->rttvar = rtt / 2;
- utcp->rto = rtt + max(2 * rtt, CLOCK_GRANULARITY);
} else {
utcp->rttvar = (utcp->rttvar * 3 + absdiff(utcp->srtt, rtt)) / 4;
utcp->srtt = (utcp->srtt * 7 + rtt) / 8;
- utcp->rto = utcp->srtt + max(utcp->rttvar, CLOCK_GRANULARITY);
}
+ utcp->rto = utcp->srtt + max(4 * utcp->rttvar, CLOCK_GRANULARITY);
+
if(utcp->rto > MAX_RTO) {
utcp->rto = MAX_RTO;
}
pkt.hdr.dst = c->dst;
pkt.hdr.seq = c->snd.iss;
pkt.hdr.ack = 0;
- pkt.hdr.wnd = c->rcv.wnd;
+ pkt.hdr.wnd = c->rcvbuf.maxsize;
pkt.hdr.ctl = SYN;
pkt.hdr.aux = 0x0101;
pkt.init[0] = 1;
static void ack(struct utcp_connection *c, bool sendatleastone) {
int32_t left = seqdiff(c->snd.last, c->snd.nxt);
- int32_t cwndleft = c->snd.cwnd - seqdiff(c->snd.nxt, c->snd.una);
- debug("cwndleft = %d\n", cwndleft);
+ int32_t cwndleft = min(c->snd.cwnd, c->snd.wnd) - seqdiff(c->snd.nxt, c->snd.una);
assert(left >= 0);
- if(cwndleft <= 0) {
- cwndleft = 0;
- }
-
- if(cwndleft < left) {
+ if(cwndleft < 0) {
+ left = 0;
+ } else if(cwndleft < left) {
left = cwndleft;
}
+ debug("cwndleft = %d, left = %d\n", cwndleft, left);
+
if(!left && !sendatleastone) {
return;
}
pkt->hdr.src = c->src;
pkt->hdr.dst = c->dst;
pkt->hdr.ack = c->rcv.nxt;
- pkt->hdr.wnd = c->snd.wnd;
+ pkt->hdr.wnd = c->rcvbuf.maxsize;
pkt->hdr.ctl = ACK;
pkt->hdr.aux = 0;
if(is_reliable(c) || (c->state != SYN_SENT && c->state != SYN_RECEIVED)) {
len = buffer_put(&c->sndbuf, data, len);
+ } else {
+ return 0;
}
if(len <= 0) {
pkt->hdr.src = c->src;
pkt->hdr.dst = c->dst;
- pkt->hdr.wnd = c->rcv.wnd;
+ pkt->hdr.wnd = c->rcvbuf.maxsize;
pkt->hdr.aux = 0;
switch(c->state) {
}
c->snd.nxt = c->snd.una + len;
- c->snd.cwnd = utcp->mtu; // reduce cwnd on retransmit
+
+ // RFC 5681 slow start after timeout
+ c->snd.ssthresh = max(c->snd.cwnd / 2, utcp->mtu * 2); // eq. 4
+ c->snd.cwnd = utcp->mtu;
+ debug_cwnd(c);
+
buffer_copy(&c->sndbuf, pkt->data, 0, len);
print_packet(c->utcp, "rtrx", pkt, sizeof(pkt->hdr) + len);
utcp->send(utcp, pkt, sizeof(pkt->hdr) + len);
ptr += 2;
}
- bool has_data = len;
+ bool has_data = len || (hdr.ctl & (SYN | FIN));
// Try to match the packet to an existing connection
c->flags = UTCP_TCP;
}
+synack:
// Return SYN+ACK, go to SYN_RECEIVED state
c->snd.wnd = hdr.wnd;
c->rcv.irs = hdr.seq;
pkt.hdr.dst = c->dst;
pkt.hdr.ack = c->rcv.irs + 1;
pkt.hdr.seq = c->snd.iss;
- pkt.hdr.wnd = c->rcv.wnd;
+ pkt.hdr.wnd = c->rcvbuf.maxsize;
pkt.hdr.ctl = SYN | ACK;
if(init) {
assert(data_acked >= 0);
+#ifndef NDEBUG
int32_t bufused = seqdiff(c->snd.last, c->snd.una);
assert(data_acked <= bufused);
+#endif
if(data_acked) {
buffer_get(&c->sndbuf, NULL, data_acked);
c->snd.una = hdr.ack;
c->dupack = 0;
- c->snd.cwnd += utcp->mtu;
+
+ // Increase the congestion window according to RFC 5681
+ if(c->snd.cwnd < c->snd.ssthresh) {
+ c->snd.cwnd += min(advanced, utcp->mtu); // eq. 2
+ } else {
+ c->snd.cwnd += max(1, (utcp->mtu * utcp->mtu) / c->snd.cwnd); // eq. 3
+ }
if(c->snd.cwnd > c->sndbuf.maxsize) {
c->snd.cwnd = c->sndbuf.maxsize;
}
+ debug_cwnd(c);
+
// Check if we have sent a FIN that is now ACKed.
switch(c->state) {
case FIN_WAIT_1:
case CLOSING:
if(c->snd.una == c->snd.last) {
gettimeofday(&c->conn_timeout, NULL);
- c->conn_timeout.tv_sec += 60;
+ c->conn_timeout.tv_sec += utcp->timeout;
set_state(c, TIME_WAIT);
}
//Reset the congestion window so we wait for ACKs.
c->snd.nxt = c->snd.una;
c->snd.cwnd = utcp->mtu;
+ debug_cwnd(c);
start_retransmit_timer(c);
}
}
break;
case SYN_RECEIVED:
+ // This is a retransmit of a SYN, send back the SYNACK.
+ goto synack;
+
case ESTABLISHED:
case FIN_WAIT_1:
case FIN_WAIT_2:
case FIN_WAIT_2:
gettimeofday(&c->conn_timeout, NULL);
- c->conn_timeout.tv_sec += 60;
+ c->conn_timeout.tv_sec += utcp->timeout;
set_state(c, TIME_WAIT);
break;
continue;
}
- c->rtrx_timeout = now;
- c->conn_timeout = then;
+ if(timerisset(&c->rtrx_timeout)) {
+ c->rtrx_timeout = now;
+ }
+
+ if(timerisset(&c->conn_timeout)) {
+ c->conn_timeout = then;
+ }
+
c->rtt_start.tv_sec = 0;
}
}
void utcp_offline(struct utcp *utcp, bool offline) {
+ struct timeval now;
+ gettimeofday(&now, NULL);
+
for(int i = 0; i < utcp->nconnections; i++) {
struct utcp_connection *c = utcp->connections[i];
- if(!c->reapable) {
- utcp_expect_data(c, offline);
-
- // If we are online again, reset the retransmission timers, but keep the connection timeout as it is,
- // to prevent peers toggling online/offline state frequently from keeping connections alive
- // if there is no progress in sending actual data.
- if(!offline) {
- gettimeofday(&utcp->connections[i]->rtrx_timeout, NULL);
- utcp->connections[i]->rtt_start.tv_sec = 0;
+ if(c->reapable) {
+ continue;
+ }
+
+ utcp_expect_data(c, offline);
+
+ if(!offline) {
+ if(timerisset(&c->rtrx_timeout)) {
+ c->rtrx_timeout = now;
}
+
+ utcp->connections[i]->rtt_start.tv_sec = 0;
}
}