X-Git-Url: http://git.meshlink.io/?p=meshlink;a=blobdiff_plain;f=src%2Fprotocol_key.c;h=3cf4ab11a0bd121fb976e2e25dfade630e966f40;hp=06c6d3364702bee9f5a21a5edce5aae64618e82e;hb=08aabbf9317806bc50a9a6693ca866c8936ce26b;hpb=43fa7283ac01f2ecc95381b519ef6b3342546f35

diff --git a/src/protocol_key.c b/src/protocol_key.c
index 06c6d336..3cf4ab11 100644
--- a/src/protocol_key.c
+++ b/src/protocol_key.c
@@ -22,10 +22,8 @@
 
 #include "system.h"
 
-#include <openssl/evp.h>
-#include <openssl/err.h>
-
-#include "avl_tree.h"
+#include "splay_tree.h"
+#include "cipher.h"
 #include "connection.h"
 #include "logger.h"
 #include "net.h"
@@ -35,10 +33,9 @@
 #include "utils.h"
 #include "xalloc.h"
 
-bool mykeyused = false;
+static bool mykeyused = false;
 
-bool send_key_changed(connection_t *c, const node_t *n)
-{
+bool send_key_changed(connection_t *c, const node_t *n) {
 	cp();
 
 	/* Only send this message if some other daemon requested our key previously.
@@ -51,20 +48,19 @@ bool send_key_changed(connection_t *c, const node_t *n)
 	return send_request(c, "%d %lx %s", KEY_CHANGED, random(), n->name);
 }
 
-bool key_changed_h(connection_t *c)
-{
+bool key_changed_h(connection_t *c, char *request) {
 	char name[MAX_STRING_SIZE];
 	node_t *n;
 
 	cp();
 
-	if(sscanf(c->buffer, "%*d %*x " MAX_STRING, name) != 1) {
+	if(sscanf(request, "%*d %*x " MAX_STRING, name) != 1) {
 		logger(LOG_ERR, _("Got bad %s from %s (%s)"), "KEY_CHANGED",
 			   c->name, c->hostname);
 		return false;
 	}
 
-	if(seen_request(c->buffer))
+	if(seen_request(request))
 		return true;
 
 	n = lookup_node(name);
@@ -81,27 +77,25 @@ bool key_changed_h(connection_t *c)
 	/* Tell the others */
 
 	if(!tunnelserver)
-		forward_request(c);
+		forward_request(c, request);
 
 	return true;
 }
 
-bool send_req_key(connection_t *c, const node_t *from, const node_t *to)
-{
+bool send_req_key(connection_t *c, const node_t *from, const node_t *to) {
 	cp();
 
 	return send_request(c, "%d %s %s", REQ_KEY, from->name, to->name);
 }
 
-bool req_key_h(connection_t *c)
-{
+bool req_key_h(connection_t *c, char *request) {
 	char from_name[MAX_STRING_SIZE];
 	char to_name[MAX_STRING_SIZE];
 	node_t *from, *to;
 
 	cp();
 
-	if(sscanf(c->buffer, "%*d " MAX_STRING " " MAX_STRING, from_name, to_name) != 2) {
+	if(sscanf(request, "%*d " MAX_STRING " " MAX_STRING, from_name, to_name) != 2) {
 		logger(LOG_ERR, _("Got bad %s from %s (%s)"), "REQ_KEY", c->name,
 			   c->hostname);
 		return false;
@@ -128,7 +122,7 @@ bool req_key_h(connection_t *c)
 	if(to == myself) {			/* Yes, send our own key back */
 		mykeyused = true;
 		from->received_seqno = 0;
-		memset(from->late, 0, sizeof(from->late));
+		memset(from->late, 0, sizeof from->late);
 		send_ans_key(c, myself, from);
 	} else {
 		if(tunnelserver)
@@ -146,25 +140,24 @@ bool req_key_h(connection_t *c)
 	return true;
 }
 
-bool send_ans_key(connection_t *c, const node_t *from, const node_t *to)
-{
-	char *key;
+bool send_ans_key(connection_t *c, const node_t *from, const node_t *to) {
+	size_t keylen = cipher_keylength(&from->cipher);
+	char key[keylen * 2 + 1];
 
 	cp();
 
-	key = alloca(2 * from->keylength + 1);
-	bin2hex(from->key, key, from->keylength);
-	key[from->keylength * 2] = '\0';
+	cipher_get_key(&from->cipher, key);
+	bin2hex(key, key, keylen);
+	key[keylen * 2] = '\0';
 
 	return send_request(c, "%d %s %s %s %d %d %d %d", ANS_KEY,
 						from->name, to->name, key,
-						from->cipher ? from->cipher->nid : 0,
-						from->digest ? from->digest->type : 0, from->maclength,
+						cipher_get_nid(&from->cipher),
+						digest_get_nid(&from->digest), from->maclength,
 						from->compression);
 }
 
-bool ans_key_h(connection_t *c)
-{
+bool ans_key_h(connection_t *c, char *request) {
 	char from_name[MAX_STRING_SIZE];
 	char to_name[MAX_STRING_SIZE];
 	char key[MAX_STRING_SIZE];
@@ -173,7 +166,7 @@ bool ans_key_h(connection_t *c)
 
 	cp();
 
-	if(sscanf(c->buffer, "%*d "MAX_STRING" "MAX_STRING" "MAX_STRING" %d %d %d %d",
+	if(sscanf(request, "%*d "MAX_STRING" "MAX_STRING" "MAX_STRING" %d %d %d %d",
 		from_name, to_name, key, &cipher, &digest, &maclength,
 		&compression) != 7) {
 		logger(LOG_ERR, _("Got bad %s from %s (%s)"), "ANS_KEY", c->name,
@@ -205,65 +198,35 @@ bool ans_key_h(connection_t *c)
 
 		if(!to->status.reachable) {
 			logger(LOG_WARNING, _("Got %s from %s (%s) destination %s which is not reachable"),
-				"ANS_KEY", c->name, c->hostname, to_name);
+				   "ANS_KEY", c->name, c->hostname, to_name);
 			return true;
 		}
 
-		return send_request(to->nexthop->connection, "%s", c->buffer);
+		return send_request(to->nexthop->connection, "%s", request);
 	}
 
-	/* Update our copy of the origin's packet key */
-
-	if(from->key)
-		free(from->key);
-
-	from->key = xstrdup(key);
-	from->keylength = strlen(key) / 2;
-	hex2bin(from->key, from->key, from->keylength);
-	from->key[from->keylength] = '\0';
-
-	from->status.validkey = true;
-	from->status.waitingforkey = false;
-	from->sent_seqno = 0;
-
 	/* Check and lookup cipher and digest algorithms */
 
-	if(cipher) {
-		from->cipher = EVP_get_cipherbynid(cipher);
-
-		if(!from->cipher) {
-			logger(LOG_ERR, _("Node %s (%s) uses unknown cipher!"), from->name,
-				   from->hostname);
-			return false;
-		}
+	if(!cipher_open_by_nid(&from->cipher, cipher)) {
+		logger(LOG_ERR, _("Node %s (%s) uses unknown cipher!"), from->name, from->hostname);
+		return false;
+	}
 
-		if(from->keylength != from->cipher->key_len + from->cipher->iv_len) {
-			logger(LOG_ERR, _("Node %s (%s) uses wrong keylength!"), from->name,
-				   from->hostname);
-			return false;
-		}
-	} else {
-		from->cipher = NULL;
+	if(strlen(key) / 2 != cipher_keylength(&from->cipher)) {
+		logger(LOG_ERR, _("Node %s (%s) uses wrong keylength!"), from->name, from->hostname);
+		return false;
 	}
 
 	from->maclength = maclength;
 
-	if(digest) {
-		from->digest = EVP_get_digestbynid(digest);
-
-		if(!from->digest) {
-			logger(LOG_ERR, _("Node %s (%s) uses unknown digest!"), from->name,
-				   from->hostname);
-			return false;
-		}
+	if(!digest_open_by_nid(&from->digest, digest)) {
+		logger(LOG_ERR, _("Node %s (%s) uses unknown digest!"), from->name, from->hostname);
+		return false;
+	}
 
-		if(from->maclength > from->digest->md_size || from->maclength < 0) {
-			logger(LOG_ERR, _("Node %s (%s) uses bogus MAC length!"),
-				   from->name, from->hostname);
-			return false;
-		}
-	} else {
-		from->digest = NULL;
+	if(from->maclength > digest_length(&from->digest) || from->maclength < 0) {
+		logger(LOG_ERR, _("Node %s (%s) uses bogus MAC length!"), from->name, from->hostname);
+		return false;
 	}
 
 	if(compression < 0 || compression > 11) {
@@ -273,12 +236,14 @@ bool ans_key_h(connection_t *c)
 	
 	from->compression = compression;
 
-	if(from->cipher)
-		if(!EVP_EncryptInit_ex(&from->packet_ctx, from->cipher, NULL, (unsigned char *)from->key, (unsigned char *)from->key + from->cipher->key_len)) {
-			logger(LOG_ERR, _("Error during initialisation of key from %s (%s): %s"),
-					from->name, from->hostname, ERR_error_string(ERR_get_error(), NULL));
-			return false;
-		}
+	/* Update our copy of the origin's packet key */
+
+	hex2bin(key, key, cipher_keylength(&from->cipher));
+	cipher_set_key(&from->cipher, key, false);
+
+	from->status.validkey = true;
+	from->status.waitingforkey = false;
+	from->sent_seqno = 0;
 
 	if(from->options & OPTION_PMTU_DISCOVERY && !from->mtuprobes)
 		send_mtu_probe(from);