X-Git-Url: http://git.meshlink.io/?p=meshlink;a=blobdiff_plain;f=src%2Flogger.c;h=78d629ee2e5305a57e812522e7bb79c04f5ed1d2;hp=ecb55a534a631f7f3cf68b447b794cf97f3819d6;hb=963c5055505f2fc117cd5efa06eaa02c9b2bf85d;hpb=ae1d95cee66f3e5c6475f03b441d455e436e9ee8

diff --git a/src/logger.c b/src/logger.c
index ecb55a53..78d629ee 100644
--- a/src/logger.c
+++ b/src/logger.c
@@ -1,6 +1,6 @@
 /*
     logger.c -- logging code
-    Copyright (C) 2014 Guus Sliepen <guus@meshlink.io>
+    Copyright (C) 2014-2017 Guus Sliepen <guus@meshlink.io>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -25,26 +25,32 @@
 
 // TODO: refactor logging code to use a meshlink_handle_t *.
 void logger(meshlink_handle_t *mesh, meshlink_log_level_t level, const char *format, ...) {
+	assert(format);
+
 	if(mesh) {
-		if(level < mesh->log_level || !mesh->log_cb)
+		if(level < mesh->log_level || !mesh->log_cb) {
 			return;
+		}
 	} else {
-		if(level < global_log_level || !global_log_cb)
+		if(level < global_log_level || !global_log_cb) {
 			return;
+		}
 	}
 
 	va_list ap;
 	char message[1024] = "";
 
 	va_start(ap, format);
-	int len = vsnprintf(message, sizeof message, format, ap);
+	int len = vsnprintf(message, sizeof(message), format, ap);
 	va_end(ap);
 
-	if(len > 0 && len < sizeof message && message[len - 1] == '\n')
+	if(len > 0 && (size_t)len < sizeof(message) && message[len - 1] == '\n') {
 		message[len - 1] = 0;
+	}
 
-	if(mesh)
+	if(mesh) {
 		mesh->log_cb(mesh, level, message);
-	else
+	} else {
 		global_log_cb(NULL, level, message);
+	}
 }