X-Git-Url: http://git.meshlink.io/?p=meshlink;a=blobdiff_plain;f=src%2Fconf.c;h=e3574ea5442888b3fa3edee6886040264f2378c5;hp=779425971439e08492c8f55f2e997dd7ce463ffc;hb=92283d7342fabd882126a892b2636d57ff0458de;hpb=5a132550deb58473285e5f91705d286aef47be71

diff --git a/src/conf.c b/src/conf.c
index 77942597..e3574ea5 100644
--- a/src/conf.c
+++ b/src/conf.c
@@ -1,9 +1,6 @@
 /*
     conf.c -- configuration code
-    Copyright (C) 1998 Robert van der Meulen
-                  1998-2005 Ivo Timmermans
-                  2000-2009 Guus Sliepen <guus@tinc-vpn.org>
-		  2000 Cris van Pelt
+    Copyright (C) 2014 Guus Sliepen <guus@meshlink.io>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -15,101 +12,78 @@
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
-    You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-
-    $Id$
+    You should have received a copy of the GNU General Public License along
+    with this program; if not, write to the Free Software Foundation, Inc.,
+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
 
 #include "system.h"
+#include <assert.h>
 
 #include "splay_tree.h"
+#include "connection.h"
 #include "conf.h"
+#include "list.h"
 #include "logger.h"
-#include "netutl.h"				/* for str2address */
-#include "utils.h"				/* for cp */
+#include "meshlink_internal.h"
+#include "netutl.h"             /* for str2address */
+#include "protocol.h"
+#include "utils.h"              /* for cp */
 #include "xalloc.h"
 
-splay_tree_t *config_tree;
-
-int pinginterval = 0;			/* seconds between pings */
-int pingtimeout = 0;			/* seconds to wait for response */
-char *confbase = NULL;			/* directory in which all config files are */
-char *netname = NULL;			/* name of the vpn network */
-
 static int config_compare(const config_t *a, const config_t *b) {
 	int result;
 
 	result = strcasecmp(a->variable, b->variable);
 
-	if(result)
+	if(result) {
 		return result;
+	}
 
-	result = a->line - b->line;
-
-	if(result)
-		return result;
-	else
-		return strcmp(a->file, b->file);
+	return result = a->line - b->line;
 }
 
-void init_configuration(splay_tree_t ** config_tree) {
-	cp();
-
+void init_configuration(splay_tree_t **config_tree) {
 	*config_tree = splay_alloc_tree((splay_compare_t) config_compare, (splay_action_t) free_config);
 }
 
-void exit_configuration(splay_tree_t ** config_tree) {
-	cp();
+void exit_configuration(splay_tree_t **config_tree) {
+	if(*config_tree) {
+		splay_delete_tree(*config_tree);
+	}
 
-	splay_delete_tree(*config_tree);
 	*config_tree = NULL;
 }
 
 config_t *new_config(void) {
-	cp();
-
-	return xmalloc_and_zero(sizeof(config_t));
+	return xzalloc(sizeof(config_t));
 }
 
 void free_config(config_t *cfg) {
-	cp();
-
-	if(cfg->variable)
-		free(cfg->variable);
-
-	if(cfg->value)
-		free(cfg->value);
-
-	if(cfg->file)
-		free(cfg->file);
-
+	free(cfg->variable);
+	free(cfg->value);
 	free(cfg);
 }
 
 void config_add(splay_tree_t *config_tree, config_t *cfg) {
-	cp();
-
 	splay_insert(config_tree, cfg);
 }
 
 config_t *lookup_config(splay_tree_t *config_tree, char *variable) {
 	config_t cfg, *found;
 
-	cp();
-
 	cfg.variable = variable;
-	cfg.file = "";
 	cfg.line = 0;
 
 	found = splay_search_closest_greater(config_tree, &cfg);
 
-	if(!found)
+	if(!found) {
 		return NULL;
+	}
 
-	if(strcasecmp(found->variable, variable))
+	if(strcasecmp(found->variable, variable)) {
 		return NULL;
+	}
 
 	return found;
 }
@@ -118,16 +92,15 @@ config_t *lookup_config_next(splay_tree_t *config_tree, const config_t *cfg) {
 	splay_node_t *node;
 	config_t *found;
 
-	cp();
-
 	node = splay_search_node(config_tree, cfg);
 
 	if(node) {
 		if(node->next) {
 			found = node->next->data;
 
-			if(!strcasecmp(found->variable, cfg->variable))
+			if(!strcasecmp(found->variable, cfg->variable)) {
 				return found;
+			}
 		}
 	}
 
@@ -135,10 +108,9 @@ config_t *lookup_config_next(splay_tree_t *config_tree, const config_t *cfg) {
 }
 
 bool get_config_bool(const config_t *cfg, bool *result) {
-	cp();
-
-	if(!cfg)
+	if(!cfg) {
 		return false;
+	}
 
 	if(!strcasecmp(cfg->value, "yes")) {
 		*result = true;
@@ -148,45 +120,74 @@ bool get_config_bool(const config_t *cfg, bool *result) {
 		return true;
 	}
 
-	logger(LOG_ERR, _("\"yes\" or \"no\" expected for configuration variable %s in %s line %d"),
-		   cfg->variable, cfg->file, cfg->line);
+	logger(NULL, MESHLINK_ERROR, "\"yes\" or \"no\" expected for configuration variable %s in line %d",
+	       cfg->variable, cfg->line);
 
 	return false;
 }
 
 bool get_config_int(const config_t *cfg, int *result) {
-	cp();
-
-	if(!cfg)
+	if(!cfg) {
 		return false;
+	}
 
-	if(sscanf(cfg->value, "%d", result) == 1)
+	if(sscanf(cfg->value, "%d", result) == 1) {
 		return true;
+	}
 
-	logger(LOG_ERR, _("Integer expected for configuration variable %s in %s line %d"),
-		   cfg->variable, cfg->file, cfg->line);
+	logger(NULL, MESHLINK_ERROR, "Integer expected for configuration variable %s in line %d",
+	       cfg->variable, cfg->line);
 
 	return false;
 }
 
-bool get_config_string(const config_t *cfg, char **result) {
-	cp();
+bool set_config_int(config_t *cfg, int val) {
+	if(!cfg) {
+		return false;
+	}
+
+	char val_str[1024];
+	snprintf(val_str, sizeof(val_str), "%d", val);
+
+	if(cfg->value) {
+		free(cfg->value);
+	}
+
+	cfg->value = xstrdup(val_str);
+
+	return true;
+}
 
-	if(!cfg)
+bool get_config_string(const config_t *cfg, char **result) {
+	if(!cfg) {
 		return false;
+	}
 
 	*result = xstrdup(cfg->value);
 
 	return true;
 }
 
+bool set_config_string(config_t *cfg, const char *val) {
+	if(!cfg) {
+		return false;
+	}
+
+	if(cfg->value) {
+		free(cfg->value);
+	}
+
+	cfg->value = xstrdup(val);
+
+	return true;
+}
+
 bool get_config_address(const config_t *cfg, struct addrinfo **result) {
 	struct addrinfo *ai;
 
-	cp();
-
-	if(!cfg)
+	if(!cfg) {
 		return false;
+	}
 
 	ai = str2addrinfo(cfg->value, NULL, 0);
 
@@ -195,220 +196,333 @@ bool get_config_address(const config_t *cfg, struct addrinfo **result) {
 		return true;
 	}
 
-	logger(LOG_ERR, _("Hostname or IP address expected for configuration variable %s in %s line %d"),
-		   cfg->variable, cfg->file, cfg->line);
+	logger(NULL, MESHLINK_ERROR, "Hostname or IP address expected for configuration variable %s in line %d",
+	       cfg->variable, cfg->line);
 
 	return false;
 }
 
-bool get_config_subnet(const config_t *cfg, subnet_t ** result) {
-	subnet_t subnet = {0};
+/*
+  Read exactly one line and strip the trailing newline if any.
+*/
+static char *readline(FILE *fp, char *buf, size_t buflen) {
+	char *newline = NULL;
+	char *p;
 
-	cp();
+	if(feof(fp)) {
+		return NULL;
+	}
 
-	if(!cfg)
-		return false;
+	p = fgets(buf, buflen, fp);
 
-	if(!str2net(&subnet, cfg->value)) {
-		logger(LOG_ERR, _("Subnet expected for configuration variable %s in %s line %d"),
-			   cfg->variable, cfg->file, cfg->line);
-		return false;
+	if(!p) {
+		return NULL;
 	}
 
-	/* Teach newbies what subnets are... */
+	newline = strchr(p, '\n');
 
-	if(((subnet.type == SUBNET_IPV4)
-		&& !maskcheck(&subnet.net.ipv4.address, subnet.net.ipv4.prefixlength, sizeof subnet.net.ipv4.address))
-		|| ((subnet.type == SUBNET_IPV6)
-		&& !maskcheck(&subnet.net.ipv6.address, subnet.net.ipv6.prefixlength, sizeof subnet.net.ipv6.address))) {
-		logger(LOG_ERR, _ ("Network address and prefix length do not match for configuration variable %s in %s line %d"),
-			   cfg->variable, cfg->file, cfg->line);
-		return false;
+	if(!newline) {
+		return buf;
 	}
 
-	*(*result = new_subnet()) = subnet;
+	/* kill newline and carriage return if necessary */
+	*newline = '\0';
 
-	return true;
+	if(newline > p && newline[-1] == '\r') {
+		newline[-1] = '\0';
+	}
+
+	return buf;
 }
 
-/*
-  Read exactly one line and strip the trailing newline if any.  If the
-  file was on EOF, return NULL. Otherwise, return all the data in a
-  dynamically allocated buffer.
-
-  If line is non-NULL, it will be used as an initial buffer, to avoid
-  unnecessary mallocing each time this function is called.  If buf is
-  given, and buf needs to be expanded, the var pointed to by buflen
-  will be increased.
-*/
-static char *readline(FILE * fp, char **buf, size_t *buflen) {
-	char *newline = NULL;
-	char *p;
-	char *line;					/* The array that contains everything that has been read so far */
-	char *idx;					/* Read into this pointer, which points to an offset within line */
-	size_t size, newsize;		/* The size of the current array pointed to by line */
-	size_t maxlen;				/* Maximum number of characters that may be read with fgets.  This is newsize - oldsize. */
+config_t *parse_config_line(char *line, const char *fname, int lineno) {
+	config_t *cfg;
+	int len;
+	char *variable, *value, *eol;
+	variable = value = line;
 
-	if(feof(fp))
-		return NULL;
+	eol = line + strlen(line);
 
-	if(buf && buflen) {
-		size = *buflen;
-		line = *buf;
-	} else {
-		size = 100;
-		line = xmalloc(size);
+	while(strchr("\t ", *--eol)) {
+		*eol = '\0';
 	}
 
-	maxlen = size;
-	idx = line;
-	*idx = 0;
-
-	for(;;) {
-		errno = 0;
-		p = fgets(idx, maxlen, fp);
+	len = strcspn(value, "\t =");
+	value += len;
+	value += strspn(value, "\t ");
 
-		if(!p) {				/* EOF or error */
-			if(feof(fp))
-				break;
+	if(*value == '=') {
+		value++;
+		value += strspn(value, "\t ");
+	}
 
-			/* otherwise: error; let the calling function print an error message if applicable */
-			free(line);
-			return NULL;
-		}
+	variable[len] = '\0';
 
-		newline = strchr(p, '\n');
-
-		if(!newline) {			/* We haven't yet read everything to the end of the line */
-			newsize = size << 1;
-			line = xrealloc(line, newsize);
-			idx = &line[size - 1];
-			maxlen = newsize - size + 1;
-			size = newsize;
-		} else {
-			*newline = '\0';	/* kill newline */
-			if(newline > p && newline[-1] == '\r')	/* and carriage return if necessary */
-				newline[-1] = '\0';
-			break;				/* yay */
-		}
+	if(!*value) {
+		const char err[] = "No value for variable";
+		logger(NULL, MESHLINK_ERROR, "%s `%s' on line %d while reading config file %s",
+		       err, variable, lineno, fname);
+		return NULL;
 	}
 
-	if(buf && buflen) {
-		*buflen = size;
-		*buf = line;
-	}
+	cfg = new_config();
+	cfg->variable = xstrdup(variable);
+	cfg->value = xstrdup(value);
+	cfg->line = lineno;
 
-	return line;
+	return cfg;
 }
 
 /*
   Parse a configuration file and put the results in the configuration tree
   starting at *base.
 */
-int read_config_file(splay_tree_t *config_tree, const char *fname) {
-	int err = -2;				/* Parse error */
+bool read_config_file(splay_tree_t *config_tree, const char *fname) {
 	FILE *fp;
-	char *buffer, *line;
-	char *variable, *value, *eol;
+	char buffer[MAX_STRING_SIZE];
+	char *line;
 	int lineno = 0;
-	int len;
 	bool ignore = false;
 	config_t *cfg;
-	size_t bufsize;
-
-	cp();
+	bool result = false;
 
 	fp = fopen(fname, "r");
 
 	if(!fp) {
-		logger(LOG_ERR, _("Cannot open config file %s: %s"), fname,
-			   strerror(errno));
-		return -3;
+		logger(NULL, MESHLINK_ERROR, "Cannot open config file %s: %s", fname, strerror(errno));
+		return false;
 	}
 
-	bufsize = 100;
-	buffer = xmalloc(bufsize);
-
 	for(;;) {
-		if(feof(fp)) {
-			err = 0;
-			break;
-		}
-
-		line = readline(fp, &buffer, &bufsize);
+		line = readline(fp, buffer, sizeof(buffer));
 
 		if(!line) {
-			err = -1;
+			if(feof(fp)) {
+				result = true;
+			}
+
 			break;
 		}
 
 		lineno++;
 
-		if(!*line || *line == '#')
+		if(!*line || *line == '#') {
 			continue;
+		}
 
 		if(ignore) {
-			if(!strncmp(line, "-----END", 8))
+			if(!strncmp(line, "-----END", 8)) {
 				ignore = false;
+			}
+
 			continue;
 		}
-		
+
 		if(!strncmp(line, "-----BEGIN", 10)) {
 			ignore = true;
 			continue;
 		}
 
-		variable = value = line;
+		cfg = parse_config_line(line, fname, lineno);
 
-		eol = line + strlen(line);
-		while(strchr("\t ", *--eol))
-			*eol = '\0';
+		if(!cfg) {
+			break;
+		}
 
-		len = strcspn(value, "\t =");
-		value += len;
-		value += strspn(value, "\t ");
-		if(*value == '=') {
-			value++;
-			value += strspn(value, "\t ");
+		config_add(config_tree, cfg);
+	}
+
+	fclose(fp);
+
+	return result;
+}
+
+bool write_config_file(const struct splay_tree_t *config_tree, const char *fname) {
+	FILE *fp;
+
+	fp = fopen(fname, "w+");
+
+	if(!fp) {
+		logger(NULL, MESHLINK_ERROR, "Cannot open config file %s: %s", fname, strerror(errno));
+		return false;
+	}
+
+	for splay_each(config_t, cnf, config_tree) {
+		if(fwrite(cnf->variable, sizeof(char), strlen(cnf->variable), fp) < strlen(cnf->variable)) {
+			goto error;
 		}
-		variable[len] = '\0';
 
-	
-		if(!*value) {
-			logger(LOG_ERR, _("No value for variable `%s' on line %d while reading config file %s"),
-				   variable, lineno, fname);
-			break;
+		if(fwrite(" = ", sizeof(char), 3, fp) < 3) {
+			goto error;
 		}
 
-		cfg = new_config();
-		cfg->variable = xstrdup(variable);
-		cfg->value = xstrdup(value);
-		cfg->file = xstrdup(fname);
-		cfg->line = lineno;
+		if(fwrite(cnf->value, sizeof(char), strlen(cnf->value), fp) < strlen(cnf->value)) {
+			goto error;
+		}
 
-		config_add(config_tree, cfg);
+		if(fwrite("\n", sizeof(char), 1, fp) < 1) {
+			goto error;
+		}
 	}
 
-	free(buffer);
 	fclose(fp);
+	return true;
+
+error:
+	logger(NULL, MESHLINK_ERROR, "Cannot write to config file %s: %s", fname, strerror(errno));
+	fclose(fp);
+	return false;
+}
+
+bool read_server_config(meshlink_handle_t *mesh) {
+	char filename[PATH_MAX];
+	bool x;
+
+	snprintf(filename, PATH_MAX, "%s" SLASH "meshlink.conf", mesh->confbase);
+	errno = 0;
+	x = read_config_file(mesh->config, filename);
+
+	if(!x && errno) {
+		logger(mesh, MESHLINK_ERROR, "Failed to read `%s': %s", filename, strerror(errno));
+	}
+
+	return x;
+}
+
+bool read_host_config(meshlink_handle_t *mesh, splay_tree_t *config_tree, const char *name) {
+	char filename[PATH_MAX];
+	bool x;
+
+	snprintf(filename, PATH_MAX, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name);
+	x = read_config_file(config_tree, filename);
+
+	return x;
+}
+
+bool write_host_config(struct meshlink_handle *mesh, const struct splay_tree_t *config_tree, const char *name) {
+	char filename[PATH_MAX];
 
-	return err;
+	snprintf(filename, PATH_MAX, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name);
+	return write_config_file(config_tree, filename);
 }
 
-bool read_server_config() {
-	char *fname;
-	int x;
+bool modify_config_file(struct meshlink_handle *mesh, const char *name, const char *key, const char *value, int trim) {
+	assert(mesh && name && key);
+
+	char filename[PATH_MAX];
+	char tmpname[PATH_MAX];
+	bool error = false;
+
+	if(snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name) >= PATH_MAX) {
+		logger(mesh, MESHLINK_ERROR, "Filename too long: %s" SLASH "hosts" SLASH "%s", mesh->confbase, name);
+		return false;
+	}
+
+	if(snprintf(tmpname, sizeof(tmpname), "%s.tmp", filename) >= PATH_MAX) {
+		logger(mesh, MESHLINK_ERROR, "Filename too long: %s.tmp", filename);
+		return false;
+	}
+
+	FILE *fr = fopen(filename, "r");
+
+	if(!fr) {
+		logger(mesh, MESHLINK_ERROR, "Cannot open config file %s: %s", filename, strerror(errno));
+		return false;
+	}
+
+	FILE *fw = fopen(tmpname, "w");
+
+	if(!fw) {
+		logger(mesh, MESHLINK_ERROR, "Cannot open temporary file %s: %s", tmpname, strerror(errno));
+		fclose(fr);
+		return false;
+	}
+
+	char buf[4096];
+	char *sep;
+	int found = 0;
+
+	if(value) {
+		fprintf(fw, "%s = %s\n", key, value);
+		found++;
+	}
+
+	while(readline(fr, buf, sizeof(buf))) {
+		if(!*buf || *buf == '#') {
+			goto copy;
+		}
+
+		sep = strchr(buf, ' ');
+
+		if(!sep) {
+			goto copy;
+		}
+
+		*sep = 0;
+
+		if(strcmp(buf, key)) {
+			*sep = ' ';
+			goto copy;
+		}
+
+		// We found the key and the value. We already added it at the top, so ignore this one.
+		if(value && sep[1] == '=' && sep[2] == ' ' && !strcmp(sep + 3, value)) {
+			continue;
+		}
+
+		// We found the key but with a different value, delete it if wanted.
+		found++;
+
+		if((!value || trim) && found > trim) {
+			continue;
+		}
+
+		*sep = ' ';
+
+copy:
+		fprintf(fw, "%s\n", buf);
+	}
+
+	if(ferror(fr)) {
+		error = true;
+	}
 
-	cp();
+	fclose(fr);
 
-	asprintf(&fname, "%s/tinc.conf", confbase);
-	x = read_config_file(config_tree, fname);
+	if(ferror(fw)) {
+		error = true;
+	}
+
+	if(fclose(fw)) {
+		error = true;
+	}
 
-	if(x == -1) {				/* System error: complain */
-		logger(LOG_ERR, _("Failed to read `%s': %s"), fname, strerror(errno));
+	// If any error occured during reading or writing, exit.
+	if(error) {
+		unlink(tmpname);
+		return false;
 	}
 
-	free(fname);
+	// Try to atomically replace the old config file with the new one.
+#ifdef HAVE_MINGW
+	char bakname[PATH_MAX];
+	snprintf(bakname, sizeof(bakname), "%s.bak", filename);
+
+	if(rename(filename, bakname) || rename(tmpname, filename)) {
+		rename(bakname, filename);
+#else
+
+	if(rename(tmpname, filename)) {
+#endif
+		return false;
+	} else {
+#ifdef HAVE_MINGW
+		unlink(bakname);
+#endif
+		return true;
+	}
+}
 
-	return x == 0;
+bool append_config_file(meshlink_handle_t *mesh, const char *name, const char *key, const char *value) {
+	return modify_config_file(mesh, name, key, value, 0);
 }