X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=test%2Futils.c;h=46e147a57f63df606f953d93bf3cb3d80b47155e;hb=9e8e77dba3462c4a7f7e758ade4d16bc669fc4a7;hp=4b2b2715de9bd5267ba2a756f4e4ed1f026eec76;hpb=668664d0ea90dc81670cccd7b7d56b36b8360eaa;p=meshlink

diff --git a/test/utils.c b/test/utils.c
index 4b2b2715..46e147a5 100644
--- a/test/utils.c
+++ b/test/utils.c
@@ -1,4 +1,4 @@
-#define _GNU_SOURCE
+#define _GNU_SOURCE 1
 
 #include <stdio.h>
 #include <stdlib.h>
@@ -8,37 +8,69 @@
 
 #include "utils.h"
 
-void set_sync_flag(struct sync_flag *s) {
+void set_sync_flag(struct sync_flag *s, bool value) {
 	pthread_mutex_lock(&s->mutex);
-	s->flag = true;
+	s->flag = value;
 	pthread_cond_broadcast(&s->cond);
 	pthread_mutex_unlock(&s->mutex);
 }
 
+bool check_sync_flag(struct sync_flag *s) {
+	bool flag;
+	pthread_mutex_lock(&s->mutex);
+	flag = s->flag;
+	pthread_mutex_unlock(&s->mutex);
+	return flag;
+}
+
 bool wait_sync_flag(struct sync_flag *s, int seconds) {
 	struct timespec timeout;
 	clock_gettime(CLOCK_REALTIME, &timeout);
 	timeout.tv_sec += seconds;
 
-	while(!s->flag)
+	pthread_mutex_lock(&s->mutex);
+
+	while(!s->flag) {
 		if(!pthread_cond_timedwait(&s->cond, &s->mutex, &timeout) || errno != EINTR) {
 			break;
 		}
+	}
+
+	pthread_mutex_unlock(&s->mutex);
 
 	return s->flag;
 }
 
+void link_meshlink_pair(meshlink_handle_t *a, meshlink_handle_t *b) {
+	// Import and export both side's data
+
+	meshlink_add_address(a, "localhost");
+	meshlink_add_address(b, "localhost");
+
+	char *data = meshlink_export(a);
+	assert(data);
+	assert(meshlink_import(b, data));
+	free(data);
+
+	data = meshlink_export(b);
+	assert(data);
+	assert(meshlink_import(a, data));
+	free(data);
+}
+
 void open_meshlink_pair(meshlink_handle_t **pa, meshlink_handle_t **pb, const char *prefix) {
 	// Create two new MeshLink instances
 
 	*pa = *pb = NULL;
 
 	char *a_name, *b_name;
+	int ret_val;
+	(void)ret_val;
 
-	asprintf(&a_name, "%s_conf.1", prefix);
+	ret_val = asprintf(&a_name, "%s_conf.1", prefix);
 	assert(a_name);
 
-	asprintf(&b_name, "%s_conf.2", prefix);
+	ret_val = asprintf(&b_name, "%s_conf.2", prefix);
 	assert(b_name);
 
 	meshlink_handle_t *a = meshlink_open(a_name, "a", prefix, DEV_CLASS_BACKBONE);
@@ -47,22 +79,13 @@ void open_meshlink_pair(meshlink_handle_t **pa, meshlink_handle_t **pb, const ch
 	meshlink_handle_t *b = meshlink_open(b_name, "b", prefix, DEV_CLASS_BACKBONE);
 	assert(b);
 
+	free(a_name);
+	free(b_name);
+
 	meshlink_enable_discovery(a, false);
 	meshlink_enable_discovery(b, false);
 
-	// Import and export both side's data
-
-	meshlink_add_address(a, "localhost");
-
-	char *data = meshlink_export(a);
-	assert(data);
-	assert(meshlink_import(b, data));
-	free(data);
-
-	data = meshlink_export(b);
-	assert(data);
-	assert(meshlink_import(a, data));
-	free(data);
+	link_meshlink_pair(a, b);
 
 	*pa = a;
 	*pb = b;
@@ -70,24 +93,22 @@ void open_meshlink_pair(meshlink_handle_t **pa, meshlink_handle_t **pb, const ch
 
 // Don't poll in the application thread, use a condition variable to signal when the peer is online.
 static void pair_status_cb(meshlink_handle_t *mesh, meshlink_node_t *node, bool reachable) {
-	set_sync_flag(mesh->priv);
+	(void)node;
+
+	set_sync_flag(mesh->priv, reachable);
 }
 
 void start_meshlink_pair(meshlink_handle_t *a, meshlink_handle_t *b) {
-	struct sync_flag pair_status = {};
+	struct sync_flag pair_status = {.flag = false};
 
 	a->priv = &pair_status;
 	meshlink_set_node_status_cb(a, pair_status_cb);
 
-	pthread_mutex_lock(&pair_status.mutex);
-
 	meshlink_start(a);
 	meshlink_start(b);
 
 	assert(wait_sync_flag(&pair_status, 5));
 
-	pthread_mutex_unlock(&pair_status.mutex);
-
 	meshlink_set_node_status_cb(a, NULL);
 	a->priv = NULL;
 }
@@ -98,18 +119,23 @@ void stop_meshlink_pair(meshlink_handle_t *a, meshlink_handle_t *b) {
 }
 
 void close_meshlink_pair(meshlink_handle_t *a, meshlink_handle_t *b, const char *prefix) {
+	int ret_val;
+	(void)ret_val;
 	meshlink_close(a);
 	meshlink_close(b);
 
 	if(prefix) {
 		char *a_name, *b_name;
 
-		asprintf(&a_name, "%s_conf.1", prefix);
+		ret_val = asprintf(&a_name, "%s_conf.1", prefix);
 		assert(a_name);
 		assert(meshlink_destroy(a_name));
 
-		asprintf(&b_name, "%s_conf.2", prefix);
+		ret_val = asprintf(&b_name, "%s_conf.2", prefix);
 		assert(b_name);
 		assert(meshlink_destroy(b_name));
+
+		free(a_name);
+		free(b_name);
 	}
 }