X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=src%2Ftincctl.c;h=33b26c2b9afac0c48bbe5ca8c77118b604cde0a5;hb=c6a94a721a780c4491e145a784f85e56b4fa9f23;hp=55e14e53657dcacb3b835a64c0907394445790a9;hpb=a38e0d621397d6d69c939ccc287d5a803b668195;p=meshlink

diff --git a/src/tincctl.c b/src/tincctl.c
index 55e14e53..33b26c2b 100644
--- a/src/tincctl.c
+++ b/src/tincctl.c
@@ -1,6 +1,6 @@
 /*
     tincctl.c -- Controlling a running tincd
-    Copyright (C) 2007-2013 Guus Sliepen <guus@tinc-vpn.org>
+    Copyright (C) 2014 Guus Sliepen <guus@meshlink.io>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -33,16 +33,13 @@
 #include "ecdsagen.h"
 #include "info.h"
 #include "invitation.h"
-#include "names.h"
 #include "rsagen.h"
 #include "utils.h"
 #include "tincctl.h"
 #include "top.h"
 
-#ifdef HAVE_MINGW
-#define SCRIPTEXTENSION ".bat"
-#else
-#define SCRIPTEXTENSION ""
+#ifndef MSG_NOSIGNAL
+#define MSG_NOSIGNAL 0
 #endif
 
 static char **orig_argv;
@@ -71,10 +68,9 @@ static bool force = false;
 bool tty = true;
 bool confbasegiven = false;
 bool netnamegiven = false;
-
-#ifdef HAVE_MINGW
-static struct WSAData wsa_state;
-#endif
+char *scriptinterpreter = NULL;
+char *scriptextension = "";
+static char *prompt;
 
 static struct option const long_options[] = {
 	{"config", required_argument, NULL, 'c'},
@@ -145,8 +141,9 @@ static void usage(bool status) {
 				"  exchange-all [--force]     Same as export-all followed by import\n"
 				"  invite NODE [...]          Generate an invitation for NODE\n"
 				"  join INVITATION            Join a VPN using an INVITIATION\n"
+				"  network [NETNAME]          List all known networks, or switch to the one named NETNAME.\n"
 				"\n");
-		printf("Report bugs to tinc@tinc-vpn.org.\n");
+		printf("Report bugs to bugs@meshlink.io.\n");
 	}
 }
 
@@ -316,8 +313,7 @@ static FILE *ask_and_open(const char *filename, const char *what, const char *mo
 	/* Check stdin and stdout */
 	if(ask && tty) {
 		/* Ask for a file and/or directory name. */
-		fprintf(stdout, "Please enter a file to save %s to [%s]: ", what, filename);
-		fflush(stdout);
+		fprintf(stderr, "Please enter a file to save %s to [%s]: ", what, filename);
 
 		if(fgets(buf, sizeof buf, stdin) == NULL) {
 			fprintf(stderr, "Error while reading stdin: %s\n", strerror(errno));
@@ -364,7 +360,7 @@ static FILE *ask_and_open(const char *filename, const char *what, const char *mo
 static bool ecdsa_keygen(bool ask) {
 	ecdsa_t *key;
 	FILE *f;
-	char *pubname, *privname;
+	char pubname[PATH_MAX], privname[PATH_MAX];
 
 	fprintf(stderr, "Generating ECDSA keypair:\n");
 
@@ -374,9 +370,8 @@ static bool ecdsa_keygen(bool ask) {
 	} else
 		fprintf(stderr, "Done.\n");
 
-	xasprintf(&privname, "%s" SLASH "ecdsa_key.priv", confbase);
+	snprintf(privname,PATH_MAX, "%s" SLASH "ecdsa_key.priv", confbase);
 	f = ask_and_open(privname, "private ECDSA key", "a", ask, 0600);
-	free(privname);
 
 	if(!f)
 		return false;
@@ -391,19 +386,17 @@ static bool ecdsa_keygen(bool ask) {
 	fclose(f);
 
 	if(name)
-		xasprintf(&pubname, "%s" SLASH "hosts" SLASH "%s", confbase, name);
+		snprintf(pubname, PATH_MAX,"%s" SLASH "hosts" SLASH "%s", confbase, name);
 	else
-		xasprintf(&pubname, "%s" SLASH "ecdsa_key.pub", confbase);
+		snprintf(pubname, PATH_MAX,"%s" SLASH "ecdsa_key.pub", confbase);
 
 	f = ask_and_open(pubname, "public ECDSA key", "a", ask, 0666);
-	free(pubname);
 
 	if(!f)
 		return false;
 
 	char *pubkey = ecdsa_get_base64_public_key(key);
 	fprintf(f, "ECDSAPublicKey = %s\n", pubkey);
-	free(pubkey);
 
 	fclose(f);
 	ecdsa_free(key);
@@ -418,7 +411,7 @@ static bool ecdsa_keygen(bool ask) {
 static bool rsa_keygen(int bits, bool ask) {
 	rsa_t *key;
 	FILE *f;
-	char *pubname, *privname;
+	char pubname[PATH_MAX], privname[PATH_MAX];
 
 	fprintf(stderr, "Generating %d bits keys:\n", bits);
 
@@ -428,9 +421,8 @@ static bool rsa_keygen(int bits, bool ask) {
 	} else
 		fprintf(stderr, "Done.\n");
 
-	xasprintf(&privname, "%s" SLASH "rsa_key.priv", confbase);
+	snprintf(privname,PATH_MAX, "%s" SLASH "rsa_key.priv", confbase);
 	f = ask_and_open(privname, "private RSA key", "a", ask, 0600);
-	free(privname);
 
 	if(!f)
 		return false;
@@ -445,12 +437,11 @@ static bool rsa_keygen(int bits, bool ask) {
 	fclose(f);
 
 	if(name)
-		xasprintf(&pubname, "%s" SLASH "hosts" SLASH "%s", confbase, name);
+		snprintf(pubname,PATH_MAX,"%s" SLASH "hosts" SLASH "%s", confbase, name);
 	else
-		xasprintf(&pubname, "%s" SLASH "rsa_key.pub", confbase);
+		snprintf(pubname,PATH_MAX,"%s" SLASH "rsa_key.pub", confbase);
 
 	f = ask_and_open(pubname, "public RSA key", "a", ask, 0666);
-	free(pubname);
 
 	if(!f)
 		return false;
@@ -536,7 +527,7 @@ bool sendline(int fd, char *format, ...) {
 	blen++;
 
 	while(blen) {
-		int result = send(fd, p, blen, 0);
+		int result = send(fd, p, blen, MSG_NOSIGNAL);
 		if(result == -1 && errno == EINTR)
 			continue;
 		else if(result <= 0)
@@ -686,14 +677,6 @@ bool connect_tincd(bool verbose) {
 
 	fclose(f);
 
-#ifdef HAVE_MINGW
-	if(WSAStartup(MAKEWORD(2, 2), &wsa_state)) {
-		if(verbose)
-			fprintf(stderr, "System call `%s' failed: %s", "WSAStartup", winerror(GetLastError()));
-		return false;
-	}
-#endif
-
 #ifndef HAVE_MINGW
 	struct sockaddr_un sa;
 	sa.sun_family = AF_UNIX;
@@ -756,6 +739,11 @@ bool connect_tincd(bool verbose) {
 	freeaddrinfo(res);
 #endif
 
+#ifdef SO_NOSIGPIPE
+	static const int one = 1;
+	setsockopt(c, SOL_SOCKET, SO_NOSIGPIPE, (void *)&one, sizeof one);
+#endif
+
 	char data[4096];
 	int version;
 
@@ -1308,6 +1296,7 @@ const var_t variables[] = {
 	{"IffOneQueue", VAR_SERVER},
 	{"Interface", VAR_SERVER},
 	{"KeyExpire", VAR_SERVER},
+	{"ListenAddress", VAR_SERVER | VAR_MULTIPLE},
 	{"LocalDiscovery", VAR_SERVER},
 	{"MACExpire", VAR_SERVER},
 	{"MaxConnectionBurst", VAR_SERVER},
@@ -1327,8 +1316,6 @@ const var_t variables[] = {
 	{"ScriptsInterpreter", VAR_SERVER},
 	{"StrictSubnets", VAR_SERVER},
 	{"TunnelServer", VAR_SERVER},
-	{"UDPRcvBuf", VAR_SERVER},
-	{"UDPSndBuf", VAR_SERVER},
 	{"VDEGroup", VAR_SERVER},
 	{"VDEPort", VAR_SERVER},
 	/* Host configuration */
@@ -1488,9 +1475,9 @@ static int cmd_config(int argc, char *argv[]) {
 	}
 
 	// Open the right configuration file.
-	char *filename;
+	char filename[PATH_MAX];
 	if(node)
-		xasprintf(&filename, "%s" SLASH "%s", hosts_dir, node);
+		snprintf(filename,PATH_MAX "%s" SLASH "%s", hosts_dir, node);
 	else
 		filename = tinc_conf;
 
@@ -1500,11 +1487,11 @@ static int cmd_config(int argc, char *argv[]) {
 		return 1;
 	}
 
-	char *tmpfile = NULL;
+	char tmpfile[PATH_MAX];
 	FILE *tf = NULL;
 
 	if(action >= -1) {
-		xasprintf(&tmpfile, "%s.config.tmp", filename);
+		snprintf(tmpfile,PATH_MAX, "%s.config.tmp", filename);
 		tf = fopen(tmpfile, "w");
 		if(!tf) {
 			fprintf(stderr, "Could not open temporary file %s: %s\n", tmpfile, strerror(errno));
@@ -1622,7 +1609,7 @@ static int cmd_config(int argc, char *argv[]) {
 	if(action < 0 && !removed) {
 		remove(tmpfile);
 		fprintf(stderr, "No configuration variables deleted.\n");
-		return *value;
+		return *value != 0;
 	}
 
 	// Replace the configuration file with the new one
@@ -1694,10 +1681,9 @@ int check_port(char *name) {
 	for(int i = 0; i < 100; i++) {
 		int port = 0x1000 + (rand() & 0x7fff);
 		if(try_bind(port)) {
-			char *filename;
-			xasprintf(&filename, "%s" SLASH "hosts" SLASH "%s", confbase, name);
+			char filename[PATH_MAX];
+			snprintf(filename,PATH_MAX "%s" SLASH "hosts" SLASH "%s", confbase, name);
 			FILE *f = fopen(filename, "a");
-			free(filename);
 			if(!f) {
 				fprintf(stderr, "Please change tinc's Port manually.\n");
 				return 0;
@@ -1726,8 +1712,7 @@ static int cmd_init(int argc, char *argv[]) {
 	} else if(argc < 2) {
 		if(tty) {
 			char buf[1024];
-			fprintf(stdout, "Enter the Name you want your tinc node to have: ");
-			fflush(stdout);
+			fprintf(stderr, "Enter the Name you want your tinc node to have: ");
 			if(!fgets(buf, sizeof buf, stdin)) {
 				fprintf(stderr, "Error while reading stdin: %s\n", strerror(errno));
 				return 1;
@@ -1755,7 +1740,7 @@ static int cmd_init(int argc, char *argv[]) {
 		return 1;
 	}
 
-	if(strcmp(confdir, confbase) && mkdir(confdir, 0755) && errno != EEXIST) {
+	if(!confbase_given && mkdir(confdir, 0755) && errno != EEXIST) {
 		fprintf(stderr, "Could not create directory %s: %s\n", confdir, strerror(errno));
 		return 1;
 	}
@@ -1793,7 +1778,7 @@ static int cmd_init(int argc, char *argv[]) {
 			fprintf(stderr, "Could not create file %s: %s\n", filename, strerror(errno));
 			return 1;
 		}
-		fprintf(f, "#!/bin/sh\n\necho 'Unconfigured tinc-up script, please edit!'\n\n#ifconfig $INTERFACE <your vpn IP address> netmask <netmask of whole VPN>\n");
+		fprintf(f, "#!/bin/sh\n\necho 'Unconfigured tinc-up script, please edit '$0'!'\n\n#ifconfig $INTERFACE <your vpn IP address> netmask <netmask of whole VPN>\n");
 		fclose(f);
 	}
 #endif
@@ -2083,6 +2068,69 @@ static int cmd_exchange_all(int argc, char *argv[]) {
 	return cmd_export_all(argc, argv) ?: cmd_import(argc, argv);
 }
 
+static int switch_network(char *name) {
+	if(fd >= 0) {
+		close(fd);
+		fd = -1;
+	}
+
+	free(confbase);
+	confbase = NULL;
+	free(pidfilename);
+	pidfilename = NULL;
+	free(logfilename);
+	logfilename = NULL;
+	free(unixsocketname);
+	unixsocketname = NULL;
+	free(tinc_conf);
+	free(hosts_dir);
+	free(prompt);
+
+	free(netname);
+	netname = strcmp(name, ".") ? xstrdup(name) : NULL;
+
+        xasprintf(&tinc_conf, "%s" SLASH "tinc.conf", confbase);
+        xasprintf(&hosts_dir, "%s" SLASH "hosts", confbase);
+	xasprintf(&prompt, "%s> ", identname);
+
+	return 0;
+}
+
+static int cmd_network(int argc, char *argv[]) {
+	if(argc > 2) {
+		fprintf(stderr, "Too many arguments!\n");
+		return 1;
+	}
+
+	if(argc == 2)
+		return switch_network(argv[1]);
+
+	DIR *dir = opendir(confdir);
+	if(!dir) {
+		fprintf(stderr, "Could not read directory %s: %s\n", confdir, strerror(errno));
+                return 1;
+        }
+
+	struct dirent *ent;
+	while((ent = readdir(dir))) {
+		if(*ent->d_name == '.')
+			continue;
+
+		if(!strcmp(ent->d_name, "tinc.conf")) {
+			printf(".\n");
+			continue;
+		}
+
+		char *fname;
+		xasprintf(&fname, "%s/%s/tinc.conf", confdir, ent->d_name);
+		if(!access(fname, R_OK))
+			printf("%s\n", ent->d_name);
+		free(fname);
+	}
+
+	return 0;
+}
+
 static const struct {
 	const char *command;
 	int (*function)(int argc, char *argv[]);
@@ -2122,6 +2170,7 @@ static const struct {
 	{"exchange-all", cmd_exchange_all},
 	{"invite", cmd_invite},
 	{"join", cmd_join},
+	{"network", cmd_network},
 	{NULL, NULL},
 };
 
@@ -2248,7 +2297,6 @@ static char **completion (const char *text, int start, int end) {
 #endif
 
 static int cmd_shell(int argc, char *argv[]) {
-	char *prompt;
 	xasprintf(&prompt, "%s> ", identname);
 	int result = 0;
 	char buf[4096];
@@ -2356,7 +2404,6 @@ int main(int argc, char *argv[]) {
 	if(!parse_options(argc, argv))
 		return 1;
 
-	make_names();
 	xasprintf(&tinc_conf, "%s" SLASH "tinc.conf", confbase);
 	xasprintf(&hosts_dir, "%s" SLASH "hosts", confbase);
 
@@ -2370,6 +2417,15 @@ int main(int argc, char *argv[]) {
 		return 0;
 	}
 
+#ifdef HAVE_MINGW
+	static struct WSAData wsa_state;
+
+	if(WSAStartup(MAKEWORD(2, 2), &wsa_state)) {
+		fprintf(stderr, "System call `%s' failed: %s", "WSAStartup", winerror(GetLastError()));
+		return false;
+	}
+#endif
+
 	srand(time(NULL));
 	crypto_init();