X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=src%2Fprotocol_edge.c;h=6788109847371e0afb7e6dd7ff754cf11661a0cb;hb=f712fdc0b3de22566cdf06954256c62f46f25542;hp=89ed901d1979b0e04e5a865dc18deb78a2e2700f;hpb=e4e5a81447142da0fb1291b2d2119ed6981b89e5;p=meshlink

diff --git a/src/protocol_edge.c b/src/protocol_edge.c
index 89ed901d..67881098 100644
--- a/src/protocol_edge.c
+++ b/src/protocol_edge.c
@@ -35,15 +35,15 @@
 
 extern bool node_write_devclass(meshlink_handle_t *mesh, node_t *n);
 
-bool send_add_edge(meshlink_handle_t *mesh, connection_t *c, const edge_t *e) {
+bool send_add_edge(meshlink_handle_t *mesh, connection_t *c, const edge_t *e, int contradictions) {
 	bool x;
 	char *address, *port;
 
 	sockaddr2str(&e->address, &address, &port);
 
-	x = send_request(mesh, c, "%d %x %s %d %s %s %s %d %x %d", ADD_EDGE, rand(),
-					 e->from->name, e->from->devclass, e->to->name, address, port, e->to->devclass,
-					 e->options, e->weight);
+	x = send_request(mesh, c, "%d %x %s %d %s %s %s %d %x %d %d", ADD_EDGE, rand(),
+	                 e->from->name, e->from->devclass, e->to->name, address, port, e->to->devclass,
+	                 e->options, e->weight, contradictions);
 	free(address);
 	free(port);
 
@@ -62,38 +62,36 @@ bool add_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
 	sockaddr_t address;
 	uint32_t options;
 	int weight;
+	int contradictions = 0;
 
-	if(sscanf(request, "%*d %*x "MAX_STRING" %d "MAX_STRING" "MAX_STRING" "MAX_STRING" %d %x %d",
-			  from_name, &from_devclass, to_name, to_address, to_port, &to_devclass, &options, &weight) != 8) {
-		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s (%s)", "ADD_EDGE", c->name,
-			   c->hostname);
+	if(sscanf(request, "%*d %*x "MAX_STRING" %d "MAX_STRING" "MAX_STRING" "MAX_STRING" %d %x %d %d",
+	                from_name, &from_devclass, to_name, to_address, to_port, &to_devclass, &options, &weight, &contradictions) < 8) {
+		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s", "ADD_EDGE", c->name);
 		return false;
 	}
 
 	/* Check if names are valid */
 
 	if(!check_id(from_name) || !check_id(to_name)) {
-		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s (%s): %s", "ADD_EDGE", c->name,
-			   c->hostname, "invalid name");
+		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s: %s", "ADD_EDGE", c->name, "invalid name");
 		return false;
 	}
 
 	// Check if devclasses are valid
 
 	if(from_devclass < 0 || from_devclass > _DEV_CLASS_MAX) {
-		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s (%s): %s", "ADD_EDGE", c->name,
-			   c->hostname, "from devclass invalid");
+		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s: %s", "ADD_EDGE", c->name, "from devclass invalid");
 		return false;
 	}
 
 	if(to_devclass < 0 || to_devclass > _DEV_CLASS_MAX) {
-		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s (%s): %s", "ADD_EDGE", c->name,
-			   c->hostname, "to devclass invalid");
+		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s: %s", "ADD_EDGE", c->name, "to devclass invalid");
 		return false;
 	}
 
-	if(seen_request(mesh, request))
+	if(seen_request(mesh, request)) {
 		return true;
+	}
 
 	/* Lookup nodes */
 
@@ -102,15 +100,21 @@ bool add_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
 
 	if(!from) {
 		from = new_node();
+		from->status.blacklisted = mesh->default_blacklist;
 		from->name = xstrdup(from_name);
 		node_add(mesh, from);
 	}
 
+	if(contradictions > 50) {
+		handle_duplicate_node(mesh, from);
+	}
+
 	from->devclass = from_devclass;
 	node_write_devclass(mesh, from);
 
 	if(!to) {
 		to = new_node();
+		to->status.blacklisted = mesh->default_blacklist;
 		to->name = xstrdup(to_name);
 		node_add(mesh, to);
 	}
@@ -129,26 +133,27 @@ bool add_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
 	if(e) {
 		if(e->weight != weight || e->options != options || sockaddrcmp(&e->address, &address)) {
 			if(from == mesh->self) {
-				logger(mesh, MESHLINK_WARNING, "Got %s from %s (%s) for ourself which does not match existing entry",
-						   "ADD_EDGE", c->name, c->hostname);
-				send_add_edge(mesh, c, e);
+				logger(mesh, MESHLINK_WARNING, "Got %s from %s for ourself which does not match existing entry",
+				       "ADD_EDGE", c->name);
+				send_add_edge(mesh, c, e, 0);
 				return true;
 			} else {
-				logger(mesh, MESHLINK_WARNING, "Got %s from %s (%s) which does not match existing entry",
-						   "ADD_EDGE", c->name, c->hostname);
+				logger(mesh, MESHLINK_WARNING, "Got %s from %s which does not match existing entry",
+				       "ADD_EDGE", c->name);
 				edge_del(mesh, e);
 				graph(mesh);
 			}
-		} else
+		} else {
 			return true;
+		}
 	} else if(from == mesh->self) {
-		logger(mesh, MESHLINK_WARNING, "Got %s from %s (%s) for ourself which does not exist",
-				   "ADD_EDGE", c->name, c->hostname);
+		logger(mesh, MESHLINK_WARNING, "Got %s from %s for ourself which does not exist",
+		       "ADD_EDGE", c->name);
 		mesh->contradicting_add_edge++;
 		e = new_edge();
 		e->from = from;
 		e->to = to;
-		send_del_edge(mesh, c, e);
+		send_del_edge(mesh, c, e, mesh->contradicting_add_edge);
 		free_edge(e);
 		return true;
 	}
@@ -172,9 +177,9 @@ bool add_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
 	return true;
 }
 
-bool send_del_edge(meshlink_handle_t *mesh, connection_t *c, const edge_t *e) {
-	return send_request(mesh, c, "%d %x %s %s", DEL_EDGE, rand(),
-						e->from->name, e->to->name);
+bool send_del_edge(meshlink_handle_t *mesh, connection_t *c, const edge_t *e, int contradictions) {
+	return send_request(mesh, c, "%d %x %s %s %d", DEL_EDGE, rand(),
+	                    e->from->name, e->to->name, contradictions);
 }
 
 bool del_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
@@ -182,23 +187,23 @@ bool del_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
 	char from_name[MAX_STRING_SIZE];
 	char to_name[MAX_STRING_SIZE];
 	node_t *from, *to;
+	int contradictions = 0;
 
-	if(sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING, from_name, to_name) != 2) {
-		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s (%s)", "DEL_EDGE", c->name,
-			   c->hostname);
+	if(sscanf(request, "%*d %*x "MAX_STRING" "MAX_STRING" %d", from_name, to_name, &contradictions) < 2) {
+		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s", "DEL_EDGE", c->name);
 		return false;
 	}
 
 	/* Check if names are valid */
 
 	if(!check_id(from_name) || !check_id(to_name)) {
-		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s (%s): %s", "DEL_EDGE", c->name,
-			   c->hostname, "invalid name");
+		logger(mesh, MESHLINK_ERROR, "Got bad %s from %s: %s", "DEL_EDGE", c->name, "invalid name");
 		return false;
 	}
 
-	if(seen_request(mesh, request))
+	if(seen_request(mesh, request)) {
 		return true;
+	}
 
 	/* Lookup nodes */
 
@@ -206,32 +211,36 @@ bool del_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
 	to = lookup_node(mesh, to_name);
 
 	if(!from) {
-		logger(mesh, MESHLINK_ERROR, "Got %s from %s (%s) which does not appear in the edge tree",
-				   "DEL_EDGE", c->name, c->hostname);
+		logger(mesh, MESHLINK_ERROR, "Got %s from %s which does not appear in the edge tree",
+		       "DEL_EDGE", c->name);
 		return true;
 	}
 
 	if(!to) {
-		logger(mesh, MESHLINK_ERROR, "Got %s from %s (%s) which does not appear in the edge tree",
-				   "DEL_EDGE", c->name, c->hostname);
+		logger(mesh, MESHLINK_ERROR, "Got %s from %s which does not appear in the edge tree",
+		       "DEL_EDGE", c->name);
 		return true;
 	}
 
+	if(contradictions > 50) {
+		handle_duplicate_node(mesh, from);
+	}
+
 	/* Check if edge exists */
 
 	e = lookup_edge(from, to);
 
 	if(!e) {
-		logger(mesh, MESHLINK_WARNING, "Got %s from %s (%s) which does not appear in the edge tree",
-				   "DEL_EDGE", c->name, c->hostname);
+		logger(mesh, MESHLINK_WARNING, "Got %s from %s which does not appear in the edge tree",
+		       "DEL_EDGE", c->name);
 		return true;
 	}
 
 	if(e->from == mesh->self) {
-		logger(mesh, MESHLINK_WARNING, "Got %s from %s (%s) for ourself",
-				   "DEL_EDGE", c->name, c->hostname);
+		logger(mesh, MESHLINK_WARNING, "Got %s from %s for ourself",
+		       "DEL_EDGE", c->name);
 		mesh->contradicting_del_edge++;
-		send_add_edge(mesh, c, e);    /* Send back a correction */
+		send_add_edge(mesh, c, e, mesh->contradicting_del_edge);    /* Send back a correction */
 		return true;
 	}
 
@@ -251,8 +260,9 @@ bool del_edge_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {
 
 	if(!to->status.reachable) {
 		e = lookup_edge(to, mesh->self);
+
 		if(e) {
-			send_del_edge(mesh, mesh->everyone, e);
+			send_del_edge(mesh, mesh->everyone, e, 0);
 			edge_del(mesh, e);
 		}
 	}