X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=src%2Fnode.c;h=e6b9f018f46657519b7cceab1939b139ad6f010b;hb=b70895cf367100792263f04d97a7533b26c5ece3;hp=0a7b4a5254921d9b3e263b3d62c21ff3fc2149d7;hpb=391a8674fcd886165dc02154d3ef0d3377f2c840;p=meshlink diff --git a/src/node.c b/src/node.c index 0a7b4a52..e6b9f018 100644 --- a/src/node.c +++ b/src/node.c @@ -29,8 +29,6 @@ #include "utils.h" #include "xalloc.h" -static hash_t *node_udp_cache; - static int node_compare(const node_t *a, const node_t *b) { return strcmp(a->name, b->name); } @@ -38,14 +36,18 @@ static int node_compare(const node_t *a, const node_t *b) { void init_nodes(meshlink_handle_t *mesh) { pthread_mutex_lock(&(mesh->nodes_mutex)); mesh->nodes = splay_alloc_tree((splay_compare_t) node_compare, (splay_action_t) free_node); - node_udp_cache = hash_alloc(0x100, sizeof(sockaddr_t)); + mesh->node_udp_cache = hash_alloc(0x100, sizeof(sockaddr_t)); pthread_mutex_unlock(&(mesh->nodes_mutex)); } void exit_nodes(meshlink_handle_t *mesh) { pthread_mutex_lock(&(mesh->nodes_mutex)); - hash_free(node_udp_cache); - splay_delete_tree(mesh->nodes); + if(mesh->node_udp_cache) + hash_free(mesh->node_udp_cache); + if(mesh->nodes) + splay_delete_tree(mesh->nodes); + mesh->node_udp_cache = NULL; + mesh->nodes = NULL; pthread_mutex_unlock(&(mesh->nodes_mutex)); } @@ -102,11 +104,9 @@ void node_del(meshlink_handle_t *mesh, node_t *n) { pthread_mutex_unlock(&(mesh->nodes_mutex)); } -node_t *lookup_node(meshlink_handle_t *mesh, char *name) { - node_t n = {NULL}; - node_t* result; - - n.name = name; +node_t *lookup_node(meshlink_handle_t *mesh, const char *name) { + const node_t n = {.name = (char *)name}; + node_t *result; pthread_mutex_lock(&(mesh->nodes_mutex)); result = splay_search(mesh->nodes, &n); @@ -116,16 +116,16 @@ node_t *lookup_node(meshlink_handle_t *mesh, char *name) { } node_t *lookup_node_udp(meshlink_handle_t *mesh, const sockaddr_t *sa) { - return hash_search(node_udp_cache, sa); + return hash_search(mesh->node_udp_cache, sa); } void update_node_udp(meshlink_handle_t *mesh, node_t *n, const sockaddr_t *sa) { if(n == mesh->self) { - logger(DEBUG_ALWAYS, LOG_WARNING, "Trying to update UDP address of mesh->self!"); + logger(mesh, MESHLINK_WARNING, "Trying to update UDP address of mesh->self!"); return; } - hash_insert(node_udp_cache, &n->address, NULL); + hash_insert(mesh->node_udp_cache, &n->address, NULL); if(sa) { n->address = *sa; @@ -136,9 +136,9 @@ void update_node_udp(meshlink_handle_t *mesh, node_t *n, const sockaddr_t *sa) { break; } } - hash_insert(node_udp_cache, sa, n); + hash_insert(mesh->node_udp_cache, sa, n); free(n->hostname); n->hostname = sockaddr2hostname(&n->address); - logger(DEBUG_PROTOCOL, LOG_DEBUG, "UDP address of %s set to %s", n->name, n->hostname); + logger(mesh, MESHLINK_DEBUG, "UDP address of %s set to %s", n->name, n->hostname); } }