X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=src%2Fnet_packet.c;h=3ee0eaec4a4be44f6d5ec57ed69ddeb5242d4656;hb=4b6c01b1d5383b1a7417244a31ad4652aab2d5db;hp=953887a53d3eed52c741c76712fb7ccffb42f263;hpb=fe5563f92021618b4a8b41e412c73d8364fcaf6e;p=meshlink diff --git a/src/net_packet.c b/src/net_packet.c index 953887a5..3ee0eaec 100644 --- a/src/net_packet.c +++ b/src/net_packet.c @@ -148,13 +148,13 @@ static void send_mtu_probe_handler(event_loop_t *loop, void *data) { n->status.broadcast = false; end: - timeout_set(&mesh->loop, &n->mtutimeout, &(struct timeval) { + timeout_set(&mesh->loop, &n->mtutimeout, &(struct timespec) { timeout, prng(mesh, TIMER_FUDGE) }); } void send_mtu_probe(meshlink_handle_t *mesh, node_t *n) { - timeout_add(&mesh->loop, &n->mtutimeout, send_mtu_probe_handler, n, &(struct timeval) { + timeout_add(&mesh->loop, &n->mtutimeout, send_mtu_probe_handler, n, &(struct timespec) { 1, 0 }); send_mtu_probe_handler(&mesh->loop, n); @@ -308,17 +308,26 @@ static void choose_udp_address(meshlink_handle_t *mesh, const node_t *n, const s return; } + /* If we have learned an address via Catta, try this once every batch */ + if(mesh->udp_choice == 1 && n->catta_address.sa.sa_family != AF_UNSPEC) { + *sa = &n->catta_address; + goto check_socket; + } + /* Otherwise, address are found in edges to this node. So we pick a random edge and a random socket. */ - int i = 0; - int j = prng(mesh, n->edge_tree->count); edge_t *candidate = NULL; - for splay_each(edge_t, e, n->edge_tree) { - if(i++ == j) { - candidate = e->reverse; - break; + { + int i = 0; + int j = prng(mesh, n->edge_tree->count); + + for splay_each(edge_t, e, n->edge_tree) { + if(i++ == j) { + candidate = e->reverse; + break; + } } } @@ -327,6 +336,8 @@ static void choose_udp_address(meshlink_handle_t *mesh, const node_t *n, const s *sock = prng(mesh, mesh->listen_sockets); } +check_socket: + /* Make sure we have a suitable socket for the chosen address */ if(mesh->listen_socket[*sock].sa.sa.sa_family != (*sa)->sa.sa_family) { for(int i = 0; i < mesh->listen_sockets; i++) { @@ -370,7 +381,7 @@ bool send_sptps_data(void *handle, uint8_t type, const void *data, size_t len) { /* Send it via TCP if it is a handshake packet, TCPOnly is in use, or this packet is larger than the MTU. */ - if(type >= SPTPS_HANDSHAKE || (type != PKT_PROBE && len > to->minmtu)) { + if(type >= SPTPS_HANDSHAKE || (type != PKT_PROBE && (len - 21) > to->minmtu)) { char buf[len * 4 / 3 + 5]; b64encode(data, buf, len); @@ -433,8 +444,8 @@ bool receive_sptps_record(void *handle, uint8_t type, const void *data, uint16_t return true; } - if(len > MTU) { - logger(mesh, MESHLINK_ERROR, "Packet from %s larger than maximum supported size (%d > %d)", from->name, len, MTU); + if(len > MAXSIZE) { + logger(mesh, MESHLINK_ERROR, "Packet from %s larger than maximum supported size (%d > %d)", from->name, len, MAXSIZE); return false; } @@ -559,7 +570,7 @@ void handle_incoming_vpn_data(event_loop_t *loop, void *data, int flags) { if(n) { update_node_udp(mesh, n, &from); - } else if(mesh->log_level >= MESHLINK_WARNING) { + } else if(mesh->log_level <= MESHLINK_WARNING) { hostname = sockaddr2hostname(&from); logger(mesh, MESHLINK_WARNING, "Received UDP packet from unknown source %s", hostname); free(hostname);