X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=src%2Fmeshlink.c;h=fce1f736ea22e0dd6ba1438ab13d24f8d622d710;hb=0bdce44687a22c8825695cba185b845f5ea5e060;hp=418be9e878d636b59844356d10b6a28e05bea162;hpb=82e6ef764b4f1d2c2b6c1be35452cb87aff11350;p=meshlink diff --git a/src/meshlink.c b/src/meshlink.c index 418be9e8..fce1f736 100644 --- a/src/meshlink.c +++ b/src/meshlink.c @@ -126,7 +126,7 @@ static bool fcopy(FILE *out, const char *filename) { char buf[1024]; size_t len; - while((len = fread(buf, 1, sizeof buf, in))) + while((len = fread(buf, 1, sizeof(buf), in))) fwrite(buf, len, 1, out); fclose(in); return true; @@ -148,7 +148,7 @@ static void scan_for_hostname(const char *filename, char **hostname, char **port if(!f) return; - while(fgets(line, sizeof line, f)) { + while(fgets(line, sizeof(line), f)) { if(!rstrip(line)) continue; char *p = line, *q; @@ -165,9 +165,9 @@ static void scan_for_hostname(const char *filename, char **hostname, char **port p += strspn(p, "\t "); p[strcspn(p, "\t ")] = 0; - if(!*port && !strcasecmp(line, "Port")) { + if(!*port && !strcasecmp(line, "Port")) *port = xstrdup(q); - } else if(!*hostname && !strcasecmp(line, "Address")) { + else if(!*hostname && !strcasecmp(line, "Address")) { *hostname = xstrdup(q); if(*p) { free(*port); @@ -191,6 +191,18 @@ static bool is_valid_hostname(const char *hostname) { return true; } +static void set_timeout(int sock, int timeout) { +#ifdef _WIN32 + DWORD tv = timeout; +#else + struct timeval tv; + tv.tv_sec = timeout / 1000; + tv.tv_usec = (timeout - tv.tv_sec * 1000) * 1000; +#endif + setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO, &tv, sizeof(tv)); + setsockopt(sock, SOL_SOCKET, SO_SNDTIMEO, &tv, sizeof(tv)); +} + char *meshlink_get_external_address(meshlink_handle_t *mesh) { char *hostname = NULL; @@ -203,14 +215,15 @@ char *meshlink_get_external_address(meshlink_handle_t *mesh) { while(aip) { int s = socket(aip->ai_family, aip->ai_socktype, aip->ai_protocol); if(s >= 0) { + set_timeout(s, 5000); if(connect(s, aip->ai_addr, aip->ai_addrlen)) { closesocket(s); s = -1; } } if(s >= 0) { - send(s, request, sizeof request - 1, 0); - int len = recv(s, line, sizeof line - 1, MSG_WAITALL); + send(s, request, sizeof(request) - 1, 0); + int len = recv(s, line, sizeof(line) - 1, MSG_WAITALL); if(len > 0) { line[len] = 0; if(line[len - 1] == '\n') @@ -242,7 +255,7 @@ char *meshlink_get_external_address(meshlink_handle_t *mesh) { return hostname; } -static char *get_my_hostname(meshlink_handle_t* mesh) { +static char *get_my_hostname(meshlink_handle_t *mesh) { char *hostname = NULL; char *port = NULL; char *hostport = NULL; @@ -251,7 +264,7 @@ static char *get_my_hostname(meshlink_handle_t* mesh) { FILE *f; // Use first Address statement in own host config file - snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); scan_for_hostname(filename, &hostname, &port); if(hostname) @@ -265,9 +278,8 @@ static char *get_my_hostname(meshlink_handle_t* mesh) { if(f) { fprintf(f, "\nAddress = %s\n", hostname); fclose(f); - } else { + } else logger(mesh, MESHLINK_DEBUG, "Could not append Address to %s: %s\n", filename, strerror(errno)); - } done: if(port) { @@ -291,7 +303,7 @@ static char *get_line(const char **data) { if(!data || !*data) return NULL; - if(!**data) { + if(! **data) { *data = NULL; return NULL; } @@ -299,7 +311,7 @@ static char *get_line(const char **data) { static char line[1024]; const char *end = strchr(*data, '\n'); size_t len = end ? end - *data : strlen(*data); - if(len >= sizeof line) { + if(len >= sizeof(line)) { logger(NULL, MESHLINK_ERROR, "Maximum line length exceeded!\n"); return NULL; } @@ -342,7 +354,7 @@ static bool try_bind(int port) { }; char portstr[16]; - snprintf(portstr, sizeof portstr, "%d", port); + snprintf(portstr, sizeof(portstr), "%d", port); if(getaddrinfo(NULL, portstr, &hint, &ai) || !ai) return false; @@ -371,7 +383,7 @@ static int check_port(meshlink_handle_t *mesh) { int port = 0x1000 + (rand() & 0x7fff); if(try_bind(port)) { char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, mesh->name); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, mesh->name); FILE *f = fopen(filename, "a"); if(!f) { logger(mesh, MESHLINK_DEBUG, "Please change MeshLink's Port manually.\n"); @@ -401,7 +413,7 @@ static bool finalize_join(meshlink_handle_t *mesh) { } char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "meshlink.conf", mesh->confbase); + snprintf(filename, sizeof(filename), "%s" SLASH "meshlink.conf", mesh->confbase); FILE *f = fopen(filename, "w"); if(!f) { @@ -411,7 +423,7 @@ static bool finalize_join(meshlink_handle_t *mesh) { fprintf(f, "Name = %s\n", name); - snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); FILE *fh = fopen(filename, "w"); if(!fh) { logger(mesh, MESHLINK_DEBUG, "Could not create file %s: %s\n", filename, strerror(errno)); @@ -484,7 +496,7 @@ static bool finalize_join(meshlink_handle_t *mesh) { return false; } - snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, value); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, value); f = fopen(filename, "w"); if(!f) { @@ -518,7 +530,7 @@ static bool finalize_join(meshlink_handle_t *mesh) { if(!b64key) { fclose(fh); return false; - } + } fprintf(fh, "ECDSAPublicKey = %s\n", b64key); fprintf(fh, "Port = %s\n", mesh->myport); @@ -541,7 +553,7 @@ static bool finalize_join(meshlink_handle_t *mesh) { } static bool invitation_send(void *handle, uint8_t type, const void *data, size_t len) { - meshlink_handle_t* mesh = handle; + meshlink_handle_t *mesh = handle; while(len) { int result = send(mesh->sock, data, len, 0); if(result == -1 && errno == EINTR) @@ -555,43 +567,43 @@ static bool invitation_send(void *handle, uint8_t type, const void *data, size_t } static bool invitation_receive(void *handle, uint8_t type, const void *msg, uint16_t len) { - meshlink_handle_t* mesh = handle; + meshlink_handle_t *mesh = handle; switch(type) { - case SPTPS_HANDSHAKE: - return sptps_send_record(&(mesh->sptps), 0, mesh->cookie, sizeof mesh->cookie); - - case 0: - mesh->data = xrealloc(mesh->data, mesh->thedatalen + len + 1); - memcpy(mesh->data + mesh->thedatalen, msg, len); - mesh->thedatalen += len; - mesh->data[mesh->thedatalen] = 0; - break; + case SPTPS_HANDSHAKE: + return sptps_send_record(&(mesh->sptps), 0, mesh->cookie, sizeof(mesh)->cookie); - case 1: - mesh->thedatalen = 0; - return finalize_join(mesh); + case 0: + mesh->data = xrealloc(mesh->data, mesh->thedatalen + len + 1); + memcpy(mesh->data + mesh->thedatalen, msg, len); + mesh->thedatalen += len; + mesh->data[mesh->thedatalen] = 0; + break; - case 2: - logger(mesh, MESHLINK_DEBUG, "Invitation succesfully accepted.\n"); - shutdown(mesh->sock, SHUT_RDWR); - mesh->success = true; - break; + case 1: + mesh->thedatalen = 0; + return finalize_join(mesh); - default: - return false; + case 2: + logger(mesh, MESHLINK_DEBUG, "Invitation succesfully accepted.\n"); + shutdown(mesh->sock, SHUT_RDWR); + mesh->success = true; + break; + + default: + return false; } return true; } -static bool recvline(meshlink_handle_t* mesh, size_t len) { +static bool recvline(meshlink_handle_t *mesh, size_t len) { char *newline = NULL; if(!mesh->sock) abort(); while(!(newline = memchr(mesh->buffer, '\n', mesh->blen))) { - int result = recv(mesh->sock, mesh->buffer + mesh->blen, sizeof mesh->buffer - mesh->blen, 0); + int result = recv(mesh->sock, mesh->buffer + mesh->blen, sizeof(mesh)->buffer - mesh->blen, 0); if(result == -1 && errno == EINTR) continue; else if(result <= 0) @@ -618,10 +630,10 @@ static bool sendline(int fd, char *format, ...) { va_list ap; va_start(ap, format); - blen = vsnprintf(buffer, sizeof buffer, format, ap); + blen = vsnprintf(buffer, sizeof(buffer), format, ap); va_end(ap); - if(blen < 1 || blen >= sizeof buffer) + if(blen < 1 || blen >= sizeof(buffer)) return false; buffer[blen] = '\n'; @@ -654,7 +666,7 @@ static const char *errstr[] = { }; const char *meshlink_strerror(meshlink_errno_t err) { - if(err < 0 || err >= sizeof errstr / sizeof *errstr) + if(err < 0 || err >= sizeof(errstr) / sizeof(*errstr)) return "Invalid error code"; return errstr[err]; } @@ -673,7 +685,7 @@ static bool ecdsa_keygen(meshlink_handle_t *mesh) { } else logger(mesh, MESHLINK_DEBUG, "Done.\n"); - snprintf(privname, sizeof privname, "%s" SLASH "ecdsa_key.priv", mesh->confbase); + snprintf(privname, sizeof(privname), "%s" SLASH "ecdsa_key.priv", mesh->confbase); f = fopen(privname, "wb"); if(!f) { @@ -695,7 +707,7 @@ static bool ecdsa_keygen(meshlink_handle_t *mesh) { fclose(f); - snprintf(pubname, sizeof pubname, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, mesh->name); + snprintf(pubname, sizeof(pubname), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, mesh->name); f = fopen(pubname, "a"); if(!f) { @@ -754,7 +766,7 @@ static bool getlocaladdrname(char *destaddr, char *host, socklen_t hostlen) { freeaddrinfo(rai); struct sockaddr_storage sn; - socklen_t sl = sizeof sn; + socklen_t sl = sizeof(sn); if(getsockname(sock, (struct sockaddr *)&sn, &sl)) return false; @@ -772,15 +784,15 @@ static void add_local_addresses(meshlink_handle_t *mesh) { // IPv4 example.org - if(getlocaladdrname("93.184.216.34", host, sizeof host)) { - snprintf(entry, sizeof entry, "%s %s", host, mesh->myport); + if(getlocaladdrname("93.184.216.34", host, sizeof(host))) { + snprintf(entry, sizeof(entry), "%s %s", host, mesh->myport); append_config_file(mesh, mesh->name, "Address", entry); } // IPv6 example.org - if(getlocaladdrname("2606:2800:220:1:248:1893:25c8:1946", host, sizeof host)) { - snprintf(entry, sizeof entry, "%s %s", host, mesh->myport); + if(getlocaladdrname("2606:2800:220:1:248:1893:25c8:1946", host, sizeof(host))) { + snprintf(entry, sizeof(entry), "%s %s", host, mesh->myport); append_config_file(mesh, mesh->name, "Address", entry); } } @@ -793,7 +805,7 @@ static bool meshlink_setup(meshlink_handle_t *mesh) { } char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "hosts", mesh->confbase); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts", mesh->confbase); if(mkdir(filename, 0777) && errno != EEXIST) { logger(mesh, MESHLINK_DEBUG, "Could not create directory %s: %s\n", filename, strerror(errno)); @@ -801,7 +813,7 @@ static bool meshlink_setup(meshlink_handle_t *mesh) { return false; } - snprintf(filename, sizeof filename, "%s" SLASH "meshlink.conf", mesh->confbase); + snprintf(filename, sizeof(filename), "%s" SLASH "meshlink.conf", mesh->confbase); if(!access(filename, F_OK)) { logger(mesh, MESHLINK_DEBUG, "Configuration file %s already exists!\n", filename); @@ -829,10 +841,10 @@ static bool meshlink_setup(meshlink_handle_t *mesh) { return true; } -meshlink_handle_t *meshlink_open(const char *confbase, const char *name, const char* appname, dev_class_t devclass) { +meshlink_handle_t *meshlink_open(const char *confbase, const char *name, const char *appname, dev_class_t devclass) { // Validate arguments provided by the application bool usingname = false; - + logger(NULL, MESHLINK_DEBUG, "meshlink_open called\n"); if(!confbase || !*confbase) { @@ -850,14 +862,14 @@ meshlink_handle_t *meshlink_open(const char *confbase, const char *name, const c if(!name || !*name) { logger(NULL, MESHLINK_ERROR, "No name given!\n"); //return NULL; - } - else { //check name only if there is a name != NULL + } else { //check name only if there is a name != NULL if(!check_id(name)) { logger(NULL, MESHLINK_ERROR, "Invalid name given!\n"); meshlink_errno = MESHLINK_EINVAL; return NULL; - } else { usingname = true;} + } else + usingname = true; } if(devclass < 0 || devclass > _DEV_CLASS_MAX) { @@ -870,14 +882,14 @@ meshlink_handle_t *meshlink_open(const char *confbase, const char *name, const c mesh->confbase = xstrdup(confbase); mesh->appname = xstrdup(appname); mesh->devclass = devclass; - if (usingname) mesh->name = xstrdup(name); + if(usingname) mesh->name = xstrdup(name); // initialize mutex pthread_mutexattr_t attr; pthread_mutexattr_init(&attr); pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE); pthread_mutex_init(&(mesh->mesh_mutex), &attr); - + mesh->threadstarted = false; event_loop_init(&mesh->loop); mesh->loop.data = mesh; @@ -885,7 +897,7 @@ meshlink_handle_t *meshlink_open(const char *confbase, const char *name, const c // Check whether meshlink.conf already exists char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "meshlink.conf", confbase); + snprintf(filename, sizeof(filename), "%s" SLASH "meshlink.conf", confbase); if(access(filename, R_OK)) { if(errno == ENOENT) { @@ -954,7 +966,7 @@ bool meshlink_start(meshlink_handle_t *mesh) { meshlink_errno = MESHLINK_EINVAL; return false; } - + logger(mesh, MESHLINK_DEBUG, "meshlink_start called\n"); pthread_mutex_lock(&(mesh->mesh_mutex)); @@ -976,7 +988,7 @@ bool meshlink_start(meshlink_handle_t *mesh) { // TODO: open listening sockets first //Check that a valid name is set - if(!mesh->name ) { + if(!mesh->name) { logger(mesh, MESHLINK_DEBUG, "No name given!\n"); meshlink_errno = MESHLINK_EINVAL; pthread_mutex_unlock(&(mesh->mesh_mutex)); @@ -989,15 +1001,16 @@ bool meshlink_start(meshlink_handle_t *mesh) { if(pthread_create(&mesh->thread, NULL, meshlink_main_loop, mesh) != 0) { logger(mesh, MESHLINK_DEBUG, "Could not start thread: %s\n", strerror(errno)); - memset(&mesh->thread, 0, sizeof mesh->thread); + memset(&mesh->thread, 0, sizeof(mesh)->thread); meshlink_errno = MESHLINK_EINTERNAL; pthread_mutex_unlock(&(mesh->mesh_mutex)); return false; } - mesh->threadstarted=true; + mesh->threadstarted = true; - discovery_start(mesh); + if(mesh->discovery) + discovery_start(mesh); pthread_mutex_unlock(&(mesh->mesh_mutex)); return true; @@ -1013,10 +1026,8 @@ void meshlink_stop(meshlink_handle_t *mesh) { logger(mesh, MESHLINK_DEBUG, "meshlink_stop called\n"); // Stop discovery - discovery_stop(mesh); - - pthread_mutex_lock(&(mesh->mesh_mutex)); - logger(mesh, MESHLINK_DEBUG, "meshlink_stop called\n"); + if(mesh->discovery) + discovery_stop(mesh); // Shut down the main thread event_loop_stop(&mesh->loop); @@ -1069,7 +1080,7 @@ void meshlink_close(meshlink_handle_t *mesh) { free(mesh->confbase); pthread_mutex_destroy(&(mesh->mesh_mutex)); - memset(mesh, 0, sizeof *mesh); + memset(mesh, 0, sizeof(*mesh)); free(mesh); } @@ -1082,7 +1093,7 @@ static void deltree(const char *dirname) { if(ent->d_name[0] == '.') continue; char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "%s", dirname, ent->d_name); + snprintf(filename, sizeof(filename), "%s" SLASH "%s", dirname, ent->d_name); if(unlink(filename)) deltree(filename); } @@ -1099,7 +1110,7 @@ bool meshlink_destroy(const char *confbase) { } char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "meshlink.conf", confbase); + snprintf(filename, sizeof(filename), "%s" SLASH "meshlink.conf", confbase); if(unlink(filename)) { if(errno == ENOENT) { @@ -1155,7 +1166,7 @@ bool meshlink_send(meshlink_handle_t *mesh, meshlink_node_t *destination, const meshlink_packethdr_t *hdr; // Validate arguments - if(!mesh || !destination || len >= MAXSIZE - sizeof *hdr) { + if(!mesh || !destination || len >= MAXSIZE - sizeof(*hdr)) { meshlink_errno = MESHLINK_EINVAL; return false; } @@ -1169,7 +1180,7 @@ bool meshlink_send(meshlink_handle_t *mesh, meshlink_node_t *destination, const } // Prepare the packet - vpn_packet_t *packet = malloc(sizeof *packet); + vpn_packet_t *packet = malloc(sizeof(*packet)); if(!packet) { meshlink_errno = MESHLINK_ENOMEM; return false; @@ -1177,16 +1188,16 @@ bool meshlink_send(meshlink_handle_t *mesh, meshlink_node_t *destination, const packet->probe = false; packet->tcp = false; - packet->len = len + sizeof *hdr; + packet->len = len + sizeof(*hdr); hdr = (meshlink_packethdr_t *)packet->data; - memset(hdr, 0, sizeof *hdr); + memset(hdr, 0, sizeof(*hdr)); // leave the last byte as 0 to make sure strings are always // null-terminated if they are longer than the buffer - strncpy(hdr->destination, destination->name, (sizeof hdr->destination) - 1); - strncpy(hdr->source, mesh->self->name, (sizeof hdr->source) -1 ); + strncpy(hdr->destination, destination->name, (sizeof(hdr)->destination) - 1); + strncpy(hdr->source, mesh->self->name, (sizeof(hdr)->source) - 1); - memcpy(packet->data + sizeof *hdr, data, len); + memcpy(packet->data + sizeof(*hdr), data, len); // Queue it if(!meshlink_queue_push(&mesh->outpacketqueue, packet)) { @@ -1196,8 +1207,8 @@ bool meshlink_send(meshlink_handle_t *mesh, meshlink_node_t *destination, const } // Notify event loop - signal_trigger(&(mesh->loop),&(mesh->datafromapp)); - + signal_trigger(&(mesh->loop), &(mesh->datafromapp)); + return true; } @@ -1222,13 +1233,11 @@ ssize_t meshlink_get_pmtu(meshlink_handle_t *mesh, meshlink_node_t *destination) if(!n->status.reachable) { pthread_mutex_unlock(&(mesh->mesh_mutex)); return 0; - - } - else if(n->mtuprobes > 30 && n->minmtu) { + + } else if(n->mtuprobes > 30 && n->minmtu) { pthread_mutex_unlock(&(mesh->mesh_mutex)); return n->minmtu; - } - else { + } else { pthread_mutex_unlock(&(mesh->mesh_mutex)); return MTU; } @@ -1293,7 +1302,7 @@ meshlink_node_t **meshlink_get_all_nodes(meshlink_handle_t *mesh, meshlink_node_ pthread_mutex_lock(&(mesh->mesh_mutex)); *nmemb = mesh->nodes->count; - result = realloc(nodes, *nmemb * sizeof *nodes); + result = realloc(nodes, *nmemb * sizeof(*nodes)); if(result) { meshlink_node_t **p = result; @@ -1354,19 +1363,18 @@ bool meshlink_verify(meshlink_handle_t *mesh, meshlink_node_t *source, const voi if(!n->ecdsa) { meshlink_errno = MESHLINK_EINTERNAL; rval = false; - } else { + } else rval = ecdsa_verify(((struct node_t *)source)->ecdsa, data, len, signature); - } pthread_mutex_unlock(&(mesh->mesh_mutex)); return rval; } static bool refresh_invitation_key(meshlink_handle_t *mesh) { char filename[PATH_MAX]; - + pthread_mutex_lock(&(mesh->mesh_mutex)); - snprintf(filename, sizeof filename, "%s" SLASH "invitations", mesh->confbase); + snprintf(filename, sizeof(filename), "%s" SLASH "invitations", mesh->confbase); if(mkdir(filename, 0700) && errno != EEXIST) { logger(mesh, MESHLINK_DEBUG, "Could not create directory %s: %s\n", filename, strerror(errno)); meshlink_errno = MESHLINK_ESTORAGE; @@ -1393,7 +1401,7 @@ static bool refresh_invitation_key(meshlink_handle_t *mesh) { continue; char invname[PATH_MAX]; struct stat st; - snprintf(invname, sizeof invname, "%s" SLASH "%s", filename, ent->d_name); + snprintf(invname, sizeof(invname), "%s" SLASH "%s", filename, ent->d_name); if(!stat(invname, &st)) { if(mesh->invitation_key && deadline < st.st_mtime) count++; @@ -1415,7 +1423,7 @@ static bool refresh_invitation_key(meshlink_handle_t *mesh) { closedir(dir); - snprintf(filename, sizeof filename, "%s" SLASH "invitations" SLASH "ecdsa_key.priv", mesh->confbase); + snprintf(filename, sizeof(filename), "%s" SLASH "invitations" SLASH "ecdsa_key.priv", mesh->confbase); // Remove the key if there are no outstanding invitations. if(!count) { @@ -1512,12 +1520,72 @@ bool meshlink_add_external_address(meshlink_handle_t *mesh) { return rval; } +int meshlink_get_port(meshlink_handle_t *mesh) { + if(!mesh) { + meshlink_errno = MESHLINK_EINVAL; + return -1; + } + + if(!mesh->myport) { + meshlink_errno = MESHLINK_EINTERNAL; + return -1; + } + + return atoi(mesh->myport); +} + +bool meshlink_set_port(meshlink_handle_t *mesh, int port) { + if(!mesh || port < 0 || port >= 65536 || mesh->threadstarted) { + meshlink_errno = MESHLINK_EINVAL; + return false; + } + + if(mesh->myport && port == atoi(mesh->myport)) + return true; + + if(!try_bind(port)) { + meshlink_errno = MESHLINK_ENETWORK; + return false; + } + + bool rval = false; + + pthread_mutex_lock(&(mesh->mesh_mutex)); + if(mesh->threadstarted) { + meshlink_errno = MESHLINK_EINVAL; + goto done; + } + + close_network_connections(mesh); + exit_configuration(&mesh->config); + + char portstr[10]; + snprintf(portstr, sizeof(portstr), "%d", port); + portstr[sizeof(portstr) - 1] = 0; + + modify_config_file(mesh, mesh->name, "Port", portstr, true); + + init_configuration(&mesh->config); + + if(!read_server_config(mesh)) + meshlink_errno = MESHLINK_ESTORAGE; + else if(!setup_network(mesh)) + meshlink_errno = MESHLINK_ENETWORK; + else + rval = true; + +done: + pthread_mutex_unlock(&(mesh->mesh_mutex)); + + return rval; +} + char *meshlink_invite(meshlink_handle_t *mesh, const char *name) { if(!mesh) { meshlink_errno = MESHLINK_EINVAL; return NULL; } - + pthread_mutex_lock(&(mesh->mesh_mutex)); // Check validity of the new node's name @@ -1530,7 +1598,7 @@ char *meshlink_invite(meshlink_handle_t *mesh, const char *name) { // Ensure no host configuration file with that name exists char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); if(!access(filename, F_OK)) { logger(mesh, MESHLINK_DEBUG, "A host config file for %s already exists!\n", name); meshlink_errno = MESHLINK_EEXIST; @@ -1576,8 +1644,8 @@ char *meshlink_invite(meshlink_handle_t *mesh, const char *name) { char buf[18 + strlen(fingerprint)]; char cookiehash[64]; memcpy(buf, cookie, 18); - memcpy(buf + 18, fingerprint, sizeof buf - 18); - sha512(buf, sizeof buf, cookiehash); + memcpy(buf + 18, fingerprint, sizeof(buf) - 18); + sha512(buf, sizeof(buf), cookiehash); b64encode_urlsafe(cookiehash, cookiehash, 18); b64encode_urlsafe(cookie, cookie, 18); @@ -1585,7 +1653,7 @@ char *meshlink_invite(meshlink_handle_t *mesh, const char *name) { free(fingerprint); // Create a file containing the details of the invitation. - snprintf(filename, sizeof filename, "%s" SLASH "invitations" SLASH "%s", mesh->confbase, cookiehash); + snprintf(filename, sizeof(filename), "%s" SLASH "invitations" SLASH "%s", mesh->confbase, cookiehash); int ifd = open(filename, O_RDWR | O_CREAT | O_EXCL, 0600); if(!ifd) { logger(mesh, MESHLINK_DEBUG, "Could not create invitation file %s: %s\n", filename, strerror(errno)); @@ -1600,17 +1668,17 @@ char *meshlink_invite(meshlink_handle_t *mesh, const char *name) { // Fill in the details. fprintf(f, "Name = %s\n", name); //if(netname) - // fprintf(f, "NetName = %s\n", netname); + // fprintf(f, "NetName = %s\n", netname); fprintf(f, "ConnectTo = %s\n", mesh->self->name); // Copy Broadcast and Mode - snprintf(filename, sizeof filename, "%s" SLASH "meshlink.conf", mesh->confbase); + snprintf(filename, sizeof(filename), "%s" SLASH "meshlink.conf", mesh->confbase); FILE *tc = fopen(filename, "r"); if(tc) { char buf[1024]; - while(fgets(buf, sizeof buf, tc)) { + while(fgets(buf, sizeof(buf), tc)) { if((!strncasecmp(buf, "Mode", 4) && strchr(" \t=", buf[4])) - || (!strncasecmp(buf, "Broadcast", 9) && strchr(" \t=", buf[9]))) { + || (!strncasecmp(buf, "Broadcast", 9) && strchr(" \t=", buf[9]))) { fputs(buf, f); // Make sure there is a newline character. if(!strchr(buf, '\n')) @@ -1628,7 +1696,7 @@ char *meshlink_invite(meshlink_handle_t *mesh, const char *name) { fprintf(f, "#---------------------------------------------------------------#\n"); fprintf(f, "Name = %s\n", mesh->self->name); - snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, mesh->self->name); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, mesh->self->name); fcopy(f, filename); fclose(f); @@ -1646,7 +1714,7 @@ bool meshlink_join(meshlink_handle_t *mesh, const char *invitation) { meshlink_errno = MESHLINK_EINVAL; return false; } - + pthread_mutex_lock(&(mesh->mesh_mutex)); //TODO: think of a better name for this variable, or of a different way to tokenize the invitation URL. @@ -1697,9 +1765,8 @@ bool meshlink_join(meshlink_handle_t *mesh, const char *invitation) { char *b64key = ecdsa_get_base64_public_key(key); //Before doing meshlink_join make sure we are not connected to another mesh - if ( mesh->threadstarted ){ + if(mesh->threadstarted) goto invalid; - } // Connect to the meshlink daemon mentioned in the URL. struct addrinfo *ai = str2addrinfo(address, port, SOCK_STREAM); @@ -1718,6 +1785,8 @@ bool meshlink_join(meshlink_handle_t *mesh, const char *invitation) { return false; } + set_timeout(mesh->sock, 5000); + if(connect(mesh->sock, ai->ai_addr, ai->ai_addrlen)) { logger(mesh, MESHLINK_DEBUG, "Could not connect to %s port %s: %s\n", address, port, strerror(errno)); closesocket(mesh->sock); @@ -1748,7 +1817,7 @@ bool meshlink_join(meshlink_handle_t *mesh, const char *invitation) { char hisname[4096] = ""; int code, hismajor, hisminor = 0; - if(!recvline(mesh, sizeof mesh->line) || sscanf(mesh->line, "%d %s %d.%d", &code, hisname, &hismajor, &hisminor) < 3 || code != 0 || hismajor != PROT_MAJOR || !check_id(hisname) || !recvline(mesh, sizeof mesh->line) || !rstrip(mesh->line) || sscanf(mesh->line, "%d ", &code) != 1 || code != ACK || strlen(mesh->line) < 3) { + if(!recvline(mesh, sizeof(mesh)->line) || sscanf(mesh->line, "%d %s %d.%d", &code, hisname, &hismajor, &hisminor) < 3 || code != 0 || hismajor != PROT_MAJOR || !check_id(hisname) || !recvline(mesh, sizeof(mesh)->line) || !rstrip(mesh->line) || sscanf(mesh->line, "%d ", &code) != 1 || code != ACK || strlen(mesh->line) < 3) { logger(mesh, MESHLINK_DEBUG, "Cannot read greeting from peer\n"); closesocket(mesh->sock); meshlink_errno = MESHLINK_ENETWORK; @@ -1781,7 +1850,7 @@ bool meshlink_join(meshlink_handle_t *mesh, const char *invitation) { } // Start an SPTPS session - if(!sptps_start(&mesh->sptps, mesh, true, false, key, hiskey, "meshlink invitation", 15, invitation_send, invitation_receive)) { + if(!sptps_start(&mesh->sptps, mesh, true, false, key, hiskey, meshlink_invitation_label, sizeof(meshlink_invitation_label), invitation_send, invitation_receive)) { meshlink_errno = MESHLINK_EINTERNAL; pthread_mutex_unlock(&(mesh->mesh_mutex)); return false; @@ -1796,7 +1865,7 @@ bool meshlink_join(meshlink_handle_t *mesh, const char *invitation) { int len; - while((len = recv(mesh->sock, mesh->line, sizeof mesh->line, 0))) { + while((len = recv(mesh->sock, mesh->line, sizeof(mesh)->line, 0))) { if(len < 0) { if(errno == EINTR) continue; @@ -1842,9 +1911,9 @@ char *meshlink_export(meshlink_handle_t *mesh) { } pthread_mutex_lock(&(mesh->mesh_mutex)); - + char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, mesh->self->name); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, mesh->self->name); FILE *f = fopen(filename, "r"); if(!f) { logger(mesh, MESHLINK_DEBUG, "Could not open %s: %s\n", filename, strerror(errno)); @@ -1870,7 +1939,7 @@ char *meshlink_export(meshlink_handle_t *mesh) { fclose(f); buf[len - 1] = 0; - + pthread_mutex_unlock(&(mesh->mesh_mutex)); return buf; } @@ -1880,7 +1949,7 @@ bool meshlink_import(meshlink_handle_t *mesh, const char *data) { meshlink_errno = MESHLINK_EINVAL; return false; } - + pthread_mutex_lock(&(mesh->mesh_mutex)); if(strncmp(data, "Name = ", 7)) { @@ -1910,7 +1979,7 @@ bool meshlink_import(meshlink_handle_t *mesh, const char *data) { } char filename[PATH_MAX]; - snprintf(filename, sizeof filename, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); + snprintf(filename, sizeof(filename), "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); if(!access(filename, F_OK)) { logger(mesh, MESHLINK_DEBUG, "File %s already exists, not importing\n", filename); meshlink_errno = MESHLINK_EEXIST; @@ -1949,11 +2018,11 @@ void meshlink_blacklist(meshlink_handle_t *mesh, meshlink_node_t *node) { } pthread_mutex_lock(&(mesh->mesh_mutex)); - + node_t *n; - n = (node_t*)node; - n->status.blacklisted=true; - logger(mesh, MESHLINK_DEBUG, "Blacklisted %s.\n",node->name); + n = (node_t *)node; + n->status.blacklisted = true; + logger(mesh, MESHLINK_DEBUG, "Blacklisted %s.\n", node->name); //Make blacklisting persistent in the config file append_config_file(mesh, n->name, "blacklisted", "yes"); @@ -1969,7 +2038,7 @@ void meshlink_whitelist(meshlink_handle_t *mesh, meshlink_node_t *node) { } pthread_mutex_lock(&(mesh->mesh_mutex)); - + node_t *n = (node_t *)node; n->status.blacklisted = false; @@ -1993,15 +2062,15 @@ void meshlink_hint_address(meshlink_handle_t *mesh, meshlink_node_t *node, const // Ignore hints about ourself. if((node_t *)node == mesh->self) return; - + pthread_mutex_lock(&(mesh->mesh_mutex)); - + char *host = NULL, *port = NULL, *str = NULL; sockaddr2str((const sockaddr_t *)addr, &host, &port); if(host && port) { xasprintf(&str, "%s %s", host, port); - if ( (strncmp ("fe80",host,4) != 0) && ( strncmp("127.",host,4) != 0 ) && ( strcmp("localhost",host) !=0 ) ) + if((strncmp("fe80", host, 4) != 0) && (strncmp("127.", host, 4) != 0) && (strcmp("localhost", host) != 0)) append_config_file(mesh, node->name, "Address", str); else logger(mesh, MESHLINK_DEBUG, "Not adding Link Local IPv6 Address to config\n"); @@ -2026,7 +2095,7 @@ meshlink_edge_t **meshlink_get_all_edges_state(meshlink_handle_t *mesh, meshlink } pthread_mutex_lock(&(mesh->mesh_mutex)); - + meshlink_edge_t **result = NULL; meshlink_edge_t *copy = NULL; int result_size = 0; @@ -2034,11 +2103,10 @@ meshlink_edge_t **meshlink_get_all_edges_state(meshlink_handle_t *mesh, meshlink result_size = mesh->edges->count; // if result is smaller than edges, we have to dealloc all the excess meshlink_edge_t - if(result_size > *nmemb) { - result = realloc(edges, result_size * sizeof (meshlink_edge_t*)); - } else { + if(result_size > *nmemb) + result = realloc(edges, result_size * sizeof(meshlink_edge_t *)); + else result = edges; - } if(result) { meshlink_edge_t **p = result; @@ -2051,24 +2119,21 @@ meshlink_edge_t **meshlink_get_all_edges_state(meshlink_handle_t *mesh, meshlink } n++; // the first *nmemb members of result can be re-used - if(n > *nmemb) { - copy = xzalloc(sizeof *copy); - } - else { + if(n > *nmemb) + copy = xzalloc(sizeof(*copy)); + else copy = *p; - } - copy->from = (meshlink_node_t*)e->from; - copy->to = (meshlink_node_t*)e->to; + copy->from = (meshlink_node_t *)e->from; + copy->to = (meshlink_node_t *)e->to; copy->address = e->address.storage; copy->options = e->options; copy->weight = e->weight; *p++ = copy; } // shrink result to the actual amount of memory used - for(int i = *nmemb; i > result_size; i--) { + for(int i = *nmemb; i > result_size; i--) free(result[i - 1]); - } - result = realloc(result, result_size * sizeof (meshlink_edge_t*)); + result = realloc(result, result_size * sizeof(meshlink_edge_t *)); *nmemb = result_size; } else { *nmemb = 0; @@ -2091,12 +2156,9 @@ static ssize_t channel_recv(struct utcp_connection *connection, const void *data abort(); node_t *n = channel->node; meshlink_handle_t *mesh = n->mesh; - if(!channel->receive_cb) - return -1; - else { + if(channel->receive_cb) channel->receive_cb(mesh, channel, data, len); - return len; - } + return len; } static void channel_accept(struct utcp_connection *utcp_connection, uint16_t port) { @@ -2106,7 +2168,7 @@ static void channel_accept(struct utcp_connection *utcp_connection, uint16_t por meshlink_handle_t *mesh = n->mesh; if(!mesh->channel_accept_cb) return; - meshlink_channel_t *channel = xzalloc(sizeof *channel); + meshlink_channel_t *channel = xzalloc(sizeof(*channel)); channel->node = n; channel->c = utcp_connection; if(mesh->channel_accept_cb(mesh, channel, port, NULL, 0)) @@ -2118,9 +2180,6 @@ static void channel_accept(struct utcp_connection *utcp_connection, uint16_t por static ssize_t channel_send(struct utcp *utcp, const void *data, size_t len) { node_t *n = utcp->priv; meshlink_handle_t *mesh = n->mesh; - char hex[len * 2 + 1]; - bin2hex(data, hex, len); - logger(mesh, MESHLINK_WARNING, "channel_send(%p, %p, %zu): %s\n", utcp, data, len, hex); return meshlink_send(mesh, (meshlink_node_t *)n, data, len) ? len : -1; } @@ -2137,9 +2196,6 @@ static void channel_receive(meshlink_handle_t *mesh, meshlink_node_t *source, co node_t *n = (node_t *)source; if(!n->utcp) abort(); - char hex[len * 2 + 1]; - bin2hex(data, hex, len); - logger(mesh, MESHLINK_WARNING, "channel_receive(%p, %p, %zu): %s\n", n->utcp, data, len, hex); utcp_recv(n->utcp, data, len); } @@ -2168,21 +2224,18 @@ void meshlink_set_channel_accept_cb(meshlink_handle_t *mesh, meshlink_channel_ac mesh->channel_accept_cb = cb; mesh->receive_cb = channel_receive; for splay_each(node_t, n, mesh->nodes) { - if(!n->utcp && n != mesh->self) { - logger(mesh, MESHLINK_WARNING, "utcp_init on node %s", n->name); + if(!n->utcp && n != mesh->self) n->utcp = utcp_init(channel_accept, channel_pre_accept, channel_send, n); - } } pthread_mutex_unlock(&mesh->mesh_mutex); } -meshlink_channel_t *meshlink_channel_open(meshlink_handle_t *mesh, meshlink_node_t *node, uint16_t port, meshlink_channel_receive_cb_t cb, const void *data, size_t len) { +meshlink_channel_t *meshlink_channel_open_ex(meshlink_handle_t *mesh, meshlink_node_t *node, uint16_t port, meshlink_channel_receive_cb_t cb, const void *data, size_t len, uint32_t flags) { if(!mesh || !node) { meshlink_errno = MESHLINK_EINVAL; return NULL; } - logger(mesh, MESHLINK_WARNING, "meshlink_channel_open(%p, %s, %u, %p, %p, %zu)\n", mesh, node->name, port, cb, data, len); node_t *n = (node_t *)node; if(!n->utcp) { n->utcp = utcp_init(channel_accept, channel_pre_accept, channel_send, n); @@ -2192,10 +2245,10 @@ meshlink_channel_t *meshlink_channel_open(meshlink_handle_t *mesh, meshlink_node return NULL; } } - meshlink_channel_t *channel = xzalloc(sizeof *channel); + meshlink_channel_t *channel = xzalloc(sizeof(*channel)); channel->node = n; channel->receive_cb = cb; - channel->c = utcp_connect(n->utcp, port, channel_recv, channel); + channel->c = utcp_connect_ex(n->utcp, port, channel_recv, channel, flags); if(!channel->c) { meshlink_errno = errno == ENOMEM ? MESHLINK_ENOMEM : MESHLINK_EINTERNAL; free(channel); @@ -2204,6 +2257,10 @@ meshlink_channel_t *meshlink_channel_open(meshlink_handle_t *mesh, meshlink_node return channel; } +meshlink_channel_t *meshlink_channel_open(meshlink_handle_t *mesh, meshlink_node_t *node, uint16_t port, meshlink_channel_receive_cb_t cb, const void *data, size_t len) { + return meshlink_channel_open_ex(mesh, node, port, cb, data, len, MESHLINK_CHANNEL_TCP); +} + void meshlink_channel_shutdown(meshlink_handle_t *mesh, meshlink_channel_t *channel, int direction) { if(!mesh || !channel) { meshlink_errno = MESHLINK_EINVAL; @@ -2251,6 +2308,15 @@ ssize_t meshlink_channel_send(meshlink_handle_t *mesh, meshlink_channel_t *chann return retval; } +uint32_t meshlink_channel_get_flags(meshlink_handle_t *mesh, meshlink_channel_t *channel) { + if(!mesh || !channel) { + meshlink_errno = MESHLINK_EINVAL; + return -1; + } + + return channel->c->flags; +} + void update_node_status(meshlink_handle_t *mesh, node_t *n) { if(n->status.reachable && mesh->channel_accept_cb && !n->utcp) n->utcp = utcp_init(channel_accept, channel_pre_accept, channel_send, n); @@ -2258,8 +2324,35 @@ void update_node_status(meshlink_handle_t *mesh, node_t *n) { mesh->node_status_cb(mesh, (meshlink_node_t *)n, n->status.reachable); } +void meshlink_enable_discovery(meshlink_handle_t *mesh, bool enable) { + if(!mesh) { + meshlink_errno = MESHLINK_EINVAL; + return; + } + + pthread_mutex_lock(&mesh->mesh_mutex); + + if(mesh->discovery == enable) + goto end; + + if(mesh->threadstarted) { + if(enable) + discovery_start(mesh); + else + discovery_stop(mesh); + } + + mesh->discovery = enable; + +end: + pthread_mutex_unlock(&mesh->mesh_mutex); +} + static void __attribute__((constructor)) meshlink_init(void) { crypto_init(); + unsigned int seed; + randomize(&seed, sizeof(seed)); + srand(seed); } static void __attribute__((destructor)) meshlink_exit(void) { @@ -2267,9 +2360,9 @@ static void __attribute__((destructor)) meshlink_exit(void) { } /// Device class traits -dev_class_traits_t dev_class_traits[_DEV_CLASS_MAX +1] = { - { .min_connects = 3, .max_connects = 10000, .edge_weight = 1 }, // DEV_CLASS_BACKBONE - { .min_connects = 3, .max_connects = 100, .edge_weight = 3 }, // DEV_CLASS_STATIONARY - { .min_connects = 3, .max_connects = 3, .edge_weight = 6 }, // DEV_CLASS_PORTABLE - { .min_connects = 1, .max_connects = 1, .edge_weight = 9 }, // DEV_CLASS_UNKNOWN +dev_class_traits_t dev_class_traits[_DEV_CLASS_MAX + 1] = { + { .min_connects = 3, .max_connects = 10000, .edge_weight = 1 }, // DEV_CLASS_BACKBONE + { .min_connects = 3, .max_connects = 100, .edge_weight = 3 }, // DEV_CLASS_STATIONARY + { .min_connects = 3, .max_connects = 3, .edge_weight = 6 }, // DEV_CLASS_PORTABLE + { .min_connects = 1, .max_connects = 1, .edge_weight = 9 }, // DEV_CLASS_UNKNOWN };