X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=src%2Fconf.c;h=ef595efca958f8cdb22ad240f41fb4f09864f0d1;hb=d90774f9eebb54dfb509b7005665a524cd0c3470;hp=36c10acb45d3d025458de83fdc89bd52f8824d43;hpb=0738678462979a3a3ee46cfc9c66d15002cafe72;p=meshlink diff --git a/src/conf.c b/src/conf.c index 36c10acb..ef595efc 100644 --- a/src/conf.c +++ b/src/conf.c @@ -51,7 +51,8 @@ void init_configuration(splay_tree_t **config_tree) { } void exit_configuration(splay_tree_t **config_tree) { - splay_delete_tree(*config_tree); + if(*config_tree) + splay_delete_tree(*config_tree); *config_tree = NULL; } @@ -124,7 +125,7 @@ bool get_config_bool(const config_t *cfg, bool *result) { return true; } - logger(DEBUG_ALWAYS, LOG_ERR, "\"yes\" or \"no\" expected for configuration variable %s in %s line %d", + logger(NULL, MESHLINK_ERROR, "\"yes\" or \"no\" expected for configuration variable %s in %s line %d", cfg->variable, cfg->file, cfg->line); return false; @@ -137,12 +138,28 @@ bool get_config_int(const config_t *cfg, int *result) { if(sscanf(cfg->value, "%d", result) == 1) return true; - logger(DEBUG_ALWAYS, LOG_ERR, "Integer expected for configuration variable %s in %s line %d", + logger(NULL, MESHLINK_ERROR, "Integer expected for configuration variable %s in %s line %d", cfg->variable, cfg->file, cfg->line); return false; } +bool set_config_int(config_t *cfg, int val) +{ + if(!cfg) + return false; + + char val_str[1024]; + snprintf(val_str, sizeof(val_str), "%d", val); + + if(cfg->value) + free(cfg->value); + + cfg->value = xstrdup(val_str); + + return true; +} + bool get_config_string(const config_t *cfg, char **result) { if(!cfg) return false; @@ -152,6 +169,19 @@ bool get_config_string(const config_t *cfg, char **result) { return true; } +bool set_config_string(config_t *cfg, const char* val) +{ + if(!cfg) + return false; + + if(cfg->value) + free(cfg->value); + + cfg->value = xstrdup(val); + + return true; +} + bool get_config_address(const config_t *cfg, struct addrinfo **result) { struct addrinfo *ai; @@ -165,7 +195,7 @@ bool get_config_address(const config_t *cfg, struct addrinfo **result) { return true; } - logger(DEBUG_ALWAYS, LOG_ERR, "Hostname or IP address expected for configuration variable %s in %s line %d", + logger(NULL, MESHLINK_ERROR, "Hostname or IP address expected for configuration variable %s in %s line %d", cfg->variable, cfg->file, cfg->line); return false; @@ -220,7 +250,7 @@ config_t *parse_config_line(char *line, const char *fname, int lineno) { if(!*value) { const char err[] = "No value for variable"; - logger(DEBUG_ALWAYS, LOG_ERR, "%s `%s' on line %d while reading config file %s", + logger(NULL, MESHLINK_ERROR, "%s `%s' on line %d while reading config file %s", err, variable, lineno, fname); return NULL; } @@ -250,7 +280,7 @@ bool read_config_file(splay_tree_t *config_tree, const char *fname) { fp = fopen(fname, "r"); if(!fp) { - logger(DEBUG_ALWAYS, LOG_ERR, "Cannot open config file %s: %s", fname, strerror(errno)); + logger(NULL, MESHLINK_ERROR, "Cannot open config file %s: %s", fname, strerror(errno)); return false; } @@ -290,6 +320,41 @@ bool read_config_file(splay_tree_t *config_tree, const char *fname) { return result; } +bool write_config_file(const struct splay_tree_t *config_tree, const char *fname) +{ + FILE *fp; + + fp = fopen(fname, "w+"); + + if(!fp) { + logger(NULL, MESHLINK_ERROR, "Cannot open config file %s: %s", fname, strerror(errno)); + return false; + } + + for splay_each(config_t, cnf, config_tree) + { + if(fwrite(cnf->variable, sizeof(char), strlen(cnf->variable), fp) < strlen(cnf->variable)) + goto error; + + if(fwrite(" = ", sizeof(char), 3, fp) < 3) + goto error; + + if(fwrite(cnf->value, sizeof(char), strlen(cnf->value), fp) < strlen(cnf->value)) + goto error; + + if(fwrite("\n", sizeof(char), 1, fp) < 1) + goto error; + } + + fclose(fp); + return true; + +error: + logger(NULL, MESHLINK_ERROR, "Cannot write to config file %s: %s", fname, strerror(errno)); + fclose(fp); + return false; +} + bool read_server_config(meshlink_handle_t *mesh) { char filename[PATH_MAX]; bool x; @@ -299,7 +364,7 @@ bool read_server_config(meshlink_handle_t *mesh) { x = read_config_file(mesh->config, filename); if(!x && errno) - logger(DEBUG_ALWAYS, LOG_ERR, "Failed to read `%s': %s", filename, strerror(errno)); + logger(mesh, MESHLINK_ERROR, "Failed to read `%s': %s", filename, strerror(errno)); return x; } @@ -314,6 +379,92 @@ bool read_host_config(meshlink_handle_t *mesh, splay_tree_t *config_tree, const return x; } +bool write_host_config(struct meshlink_handle *mesh, const struct splay_tree_t *config_tree, const char *name) +{ + char filename[PATH_MAX]; + + snprintf(filename,PATH_MAX, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); + return write_config_file(config_tree, filename); +} + +bool change_config_file(meshlink_handle_t *mesh, const char *name, const char *key, const char *value) { + char filename[PATH_MAX]; + char tmpname[PATH_MAX]; + char buf[MAX_STRING_SIZE]; + const int keylen = strlen(key); + + snprintf(filename, PATH_MAX, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); + snprintf(tmpname, PATH_MAX, "%s.tmp", filename); + + FILE *in = fopen(filename, "r"); + if(!in) { + // Hm, maybe the file does not exist? Try appending. + return append_config_file(mesh, name, key, value); + } + + FILE *out = fopen(tmpname, "w"); + if(!out) { + logger(mesh, MESHLINK_ERROR, "Failed to write `%s': %s", tmpname, strerror(errno)); + fclose(in); + return false; + } + + bool ignore = false; + + while(readline(in, buf, sizeof buf)) { + if(ignore) { + if(!strncmp(buf, "-----END", 8)) + ignore = false; + } else { + if(!strncmp(buf, "-----BEGIN", 10)) + ignore = true; + } + + if(!ignore && !strncmp(buf, key, keylen)) { + if(strchr("\t =", buf[keylen])) { + continue; + } + } + + fputs(buf, out); + fputc('\n', out); + } + + if(ferror(in)) { + logger(mesh, MESHLINK_ERROR, "Failed to read `%s': %s", filename, strerror(errno)); + fclose(in); + fclose(out); + return false; + } + + fclose(in); + + fprintf(out, "%s = %s\n", key, value); + + if(ferror(out)) { + logger(mesh, MESHLINK_ERROR, "Failed to write `%s': %s", tmpname, strerror(errno)); + fclose(out); + return false; + } + + fclose(out); + +#ifdef HAVE_MINGW + // We cannot atomically replace files on Windows. + char bakname[PATH_MAX]; + snprintf(bakname, PATH_MAX, "%s.bak", filename); + if(rename(tmpname, bakfile) || rename(bakfile, filename)) { + rename(bakfile, filename); +#else + if(rename(tmpname, filename)) { +#endif + logger(mesh, MESHLINK_ERROR, "Failed to update `%s': %s", filename, strerror(errno)); + return false; + } + + return true; +} + bool append_config_file(meshlink_handle_t *mesh, const char *name, const char *key, const char *value) { char filename[PATH_MAX]; snprintf(filename,PATH_MAX, "%s" SLASH "hosts" SLASH "%s", mesh->confbase, name); @@ -321,11 +472,30 @@ bool append_config_file(meshlink_handle_t *mesh, const char *name, const char *k FILE *fp = fopen(filename, "a"); if(!fp) { - logger(DEBUG_ALWAYS, LOG_ERR, "Cannot open config file %s: %s", filename, strerror(errno)); - } else { - fprintf(fp, "%s = %s\n", key, value); - fclose(fp); + logger(mesh, MESHLINK_ERROR, "Cannot open config file %s: %s", filename, strerror(errno)); + return false; + } + + // Check if we don't add a duplicate entry + + char entry[MAX_STRING_SIZE]; + snprintf(entry, sizeof entry, "%s = %s", key, value); + + char buffer[MAX_STRING_SIZE]; + bool found = false; + + while(readline(fp, buffer, sizeof buffer)) { + if(!strcmp(buffer, entry)) { + found = true; + break; + } } - return fp != NULL; + // If not, append the new entry + + if(!found) + fprintf(fp, "%s\n", entry); + + fclose(fp); + return true; }