X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=src%2Fconf.c;h=ac4d71a2bc9ad1db5547eac56ba958c77900bc6c;hb=5678b294c5bbb61b983a7a269bc85fd6ea6590ff;hp=5db2c016e8c5bfcfcde876207961605a0600c2ad;hpb=1442d234fb6681e32b10348a6c7b226c11629203;p=meshlink

diff --git a/src/conf.c b/src/conf.c
index 5db2c016..ac4d71a2 100644
--- a/src/conf.c
+++ b/src/conf.c
@@ -31,26 +31,47 @@
 
 /// Generate a path to the main configuration file.
 static void make_main_path(meshlink_handle_t *mesh, const char *conf_subdir, char *path, size_t len) {
+	assert(conf_subdir);
+	assert(path);
+	assert(len);
+
 	snprintf(path, len, "%s" SLASH "%s" SLASH "meshlink.conf", mesh->confbase, conf_subdir);
 }
 
 /// Generate a path to a host configuration file.
 static void make_host_path(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, char *path, size_t len) {
+	assert(conf_subdir);
+	assert(name);
+	assert(path);
+	assert(len);
+
 	snprintf(path, len, "%s" SLASH "%s" SLASH "hosts" SLASH "%s", mesh->confbase, conf_subdir, name);
 }
 
 /// Generate a path to an unused invitation file.
 static void make_invitation_path(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, char *path, size_t len) {
+	assert(conf_subdir);
+	assert(name);
+	assert(path);
+	assert(len);
+
 	snprintf(path, len, "%s" SLASH "%s" SLASH "invitations" SLASH "%s", mesh->confbase, conf_subdir, name);
 }
 
 /// Generate a path to a used invitation file.
 static void make_used_invitation_path(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, char *path, size_t len) {
+	assert(conf_subdir);
+	assert(name);
+	assert(path);
+	assert(len);
+
 	snprintf(path, len, "%s" SLASH "%s" SLASH "invitations" SLASH "%s.used", mesh->confbase, conf_subdir, name);
 }
 
 /// Remove a directory recursively
 static void deltree(const char *dirname) {
+	assert(dirname);
+
 	DIR *d = opendir(dirname);
 
 	if(d) {
@@ -76,22 +97,27 @@ static void deltree(const char *dirname) {
 }
 
 static bool sync_path(const char *pathname) {
+	assert(pathname);
+
 	int fd = open(pathname, O_RDONLY);
 
 	if(fd < 0) {
 		logger(NULL, MESHLINK_ERROR, "Failed to open %s: %s\n", pathname, strerror(errno));
+		meshlink_errno = MESHLINK_ESTORAGE;
 		return false;
 	}
 
 	if(fsync(fd)) {
 		logger(NULL, MESHLINK_ERROR, "Failed to sync %s: %s\n", pathname, strerror(errno));
 		close(fd);
+		meshlink_errno = MESHLINK_ESTORAGE;
 		return false;
 	}
 
 	if(close(fd)) {
 		logger(NULL, MESHLINK_ERROR, "Failed to close %s: %s\n", pathname, strerror(errno));
 		close(fd);
+		meshlink_errno = MESHLINK_ESTORAGE;
 		return false;
 	}
 
@@ -100,9 +126,9 @@ static bool sync_path(const char *pathname) {
 
 /// Try decrypting the main configuration file from the given sub-directory.
 static bool main_config_decrypt(meshlink_handle_t *mesh, const char *conf_subdir) {
-	if(!mesh->config_key && !mesh->confbase && !conf_subdir) {
-		return false;
-	}
+	assert(mesh->config_key);
+	assert(mesh->confbase);
+	assert(conf_subdir);
 
 	config_t config;
 
@@ -121,14 +147,12 @@ static bool main_config_decrypt(meshlink_handle_t *mesh, const char *conf_subdir
 
 /// Create a fresh configuration directory
 bool config_init(meshlink_handle_t *mesh, const char *conf_subdir) {
+	assert(conf_subdir);
+
 	if(!mesh->confbase) {
 		return true;
 	}
 
-	if(!conf_subdir) {
-		return false;
-	}
-
 	if(mkdir(mesh->confbase, 0700) && errno != EEXIST) {
 		logger(mesh, MESHLINK_DEBUG, "Could not create directory %s: %s\n", mesh->confbase, strerror(errno));
 		return false;
@@ -164,7 +188,9 @@ bool config_init(meshlink_handle_t *mesh, const char *conf_subdir) {
 
 /// Wipe an existing configuration directory
 bool config_destroy(const char *confbase, const char *conf_subdir) {
-	if(!confbase && !conf_subdir) {
+	assert(conf_subdir);
+
+	if(!confbase) {
 		return false;
 	}
 
@@ -202,9 +228,12 @@ bool config_destroy(const char *confbase, const char *conf_subdir) {
 }
 
 static bool copytree(const char *src_dir_name, const void *src_key, const char *dst_dir_name, const void *dst_key) {
-	if(!src_dir_name || !dst_dir_name) {
-		return false;
-	}
+	assert(src_dir_name);
+	assert(dst_dir_name);
+
+	char src_filename[PATH_MAX];
+	char dst_filename[PATH_MAX];
+	struct dirent *ent;
 
 	DIR *src_dir = opendir(src_dir_name);
 
@@ -213,29 +242,23 @@ static bool copytree(const char *src_dir_name, const void *src_key, const char *
 		return false;
 	}
 
-	struct dirent *ent;
+	// Delete if already exists and create a new destination directory
+	deltree(dst_dir_name);
+
+	if(mkdir(dst_dir_name, 0700)) {
+		logger(NULL, MESHLINK_ERROR, "Could not create directory %s\n", dst_filename);
+		return false;
+	}
 
 	while((ent = readdir(src_dir))) {
 		if(ent->d_name[0] == '.') {
 			continue;
 		}
 
-		char src_filename[PATH_MAX];
-		char dst_filename[PATH_MAX];
-
 		snprintf(dst_filename, sizeof(dst_filename), "%s" SLASH "%s", dst_dir_name, ent->d_name);
 		snprintf(src_filename, sizeof(src_filename), "%s" SLASH "%s", src_dir_name, ent->d_name);
 
 		if(ent->d_type == DT_DIR) {
-
-			// Delete if already exists and create a new destination directory
-			deltree(dst_filename);
-
-			if(mkdir(dst_filename, 0700)) {
-				logger(NULL, MESHLINK_ERROR, "Could create directory %s\n", dst_filename);
-				return false;
-			}
-
 			if(!copytree(src_filename, src_key, dst_filename, dst_key)) {
 				logger(NULL, MESHLINK_ERROR, "Copying %s to %s failed\n", src_filename, dst_filename);
 				return false;
@@ -244,7 +267,6 @@ static bool copytree(const char *src_dir_name, const void *src_key, const char *
 			if(!sync_path(dst_filename)) {
 				return false;
 			}
-
 		} else if(ent->d_type == DT_REG) {
 			struct stat st;
 			config_t config;
@@ -312,27 +334,23 @@ static bool copytree(const char *src_dir_name, const void *src_key, const char *
 }
 
 bool config_copy(meshlink_handle_t *mesh, const char *src_dir_name, const void *src_key, const char *dst_dir_name, const void *dst_key) {
+	assert(src_dir_name);
+	assert(dst_dir_name);
+
 	char src_filename[PATH_MAX];
 	char dst_filename[PATH_MAX];
 
 	snprintf(dst_filename, sizeof(dst_filename), "%s" SLASH "%s", mesh->confbase, dst_dir_name);
 	snprintf(src_filename, sizeof(src_filename), "%s" SLASH "%s", mesh->confbase, src_dir_name);
 
-	if(main_config_exists(mesh, dst_dir_name)) {
-		deltree(dst_dir_name);
-	}
-
-	if(mkdir(dst_filename, 0700)) {
-		logger(NULL, MESHLINK_ERROR, "Could create directory %s\n", dst_filename);
-		return false;
-	}
-
 	return copytree(src_filename, src_key, dst_filename, dst_key);
 }
 
 /// Check the presence of the main configuration file.
 bool main_config_exists(meshlink_handle_t *mesh, const char *conf_subdir) {
-	if(!mesh->confbase && !conf_subdir) {
+	assert(conf_subdir);
+
+	if(!mesh->confbase) {
 		return false;
 	}
 
@@ -342,7 +360,10 @@ bool main_config_exists(meshlink_handle_t *mesh, const char *conf_subdir) {
 }
 
 bool config_rename(meshlink_handle_t *mesh, const char *old_conf_subdir, const char *new_conf_subdir) {
-	if(!mesh->confbase && !old_conf_subdir && !new_conf_subdir) {
+	assert(old_conf_subdir);
+	assert(new_conf_subdir);
+
+	if(!mesh->confbase) {
 		return false;
 	}
 
@@ -355,6 +376,29 @@ bool config_rename(meshlink_handle_t *mesh, const char *old_conf_subdir, const c
 	return rename(old_path, new_path) == 0;
 }
 
+bool config_sync(meshlink_handle_t *mesh, const char *conf_subdir) {
+	assert(conf_subdir);
+
+	if(!mesh->confbase) {
+		return true;
+	}
+
+	char path[PATH_MAX];
+	snprintf(path, sizeof(path), "%s" SLASH "%s" SLASH "hosts", mesh->confbase, conf_subdir);
+
+	if(!sync_path(path)) {
+		return false;
+	}
+
+	snprintf(path, sizeof(path), "%s" SLASH "%s", mesh->confbase, conf_subdir);
+
+	if(!sync_path(path)) {
+		return false;
+	}
+
+	return true;
+}
+
 bool meshlink_confbase_exists(meshlink_handle_t *mesh) {
 	if(!mesh->confbase) {
 		return false;
@@ -460,12 +504,13 @@ void main_config_unlock(meshlink_handle_t *mesh) {
 
 /// Read a configuration file from a FILE handle.
 bool config_read_file(meshlink_handle_t *mesh, FILE *f, config_t *config, const void *key) {
+	assert(f);
+
 	long len;
 
 	if(fseek(f, 0, SEEK_END) || !(len = ftell(f)) || fseek(f, 0, SEEK_SET)) {
 		logger(mesh, MESHLINK_ERROR, "Cannot get config file size: %s\n", strerror(errno));
 		meshlink_errno = MESHLINK_ESTORAGE;
-		fclose(f);
 		return false;
 	}
 
@@ -474,7 +519,6 @@ bool config_read_file(meshlink_handle_t *mesh, FILE *f, config_t *config, const
 	if(fread(buf, len, 1, f) != 1) {
 		logger(mesh, MESHLINK_ERROR, "Cannot read config file: %s\n", strerror(errno));
 		meshlink_errno = MESHLINK_ESTORAGE;
-		fclose(f);
 		return false;
 	}
 
@@ -508,6 +552,8 @@ bool config_read_file(meshlink_handle_t *mesh, FILE *f, config_t *config, const
 
 /// Write a configuration file to a FILE handle.
 bool config_write_file(meshlink_handle_t *mesh, FILE *f, const config_t *config, const void *key) {
+	assert(f);
+
 	if(key) {
 		uint8_t buf[config->len + 16];
 		size_t len = sizeof(buf);
@@ -544,6 +590,8 @@ bool config_write_file(meshlink_handle_t *mesh, FILE *f, const config_t *config,
 
 /// Free resources of a loaded configuration file.
 void config_free(config_t *config) {
+	assert(!config->len || config->buf);
+
 	free((uint8_t *)config->buf);
 	config->buf = NULL;
 	config->len = 0;
@@ -551,7 +599,9 @@ void config_free(config_t *config) {
 
 /// Check the presence of a host configuration file.
 bool config_exists(meshlink_handle_t *mesh, const char *conf_subdir, const char *name) {
-	if(!mesh->confbase && !conf_subdir) {
+	assert(conf_subdir);
+
+	if(!mesh->confbase) {
 		return false;
 	}
 
@@ -563,7 +613,9 @@ bool config_exists(meshlink_handle_t *mesh, const char *conf_subdir, const char
 
 /// Read a host configuration file.
 bool config_read(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, config_t *config, void *key) {
-	if(!mesh->confbase && !conf_subdir) {
+	assert(conf_subdir);
+
+	if(!mesh->confbase) {
 		return false;
 	}
 
@@ -583,17 +635,17 @@ bool config_read(meshlink_handle_t *mesh, const char *conf_subdir, const char *n
 		return false;
 	}
 
-	if(fclose(f)) {
-		logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", path, strerror(errno));
-		return false;
-	}
+	fclose(f);
 
 	return true;
 }
 
 bool config_scan_all(meshlink_handle_t *mesh, const char *conf_subdir, const char *conf_type, config_scan_action_t action, void *arg) {
-	if(!mesh->confbase && !conf_subdir && !conf_type) {
-		return false;
+	assert(conf_subdir);
+	assert(conf_type);
+
+	if(!mesh->confbase) {
+		return true;
 	}
 
 	DIR *dir;
@@ -626,28 +678,45 @@ bool config_scan_all(meshlink_handle_t *mesh, const char *conf_subdir, const cha
 
 /// Write a host configuration file.
 bool config_write(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, const config_t *config, void *key) {
-	if(!mesh->confbase && !conf_subdir && !name) {
+	assert(conf_subdir);
+	assert(name);
+	assert(config);
+
+	if(!mesh->confbase) {
 		return true;
 	}
 
 	char path[PATH_MAX];
+	char tmp_path[PATH_MAX + 4];
 	make_host_path(mesh, conf_subdir, name, path, sizeof(path));
+	snprintf(tmp_path, sizeof(tmp_path), "%s.tmp", path);
 
-	FILE *f = fopen(path, "w");
+	FILE *f = fopen(tmp_path, "w");
 
 	if(!f) {
-		logger(mesh, MESHLINK_ERROR, "Failed to open `%s': %s", path, strerror(errno));
+		logger(mesh, MESHLINK_ERROR, "Failed to open `%s': %s", tmp_path, strerror(errno));
 		return false;
 	}
 
 	if(!config_write_file(mesh, f, config, key)) {
-		logger(mesh, MESHLINK_ERROR, "Failed to write `%s': %s", path, strerror(errno));
+		logger(mesh, MESHLINK_ERROR, "Failed to write `%s': %s", tmp_path, strerror(errno));
+		fclose(f);
+		return false;
+	}
+
+	if(fsync(fileno(f))) {
+		logger(mesh, MESHLINK_ERROR, "Failed to sync `%s': %s", tmp_path, strerror(errno));
 		fclose(f);
 		return false;
 	}
 
 	if(fclose(f)) {
-		logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", path, strerror(errno));
+		logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", tmp_path, strerror(errno));
+		return false;
+	}
+
+	if(rename(tmp_path, path)) {
+		logger(mesh, MESHLINK_ERROR, "Failed to rename `%s' to `%s': %s", tmp_path, path, strerror(errno));
 		return false;
 	}
 
@@ -656,7 +725,10 @@ bool config_write(meshlink_handle_t *mesh, const char *conf_subdir, const char *
 
 /// Read the main configuration file.
 bool main_config_read(meshlink_handle_t *mesh, const char *conf_subdir, config_t *config, void *key) {
-	if(!mesh->confbase && !conf_subdir) {
+	assert(conf_subdir);
+	assert(config);
+
+	if(!mesh->confbase) {
 		return false;
 	}
 
@@ -676,38 +748,52 @@ bool main_config_read(meshlink_handle_t *mesh, const char *conf_subdir, config_t
 		return false;
 	}
 
-	if(fclose(f)) {
-		logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", path, strerror(errno));
-		return false;
-	}
+	fclose(f);
 
 	return true;
 }
 
 /// Write the main configuration file.
 bool main_config_write(meshlink_handle_t *mesh, const char *conf_subdir, const config_t *config, void *key) {
-	if(!mesh->confbase && !conf_subdir) {
+	assert(conf_subdir);
+	assert(config);
+
+	if(!mesh->confbase) {
 		return true;
 	}
 
 	char path[PATH_MAX];
+	char tmp_path[PATH_MAX + 4];
 	make_main_path(mesh, conf_subdir, path, sizeof(path));
+	snprintf(tmp_path, sizeof(tmp_path), "%s.tmp", path);
 
-	FILE *f = fopen(path, "w");
+	FILE *f = fopen(tmp_path, "w");
 
 	if(!f) {
-		logger(mesh, MESHLINK_ERROR, "Failed to open `%s': %s", path, strerror(errno));
+		logger(mesh, MESHLINK_ERROR, "Failed to open `%s': %s", tmp_path, strerror(errno));
 		return false;
 	}
 
 	if(!config_write_file(mesh, f, config, key)) {
-		logger(mesh, MESHLINK_ERROR, "Failed to write `%s': %s", path, strerror(errno));
+		logger(mesh, MESHLINK_ERROR, "Failed to write `%s': %s", tmp_path, strerror(errno));
+		fclose(f);
+		return false;
+	}
+
+	if(fsync(fileno(f))) {
+		logger(mesh, MESHLINK_ERROR, "Failed to sync `%s': %s", tmp_path, strerror(errno));
+		fclose(f);
+		return false;
+	}
+
+	if(rename(tmp_path, path)) {
+		logger(mesh, MESHLINK_ERROR, "Failed to rename `%s' to `%s': %s", tmp_path, path, strerror(errno));
 		fclose(f);
 		return false;
 	}
 
 	if(fclose(f)) {
-		logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", path, strerror(errno));
+		logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", tmp_path, strerror(errno));
 		return false;
 	}
 
@@ -716,7 +802,11 @@ bool main_config_write(meshlink_handle_t *mesh, const char *conf_subdir, const c
 
 /// Read an invitation file from the confbase sub-directory, and immediately delete it.
 bool invitation_read(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, config_t *config, void *key) {
-	if(!mesh->confbase && !conf_subdir) {
+	assert(conf_subdir);
+	assert(name);
+	assert(config);
+
+	if(!mesh->confbase) {
 		return false;
 	}
 
@@ -753,7 +843,7 @@ bool invitation_read(meshlink_handle_t *mesh, const char *conf_subdir, const cha
 		return false;
 	}
 
-	if(time(NULL) > st.st_mtime + mesh->invitation_timeout) {
+	if(mesh->loop.now.tv_sec >= st.st_mtime + mesh->invitation_timeout) {
 		logger(mesh, MESHLINK_ERROR, "Peer tried to use an outdated invitation file %s\n", name);
 		fclose(f);
 		unlink(used_path);
@@ -767,10 +857,7 @@ bool invitation_read(meshlink_handle_t *mesh, const char *conf_subdir, const cha
 		return false;
 	}
 
-	if(fclose(f)) {
-		logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", path, strerror(errno));
-		return false;
-	}
+	fclose(f);
 
 	unlink(used_path);
 	return true;
@@ -778,7 +865,11 @@ bool invitation_read(meshlink_handle_t *mesh, const char *conf_subdir, const cha
 
 /// Write an invitation file.
 bool invitation_write(meshlink_handle_t *mesh, const char *conf_subdir, const char *name, const config_t *config, void *key) {
-	if(!mesh->confbase && !conf_subdir) {
+	assert(conf_subdir);
+	assert(name);
+	assert(config);
+
+	if(!mesh->confbase) {
 		return false;
 	}
 
@@ -798,6 +889,12 @@ bool invitation_write(meshlink_handle_t *mesh, const char *conf_subdir, const ch
 		return false;
 	}
 
+	if(fsync(fileno(f))) {
+		logger(mesh, MESHLINK_ERROR, "Failed to sync `%s': %s", path, strerror(errno));
+		fclose(f);
+		return false;
+	}
+
 	if(fclose(f)) {
 		logger(mesh, MESHLINK_ERROR, "Failed to close `%s': %s", path, strerror(errno));
 		return false;