X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=avahi-daemon%2Fstatic-services.c;h=b9a852cc362b0e685ba8d075c4d46d52c95b8296;hb=41f897e018ee55395441504c0cf3aef584527dd9;hp=7f910b0f720eb504e23c32e51b52129fab7f6bb9;hpb=aedd4e87362371d83dd64d0bfb03ea3e5526607f;p=catta diff --git a/avahi-daemon/static-services.c b/avahi-daemon/static-services.c index 7f910b0..b9a852c 100644 --- a/avahi-daemon/static-services.c +++ b/avahi-daemon/static-services.c @@ -222,7 +222,9 @@ static void add_static_service_group_to_server(StaticServiceGroup *g) { /* This service group is already registered in the server */ return; - if (!g->chosen_name) { + if (!g->chosen_name || (g->replace_wildcards && strstr(g->name, "%h"))) { + + avahi_free(g->chosen_name); if (g->replace_wildcards) g->chosen_name = replacestr(g->name, "%h", avahi_server_get_host_name(avahi_server)); @@ -302,6 +304,10 @@ struct xml_userdata { char *buf; }; +#ifndef XMLCALL +#define XMLCALL +#endif + static void XMLCALL xml_start(void *data, const char *el, const char *attr[]) { struct xml_userdata *u = data; @@ -609,7 +615,7 @@ static int static_service_group_load(StaticServiceGroup *g) { } if (!XML_ParseBuffer(parser, n, n == 0)) { - avahi_log_error("XML_ParseBuffer() failed at line %d: %s.\n", XML_GetCurrentLineNumber(parser), XML_ErrorString(XML_GetErrorCode(parser))); + avahi_log_error("XML_ParseBuffer() failed at line %d: %s.\n", (int) XML_GetCurrentLineNumber(parser), XML_ErrorString(XML_GetErrorCode(parser))); goto finish; } @@ -651,6 +657,7 @@ static void load_file(char *n) { void static_service_load(int in_chroot) { StaticServiceGroup *g, *n; glob_t globbuf; + int globret; char **p; for (g = groups; g; g = n) { @@ -677,8 +684,25 @@ void static_service_load(int in_chroot) { } memset(&globbuf, 0, sizeof(globbuf)); - if (glob(in_chroot ? "/services/*.service" : AVAHI_SERVICE_DIR "/*.service", GLOB_ERR, NULL, &globbuf) != 0) - avahi_log_error("Failed to read service directory."); + + if ((globret = glob(in_chroot ? "/services/*.service" : AVAHI_SERVICE_DIR "/*.service", GLOB_ERR, NULL, &globbuf)) != 0) + + switch (globret) { +#ifdef GLOB_NOSPACE + case GLOB_NOSPACE: + avahi_log_error("Not enough memory to read service directory "AVAHI_SERVICE_DIR"."); + break; +#endif +#ifdef GLOB_NOMATCH + case GLOB_NOMATCH: + avahi_log_info("No service file found in "AVAHI_SERVICE_DIR"."); + break; +#endif + default: + avahi_log_error("Failed to read "AVAHI_SERVICE_DIR"."); + break; + } + else { for (p = globbuf.gl_pathv; *p; p++) load_file(*p);