X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=avahi-core%2Fnetlink.c;h=ff88b91d5661ed554588b74f88c6d7be18d524a5;hb=38b45921cd1d33119f1c06979a57bcfe982e22da;hp=e3cc3fa1a4614d4a90920d7d498a5d5243ddbc79;hpb=c526a85bcdb32f84e6ade05ce647a431f6a07c10;p=catta diff --git a/avahi-core/netlink.c b/avahi-core/netlink.c index e3cc3fa..ff88b91 100644 --- a/avahi-core/netlink.c +++ b/avahi-core/netlink.c @@ -26,8 +26,10 @@ #include #include #include +#include #include "netlink.h" +#include "log.h" struct AvahiNetlink { GMainContext *context; @@ -43,23 +45,25 @@ gboolean avahi_netlink_work(AvahiNetlink *nl, gboolean block) { g_assert(nl); for (;;) { - guint8 replybuf[64*1024]; ssize_t bytes; - struct nlmsghdr *p = (struct nlmsghdr *) replybuf; + struct nlmsghdr *p; + guint8 buffer[64*1024]; - if ((bytes = recv(nl->fd, replybuf, sizeof(replybuf), block ? 0 : MSG_DONTWAIT)) < 0) { + p = (struct nlmsghdr *) buffer; + + if ((bytes = recv(nl->fd, buffer, sizeof(buffer), block ? 0 : MSG_DONTWAIT)) < 0) { if (errno == EAGAIN || errno == EINTR) break; - g_warning("NETLINK: recv() failed"); + avahi_log_warn("NETLINK: recv() failed: %s", strerror(errno)); return FALSE; } if (nl->callback) { for (; bytes > 0; p = NLMSG_NEXT(p, bytes)) { if (!NLMSG_OK(p, (size_t) bytes)) { - g_warning("NETLINK: packet truncated"); + avahi_log_warn("NETLINK: packet truncated"); return FALSE; } @@ -116,7 +120,6 @@ AvahiNetlink *avahi_netlink_new(GMainContext *context, gint priority, guint32 gr NULL }; - g_assert(context); g_assert(cb); if ((fd = socket(PF_NETLINK, SOCK_DGRAM, NETLINK_ROUTE)) < 0) { @@ -136,8 +139,7 @@ AvahiNetlink *avahi_netlink_new(GMainContext *context, gint priority, guint32 gr } nl = g_new(AvahiNetlink, 1); - nl->context = context; - g_main_context_ref(context); + g_main_context_ref(nl->context = context ? context : g_main_context_default()); nl->fd = fd; nl->seq = 0; nl->callback = cb; @@ -160,7 +162,7 @@ AvahiNetlink *avahi_netlink_new(GMainContext *context, gint priority, guint32 gr void avahi_netlink_free(AvahiNetlink *nl) { g_assert(nl); - + g_source_destroy(nl->source); g_source_unref(nl->source); g_main_context_unref(nl->context); @@ -176,7 +178,7 @@ int avahi_netlink_send(AvahiNetlink *nl, struct nlmsghdr *m, guint *ret_seq) { m->nlmsg_flags |= NLM_F_ACK; if (send(nl->fd, m, m->nlmsg_len, 0) < 0) { - g_warning("NETLINK: send(): %s\n", strerror(errno)); + avahi_log_warn("NETLINK: send(): %s\n", strerror(errno)); return -1; }