X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=avahi-core%2Fiface.c;h=fb491c9b534568e648e6ef7caaa05da96be5b043;hb=dbd6c48a552238d33e80a703feb901ade0c1a2b8;hp=13ffcef973d284c399a6cc59e63dca9b4111a3ec;hpb=c58379bde376cb2298fca14f83a86626f1b76f2f;p=catta diff --git a/avahi-core/iface.c b/avahi-core/iface.c index 13ffcef..fb491c9 100644 --- a/avahi-core/iface.c +++ b/avahi-core/iface.c @@ -36,27 +36,44 @@ #include "dns.h" #include "socket.h" #include "announce.h" +#include "util.h" +#include "log.h" -static void update_address_rr(AvahiInterfaceMonitor *m, AvahiInterfaceAddress *a, int remove) { +static void update_address_rr(AvahiInterfaceMonitor *m, AvahiInterfaceAddress *a, gboolean remove) { g_assert(m); g_assert(a); - if (!avahi_interface_address_relevant(a) || remove) { + if (avahi_interface_address_relevant(a) && + !remove && + m->server->config.publish_addresses && + (m->server->state == AVAHI_SERVER_RUNNING || + m->server->state == AVAHI_SERVER_REGISTERING)) { + + if (!a->entry_group) { + a->entry_group = avahi_entry_group_new(m->server, avahi_host_rr_entry_group_callback, NULL); + if (avahi_server_add_address(m->server, a->entry_group, a->interface->hardware->index, a->interface->protocol, 0, NULL, &a->address) < 0) { + avahi_log_warn(__FILE__": avahi_server_add_address() failed."); + avahi_entry_group_free(a->entry_group); + a->entry_group = NULL; + } else + avahi_entry_group_commit(a->entry_group); + } + } else { + if (a->entry_group) { + + if (avahi_entry_group_get_state(a->entry_group) == AVAHI_ENTRY_GROUP_REGISTERING) + avahi_server_decrease_host_rr_pending(m->server); + avahi_entry_group_free(a->entry_group); a->entry_group = NULL; } - } else { - if (!a->entry_group) { - a->entry_group = avahi_entry_group_new(m->server, NULL, NULL); - avahi_server_add_address(m->server, a->entry_group, a->interface->hardware->index, AF_UNSPEC, 0, NULL, &a->address); - avahi_entry_group_commit(a->entry_group); - } - } + } } -static void update_interface_rr(AvahiInterfaceMonitor *m, AvahiInterface *i, int remove) { +static void update_interface_rr(AvahiInterfaceMonitor *m, AvahiInterface *i, gboolean remove) { AvahiInterfaceAddress *a; + g_assert(m); g_assert(i); @@ -64,7 +81,7 @@ static void update_interface_rr(AvahiInterfaceMonitor *m, AvahiInterface *i, int update_address_rr(m, a, remove); } -static void update_hw_interface_rr(AvahiInterfaceMonitor *m, AvahiHwInterface *hw, int remove) { +static void update_hw_interface_rr(AvahiInterfaceMonitor *m, AvahiHwInterface *hw, gboolean remove) { AvahiInterface *i; g_assert(m); @@ -72,6 +89,40 @@ static void update_hw_interface_rr(AvahiInterfaceMonitor *m, AvahiHwInterface *h for (i = hw->interfaces; i; i = i->by_hardware_next) update_interface_rr(m, i, remove); + + if (!remove && + m->server->config.publish_workstation && + (m->server->state == AVAHI_SERVER_RUNNING || + m->server->state == AVAHI_SERVER_REGISTERING)) { + + if (!hw->entry_group) { + gchar *name; + gchar *t = avahi_format_mac_address(hw->mac_address, hw->mac_address_size); + name = g_strdup_printf("%s [%s]", m->server->host_name, t); + g_free(t); + + hw->entry_group = avahi_entry_group_new(m->server, avahi_host_rr_entry_group_callback, NULL); + if (avahi_server_add_service(m->server, hw->entry_group, hw->index, AVAHI_PROTO_UNSPEC, "_workstation._tcp", name, NULL, NULL, 9, NULL) < 0) { + avahi_log_warn(__FILE__": avahi_server_add_service() failed."); + avahi_entry_group_free(hw->entry_group); + hw->entry_group = NULL; + } else + avahi_entry_group_commit(hw->entry_group); + + g_free(name); + } + + } else { + + if (hw->entry_group) { + + if (avahi_entry_group_get_state(hw->entry_group) == AVAHI_ENTRY_GROUP_REGISTERING) + avahi_server_decrease_host_rr_pending(m->server); + + avahi_entry_group_free(hw->entry_group); + hw->entry_group = NULL; + } + } } static void free_address(AvahiInterfaceMonitor *m, AvahiInterfaceAddress *a) { @@ -79,10 +130,8 @@ static void free_address(AvahiInterfaceMonitor *m, AvahiInterfaceAddress *a) { g_assert(a); g_assert(a->interface); + update_address_rr(m, a, TRUE); AVAHI_LLIST_REMOVE(AvahiInterfaceAddress, address, a->interface->addresses, a); - - if (a->entry_group) - avahi_entry_group_free(a->entry_group); g_free(a); } @@ -91,18 +140,19 @@ static void free_interface(AvahiInterfaceMonitor *m, AvahiInterface *i, gboolean g_assert(m); g_assert(i); - g_message("removing interface %s.%i", i->hardware->name, i->protocol); avahi_goodbye_interface(m->server, i, send_goodbye); - g_message("flushing..."); - avahi_packet_scheduler_flush_responses(i->scheduler); - g_message("done"); + avahi_response_scheduler_force(i->response_scheduler); g_assert(!i->announcements); + update_interface_rr(m, i, TRUE); + while (i->addresses) free_address(m, i->addresses); - avahi_packet_scheduler_free(i->scheduler); + avahi_response_scheduler_free(i->response_scheduler); + avahi_query_scheduler_free(i->query_scheduler); + avahi_probe_scheduler_free(i->probe_scheduler); avahi_cache_free(i->cache); AVAHI_LLIST_REMOVE(AvahiInterface, interface, m->interfaces, i); @@ -115,6 +165,8 @@ static void free_hw_interface(AvahiInterfaceMonitor *m, AvahiHwInterface *hw, gb g_assert(m); g_assert(hw); + update_hw_interface_rr(m, hw, TRUE); + while (hw->interfaces) free_interface(m, hw->interfaces, send_goodbye); @@ -148,7 +200,7 @@ static int netlink_list_items(AvahiNetlink *nl, guint16 type, guint *ret_seq) { n = (struct nlmsghdr*) req; n->nlmsg_len = NLMSG_LENGTH(sizeof(struct rtgenmsg)); n->nlmsg_type = type; - n->nlmsg_flags = NLM_F_ROOT|NLM_F_MATCH|NLM_F_REQUEST; + n->nlmsg_flags = NLM_F_ROOT/*|NLM_F_MATCH*/|NLM_F_REQUEST; n->nlmsg_pid = 0; gen = NLMSG_DATA(n); @@ -158,12 +210,12 @@ static int netlink_list_items(AvahiNetlink *nl, guint16 type, guint *ret_seq) { return avahi_netlink_send(nl, n, ret_seq); } -static void new_interface(AvahiInterfaceMonitor *m, AvahiHwInterface *hw, guchar protocol) { +static void new_interface(AvahiInterfaceMonitor *m, AvahiHwInterface *hw, AvahiProtocol protocol) { AvahiInterface *i; g_assert(m); g_assert(hw); - g_assert(protocol != AF_UNSPEC); + g_assert(protocol != AVAHI_PROTO_UNSPEC); i = g_new(AvahiInterface, 1); i->monitor = m; @@ -175,7 +227,9 @@ static void new_interface(AvahiInterfaceMonitor *m, AvahiHwInterface *hw, guchar AVAHI_LLIST_HEAD_INIT(AvahiAnnouncement, i->announcements); i->cache = avahi_cache_new(m->server, i); - i->scheduler = avahi_packet_scheduler_new(m->server, i); + i->response_scheduler = avahi_response_scheduler_new(i); + i->query_scheduler = avahi_query_scheduler_new(i); + i->probe_scheduler = avahi_probe_scheduler_new(i); AVAHI_LLIST_PREPEND(AvahiInterface, by_hardware, hw->interfaces, i); AVAHI_LLIST_PREPEND(AvahiInterface, interface, m->interfaces, i); @@ -190,24 +244,29 @@ static void check_interface_relevant(AvahiInterfaceMonitor *m, AvahiInterface *i b = avahi_interface_relevant(i); if (b && !i->announcing) { - g_message("New relevant interface %s.%i", i->hardware->name, i->protocol); + avahi_log_debug("New relevant interface %s.%i (#%i)", i->hardware->name, i->protocol, i->hardware->index); - if (i->protocol == AF_INET) - avahi_mdns_mcast_join_ipv4 (i->hardware->index, m->server->fd_ipv4); - if (i->protocol == AF_INET6) - avahi_mdns_mcast_join_ipv6 (i->hardware->index, m->server->fd_ipv6); + if (i->protocol == AVAHI_PROTO_INET) + avahi_mdns_mcast_join_ipv4(i->hardware->index, m->server->fd_ipv4); + if (i->protocol == AVAHI_PROTO_INET6) + avahi_mdns_mcast_join_ipv6(i->hardware->index, m->server->fd_ipv6); i->announcing = TRUE; avahi_announce_interface(m->server, i); + avahi_browser_new_interface(m->server, i); } else if (!b && i->announcing) { - g_message("Interface %s.%i no longer relevant", i->hardware->name, i->protocol); + avahi_log_debug("Interface %s.%i no longer relevant", i->hardware->name, i->protocol); - avahi_goodbye_interface(m->server, i, FALSE); + if (i->protocol == AVAHI_PROTO_INET) + avahi_mdns_mcast_leave_ipv4(i->hardware->index, m->server->fd_ipv4); + if (i->protocol == AVAHI_PROTO_INET6) + avahi_mdns_mcast_leave_ipv6(i->hardware->index, m->server->fd_ipv6); - if (i->protocol == AF_INET) - avahi_mdns_mcast_leave_ipv4 (i->hardware->index, m->server->fd_ipv4); - if (i->protocol == AF_INET6) - avahi_mdns_mcast_leave_ipv6 (i->hardware->index, m->server->fd_ipv6); + avahi_goodbye_interface(m->server, i, FALSE); + avahi_response_scheduler_clear(i->response_scheduler); + avahi_query_scheduler_clear(i->query_scheduler); + avahi_probe_scheduler_clear(i->probe_scheduler); + avahi_cache_flush(i->cache); i->announcing = FALSE; } @@ -246,6 +305,8 @@ static void callback(AvahiNetlink *nl, struct nlmsghdr *n, gpointer userdata) { hw->flags = 0; hw->mtu = 1500; hw->index = ifinfomsg->ifi_index; + hw->mac_address_size = 0; + hw->entry_group = NULL; AVAHI_LLIST_HEAD_INIT(AvahiInterface, hw->interfaces); AVAHI_LLIST_PREPEND(AvahiHwInterface, hardware, m->hw_interfaces, hw); @@ -253,9 +314,9 @@ static void callback(AvahiNetlink *nl, struct nlmsghdr *n, gpointer userdata) { g_hash_table_insert(m->hash_table, &hw->index, hw); if (m->server->fd_ipv4 >= 0) - new_interface(m, hw, AF_INET); + new_interface(m, hw, AVAHI_PROTO_INET); if (m->server->fd_ipv6 >= 0) - new_interface(m, hw, AF_INET6); + new_interface(m, hw, AVAHI_PROTO_INET6); } hw->flags = ifinfomsg->ifi_flags; @@ -274,6 +335,15 @@ static void callback(AvahiNetlink *nl, struct nlmsghdr *n, gpointer userdata) { g_assert(RTA_PAYLOAD(a) == sizeof(unsigned int)); hw->mtu = *((unsigned int*) RTA_DATA(a)); break; + + case IFLA_ADDRESS: { + hw->mac_address_size = RTA_PAYLOAD(a); + if (hw->mac_address_size > AVAHI_MAX_MAC_ADDRESS) + hw->mac_address_size = AVAHI_MAX_MAC_ADDRESS; + + memcpy(hw->mac_address, RTA_DATA(a), hw->mac_address_size); + break; + } default: ; @@ -305,9 +375,9 @@ static void callback(AvahiNetlink *nl, struct nlmsghdr *n, gpointer userdata) { struct rtattr *a = NULL; size_t l; AvahiAddress raddr; - int raddr_valid = 0; + gboolean raddr_valid = FALSE; - if (ifaddrmsg->ifa_family != AF_INET && ifaddrmsg->ifa_family != AF_INET6) + if (ifaddrmsg->ifa_family != AVAHI_PROTO_INET && ifaddrmsg->ifa_family != AVAHI_PROTO_INET6) return; if (!(i = (AvahiInterface*) avahi_interface_monitor_get_interface(m, ifaddrmsg->ifa_index, ifaddrmsg->ifa_family))) @@ -315,28 +385,28 @@ static void callback(AvahiNetlink *nl, struct nlmsghdr *n, gpointer userdata) { raddr.family = ifaddrmsg->ifa_family; - l = NLMSG_PAYLOAD(n, sizeof(struct ifinfomsg)); + l = NLMSG_PAYLOAD(n, sizeof(struct ifaddrmsg)); a = IFA_RTA(ifaddrmsg); while (RTA_OK(a, l)) { + switch(a->rta_type) { case IFA_ADDRESS: - if ((raddr.family == AF_INET6 && RTA_PAYLOAD(a) != 16) || - (raddr.family == AF_INET && RTA_PAYLOAD(a) != 4)) + if ((raddr.family == AVAHI_PROTO_INET6 && RTA_PAYLOAD(a) != 16) || + (raddr.family == AVAHI_PROTO_INET && RTA_PAYLOAD(a) != 4)) return; memcpy(raddr.data.data, RTA_DATA(a), RTA_PAYLOAD(a)); - raddr_valid = 1; + raddr_valid = TRUE; break; - + default: ; } a = RTA_NEXT(a, l); } - if (!raddr_valid) return; @@ -356,6 +426,7 @@ static void callback(AvahiNetlink *nl, struct nlmsghdr *n, gpointer userdata) { addr->flags = ifaddrmsg->ifa_flags; addr->scope = ifaddrmsg->ifa_scope; + addr->prefix_len = ifaddrmsg->ifa_prefixlen; update_address_rr(m, addr, FALSE); check_interface_relevant(m, i); @@ -377,19 +448,19 @@ static void callback(AvahiNetlink *nl, struct nlmsghdr *n, gpointer userdata) { m->list = LIST_DONE; if (netlink_list_items(m->netlink, RTM_GETADDR, &m->query_addr_seq) < 0) - g_warning("NETLINK: Failed to list addrs: %s", strerror(errno)); + avahi_log_warn("NETLINK: Failed to list addrs: %s", strerror(errno)); else m->list = LIST_ADDR; } else { m->list = LIST_DONE; - g_message("Enumeration complete"); + avahi_log_debug("Enumeration complete"); } } else if (n->nlmsg_type == NLMSG_ERROR && (n->nlmsg_seq == m->query_link_seq || n->nlmsg_seq == m->query_addr_seq)) { struct nlmsgerr *e = NLMSG_DATA (n); if (e->error) - g_warning("NETLINK: Failed to browse: %s", strerror(-e->error)); + avahi_log_warn("NETLINK: Failed to browse: %s", strerror(-e->error)); } } @@ -446,13 +517,13 @@ void avahi_interface_monitor_free(AvahiInterfaceMonitor *m) { } -AvahiInterface* avahi_interface_monitor_get_interface(AvahiInterfaceMonitor *m, gint index, guchar protocol) { +AvahiInterface* avahi_interface_monitor_get_interface(AvahiInterfaceMonitor *m, AvahiIfIndex index, AvahiProtocol protocol) { AvahiHwInterface *hw; AvahiInterface *i; g_assert(m); g_assert(index > 0); - g_assert(protocol != AF_UNSPEC); + g_assert(protocol != AVAHI_PROTO_UNSPEC); if (!(hw = avahi_interface_monitor_get_hw_interface(m, index))) return NULL; @@ -464,7 +535,7 @@ AvahiInterface* avahi_interface_monitor_get_interface(AvahiInterfaceMonitor *m, return NULL; } -AvahiHwInterface* avahi_interface_monitor_get_hw_interface(AvahiInterfaceMonitor *m, gint index) { +AvahiHwInterface* avahi_interface_monitor_get_hw_interface(AvahiInterfaceMonitor *m, AvahiIfIndex index) { g_assert(m); g_assert(index > 0); @@ -472,43 +543,62 @@ AvahiHwInterface* avahi_interface_monitor_get_hw_interface(AvahiInterfaceMonitor } -void avahi_interface_send_packet(AvahiInterface *i, AvahiDnsPacket *p) { +void avahi_interface_send_packet_unicast(AvahiInterface *i, AvahiDnsPacket *p, const AvahiAddress *a, guint16 port) { g_assert(i); g_assert(p); +/* char t[64]; */ - if (avahi_interface_relevant(i)) { - g_message("sending on '%s.%i'", i->hardware->name, i->protocol); + if (!avahi_interface_relevant(i)) + return; + + g_assert(!a || a->family == i->protocol); - if (i->protocol == AF_INET && i->monitor->server->fd_ipv4 >= 0) - avahi_send_dns_packet_ipv4(i->monitor->server->fd_ipv4, i->hardware->index, p); - else if (i->protocol == AF_INET6 && i->monitor->server->fd_ipv6 >= 0) - avahi_send_dns_packet_ipv6(i->monitor->server->fd_ipv6, i->hardware->index, p); - } +/* if (a) */ +/* avahi_log_debug("unicast sending on '%s.%i' to %s:%u", i->hardware->name, i->protocol, avahi_address_snprint(t, sizeof(t), a), port); */ +/* else */ +/* avahi_log_debug("multicast sending on '%s.%i'", i->hardware->name, i->protocol); */ + + if (i->protocol == AVAHI_PROTO_INET && i->monitor->server->fd_ipv4 >= 0) + avahi_send_dns_packet_ipv4(i->monitor->server->fd_ipv4, i->hardware->index, p, a ? &a->data.ipv4 : NULL, port); + else if (i->protocol == AVAHI_PROTO_INET6 && i->monitor->server->fd_ipv6 >= 0) + avahi_send_dns_packet_ipv6(i->monitor->server->fd_ipv6, i->hardware->index, p, a ? &a->data.ipv6 : NULL, port); +} + +void avahi_interface_send_packet(AvahiInterface *i, AvahiDnsPacket *p) { + g_assert(i); + g_assert(p); + + avahi_interface_send_packet_unicast(i, p, NULL, 0); } -void avahi_interface_post_query(AvahiInterface *i, AvahiKey *key, gboolean immediately) { +gboolean avahi_interface_post_query(AvahiInterface *i, AvahiKey *key, gboolean immediately) { g_assert(i); g_assert(key); if (avahi_interface_relevant(i)) - avahi_packet_scheduler_post_query(i->scheduler, key, immediately); -} + return avahi_query_scheduler_post(i->query_scheduler, key, immediately); + return FALSE; +} -void avahi_interface_post_response(AvahiInterface *i, const AvahiAddress *a, AvahiRecord *record, gboolean flush_cache, gboolean immediately) { +gboolean avahi_interface_post_response(AvahiInterface *i, AvahiRecord *record, gboolean flush_cache, const AvahiAddress *querier, gboolean immediately) { g_assert(i); g_assert(record); if (avahi_interface_relevant(i)) - avahi_packet_scheduler_post_response(i->scheduler, a, record, flush_cache, immediately); + return avahi_response_scheduler_post(i->response_scheduler, record, flush_cache, querier, immediately); + + return FALSE; } -void avahi_interface_post_probe(AvahiInterface *i, AvahiRecord *record, gboolean immediately) { +gboolean avahi_interface_post_probe(AvahiInterface *i, AvahiRecord *record, gboolean immediately) { g_assert(i); g_assert(record); if (avahi_interface_relevant(i)) - avahi_packet_scheduler_post_probe(i->scheduler, record, immediately); + return avahi_probe_scheduler_post(i->probe_scheduler, record, immediately); + + return FALSE; } void avahi_dump_caches(AvahiInterfaceMonitor *m, FILE *f) { @@ -525,14 +615,33 @@ void avahi_dump_caches(AvahiInterfaceMonitor *m, FILE *f) { } gboolean avahi_interface_relevant(AvahiInterface *i) { + AvahiInterfaceAddress *a; + gboolean relevant_address; + g_assert(i); + relevant_address = FALSE; + + for (a = i->addresses; a; a = a->address_next) + if (avahi_interface_address_relevant(a)) { + relevant_address = TRUE; + break; + } + +/* avahi_log_debug("%p. iface-relevant: %i %i %i %i %i %i", i, relevant_address, */ +/* (i->hardware->flags & IFF_UP), */ +/* (i->hardware->flags & IFF_RUNNING), */ +/* !(i->hardware->flags & IFF_LOOPBACK), */ +/* (i->hardware->flags & IFF_MULTICAST), */ +/* !(i->hardware->flags & IFF_POINTOPOINT)); */ + return (i->hardware->flags & IFF_UP) && - (i->hardware->flags & IFF_RUNNING) && + (!i->monitor->server->config.use_iff_running || (i->hardware->flags & IFF_RUNNING)) && !(i->hardware->flags & IFF_LOOPBACK) && (i->hardware->flags & IFF_MULTICAST) && - i->addresses; + !(i->hardware->flags & IFF_POINTOPOINT) && + relevant_address; } gboolean avahi_interface_address_relevant(AvahiInterfaceAddress *a) { @@ -542,25 +651,24 @@ gboolean avahi_interface_address_relevant(AvahiInterfaceAddress *a) { } -gboolean avahi_interface_match(AvahiInterface *i, gint index, guchar protocol) { +gboolean avahi_interface_match(AvahiInterface *i, AvahiIfIndex index, AvahiProtocol protocol) { g_assert(i); if (index > 0 && index != i->hardware->index) return FALSE; - if (protocol != AF_UNSPEC && protocol != i->protocol) + if (protocol != AVAHI_PROTO_UNSPEC && protocol != i->protocol) return FALSE; return TRUE; } - -void avahi_interface_monitor_walk(AvahiInterfaceMonitor *m, gint interface, guchar protocol, AvahiInterfaceMonitorWalkCallback callback, gpointer userdata) { +void avahi_interface_monitor_walk(AvahiInterfaceMonitor *m, AvahiIfIndex interface, AvahiProtocol protocol, AvahiInterfaceMonitorWalkCallback callback, gpointer userdata) { g_assert(m); g_assert(callback); if (interface > 0) { - if (protocol != AF_UNSPEC) { + if (protocol != AVAHI_PROTO_UNSPEC) { AvahiInterface *i; if ((i = avahi_interface_monitor_get_interface(m, interface, protocol))) @@ -584,3 +692,74 @@ void avahi_interface_monitor_walk(AvahiInterfaceMonitor *m, gint interface, guch callback(m, i, userdata); } } + +void avahi_update_host_rrs(AvahiInterfaceMonitor *m, gboolean remove) { + AvahiHwInterface *hw; + + g_assert(m); + + for (hw = m->hw_interfaces; hw; hw = hw->hardware_next) + update_hw_interface_rr(m, hw, remove); +} + +gboolean avahi_address_is_local(AvahiInterfaceMonitor *m, const AvahiAddress *a) { + AvahiInterface *i; + AvahiInterfaceAddress *ia; + g_assert(m); + g_assert(a); + + for (i = m->interfaces; i; i = i->interface_next) + for (ia = i->addresses; ia; ia = ia->address_next) + if (avahi_address_cmp(a, &ia->address) == 0) + return TRUE; + + return FALSE; +} + +gboolean avahi_interface_address_on_link(AvahiInterface *i, const AvahiAddress *a) { + AvahiInterfaceAddress *ia; + + g_assert(i); + g_assert(a); + + if (a->family != i->protocol) + return FALSE; + + for (ia = i->addresses; ia; ia = ia->address_next) { + + if (a->family == AVAHI_PROTO_INET) { + guint32 m; + + m = ~(((guint32) -1) >> ia->prefix_len); + + if ((g_ntohl(a->data.ipv4.address) & m) == (g_ntohl(ia->address.data.ipv4.address) & m)) + return TRUE; + } else { + guint i; + guchar pl; + g_assert(a->family == AVAHI_PROTO_INET6); + + pl = ia->prefix_len; + + for (i = 0; i < 16; i++) { + guint8 m; + + if (pl == 0) + return TRUE; + + if (pl >= 8) { + m = 0xFF; + pl -= 8; + } else { + m = ~(0xFF >> pl); + pl = 0; + } + + if ((a->data.ipv6.address[i] & m) != (ia->address.data.ipv6.address[i] & m)) + break; + } + } + } + + return FALSE; +}