X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;f=avahi-compat-libdns_sd%2Fwarn.c;h=13586ef31fa60d317ce4b5395e47627d96ff0889;hb=fc3830c24fd0341d762a2c4f05198f27fc3ccac0;hp=1bdafd00c7b8cdbbbc5a436527e4a19fc71c8828;hpb=2d6a80b9c57b32e5202c91b2239374555a098997;p=catta

diff --git a/avahi-compat-libdns_sd/warn.c b/avahi-compat-libdns_sd/warn.c
index 1bdafd0..13586ef 100644
--- a/avahi-compat-libdns_sd/warn.c
+++ b/avahi-compat-libdns_sd/warn.c
@@ -37,49 +37,71 @@
 
 #ifndef COMPAT_LAYER
 #define COMPAT_LAYER "Apple Bonjour"
-#endif 
+#endif
+
+#ifndef CGI_SUBSYSTEM
+#define CGI_SUBSYSTEM "libdns_sd"
+#endif
 
 static pthread_mutex_t linkage_mutex = PTHREAD_MUTEX_INITIALIZER;
 static int linkage_warning = 0;
 
-static void get_exe_name(char *t, size_t l) {
-    int k;
-    char fn[1024];
+const char *avahi_exe_name(void) {
+#ifdef HAVE_GETPROGNAME
+    return getprogname();
+#elif defined(__linux__)
+    static char exe_name[1024] = "";
+    static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
 
-    /* Yes, I know, this is not portable. But who cares? It's
-     * for cosmetics only, anyway. */
+    /* Yes, I know, this is not portable. But who cares? It's for
+     * cosmetics only, anyway. */
     
-    snprintf(fn, sizeof(fn), "/proc/%lu/exe", (unsigned long) getpid());
-
-    if ((k = readlink(fn, t, l-1)) < 0)
-        snprintf(t, l, "(unknown)");
-    else {
-        char *slash;
-
-        assert((size_t) k <= l-1);
-        t[k] = 0;
-
-        if ((slash = strrchr(t, '/')))
-            memmove(t, slash+1, strlen(slash)+1);
+    pthread_mutex_lock(&mutex);
+
+    if (exe_name[0] == 0) {
+        int k;
+        
+        if ((k = readlink("/proc/self/exe", exe_name, sizeof(exe_name)-1)) < 0)
+            snprintf(exe_name, sizeof(exe_name), "(unknown)");
+        else {
+            char *slash;
+            
+            assert((size_t) k <= sizeof(exe_name)-1);
+            exe_name[k] = 0;
+            
+            if ((slash = strrchr(exe_name, '/')))
+                memmove(exe_name, slash+1, strlen(slash)+1);
+        }
     }
+    
+    pthread_mutex_unlock(&mutex);
+
+    return exe_name;
+#else
+#ifdef __GNUC__
+#warning "avahi_exe_name() needs to be implemented for your operating system"
+#endif
+    return "(unknown)";
+#endif
 }
 
-static void warning(const char *ident, const char *fmt, ...) {
-    va_list ap, ap2;
+void avahi_warn(const char *fmt, ...) {
+    char msg[512]  = "*** WARNING *** ";
+    va_list ap;
+    size_t n;
     
-    assert(ident);
     assert(fmt);
-
+                
     va_start(ap, fmt);
-    va_copy(ap2, ap);
-    
-    vfprintf(stderr, fmt, ap);
+    n = strlen(msg);
+    vsnprintf(msg + n, sizeof(msg) - n, fmt, ap);
     va_end(ap);
+    
+    fprintf(stderr, "%s\n", msg);
 
-    openlog(ident, LOG_PID, LOG_USER);
-    vsyslog(LOG_WARNING, fmt, ap2);
+    openlog(avahi_exe_name(), LOG_PID, LOG_USER);
+    syslog(LOG_WARNING, "%s", msg);
     closelog();
-    va_end(ap2);
 }
 
 void avahi_warn_linkage(void) {
@@ -91,20 +113,14 @@ void avahi_warn_linkage(void) {
     pthread_mutex_unlock(&linkage_mutex);
 
     if (!w && !getenv("AVAHI_COMPAT_NOWARN")) {
-        char exename[256];
-
-        get_exe_name(exename, sizeof(exename));
-
-        warning(exename, "*** WARNING: The application '%s' uses the "COMPAT_LAYER" compatiblity layer of Avahi. Please fix your application to use the native API of Avahi! ***\n", exename);
+        avahi_warn("The programme '%s' uses the "COMPAT_LAYER" compatiblity layer of Avahi.", avahi_exe_name());
+        avahi_warn("Please fix your application to use the native API of Avahi!");
+        avahi_warn("For more information see <http://0pointer.de/avahi-compat?s="CGI_SUBSYSTEM"&e=%s>", avahi_exe_name());
     }
 }
 
 void avahi_warn_unsupported(const char *function) {
-    char exename[256];
-    get_exe_name(exename, sizeof(exename));
-
-    warning(exename, "*** WARNING: The application '%s' called '%s()' which is not supported (or only supported partially) in the "COMPAT_LAYER" compatiblity layer of Avahi. Please fix your application to use the native API of Avahi! ***\n", exename, function);
+    avahi_warn("The programme '%s' called '%s()' which is not supported (or only supported partially) in the "COMPAT_LAYER" compatiblity layer of Avahi.", avahi_exe_name(), function);
+    avahi_warn("Please fix your application to use the native API of Avahi!");
+    avahi_warn("For more information see <http://0pointer.de/avahi-compat?s="CGI_SUBSYSTEM"&e=%s&f=%s>", avahi_exe_name(), function);
 }
-
-
-