X-Git-Url: http://git.meshlink.io/?a=blobdiff_plain;ds=sidebyside;f=src%2Fnet_setup.c;h=2cc7ddf55a46c5555cd5a93ba0ecf54e1e214705;hb=a7ebfcff0fe55596cb18a3cb488d14c73aacbe5f;hp=a667a67668f2ddb2f83db96661cf14c513374e5b;hpb=ab7c61b06f6c6e991225f2fcc32d02b8e1084aee;p=meshlink diff --git a/src/net_setup.c b/src/net_setup.c index a667a676..2cc7ddf5 100644 --- a/src/net_setup.c +++ b/src/net_setup.c @@ -1,7 +1,6 @@ /* net_setup.c -- Setup. - Copyright (C) 1998-2005 Ivo Timmermans, - 2000-2009 Guus Sliepen + Copyright (C) 2014 Guus Sliepen This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -20,403 +19,329 @@ #include "system.h" -#include -#include -#include -#include -#include - -#include "avl_tree.h" +#include "cipher.h" #include "conf.h" #include "connection.h" -#include "device.h" -#include "event.h" +#include "digest.h" +#include "ecdsa.h" #include "graph.h" #include "logger.h" #include "net.h" #include "netutl.h" -#include "process.h" #include "protocol.h" #include "route.h" -#include "subnet.h" #include "utils.h" #include "xalloc.h" char *myport; -bool read_rsa_public_key(connection_t *c) -{ - FILE *fp; - char *fname; - char *key; +char *proxyhost; +char *proxyport; +char *proxyuser; +char *proxypass; +proxytype_t proxytype; +int autoconnect; +bool disablebuggypeers; - cp(); +bool node_read_ecdsa_public_key(node_t *n) { + if(ecdsa_active(n->ecdsa)) + return true; - if(!c->rsa_key) { - c->rsa_key = RSA_new(); -// RSA_blinding_on(c->rsa_key, NULL); - } + splay_tree_t *config_tree; + char *p; - /* First, check for simple PublicKey statement */ + init_configuration(&config_tree); + if(!read_host_config(config_tree, n->name)) + goto exit; - if(get_config_string(lookup_config(c->config_tree, "PublicKey"), &key)) { - BN_hex2bn(&c->rsa_key->n, key); - BN_hex2bn(&c->rsa_key->e, "FFFF"); - free(key); - return true; + /* First, check for simple ECDSAPublicKey statement */ + + if(get_config_string(lookup_config(config_tree, "ECDSAPublicKey"), &p)) { + n->ecdsa = ecdsa_set_base64_public_key(p); + free(p); } - /* Else, check for PublicKeyFile statement and read it */ +exit: + exit_configuration(&config_tree); + return n->ecdsa; +} - if(get_config_string(lookup_config(c->config_tree, "PublicKeyFile"), &fname)) { - fp = fopen(fname, "r"); +bool read_ecdsa_public_key(connection_t *c) { + if(ecdsa_active(c->ecdsa)) + return true; - if(!fp) { - logger(LOG_ERR, _("Error reading RSA public key file `%s': %s"), - fname, strerror(errno)); - free(fname); - return false; - } + char *p; - free(fname); - c->rsa_key = PEM_read_RSAPublicKey(fp, &c->rsa_key, NULL, NULL); - fclose(fp); + if(!c->config_tree) { + init_configuration(&c->config_tree); + if(!read_host_config(c->config_tree, c->name)) + return false; + } - if(c->rsa_key) - return true; /* Woohoo. */ + /* First, check for simple ECDSAPublicKey statement */ - /* If it fails, try PEM_read_RSA_PUBKEY. */ - fp = fopen(fname, "r"); + if(get_config_string(lookup_config(c->config_tree, "ECDSAPublicKey"), &p)) { + c->ecdsa = ecdsa_set_base64_public_key(p); + free(p); + return c->ecdsa; + } - if(!fp) { - logger(LOG_ERR, _("Error reading RSA public key file `%s': %s"), - fname, strerror(errno)); - free(fname); - return false; - } + return false; +} - free(fname); - c->rsa_key = PEM_read_RSA_PUBKEY(fp, &c->rsa_key, NULL, NULL); - fclose(fp); +static bool read_ecdsa_private_key(void) { + FILE *fp; + char *fname; - if(c->rsa_key) { -// RSA_blinding_on(c->rsa_key, NULL); - return true; - } + xasprintf(&fname, "%s" SLASH "ecdsa_key.priv", confbase); + fp = fopen(fname, "r"); + free(fname); - logger(LOG_ERR, _("Reading RSA public key file `%s' failed: %s"), - fname, strerror(errno)); + if(!fp) { + logger(DEBUG_ALWAYS, LOG_ERR, "Error reading ECDSA private key file: %s", strerror(errno)); return false; } - /* Else, check if a harnessed public key is in the config file */ + myself->connection->ecdsa = ecdsa_read_pem_private_key(fp); + fclose(fp); - xasprintf(&fname, "%s/hosts/%s", confbase, c->name); - fp = fopen(fname, "r"); + if(!myself->connection->ecdsa) + logger(DEBUG_ALWAYS, LOG_ERR, "Reading ECDSA private key file failed: %s", strerror(errno)); - if(fp) { - c->rsa_key = PEM_read_RSAPublicKey(fp, &c->rsa_key, NULL, NULL); - fclose(fp); - } + return myself->connection->ecdsa; +} - free(fname); +static bool read_invitation_key(void) { + FILE *fp; + char *fname; - if(c->rsa_key) - return true; + if(invitation_key) { + ecdsa_free(invitation_key); + invitation_key = NULL; + } - /* Try again with PEM_read_RSA_PUBKEY. */ + xasprintf(&fname, "%s" SLASH "invitations" SLASH "ecdsa_key.priv", confbase); - xasprintf(&fname, "%s/hosts/%s", confbase, c->name); fp = fopen(fname, "r"); if(fp) { - c->rsa_key = PEM_read_RSA_PUBKEY(fp, &c->rsa_key, NULL, NULL); -// RSA_blinding_on(c->rsa_key, NULL); + invitation_key = ecdsa_read_pem_private_key(fp); fclose(fp); + if(!invitation_key) + logger(DEBUG_ALWAYS, LOG_ERR, "Reading ECDSA private key file `%s' failed: %s", fname, strerror(errno)); } free(fname); - - if(c->rsa_key) - return true; - - logger(LOG_ERR, _("No public key for %s specified!"), c->name); - - return false; + return invitation_key; } -bool read_rsa_private_key(void) -{ - FILE *fp; - char *fname, *key, *pubkey; - struct stat s; - - cp(); +static timeout_t keyexpire_timeout; - if(get_config_string(lookup_config(config_tree, "PrivateKey"), &key)) { - if(!get_config_string(lookup_config(myself->connection->config_tree, "PublicKey"), &pubkey)) { - logger(LOG_ERR, _("PrivateKey used but no PublicKey found!")); - return false; - } - myself->connection->rsa_key = RSA_new(); -// RSA_blinding_on(myself->connection->rsa_key, NULL); - BN_hex2bn(&myself->connection->rsa_key->d, key); - BN_hex2bn(&myself->connection->rsa_key->n, pubkey); - BN_hex2bn(&myself->connection->rsa_key->e, "FFFF"); - free(key); - free(pubkey); - return true; - } - - if(!get_config_string(lookup_config(config_tree, "PrivateKeyFile"), &fname)) - xasprintf(&fname, "%s/rsa_key.priv", confbase); - - fp = fopen(fname, "r"); +static void keyexpire_handler(void *data) { + regenerate_key(); + timeout_set(data, &(struct timeval){keylifetime, rand() % 100000}); +} - if(!fp) { - logger(LOG_ERR, _("Error reading RSA private key file `%s': %s"), - fname, strerror(errno)); - free(fname); - return false; - } +void regenerate_key(void) { + logger(DEBUG_STATUS, LOG_INFO, "Expiring symmetric keys"); + send_key_changed(); +} -#if !defined(HAVE_MINGW) && !defined(HAVE_CYGWIN) - if(fstat(fileno(fp), &s)) { - logger(LOG_ERR, _("Could not stat RSA private key file `%s': %s'"), - fname, strerror(errno)); - free(fname); - return false; +void load_all_nodes(void) { + DIR *dir; + struct dirent *ent; + char *dname; + + xasprintf(&dname, "%s" SLASH "hosts", confbase); + dir = opendir(dname); + if(!dir) { + logger(DEBUG_ALWAYS, LOG_ERR, "Could not open %s: %s", dname, strerror(errno)); + free(dname); + return; } - if(s.st_mode & ~0100700) - logger(LOG_WARNING, _("Warning: insecure file permissions for RSA private key file `%s'!"), fname); -#endif + while((ent = readdir(dir))) { + if(!check_id(ent->d_name)) + continue; - myself->connection->rsa_key = PEM_read_RSAPrivateKey(fp, NULL, NULL, NULL); - fclose(fp); + node_t *n = lookup_node(ent->d_name); + if(n) + continue; - if(!myself->connection->rsa_key) { - logger(LOG_ERR, _("Reading RSA private key file `%s' failed: %s"), - fname, strerror(errno)); - free(fname); - return false; + n = new_node(); + n->name = xstrdup(ent->d_name); + node_add(n); } - free(fname); - return true; + closedir(dir); } -/* - Configure node_t myself and set up the local sockets (listen only) -*/ -bool setup_myself(void) -{ - config_t *cfg; - subnet_t *subnet; - char *name, *hostname, *mode, *afname, *cipher, *digest; - char *address = NULL; - char *envp[5]; - struct addrinfo *ai, *aip, hint = {0}; - bool choice; - int i, err; - cp(); +char *get_name(void) { + char *name = NULL; - myself = new_node(); - myself->connection = new_connection(); - init_configuration(&myself->connection->config_tree); + get_config_string(lookup_config(config_tree, "Name"), &name); - xasprintf(&myself->hostname, _("MYSELF")); - xasprintf(&myself->connection->hostname, _("MYSELF")); - - myself->connection->options = 0; - myself->connection->protocol_version = PROT_CURRENT; - - if(!get_config_string(lookup_config(config_tree, "Name"), &name)) { /* Not acceptable */ - logger(LOG_ERR, _("Name for tinc daemon required!")); - return false; - } + if(!name) + return NULL; if(!check_id(name)) { - logger(LOG_ERR, _("Invalid name for myself!")); + logger(DEBUG_ALWAYS, LOG_ERR, "Invalid name for myself!"); free(name); - return false; - } - - myself->name = name; - myself->connection->name = xstrdup(name); - - if(!read_connection_config(myself->connection)) { - logger(LOG_ERR, _("Cannot open host configuration file for myself!")); - return false; + return NULL; } - if(!read_rsa_private_key()) - return false; - - if(!get_config_string(lookup_config(myself->connection->config_tree, "Port"), &myport)) - xasprintf(&myport, "655"); + return name; +} - /* Read in all the subnets specified in the host configuration file */ +bool setup_myself_reloadable(void) { + localdiscovery = true; + keylifetime = 3600; // TODO: check if this can be removed as well + maxtimeout = 900; + autoconnect = 3; + myself->options |= OPTION_PMTU_DISCOVERY; - cfg = lookup_config(myself->connection->config_tree, "Subnet"); + read_invitation_key(); - while(cfg) { - if(!get_config_subnet(cfg, &subnet)) - return false; + return true; +} - subnet_add(myself, subnet); +/* + Add listening sockets. +*/ +static bool add_listen_address(char *address, bool bindto) { + char *port = myport; + + if(address) { + char *space = strchr(address, ' '); + if(space) { + *space++ = 0; + port = space; + } - cfg = lookup_config_next(myself->connection->config_tree, cfg); + if(!strcmp(address, "*")) + *address = 0; } - /* Check some options */ - - if(get_config_bool(lookup_config(config_tree, "IndirectData"), &choice) && choice) - myself->options |= OPTION_INDIRECT; + struct addrinfo *ai, hint = {0}; + hint.ai_family = addressfamily; + hint.ai_socktype = SOCK_STREAM; + hint.ai_protocol = IPPROTO_TCP; + hint.ai_flags = AI_PASSIVE; - if(get_config_bool(lookup_config(config_tree, "TCPOnly"), &choice) && choice) - myself->options |= OPTION_TCPONLY; + int err = getaddrinfo(address && *address ? address : NULL, port, &hint, &ai); + free(address); - if(get_config_bool(lookup_config(myself->connection->config_tree, "IndirectData"), &choice) && choice) - myself->options |= OPTION_INDIRECT; + if(err || !ai) { + logger(DEBUG_ALWAYS, LOG_ERR, "System call `%s' failed: %s", "getaddrinfo", err == EAI_SYSTEM ? strerror(err) : gai_strerror(err)); + return false; + } - if(get_config_bool(lookup_config(myself->connection->config_tree, "TCPOnly"), &choice) && choice) - myself->options |= OPTION_TCPONLY; + for(struct addrinfo *aip = ai; aip; aip = aip->ai_next) { + // Ignore duplicate addresses + bool found = false; - if(myself->options & OPTION_TCPONLY) - myself->options |= OPTION_INDIRECT; + for(int i = 0; i < listen_sockets; i++) + if(!memcmp(&listen_socket[i].sa, aip->ai_addr, aip->ai_addrlen)) { + found = true; + break; + } - get_config_bool(lookup_config(config_tree, "TunnelServer"), &tunnelserver); + if(found) + continue; - if(get_config_string(lookup_config(config_tree, "Mode"), &mode)) { - if(!strcasecmp(mode, "router")) - routing_mode = RMODE_ROUTER; - else if(!strcasecmp(mode, "switch")) - routing_mode = RMODE_SWITCH; - else if(!strcasecmp(mode, "hub")) - routing_mode = RMODE_HUB; - else { - logger(LOG_ERR, _("Invalid routing mode!")); + if(listen_sockets >= MAXSOCKETS) { + logger(DEBUG_ALWAYS, LOG_ERR, "Too many listening sockets"); return false; } - free(mode); - } else - routing_mode = RMODE_ROUTER; - // Enable PMTUDiscovery by default if we are in router mode. + int tcp_fd = setup_listen_socket((sockaddr_t *) aip->ai_addr); - choice = routing_mode == RMODE_ROUTER; - get_config_bool(lookup_config(myself->connection->config_tree, "PMTUDiscovery"), &choice); - if(choice) - myself->options |= OPTION_PMTU_DISCOVERY; + if(tcp_fd < 0) + continue; - get_config_bool(lookup_config(config_tree, "PriorityInheritance"), &priorityinheritance); + int udp_fd = setup_vpn_in_socket((sockaddr_t *) aip->ai_addr); -#if !defined(SOL_IP) || !defined(IP_TOS) - if(priorityinheritance) - logger(LOG_WARNING, _("%s not supported on this platform"), "PriorityInheritance"); -#endif + if(tcp_fd < 0) { + close(tcp_fd); + continue; + } - if(!get_config_int(lookup_config(config_tree, "MACExpire"), &macexpire)) - macexpire = 600; + io_add(&listen_socket[listen_sockets].tcp, handle_new_meta_connection, &listen_socket[listen_sockets], tcp_fd, IO_READ); + io_add(&listen_socket[listen_sockets].udp, handle_incoming_vpn_data, &listen_socket[listen_sockets], udp_fd, IO_READ); - if(get_config_int(lookup_config(config_tree, "MaxTimeout"), &maxtimeout)) { - if(maxtimeout <= 0) { - logger(LOG_ERR, _("Bogus maximum timeout!")); - return false; - } - } else - maxtimeout = 900; - - if(get_config_string(lookup_config(config_tree, "AddressFamily"), &afname)) { - if(!strcasecmp(afname, "IPv4")) - addressfamily = AF_INET; - else if(!strcasecmp(afname, "IPv6")) - addressfamily = AF_INET6; - else if(!strcasecmp(afname, "any")) - addressfamily = AF_UNSPEC; - else { - logger(LOG_ERR, _("Invalid address family!")); - return false; + if(debug_level >= DEBUG_CONNECTIONS) { + char *hostname = sockaddr2hostname((sockaddr_t *) aip->ai_addr); + logger(DEBUG_CONNECTIONS, LOG_NOTICE, "Listening on %s", hostname); + free(hostname); } - free(afname); + + listen_socket[listen_sockets].bindto = bindto; + memcpy(&listen_socket[listen_sockets].sa, aip->ai_addr, aip->ai_addrlen); + listen_sockets++; } - get_config_bool(lookup_config(config_tree, "Hostnames"), &hostnames); + freeaddrinfo(ai); + return true; +} - /* Generate packet encryption key */ +/* + Configure node_t myself and set up the local sockets (listen only) +*/ +bool setup_myself(void) { + char *name, *hostname, *cipher, *digest, *type; + char *address = NULL; + bool port_specified = false; - if(get_config_string - (lookup_config(myself->connection->config_tree, "Cipher"), &cipher)) { - if(!strcasecmp(cipher, "none")) { - myself->incipher = NULL; - } else { - myself->incipher = EVP_get_cipherbyname(cipher); + if(!(name = get_name())) { + logger(DEBUG_ALWAYS, LOG_ERR, "Name for tinc daemon required!"); + return false; + } - if(!myself->incipher) { - logger(LOG_ERR, _("Unrecognized cipher type!")); - return false; - } - } - } else - myself->incipher = EVP_aes_256_cbc(); + myself = new_node(); + myself->connection = new_connection(); + myself->name = name; + myself->connection->name = xstrdup(name); + read_host_config(config_tree, name); - if(myself->incipher) - myself->inkeylength = myself->incipher->key_len + myself->incipher->iv_len; + if(!get_config_string(lookup_config(config_tree, "Port"), &myport)) + myport = xstrdup("655"); else - myself->inkeylength = 1; + port_specified = true; - myself->connection->outcipher = EVP_aes_256_ofb(); + myself->connection->options = 0; + myself->connection->protocol_major = PROT_MAJOR; + myself->connection->protocol_minor = PROT_MINOR; - if(!get_config_int(lookup_config(config_tree, "KeyExpire"), &keylifetime)) - keylifetime = 3600; + myself->options |= PROT_MINOR << 24; - keyexpires = now + keylifetime; - - /* Check if we want to use message authentication codes... */ + if(!read_ecdsa_private_key()) + return false; - if(get_config_string(lookup_config(myself->connection->config_tree, "Digest"), &digest)) { - if(!strcasecmp(digest, "none")) { - myself->indigest = NULL; - } else { - myself->indigest = EVP_get_digestbyname(digest); + /* Ensure myport is numeric */ - if(!myself->indigest) { - logger(LOG_ERR, _("Unrecognized digest type!")); - return false; - } - } - } else - myself->indigest = EVP_sha256(); - - myself->connection->outdigest = EVP_sha256(); - - if(get_config_int(lookup_config(myself->connection->config_tree, "MACLength"), &myself->inmaclength)) { - if(myself->indigest) { - if(myself->inmaclength > myself->indigest->md_size) { - logger(LOG_ERR, _("MAC length exceeds size of digest!")); - return false; - } else if(myself->inmaclength < 0) { - logger(LOG_ERR, _("Bogus MAC length!")); - return false; - } - } - } else - myself->inmaclength = 4; + if(!atoi(myport)) { + struct addrinfo *ai = str2addrinfo("localhost", myport, SOCK_DGRAM); + sockaddr_t sa; + if(!ai || !ai->ai_addr) + return false; + free(myport); + memcpy(&sa, ai->ai_addr, ai->ai_addrlen); + sockaddr2str(&sa, NULL, &myport); + } - myself->connection->outmaclength = 0; + /* Check some options */ - /* Compression */ + if(!setup_myself_reloadable()) + return false; - if(get_config_int(lookup_config(myself->connection->config_tree, "Compression"), &myself->incompression)) { - if(myself->incompression < 0 || myself->incompression > 11) { - logger(LOG_ERR, _("Bogus compression level!")); - return false; - } - } else - myself->incompression = 0; + // TODO: check whether this is used at all + timeout_add(&keyexpire_timeout, keyexpire_handler, &keyexpire_timeout, &(struct timeval){keylifetime, rand() % 100000}); + + /* Compression */ + // TODO: drop compression in the packet layer? + myself->incompression = 0; myself->connection->outcompression = 0; /* Done */ @@ -424,81 +349,38 @@ bool setup_myself(void) myself->nexthop = myself; myself->via = myself; myself->status.reachable = true; + myself->last_state_change = now.tv_sec; node_add(myself); graph(); - /* Open device */ - - if(!setup_device()) - return false; - - /* Run tinc-up script to further initialize the tap interface */ - xasprintf(&envp[0], "NETNAME=%s", netname ? : ""); - xasprintf(&envp[1], "DEVICE=%s", device ? : ""); - xasprintf(&envp[2], "INTERFACE=%s", iface ? : ""); - xasprintf(&envp[3], "NAME=%s", myself->name); - envp[4] = NULL; - - execute_script("tinc-up", envp); - - for(i = 0; i < 5; i++) - free(envp[i]); - - /* Run subnet-up scripts for our own subnets */ - - subnet_update(myself, NULL, true); + if(autoconnect) + load_all_nodes(); /* Open sockets */ - get_config_string(lookup_config(config_tree, "BindToAddress"), &address); - - hint.ai_family = addressfamily; - hint.ai_socktype = SOCK_STREAM; - hint.ai_protocol = IPPROTO_TCP; - hint.ai_flags = AI_PASSIVE; + listen_sockets = 0; + int cfgs = 0; - err = getaddrinfo(address, myport, &hint, &ai); + if(!add_listen_address(address, NULL)) + return false; - if(err || !ai) { - logger(LOG_ERR, _("System call `%s' failed: %s"), "getaddrinfo", - gai_strerror(err)); + if(!listen_sockets) { + logger(DEBUG_ALWAYS, LOG_ERR, "Unable to create any listening socket!"); return false; } - listen_sockets = 0; + // TODO: require Port to be set? Or use "0" and use getsockname()? - for(aip = ai; aip; aip = aip->ai_next) { - listen_socket[listen_sockets].tcp = - setup_listen_socket((sockaddr_t *) aip->ai_addr); + if(!myport) + myport = xstrdup("655"); - if(listen_socket[listen_sockets].tcp < 0) - continue; + xasprintf(&myself->hostname, "MYSELF port %s", myport); + myself->connection->hostname = xstrdup(myself->hostname); - listen_socket[listen_sockets].udp = - setup_vpn_in_socket((sockaddr_t *) aip->ai_addr); + /* Done. */ - if(listen_socket[listen_sockets].udp < 0) - continue; - - ifdebug(CONNECTIONS) { - hostname = sockaddr2hostname((sockaddr_t *) aip->ai_addr); - logger(LOG_NOTICE, _("Listening on %s"), hostname); - free(hostname); - } - - memcpy(&listen_socket[listen_sockets].sa, aip->ai_addr, aip->ai_addrlen); - listen_sockets++; - } - - freeaddrinfo(ai); - - if(listen_sockets) - logger(LOG_NOTICE, _("Ready")); - else { - logger(LOG_ERR, _("Unable to create any listening socket!")); - return false; - } + last_config_check = now.tv_sec; return true; } @@ -506,33 +388,15 @@ bool setup_myself(void) /* initialize network */ -bool setup_network(void) -{ - cp(); - - now = time(NULL); - - init_events(); +bool setup_network(void) { init_connections(); - init_subnets(); init_nodes(); init_edges(); init_requests(); - if(get_config_int(lookup_config(config_tree, "PingInterval"), &pinginterval)) { - if(pinginterval < 1) { - pinginterval = 86400; - } - } else - pinginterval = 60; - - if(!get_config_int(lookup_config(config_tree, "PingTimeout"), &pingtimeout)) - pingtimeout = 5; - if(pingtimeout < 1 || pingtimeout > pinginterval) - pingtimeout = pinginterval; - - if(!get_config_int(lookup_config(config_tree, "MaxOutputBufferSize"), &maxoutbufsize)) - maxoutbufsize = 10 * MTU; + pinginterval = 60; + pingtimeout = 5; + maxoutbufsize = 10 * MTU; if(!setup_myself()) return false; @@ -543,56 +407,35 @@ bool setup_network(void) /* close all open network connections */ -void close_network_connections(void) -{ - avl_node_t *node, *next; - connection_t *c; - char *envp[5]; - int i; - - cp(); - - for(node = connection_tree->head; node; node = next) { +void close_network_connections(void) { + for(list_node_t *node = connection_list->head, *next; node; node = next) { next = node->next; - c = node->data; - c->outgoing = false; + connection_t *c = node->data; + c->outgoing = NULL; terminate_connection(c, false); } - list_delete_list(outgoing_list); + if(outgoing_list) + list_delete_list(outgoing_list); if(myself && myself->connection) { - subnet_update(myself, NULL, false); terminate_connection(myself->connection, false); free_connection(myself->connection); } - for(i = 0; i < listen_sockets; i++) { - close(listen_socket[i].tcp); - close(listen_socket[i].udp); + for(int i = 0; i < listen_sockets; i++) { + io_del(&listen_socket[i].tcp); + io_del(&listen_socket[i].udp); + close(listen_socket[i].tcp.fd); + close(listen_socket[i].udp.fd); } - xasprintf(&envp[0], "NETNAME=%s", netname ? : ""); - xasprintf(&envp[1], "DEVICE=%s", device ? : ""); - xasprintf(&envp[2], "INTERFACE=%s", iface ? : ""); - xasprintf(&envp[3], "NAME=%s", myself->name); - envp[4] = NULL; - exit_requests(); exit_edges(); - exit_subnets(); exit_nodes(); exit_connections(); - exit_events(); - - execute_script("tinc-down", envp); if(myport) free(myport); - for(i = 0; i < 4; i++) - free(envp[i]); - - close_device(); - return; }